2733 Commits

Author	SHA1	Message	Date
Sam Minnee	85252ca05e	FIX: Ensure Embed options are always array ... This maintains support for embed 3.0.0.	2020-09-15 17:40:42 +12:00
Garion Herman	f1c94e6d54	FIX Allow quotes in expected ReflectionExceptions within tests	2020-09-15 17:40:42 +12:00
Garion Herman	44685eceba	FIX Support PHP 8 namespace tokens in i18nTextCollector	2020-09-15 17:40:42 +12:00
Garion Herman	bad0662291	FIX Disable libxml_disable_entity_loader() calls in PHP 8	2020-09-15 17:40:42 +12:00
Sam Minnee	b3dd27953b	NEW: Allow league/csv ^9 ... Hopefully this has better PHP 8 support.	2020-09-15 17:40:42 +12:00
Sam Minnee	09fb33e657	FIX: Avoid passing non-class to get_parent_class() ... Throws errors in PHP 8	2020-09-15 17:40:42 +12:00
Sam Minnee	5cb3d07f44	FIX: Avoid pass-literal-by-reference warning in PHP 8	2020-09-15 17:40:42 +12:00
Steve Boyd	ab50e2cc51	Merge branch '4.6' into 4	2020-09-15 13:44:57 +12:00
Steve Boyd	e339549e0d	Merge pull request #9649 from kinglozzer/9648-security-titles ... FIX: Include missing security page titles when CMS not installed (fixes #9648)	2020-09-15 13:43:59 +12:00
Sam Minnee	2143660c3f	FIX: Add class_exists() guards to SapphireTest ... This test helper has a number of hooks to other parts of the and required many class_exists() guards to operate without them This has come out of PoC development work as part of: https://github.com/silverstripe/silverstripe-framework/issues/9679 But can stand-alone as a mergeable PR.	2020-09-14 13:49:21 +12:00
Steve Boyd	015ea8cfc8	Merge branch '4.6' into 4	2020-09-11 11:54:23 +12:00
Damian Mooyman	ac6f34846e	BUG Resolve issue where TreeMultiSelectField would error loading its value (#9604) ... * BUG Resolve issue with TreeMultiSelectField not retaining value in some situations E.g. in an elemental form	2020-09-11 11:52:36 +12:00
Robbie Averill	de61681dec	Merge pull request #9634 from open-sausages/pulls/4/ellipsis ... BUG Use proper ellipsis character in the various summary method.	2020-09-10 14:48:33 -07:00
Maxime Rainville	8bcfa57342	BUG Make PasswordEncryptor::check more resistent to timing attacks	2020-09-10 22:17:50 +12:00
Maxime Rainville	acdebcdba7	Fix unit test	2020-09-10 17:08:13 +12:00
Steve Boyd	02827a6670	FIX Problem with direct compare in SELECT statement causing incompatibility with SQL Server database ... Co-authored-by: Tomas Bilek	2020-09-10 14:48:09 +12:00
Jackson Darlow	2753f823ee	DOC Added a tip to docs describing how to set a cookie for less than a day (#9552) ... DOC Added a tip to docs describing how to set a cookie for less than a day Co-authored-by: Garion Herman <garion@silverstripe.com>	2020-09-10 12:34:33 +12:00
Steve Boyd	4c3a5441b2	Merge branch '4.6' into 4	2020-09-09 13:58:35 +12:00
Nicolaas	27c1c72912	FIX ModuleManifest::getModuleByPath fix to ensure right module is returned (#9569) ... * FIX: ModuleManifest::getModuleByPath returns the wrong module #9561 Co-authored-by: Nicolaas Thiemen <nt@sunnysideup.co.nz>	2020-09-09 13:47:36 +12:00
Maxime Rainville	adaf793ddb	BUG Always validate Member credentials against DRAFT stage (#9671)	2020-09-08 11:47:04 +12:00
Sam Minnee	622cf8b914	FIX: Drop parameter names in Injector instantiation to preserve behaviour in PHP 8 ... Fixes #9667	2020-09-07 17:24:00 +12:00
Sam Minnee	e0f3797489	FIX: Remove deprecated & non-functional default argument config ... This throws deprecation errors on PHP 8. Fixes #9666	2020-09-07 17:24:00 +12:00
Garion Herman	08010d5933	NEW Support namespace tokens in ClassInfo::parse_class_spec() ... The T_NAME_QUALIFIED and T_NAME_FULLY_QUALIFIED tokens are introduced in PHP 8, and encapsulate theentire FQCN, replacing the previous structure of a group of T_STRINGs and T_NS_SEPARATORs.	2020-09-07 17:23:56 +12:00
Guy Marriott	ff04f97149	Add return type ... Co-authored-by: Robbie Averill <robbie@averill.co.nz>	2020-09-01 08:43:36 -07:00
Guy Marriott	3575070b9d	FIX Removing selected column detail only if having is empty (MySQL "feature")	2020-09-01 16:21:43 +12:00
Guy Marriott	f9fc4f6641	FIX Allow for BC for DB adapters that return an actual boolean when selecting boolean literals in SQL	2020-09-01 16:20:07 +12:00
Guy Marriott	ef0af7ae9c	FIX Exists statements can't remove GROUP BY if there's a HAVING clause as it might rely on an aggregate	2020-09-01 16:20:07 +12:00
Guy Marriott	91591373d6	NEW Add exists as a method to the DataQuery API that will generate an SQL "exists" query ... The exists query in SQL allows the query optimiser (engine specific) to execute these queries much faster - often only needing the presence of an index to return "yes it exists".	2020-09-01 16:20:07 +12:00
Steve Boyd	7474a76d1b	Merge pull request #9657 from creative-commoners/pulls/4/expose-recipe-core-version ... NEW Add recipe-core to default VersionProvider module list	2020-08-28 10:36:58 +12:00
Jackson Darlow	699913406b	NEW Added a dev view to output the current config from dev/config (#9542) ... * #3236 Added dev/config view * Refactored use of echo to * Added config/audit for matching missing property definitions in the current config * Minor enhancements to dev/config implementation	2020-08-28 07:19:03 +12:00
Garion Herman	9aa2642d03	Merge pull request #9639 from creative-commoners/pulls/4/embed-performance ... NEW Cache embed shortcodes	2020-08-27 12:15:24 +12:00
Garion Herman	680adbd10b	NEW Add recipe-core to default VersionProvider module list ... Recipe versions are a more useful indicator than the framework module version, so if installed we want to show the recipe-core version. The cms module expands upon this to include recipe-cms.	2020-08-26 14:49:11 +12:00
Mojmir Fendek	7c84171d5b	NEW: Improved task runner UI. (#9540) ... Co-authored-by: Sacha Judd <sjudd@silverstripe.com>	2020-08-26 11:11:13 +12:00
Dylan Grech	efdd359485	Fixed spelling and changed to shorthand array	2020-08-23 14:31:06 +02:00
Dylan Grech	a380cc7444	Added exception for enumerated array (#9644) ... \SilverStripe\View\ArrayData::__construct() throws error when passed an enumerated array #9644	2020-08-22 13:48:59 +02:00
Loz Calver	7377d094c0	FIX: Include missing security page titles when CMS not installed (fixes #9648)	2020-08-21 14:55:06 +01:00
Garion Herman	c143941e44	Merge pull request #9628 from creative-commoners/pulls/4/version-provider ... NEW Additional logic for VersionProvider	2020-08-21 14:25:23 +12:00
Mason Dechaineux	abd0f3fbf3	Fix DataList->column mutating underlying DataQuery	2020-08-21 09:25:27 +10:00
Sam Minnée	b810b7d5c9	API: Allow for user-created objects to have values passed in the constructor (#8591)	2020-08-20 12:28:31 +12:00
Maxime Rainville	5226d961e8	Fix unit test	2020-08-18 10:29:57 +12:00
Maxime Rainville	a43414dedb	Make sure GridState always outputs a JSON Object string	2020-08-17 23:23:42 +12:00
Maxime Rainville	70ffb3297a	API Only include gridfield state value that differ from the expected default	2020-08-17 12:11:56 +12:00
Steve Boyd	7304acb171	NEW Cache embed shortcodes	2020-08-12 12:14:05 +12:00
Steve Boyd	e19ef240f7	NEW VersionProvider now supports recipes as well as modules	2020-08-11 13:04:48 +12:00
Maxime Rainville	26b8b7964e	Rename DefaultEllipsis to defaultEllipsis	2020-08-07 09:48:42 +12:00
Maxime Rainville	896c0e4388	BUG Use proper ellipsis character in the various summary method.	2020-08-06 19:37:03 +12:00
Mojmir Fendek	c2ed6a4cd6	NEW: WithMockTime callback.	2020-08-06 11:18:39 +12:00
Steve Boyd	65c3295917	Merge branch '4.6' into 4	2020-08-05 10:52:49 +12:00
Ingo Schommer	9d03a6856c	FIX Retain custom sort on custom lists in GridFieldAddExistingAutoCompleter ... Forcing sort by the first search field isn't always appropriate. When a custom search list is used, we can set the expectation that custom sorting is intended as well. As an example, this can be used to autocomplete based on FULLTEXT indexes, and sort based on relevancy.	2020-08-04 22:02:20 +12:00
Loz Calver	e368c370ff	Merge pull request #9627 from creative-commoners/pulls/4.6/try-catch-config-db-paths ... FIX Handle DatabaseAdapterRegistry cache exception	2020-08-03 09:19:02 +01:00
Steve Boyd	b59f75dd50	FIX Handle DatabaseAdapterRegistry cache exception ... Co-authored-by: Loz Calver <lozcalver@bigfork.co.uk>	2020-08-03 10:57:27 +12:00
Steve Boyd	8287fad24d	Merge branch '4.6' into 4	2020-07-29 11:38:49 +12:00
Steve Boyd	52d38a8b4a	Merge pull request #9615 from creative-commoners/pulls/4.6/embed-iframe-dimensions ... FIX Set iframe dimension attributes specified in shortcode	2020-07-28 11:04:24 +12:00
Steve Boyd	f0936d4c1e	FIX Set iframe dimension attributes specified in shortcode	2020-07-27 18:04:03 +12:00
Garion Herman	e2443763a6	Merge pull request #9064 from creative-commoners/pulls/4.5/filter-interface ... NEW Add FilterInterface and retrofit into URLSegmentFilter	2020-07-27 11:18:23 +12:00
Nicolaas	f264ff8616	PATCH: improving @return values in docblocks	2020-07-23 22:40:14 +12:00
Nicolaas	d292eb8840	PATCH: fix doctype return type hints: add null	2020-07-23 21:10:17 +12:00
Guy Marriott	5e7f0a5685	Merge pull request #9599 from martinheise/groupeddropdown-readonly ... BUG Readonly version of GroupedDropdownField	2020-07-21 09:21:52 -07:00
Martin Heise	404f450ac3	BUG Readonly version of GroupedDropdownField ... GroupedDropdownField was showing empty values in Readonly mode due to not correctly handling the hierarchical source array. Uses flattened source now in GroupedDropdownField->performReadonlyTransformation()	2020-07-21 09:23:30 +02:00
rdigitalg	56f15b1c14	FIX Try Catch for embeded media (#9424) ... * Try Catch for embeded media * added missing namespaces, translatable message INVALID_URL * generate tag only once * catch after closing bracket * space after comma * Update src/View/Shortcodes/EmbedShortcodeProvider.php * Linting Co-authored-by: ivan@digitalgarage.ro <ivan@digitalgarage.ro> Co-authored-by: Steve Boyd <emteknetnz@gmail.com> Co-authored-by: Loz Calver <kinglozzer@gmail.com>	2020-07-17 19:38:01 +12:00
Robbie Averill	84b4057a9a	Merge pull request #9406 from chrispenny/feature/standardise-get-cms-validator ... v4 improvement: Standardise getCMSValidator for DataObjects/Forms	2020-07-16 15:58:33 -07:00
Maxime Rainville	34eb170075	Merge branch '4.6' into 4	2020-07-16 11:45:25 +12:00
Nicolaas	65e0233258	PATCH: using standard way to refer to classes Group and PermissionRoleCode	2020-07-14 07:50:05 +12:00
Garion Herman	d408a4e714	Merge branch '4.6' into 4	2020-07-13 12:28:14 +12:00
Garion Herman	fbe0f5a981	Merge branch '4.5' into 4.6	2020-07-13 12:27:02 +12:00
Garion Herman	2b9ef6be16	Merge tag '4.6.0' into 4.6 ... Release 4.6.0	2020-07-13 12:26:06 +12:00
Ingo Schommer	8d6a248431	Merge remote-tracking branch 'origin/4.6' into 4	2020-07-11 09:07:39 +12:00
Maxime Rainville	cce2b16309	[CVE-2020-6164] Remove/deprecate unused controllers that can potentially give away some information about the underlying project.	2020-07-10 17:57:06 +12:00
Maxime Rainville	8518987cbd	[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()	2020-07-10 17:56:15 +12:00
Maxime Rainville	996c1b5719	[CVE-2020-6164] Remove/deprecate unused controllers that can potentially give away some information about the underlying project.	2020-07-10 15:03:18 +12:00
Maxime Rainville	71db45b18b	[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()	2020-07-10 14:57:26 +12:00
Guy Marriott	fae61c0f1d	Merge pull request #9582 from open-sausages/pulls/fix-gridfielddatacolumns-callback	2020-07-09 11:58:39 -07:00
Andre Kiste	0ed340faa9	Merge pull request #9584 from open-sausages/pulls/4.5/plain-method-for-chinese-character ... BUG Tweak DBHTMLText::Plain to avoid treating some chinese characters…	2020-07-09 23:13:12 +12:00
Maxime Rainville	c3f0ac7718	Merge branch '4.5' into 4.6	2020-07-09 14:33:57 +12:00
Maxime Rainville	f8360356e0	Merge branch '4.4' into 4.5	2020-07-09 14:28:28 +12:00
Maxime Rainville	b780c4f504	BUG Tweak DBHTMLText::Plain to avoid treating some chinese characters as line breaks.	2020-07-09 13:33:43 +12:00
Ingo Schommer	1f0a78e57b	FIX More context for GridFieldDataColumns callbacks ... This emulates the callback signature from GridFieldEditableColumns in the symbiote/silverstripe-gridfieldextensions module, which extends GridFieldDataColumns. In case canEdit() fails, this component passes control back to the parent (rendering a standard column content rather than a formfield). Which can become an issue if you've defined custom 'callback' handlers on setDisplayFields() - GridFieldDataColumns passes in only one arg (`$record`), while GridFieldEditableColumns passes in three (`$record`, `$col` and `$grid`). While you could argue that this is a bug in the other module, I think this additional context is beneficial for the main GridFieldDataColumns use case as well, and it just happens to fix that bug.	2020-07-09 09:33:21 +12:00
rdigitalg	3bf89b2d13	FIX Try Catch for embeded media (#9424) ... * Try Catch for embeded media * added missing namespaces, translatable message INVALID_URL * generate tag only once * catch after closing bracket * space after comma * Update src/View/Shortcodes/EmbedShortcodeProvider.php * Linting Co-authored-by: ivan@digitalgarage.ro <ivan@digitalgarage.ro> Co-authored-by: Steve Boyd <emteknetnz@gmail.com> Co-authored-by: Loz Calver <kinglozzer@gmail.com>	2020-07-03 13:04:54 +12:00
Sam Minnee	01d3b4fd96	FIX: Set many-many-through joinRecord on newly added records. ... When many-many-through relations are queried, a joinRecord is set on each DataObject in the list to provide the extra fields defined on the connector object. This didn’t previously happen when the record was first add()ed to a list. This fixes that bug.	2020-07-02 15:18:12 +12:00
Maxime Rainville	ec83959f2c	API Remove UpgradeBootstrap (not part of our official API)	2020-06-30 21:35:51 +12:00
Jackson Darlow	57d75c89d5	NEW Added onAfterBuild (#9545) ... * Added onAfterBuild * Remove arbitrary argument	2020-06-30 16:56:14 +12:00
Steve Boyd	16914bfdfc	Merge pull request #9531 from alessandromarotta/patch-1 ... DBField Documentation correction	2020-06-30 13:00:20 +12:00
Tom Yrjas	00ee8d8abf	BUGFIX: Re-declare $items to be an ArrayList if it's null ... getBackLink() modified to tolerate empty ArrayList	2020-06-29 16:07:24 +03:00
Tom Yrjas	824b5e0b67	BUGFIX: Ensure $items isn't null in GridFieldDetailForm_ItemRequest->Breadcrumbs() prior to performing operations on it.	2020-06-29 14:13:49 +03:00
Aaron Carlino	658ca4deb1	MINOR: Add noindex metatag to debugview	2020-06-25 12:09:28 +12:00
Sam Minnée	714c4cba9c	Merge pull request #9546 from andrewandante/feature/disambiguate_first_methods_on_lists ... deprecate First and Last in order to disambiguate for array lists	2020-06-23 14:46:29 +12:00
Serge Latyntcev	b4669ad1bb	FIX 4.6 regression in the TempDatabase reset schema logic	2020-06-22 16:17:14 +12:00
Andrew Aitken-Fincham	09dca5fa9e	Update deprecation notice to 5.0.0 ... Co-authored-by: Robbie Averill <robbie@averill.co.nz>	2020-06-18 21:40:20 +01:00
Andrew Aitken-Fincham	34f660a311	Update src/View/SSViewer_BasicIteratorSupport.php ... Co-authored-by: Robbie Averill <robbie@averill.co.nz>	2020-06-18 21:39:32 +01:00
Guy Marriott	4df45f4fe0	Merge pull request #9550 from jakxnz/pulls/4/docs-regarding-cached-get-ones ... Added documentation regarding some cached ORM scenarios	2020-06-17 09:04:07 -07:00
Jackson Darlow	6813c0f7e8	Added documentation regarding some cached ORM scenarios	2020-06-17 17:17:04 +12:00
Guy Marriott	9eadef19d3	Merge pull request #9544 from jakxnz/pulls/4.6/dataextension-doc-blocks	2020-06-15 23:32:59 -07:00
Guy Marriott	1a6e2da995	Merge pull request #9543 from jakxnz/pulls/4.6/undeclared-private-statics	2020-06-15 23:16:57 -07:00
Andrew Aitken-Fincham	7c95237e8d	update template docs, move deprecation to 5.0, capitalise Is	2020-06-15 12:25:13 +01:00
Jackson Darlow	dadac00c19	Added array declaration to GridFieldDetailForm_ItemRequest::$formActions ... Co-authored-by: Robbie Averill <robbie@averill.co.nz>	2020-06-15 11:45:33 +12:00
Jackson Darlow	1edd8fd754	Added array declaration to DevelopmentAdmin::$registered_controllers ... Co-authored-by: Robbie Averill <robbie@averill.co.nz>	2020-06-15 11:45:10 +12:00
Jackson Darlow	fcc7a9ce5b	Added array declaration to VersionProvider::$modules ... Co-authored-by: Robbie Averill <robbie@averill.co.nz>	2020-06-15 11:44:43 +12:00
Jackson Darlow	dfe8d23ffc	Added extra type-hints to DataExtension DocBlocks	2020-06-12 13:45:14 +12:00
Andrew Aitken-Fincham	2e0e04f701	fix deprecation notices	2020-06-12 01:38:24 +01:00
Steve Boyd	7d87ba72d5	Merge branch '4.6' into 4	2020-06-12 11:20:53 +12:00
Steve Boyd	4daccfab67	Merge branch '4.5' into 4.6	2020-06-12 11:20:13 +12:00
Andrew Aitken-Fincham	bac826bc06	deprecate First and Last in order to disambiguate for array lists	2020-06-11 23:45:42 +01:00
Jackson Darlow	2175de9560	Adjusted DataExtension DocBlocks to another degree of detail	2020-06-12 10:19:15 +12:00
Jackson Darlow	0d6572a2d6	Added DocBlocks to DataExtension methods	2020-06-11 17:04:45 +12:00
Jackson Darlow	84235c6518	Adjusted missing definitions to only include definitions referenced by framework	2020-06-11 14:28:47 +12:00
Jackson Darlow	dfc01457d6	#3236 Added missing config definitions (private statics)	2020-06-11 13:35:15 +12:00
Alessandro Marotta	fa406c1115	Documentation correction	2020-06-02 09:33:52 +02:00
Christopher Darling	4303917ac5	DOCS Form::loadDataFrom constants in docblock ... ... missing MERGE_ prefix as defined in this class	2020-05-28 16:40:12 +01:00
Sam Minnée	eb658e0705	Merge pull request #9528 from silverstripe-terraformers/bugfix/remove-recursive-write-rebased ... Remove recursive write until its fixed [Rebased]	2020-05-28 17:12:36 +12:00
Adrian Humphreys	d320026375	Remove recursive write until its fixed	2020-05-28 14:34:55 +12:00
cpenny	d4165db690	Update getter name to getCMSCompositeValidator	2020-05-28 12:23:35 +12:00
cpenny	8ba65313e9	Add internal note for protected method	2020-05-28 11:18:46 +12:00
cpenny	bca4be77ed	Update name to CompositeValidator. Add docblocks	2020-05-28 11:18:46 +12:00
cpenny	a2b57f0801	Update DefaultFormFactory extension point. Use array for validators	2020-05-28 11:18:46 +12:00
cpenny	11e2005b9b	Add deprecation notice for 4.6 and update docs	2020-05-28 11:18:46 +12:00
cpenny	f977f9734c	Add base updateValidatorList method to DataExtension	2020-05-28 11:18:46 +12:00
cpenny	b45a3561df	Implemented PR feedback. Added some initial test cov	2020-05-28 11:18:46 +12:00
cpenny	d7dd93f7a7	Standardise getCMSValidator for DataObjects/Forms	2020-05-28 11:18:46 +12:00
Maxime Rainville	acccdd8a1c	Merge branch '4.5' into 4	2020-05-26 14:31:06 +12:00
Maxime Rainville	42bb28965c	Merge branch '4.4' into 4.5	2020-05-26 14:30:27 +12:00
Maxime Rainville	395893b559	Merge branch '4.3' into 4.4	2020-05-26 14:30:02 +12:00
Maxime Rainville	86fcb9e29c	Merge branch '4.2' into 4.3	2020-05-26 14:29:16 +12:00
Daniel Hensby	080ce157ce	Fix various typos in comments	2020-05-16 10:34:53 +01:00
Michal Kleiner	21129b1624	Use short array syntax across the framework's codebase	2020-05-16 10:34:45 +01:00
Brett Tasker	1d19051c10	Add sha1 and md5 hashing options in resource URL	2020-05-12 18:14:03 +12:00
Alessandro Marotta	f3d1e308e5	Update Member.php ... The public function isLockedOut() in Member.php call LoginAttempt::getByEmail but serves to it the unique_identifier_field. This PR could allow to extensions to patch the use of uniqueidentifierfield (otherwise it would be necessary to extends the Member Class to override the isLockedOut function, with a lot of problems)	2020-05-10 19:07:22 +02:00
Matt Clegg	153e2383e6	DOCS: Minor typo	2020-05-10 08:01:10 +05:45
Mojmir Fendek	7dc6b36c16	Unique key for DataObject (#9400) ... NEW Unique key for DataObject	2020-05-04 09:10:51 +12:00
Andre Kiste	3a424747df	Merge pull request #9332 from shoosah/feature/add-error-message-into-field ... Allow to add error message into a specific field	2020-05-01 15:46:29 +12:00
Andre Kiste	ec51f98adb	Merge pull request #8870 from jinjie/4 ... Fix: Allow editing of relation if item is created.	2020-05-01 15:37:52 +12:00
Guy Marriott	693c4cde46	Merge pull request #9499 from lekoala/patch-16	2020-04-28 12:23:28 -07:00
Thomas Portelange	2f3c0fc8dd	Update src/Control/Session.php ... Co-Authored-By: Guy Marriott <guy.the.person@gmail.com>	2020-04-28 19:21:52 +02:00
Robbie Averill	8bd9f48669	Merge pull request #9501 from mattclegg/1588075087 ... DOCS: Fix typos & grammer	2020-04-28 09:42:03 -07:00
mattclegg	dbecdd52d2	DOCS: Add reference for undocumented TEMP_FOLDER	2020-04-28 17:51:25 +05:45
mattclegg	df8cb9e010	DOCS: Update filter to use correct class	2020-04-28 17:50:40 +05:45
mattclegg	76bc7524a7	DOCS: Fix typos & grammer	2020-04-28 17:50:39 +05:45
Thomas Portelange	b38c35fe90	Fixes warning if session is not active ... See issue https://github.com/silverstripe/silverstripe-framework/issues/9496	2020-04-27 13:51:19 +02:00
Dan Hensby	28ba4f701a	Merge branch '4.5' into 4	2020-04-27 09:54:27 +01:00
Dan Hensby	13b4d60d4a	Merge branch '4.4' into 4.5	2020-04-27 09:53:42 +01:00
Dan Hensby	85b37999be	Merge branch '4.3' into 4.4	2020-04-27 09:52:52 +01:00
Dan Hensby	e328d6f0d9	Merge branch '4.2' into 4.3	2020-04-27 09:51:24 +01:00
Dan Hensby	33b0b6985a	Update file paths for autoloading compatibility	2020-04-25 10:28:28 +01:00
Dan Hensby	b9f8ab44ac	Rename DBBigint.php for composer autoloading compatability	2020-04-24 23:15:42 +01:00
Garion Herman	50484417da	Merge branch '4.5' into 4	2020-04-23 23:11:46 +12:00
Daniel Hensby	42cee6f5fb	Merge pull request #9489 from mattclegg/1587548067 ... DOCS: Fix typos	2020-04-22 12:28:02 +01:00
Daniel Hensby	826d1fa4eb	Merge pull request #9491 from mattclegg/1587548119 ... DOCS: Remove unnecessary `return`	2020-04-22 12:22:15 +01:00
mattclegg	2f717a4d90	DOCS: Remove unnecessary return	2020-04-22 15:50:12 +05:45
mattclegg	d521a52a33	DOCS: Fix typos	2020-04-22 15:20:11 +05:45
Daniel Hensby	237b2d5f74	Convert array delcarations to short array syntax	2020-04-20 18:58:09 +01:00
Garion Herman	9aba767e36	Merge pull request #9460 from chrometoasters/pulls/fix-9459-public-path ... Fix SS_BASE_URL logic when undefined and docroot without public folder	2020-04-20 21:06:46 +12:00
Garion Herman	f94078d963	Merge pull request #9408 from chrometoasters/pulls/classes-with-extension ... Add ClassInfo method to get all classes with a given extension applied	2020-04-20 20:11:01 +12:00
Loz Calver	e08bf1cdd9	Merge pull request #9461 from creative-commoners/pulls/4/remove-db-config-glob ... Cache results of _configure_database.php glob	2020-04-20 08:45:48 +01:00
mattclegg	2169891651	BUGFIX: Ensure realpath returns a string for stripos ... [Deprecated] stripos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior	2020-04-19 11:21:34 +05:45
Serge Latyntcev	cb36aab80c	Merge branch '4.5' into 4	2020-04-15 14:49:19 +12:00
Maxime Rainville	7da77be5ce	Merge branch '4.5' into 4	2020-04-15 08:22:27 +12:00
Daniel Hensby	03239f9dcc	Merge pull request #9454 from open-sausages/pulls/4/myisam ... NEW Allow InnoDB for FULLTEXT indexes	2020-04-14 11:50:45 +01:00
mattclegg	60e670176a	DOCS: Correct spelling	2020-04-14 15:00:08 +05:45
mattclegg	5585f6633f	DOCS: Update typos	2020-04-14 15:00:08 +05:45
mattclegg	e968f5cb86	DOCS: Remove outdated TODO	2020-04-14 15:00:08 +05:45
Maxime Rainville	14bbaac1cb	Merge tag '4.5.3' into 4.5 ... Release 4.5.3	2020-04-14 14:23:57 +12:00
Maxime Rainville	de8fd82c55	Merge branch '4.4' into 4.5	2020-04-14 14:18:18 +12:00
Maxime Rainville	1fe6255f9b	Merge tag '4.4.6' into 4.4 ... Release 4.4.6	2020-04-14 14:13:59 +12:00
Serge Latyntcev	9779e42963	BUG Register new sub tasks to fix files affected by CVE-2020-9280 and CVE-2019-12245	2020-04-13 19:43:53 +12:00
Serge Latyntcev	b269d87490	BUG Register new sub tasks to fix files affected by CVE-2020-9280 and CVE-2019-12245	2020-04-13 17:16:57 +12:00
Steve Boyd	75d31c2cd3	Cache glob results for _configure_database.php	2020-04-10 23:15:12 +12:00
Michal Kleiner	ab87bdc044	Fix SS_BASE_URL logic when undefined and docroot without public folder	2020-04-10 15:06:14 +12:00
Ingo Schommer	a50e15e5ee	FIX Avoid VACUUM on test dbs in Postgres ... The Postgres implementation was always faulty, but the database exception was swallowed until See https://github.com/silverstripe/silverstripe-framework/pull/9456. Now that the the exception is only swallowed the first time, the second recurrence will cause failing test execution. This is a bit of an awkward fix, but the indirection "through" DataObject doesn't allow for anything else without changing public API surface. The logic goes from TempDatabase to DBSchemaManager, then through the closure into DataObject->requireTable(), then back into DBSchemaManager->requireTable(). And updateschema() is subclassed in SQLite3, making it difficult to add more arguments. VACUUM is described as: > VACUUM reclaims storage occupied by dead tuples. In normal PostgreSQL operation, tuples that are deleted or obsoleted by an update are not physically removed from their table; they remain present until a VACUUM is done. Therefore it's necessary to do VACUUM periodically, especially on frequently-updated tables. https://www.postgresql.org/docs/9.1/sql-vacuum.html Since test databases are short-lived, there's no reason to delete dead tuples, they'll be garbage collected when either the transaction is rolled back, or the database is destroyed after the test run.	2020-04-09 14:43:16 +12:00
Ingo Schommer	2c5deceeb4	FIX Filter out all FULLTEXT BOOLEAN chars ... The query might still work depending on where these chars are placed, but it seems weird to only remove *some* of the valid chars here. See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html Note that the query runs both the actual boolean query with chars, and then a separate relevance search without them.	2020-04-09 10:32:45 +12:00
Ingo Schommer	0215fdd262	DOC Clarify sanitisation in searchEngine() under boolean mode ... This came up in https://github.com/silverstripe/silverstripe-cms/issues/1452, and wasn't fully addressed. Either we allow boolean mode and all the constraints this brings around special character usage, or we filter out those special characters, which makes boolean mode pointless. You can't just pass arbitrary user input in a power-user function like this. See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html Context: This used to work for some examples like "foo>*" under MyISAM, presumably because it had a more lenient parser. InnoDB rightfully complains about this now.	2020-04-09 10:32:45 +12:00
Ingo Schommer	c6b698cb02	NEW Allow InnoDB for FULLTEXT indexes ... MyISAM used to be the only one to support it, now InnoDB has caught up. Unless an engine is set specifically in create_table_options, this will auto-convert existing MyISAM tables to InnoDb. Fixes #9242	2020-04-09 10:32:45 +12:00
Ingo Schommer	052c5cbc38	BUG Infinite loops in TempDatabase (fixes #8902) ... Ugly, but so is the original implementation that this works around (swallowing an exception to trigger functionality)	2020-04-08 13:58:02 +12:00
Robbie Averill	f77f725355	Merge pull request #9447 from mattclegg/docs__GridFieldDetailForm_ItemRequest-httpError ... [DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest	2020-04-02 13:05:49 -07:00
Robbie Averill	d3b19069b3	Apply suggestions from code review ... Add double quotes around object title	2020-04-02 12:51:13 -07:00
Dan Hensby	d1075f29b8	Remove empty parameter as per feedback	2020-04-02 12:11:35 +01:00
Dan Hensby	9e0ed0a50a	Fix spaces around concatenation operator	2020-04-02 12:09:22 +01:00
Dan Hensby	5bf2ac83ee	Merge branch '4.5' into 4	2020-04-01 19:23:47 +01:00
Loz Calver	39fab1974a	Merge pull request #9435 from unclecheese/pulls/4.5/wha-diff ... BUGFIX: Ensure diff arrays are one-dimensional	2020-04-01 09:16:20 +01:00
Matt Clegg	e80f1b2b83	[DOCS] Member::logInAs is not a valid example ... Member::logInAs doesn't exist as a static function. Additionally, `logInAs` does exist as a function in SapphireTest.php, so, should this be updated to also use `Member::actAs` for consistency?	2020-03-31 18:20:21 +05:45
mattclegg	24bc80ed35	[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest	2020-03-31 12:09:16 +05:45
Daniel Hensby	1fb574a5bd	NEW: Variadic URL parameter matches for url_handlers (#9438) ... * Add wildcard URL parameter matches for url_handlers * Extra tests for wildcard parameters * Add a PHP warning if more params appear after wildcard param	2020-03-25 09:16:13 +13:00
Michal Kleiner	30c3b127c1	NEW Add ClassInfo method to get all classes with a given extension applied	2020-03-24 10:48:35 +13:00
Robbie Averill	5002f514b3	FIX Capitalisation fixes in welcome back message (#9439)	2020-03-23 15:54:30 +13:00
Aaron Carlino	7ad5f1bb14	BUGFIX: Ensure diff arrays are one-dimensional	2020-03-17 15:57:28 +13:00
Robbie Averill	b6512edec8	Merge pull request #9434 from mattclegg/bugfix--silverstripe-admin--requirements ... [BUGFIX] silverstripe/admin is not required to be installed	2020-03-16 09:48:39 -07:00
mattclegg	06dab6b539	[BUGFIX] silverstripe/admin is not required to be installed ... If the silverstripe/admin module is not installed then the javascript/css requirements fail to load	2020-03-16 18:54:01 +05:45
Garion Herman	88660e6435	Merge pull request #9426 from creative-commoners/pulls/4.5/change-atomic-job-title ... DOC Update atomic MigrationTask description	2020-03-16 15:19:33 +13:00
Ramon Lapenta	9c7eac481e	Add "option" to list elements that belong to "listbox" ... The accessibility attribute `role="listbox"` requires its immediate children to be set as `role="option"`, currently they don't have this option and accessibility tests are failing.	2020-03-10 11:10:04 -06:00
Steve Boyd	667495eaf9	Merge branch '4.5' into 4	2020-03-06 10:53:28 +13:00
Steve Boyd	687435a2f1	Merge branch '4.4' into 4.5	2020-03-06 10:52:22 +13:00
Steve Boyd	6d6cc65927	Update description	2020-03-06 09:57:31 +13:00
UndefinedOffset	bba0f2f72f	BUGFIX: Fixed issue where TimeField_Readonly would only show "(not set)" instead of the value	2020-02-24 09:59:00 -04:00
Maxime Rainville	affd43052a	Merge branch '4.5' into 4	2020-02-17 18:11:23 +13:00
Maxime Rainville	acd7d94167	Merge branch '4.4' into 4.5	2020-02-17 13:07:26 +13:00
Maxime Rainville	49fda52b12	Merge pull request #94 from silverstripe-security/fix/cve-2019-19325 ... CVE-2019-1935	2020-02-17 12:54:40 +13:00
Serge Latyntcev	ad1b00ec7d	[CVE-2019-19325] XSS through non-scalar FormField attributes ... Silverstripe Forms allow malicious HTML or JavaScript to be inserted through non-scalar FormField attributes, which allows performing XSS (Cross-Site Scripting) on some forms built with user input (Request data). This can lead to phishing attempts to obtain a user's credentials or other sensitive user input. There is no known attack vector for extracting user-session information or credentials automatically, it required a user to fall for the phishing attempt. XSS can also be used to modify the presentation of content in malicious ways.	2020-02-17 09:58:29 +13:00
Guy Marriott	c31de772ab	Merge pull request #8838 from creative-commoners/pulls/4/slash-means-root ... Use '/' as an alternative designation for root in routing	2020-02-14 11:29:32 -08:00
Garion Herman	29943f9049	API TestSession request methods now use the correct HTTP method (#8987) ... * API TestSession request methods now use the correct HTTP method * DOCS Update requests section in Functional Testing to reflect API change	2020-02-14 16:01:06 +13:00
Garion Herman	9d1d59d8d1	NEW Accept / as designation for root URL controller	2020-02-14 14:41:10 +13:00
Steve Boyd	8c7e10bd55	Merge branch '4.5' into 4	2020-02-11 16:45:35 +13:00
Steve Boyd	9d5c3ef20e	Merge branch '4.4' into 4.5	2020-02-11 16:45:15 +13:00
Mojmir Fendek	285e6caafa	PR fixes	2020-02-11 10:43:01 +13:00
Mojmir Fendek	448147c2f1	PR fixes	2020-02-10 09:17:34 +13:00
Mojmir Fendek	660f80d284	PR fixes	2020-02-07 13:49:19 +13:00
mnuguid	ca36a47bb1	FIX Update ORM DBField types to use Injector in scaffoldFormField() ... - This is usable in cases where a DBField is needed to be overloaded through the Injector.	2020-02-04 21:43:47 +13:00
Mojmir Fendek	99786dda22	ORM Column now supports related table lookup	2020-01-28 15:46:30 +13:00
Mojmir Fendek	9c38c5f625	CMS action related extension points (#9340) ... * CMS action related extension points * Refactor to use fewer extension points * Remove explicit return type Co-authored-by: Aaron Carlino <unclecheese@leftandmain.com>	2020-01-27 15:09:15 +13:00
Maxime Rainville	6ff0f3f466	BUG The "Link existing" should be disabled rather than readonly.	2020-01-24 14:47:12 +13:00
Robbie Averill	4121099484	Merge branch '4.5' into 4	2020-01-16 20:00:02 -08:00
Robbie Averill	53fcd47dfc	Merge branch '4.4' into 4.5	2020-01-16 19:59:42 -08:00
Robbie Averill	26e3b6f4e3	Merge branch '4.3' into 4.4	2020-01-16 19:59:24 -08:00
Mojmir Fendek	acbbf80d14	CMS action related extension points (#9340) ... * CMS action related extension points * Refactor to use fewer extension points * Remove explicit return type Co-authored-by: Aaron Carlino <unclecheese@leftandmain.com>	2020-01-15 14:24:49 +13:00
Robbie Averill	38d7bd700d	Merge pull request #9373 from manja/4.5 ... Fixed issue with merging existing entities in text collector	2020-01-14 09:27:35 -08:00
Martin D	ec6a353543	array_key_exists() on objects is deprecated ... Ref: https://wiki.php.net/rfc/deprecations_php_7_4#array_key_exists_with_objects	2020-01-14 09:22:49 -08:00
Nemanja Karadzic	18f0829053	Fixed issue with merging existing entities in text collector	2020-01-14 14:20:40 +01:00
Garion Herman	af90d17e19	Merge pull request #9359 from open-sausages/pulls/4.4/dbhtmlvarchar-scafolding ... BUG Remove bad default when scaffolding form field for DBHTMLVarchar	2020-01-07 09:33:25 +13:00
Maxime Rainville	31a8c16c43	Remove default row size	2020-01-07 09:13:03 +13:00
Loz Calver	a42249b6fc	Minor performance improvement in DatabaseAdapterRegistry::autoconfigure()	2019-12-19 14:39:46 +00:00
Serge Latyntcev	eaf6bca706	Merge branch '4.5' into 4	2019-12-19 11:26:38 +13:00
Maxime Rainville	8d69cf9f75	BUG Remove bad default when scaffolding form field for DBHTMLVarchar	2019-12-18 17:32:02 +13:00
Andre Kiste	6650d81324	BUG Fix extra blank Group being created when creating a new Group (#9325) ... * Fix extra blank Group being created when creating a new Group * Update tests to reflect expected behavior * Improved tests	2019-11-27 09:32:33 +13:00
shoosah	2724d93111	Allow to add error message into a specific field	2019-11-22 11:03:27 +13:00
Loz Calver	453945da14	FIX: Session::restart() didn't correctly restart session (fixes #9259)	2019-11-20 14:21:30 +00:00
Serge Latyntcev	f67e15b8ee	Merge branch '4.5' into 4	2019-11-20 11:12:49 +13:00
Serge Latyntcev	91e4aa90f1	Merge branch '4.4' into 4.5	2019-11-20 11:09:23 +13:00
Serge Latyntcev	8219491705	Merge branch '4.3' into 4.4	2019-11-20 11:08:35 +13:00
Robbie Averill	77ccadd663	Merge pull request #9300 from LABCAT/patch-1 ... Improvement to docs for send_file function	2019-11-14 09:08:16 -08:00
Serge Latyntcev	559f660e0e	Merge branch '4.4' into 4	2019-11-13 15:40:34 +13:00
Mojmir Fendek	e2bea6b41f	API Add withConfig method (#9011) ... * With config functionality added. * Update docs/en/02_Developer_Guides/04_Configuration/00_Configuration.md	2019-10-31 16:12:04 +13:00
Michal Kleiner	4f614423ad	Ensure Requirements_Backend respects explicit false for async/defer	2019-10-30 09:59:57 +13:00
Damian Mooyman	e76601e5c8	BUG FormAction title property cannot be set if useButtonTag is false	2019-10-29 17:21:45 +13:00
LABCAT	501d9a1480	Update HTTPRequest.php	2019-10-23 22:52:53 +13:00
LABCAT	630c6c0514	Update src/Control/HTTPRequest.php ... Co-Authored-By: Robbie Averill <robbie@averill.co.nz>	2019-10-23 21:05:22 +13:00
Garion Herman	17f4cc6e30	Merge pull request #9281 from creative-commoners/pulls/4/textfield-tip-ui ... NEW: Add support for Tip UI in TextField	2019-10-23 16:50:43 +13:00
Garion Herman	bed3f2b3c6	NEW Add type declarations to Tip API, add TippableFieldInterface	2019-10-23 10:46:22 +13:00
Garion Herman	195417b061	NEW Extract Tip from TextField, add test coverage	2019-10-22 17:04:58 +13:00
LABCAT	d3a17958ef	Update src/Control/HTTPRequest.php ... Co-Authored-By: Robbie Averill <robbie@averill.co.nz>	2019-10-22 16:17:04 +13:00
LABCAT	67c944c962	Improvement to docs for send_file function	2019-10-22 15:18:03 +13:00
Serge Latyntsev	bd2ccf70fa	Merge pull request #9282 from open-sausages/pulls/4/docs/clarify-basic-auth ... DOCS Clarify BasicAuth limitations	2019-10-22 14:01:51 +13:00
Maxime Rainville	e59625fe5a	NEW Add ability to define image size preset for the TinyMCE editor. (#9276) ... * NEW Add ability to define image size preset for the TinyMCE editor. * DOC Explain how to define image size pre-sets	2019-10-22 11:50:28 +13:00
Serge Latyntcev	33a28394d6	Merge branch '4.4' into 4	2019-10-18 15:59:28 +13:00
Serge Latyntcev	0cf5d4cbe2	Merge branch '4.3' into 4.4	2019-10-18 15:58:13 +13:00
Serge Latyntcev	46b9530d88	PSR2 linting fixes	2019-10-18 15:31:39 +13:00
Serge Latyntcev	7873efde9c	Merge branch '4.4' into 4	2019-10-18 10:58:19 +13:00
Serge Latyntcev	dcbe6d0310	Merge branch '4.3' into 4.4	2019-10-18 10:57:35 +13:00
Garion Herman	efc7ba9520	NEW Tweak TextField Tip API to match changes to component	2019-10-11 15:04:56 +13:00
Ingo Schommer	8dcda91538	DOCS Clarify BasicAuth limitations	2019-10-10 10:41:39 +13:00
Garion Herman	a44bc5bcf3	NEW Add support for Tip UI in TextField ... See TextField documentation in silverstripe/admin Pattern Library	2019-10-09 16:26:06 +13:00
Damian Mooyman	d7752b7945	Run PSR2 Lint cleaner	2019-10-04 13:26:31 +13:00
Damian Mooyman	f1594fd991	BUG Ensure that canCreate() context matches that respected by GridFieldAddNewButton	2019-10-04 11:24:34 +13:00
Robbie Averill	4d5d7a34a1	NEW Add FilterInterface and retrofit into URLSegmentFilter ... There are other filters in the core SilverStripe product, e.g. FileNameFilter in silverstripe/assets which would benefit from having a common filter interface. This retrofits one for URLSegmentFilter in framework. I have not added any PHP 7 syntax in method signatures to avoid breaking backwards compatibility.	2019-10-04 10:51:24 +13:00
Robbie Averill	1265f09f4f	Merge pull request #9271 from michalkleiner/pulls/4/check-array-props-in-custom-methods ... FIX Check array keys existence when removing methods in CustomMethods	2019-10-03 14:30:22 -07:00
Serge Latyntcev	7db524bd90	FIX DebugViewFrendlyErrorFormatter handle of admin_email	2019-10-04 10:26:54 +13:00
Robbie Averill	e49cec3a00	Merge pull request #9247 from jakxnz/pulls/4/record-login-attempt-outputs ... ENHANCEMENT: MemberAuthenticator::recordLoginAttempt() outputs	2019-10-03 10:46:34 -07:00
Dylan Wagstaff	047ac060c4	Merge pull request #9265 from emteknetnz/feature/noopener ... Add noopener attribute to links with a target	2019-10-03 14:42:50 +13:00
Steve Boyd	887f198b07	Add rel attribute to link elements with a target attribute	2019-10-03 14:03:12 +13:00
Damian Mooyman	58c080db5a	FEATURE Option placeholder for upload folder id (#9262) ... * FEATURE Option placeholder for upload folder id * ENHANCEMENT Add setFolderName() to TinyMCEConfig * Typehint return type * Add type to param	2019-09-30 10:50:55 +13:00
Michal Kleiner	1a2dbfd3a5	Update conditional logic when checking array keys before removing methods in CustomMethods	2019-09-30 10:17:59 +13:00
Michal Kleiner	52a039f631	Check array keys existence prior to their usage when removing methods in CustomMethods	2019-09-27 14:57:15 +12:00
JorisDebonnet	349589b23b	Clarify that $title in FormField can accept ViewableData ... When constructing a FormField, an IDE would previously tell you the `$title` needs to be string (or null). Let's make it more clear that a ViewableData instance (such as `HTMLValue::create($title)`) is also accepted. This should help people more quickly find a solution to put html in labels.	2019-09-26 02:39:39 +02:00
Sam Minnée	af6644f762	Merge pull request #9240 from chrometoasters/pulls/db-readonly-transactions-support ... NEW Introduce supported database transaction mode check	2019-09-25 10:02:53 +12:00
Serge Latyntcev	88fde6e7c3	Merge branch '4.4' into 4	2019-09-24 17:29:06 +12:00
Serge Latyntcev	50a1aa4c4d	Merge branch '4.3' into 4.4	2019-09-24 17:28:31 +12:00
Aaron Carlino	b002ef1171	Merge branch '4.4' into 4	2019-09-24 17:26:50 +12:00
Serge Latyntcev	8b7063a8e2	[CVE-2019-12617] Fix access escalation for CMS users with limited access through permission cache pollution	2019-09-24 16:03:48 +12:00
Serge Latyntcev	eccfa9b10d	[CVE-2019-12203] Session fixation in "change password" form ... A potential account hijacking may happen if an attacker has physical access to victim's computer to perform session fixation. Also possible if the targeted application contains an XSS vulnerability. Requires the victim to click the password reset link sent to their email. If all the above happens, attackers may reset the password before the actual user does that.	2019-09-24 16:03:48 +12:00
Serge Latyntcev	5af205993d	[CVE-2019-12617] Fix access escalation for CMS users with limited access through permission cache pollution	2019-09-24 16:00:51 +12:00
Serge Latyntcev	569237c0f4	[CVE-2019-12203] Session fixation in "change password" form ... A potential account hijacking may happen if an attacker has physical access to victim's computer to perform session fixation. Also possible if the targeted application contains an XSS vulnerability. Requires the victim to click the password reset link sent to their email. If all the above happens, attackers may reset the password before the actual user does that.	2019-09-24 16:00:51 +12:00
Jackson Darlow	a033662a3a	MemberAuthenticator::recordLoginAttempt() outputs	2019-09-24 14:24:59 +12:00
Garion Herman	0d27f32cc9	FIX Add 'legal empty attributes' to allow empty alt values on imgs ... In some situations, a caption is used in place of a value in the alt attribute, and in others an image may be cosmetic and not in need of an alt attribute value (though the alt attribute must still be rendered in this case).	2019-09-24 11:44:12 +12:00
Robbie Averill	3cfc21c405	Merge pull request #9241 from open-sausages/pulls/4.4.3/fix-file-permission ... Fix administrators not being able to see files that are restricted to groups	2019-09-23 11:13:26 -07:00
Guy Marriott	aa7c057422	FIX: Don't force-add view button to readonly GridField (fixes #… (#9254) ... FIX: Don't force-add view button to readonly GridField (fixes #9249)	2019-09-23 10:31:25 -07:00
Loz Calver	efdb9cc718	FIX: run member CMS validator when editing via groups (fixes #9184)	2019-09-23 16:59:58 +01:00
Loz Calver	d85ff3bc44	FIX: Don't force-add view button to readonly GridField (fixes #9249)	2019-09-23 16:52:47 +01:00
bergice	6a1c6ecec6	Fix administrators not being able to see files that are restricted to groups ... Resolves https://github.com/silverstripe/silverstripe-asset-admin/issues/777	2019-09-23 16:44:28 +12:00
Guy Marriott	6ff97821ed	Merge branch '4.4' into 4	2019-09-18 15:52:36 -07:00
Guy Marriott	7877ffcc85	Merge branch '4.3' into 4.4	2019-09-18 15:52:18 -07:00
Hayden Shaw	daf9d55ecb	Allow non summary fields to be used as export fields ... Fixes regression in 3d989a6eae.	2019-09-19 10:00:54 +12:00
Michal Kleiner	bcbf90a837	NEW Introduce supported database transaction mode check	2019-09-16 14:44:15 +12:00
Robbie Averill	aa6b244db9	Merge branch '4.4' into 4	2019-09-13 18:11:46 -07:00
Robbie Averill	592ab6abc1	Merge branch '4.3' into 4.4	2019-09-13 18:11:34 -07:00
Robbie Averill	066ce8e01c	Merge branch '4.2' into 4.3 ... # Conflicts: # src/View/ThemeResourceLoader.php	2019-09-13 18:10:37 -07:00
Robbie Averill	cfe86ad5a1	Merge pull request #9153 from creative-commoners/pulls/4.4/stream-ree-tags ... FIX Skip md5-ing the whole contents of a stream for etags	2019-09-13 17:59:26 -07:00
Robbie Averill	9a76d4adb4	Merge pull request #9181 from kinglozzer/8762-shortcode-templates ... NEW: Use templates to render embed shortcodes (closes #8762)	2019-09-13 17:58:32 -07:00
Serge Latyntsev	233e0e7aa0	ENH PasswordExpirationMiddleware implementation (#9207)	2019-09-12 14:34:06 +12:00
Aaron Carlino	da6582f593	NEW: Remove web installer, move to separate package (#9231) ... * Remove installer * Remove exposed install files * Replace Dev/Install classes still in use * Update changelog * FIX make the grid field actions consistent to what they look like on pages Resolves https://github.com/silverstripe/silverstripe-admin/issues/904 * Docs changes	2019-09-11 13:10:25 +12:00
Maxime Rainville	591b88a9bc	BUG Allow infinite loop when calling DataObject::writeComponent() recursively	2019-09-10 14:15:28 +12:00
Robbie Averill	e8c2f963fd	FIX Member::getLastName() now correctly returns the Member surname	2019-09-06 12:12:27 -07:00
Robbie Averill	41a766d135	Merge pull request #9085 from kinglozzer/9084-path-join-exception ... Catch Path::join() exceptions in findTemplate() (fixes #9084)	2019-09-06 12:00:39 -07:00
Robbie Averill	42dd02ef78	Merge pull request #9122 from aNickzz/4 ... Add onBeforeRenderHolder extension point for FormField	2019-09-06 11:53:10 -07:00
Hels666	22a6a5b1e3	NEW Add getLastName() method to Member.php (#9222) ... * Add getLastName() method to Member.php Add getLastName() method to Silverstripe\Security\Member.php to allow use of $LastName instead of $Surname in templates as it is a common mistake made this is for issue #9219 as discussed in Slack on 04-Sep-2019 * Minor doc block clean-up * Update src/Security/Member.php - typo fix Co-Authored-By: Guy Marriott <guy@scopey.co.nz>	2019-09-06 20:31:22 +12:00
Maxime Rainville	dd40d53e6b	Merge branch '4.4' into 4	2019-09-04 09:46:33 +12:00
Maxime Rainville	24015c7767	Merge branch '4.3' into 4.4	2019-09-04 09:42:09 +12:00
Robbie Averill	aec5051a24	Merge pull request #9206 from creative-commoners/pulls/4.3/strip-bom-on-csv-import ... FIX Byte Order Marks (BOM) are now stripped when importing CSV files	2019-09-03 09:55:38 -07:00
Damian Mooyman	6759af3767	Escape strings a bit safer for doc generation	2019-09-03 19:38:19 +12:00
Damian Mooyman	f649657182	Clarify Director::absoluteURL behaviour ... Fixes #9111	2019-09-03 19:34:16 +12:00
Robbie Averill	ef49dcf726	Merge pull request #9164 from sminnee/fix-9162 ... FIX: Write relations when saving in grid-field item edit form	2019-09-01 20:44:13 -07:00
Maxime Rainville	a2a202c016	Merge pull request #9200 from open-sausages/pulls/4.4.3/consistent-actions ... FIX make the grid field actions consistent to what they look like on pages	2019-09-02 14:07:22 +12:00
bergice	2f8d847a10	FIX make the grid field actions consistent to what they look like on pages ... Resolves https://github.com/silverstripe/silverstripe-admin/issues/904	2019-09-02 12:22:32 +12:00
Robbie Averill	0b991cc039	Merge pull request #9198 from elabuwa/pulls/4.3/bug-fix-html-entities-breadcrumbs-in-group ... Bug : Add html_entity_decode to group parents	2019-08-30 09:51:52 +12:00
Dileep Ratnayake	fe4eb5dd2a	Update src/Security/Group.php ... Co-Authored-By: Maxime Rainville <maxime@rainville.me>	2019-08-29 15:44:41 +12:00
Robbie Averill	77ba8391c4	FIX Byte Order Marks (BOM) are now stripped when importing CSV files	2019-08-29 14:54:57 +12:00
Maxime Rainville	73f43c6f42	BUG Remove placeholder text on new group form	2019-08-28 17:14:19 +12:00
Dileep Ratnayake	9b7075ed5d	Update Group.php	2019-08-27 16:22:00 +12:00
Dileep Ratnayake	a976a1688b	Update Group.php ... move to private method	2019-08-27 16:21:08 +12:00
Dileep Ratnayake	40e5c4ec59	Update Group.php ... use of convert::raw2xml, rename $grp to $group	2019-08-27 16:19:40 +12:00
Dileep Ratnayake	4f8240bd48	Update src/Security/Group.php ... Co-Authored-By: Andre Kiste <bergice@users.noreply.github.com>	2019-08-27 12:19:03 +12:00
Will Rossiter	d2a07b1047	FIX Remove error when exporting a column that is not displayed in a GridField	2019-08-27 11:54:31 +12:00
Dileep Ratnayake	f7a602137a	add html_entity_decode to breadcrumbs	2019-08-27 11:49:17 +12:00
Loz Calver	759601741d	NEW: Use templates to render embed shortcodes (closes #8762)	2019-08-21 09:32:16 +01:00
Robbie Averill	a5d6b998fc	Merge branch '4.4' into 4	2019-08-16 16:40:39 +12:00
Robbie Averill	bae7e32680	FIX Member::changePassword() no longer applies password validation rules to the hashed value	2019-08-16 09:06:07 +12:00
Robbie Averill	45f86658ca	Merge branch '4.4' into 4	2019-08-14 09:31:05 +12:00
Robbie Averill	4b44272367	Merge branch '4.3' into 4.4	2019-08-14 09:30:53 +12:00
Robbie Averill	d63e4b520c	Merge branch '4.2' into 4.3	2019-08-14 09:30:41 +12:00
Nicholas Sorokin	4a32b3418a	Add onBeforeRenderHolder extension point for FormField	2019-08-09 14:43:14 +09:30
Guy Marriott	3d989a6eae	FIX Use content generated by DataColumns component for print and csv export	2019-08-09 15:04:38 +12:00
Guy Marriott	f3132c89d7	Merge pull request #9170 from open-sausages/pulls/4/add-option-to-disable-user-agent-session-check ... API Add option to disable user-agent header session validation	2019-08-08 11:47:07 +12:00
Aaron Carlino	b3093b7a1a	BUGFIX: Allow state to be shared across nested GridFields	2019-08-07 23:09:51 +12:00
Maxime Rainville	4380d7d155	API Add option to disable user-agent header session validation	2019-08-06 22:00:01 +12:00
Robbie Averill	4268db069d	Merge pull request #9165 from sminnee/fix-multiline-gridfield ... FIX: Allow multi-line content in grid field cells	2019-08-05 09:59:22 +12:00
Sam Minnee	6ec02da577	FIX: Allow multi-line content in grid field cells ... It’s amazing that this but has been present for 7 years, but there you go!	2019-08-02 17:46:56 +12:00
Sam Minnee	d088354f46	FIX: Write relations when saving in grid-field item edit form ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/9162	2019-08-02 16:17:42 +12:00
Robbie Averill	0672f8b76b	NEW HTTPRequest now has hasSession() to determine whether a session exists for it	2019-08-02 11:29:23 +12:00
Robbie Averill	3224c9971b	Merge branch '4.4' into 4	2019-08-02 11:24:54 +12:00
Robbie Averill	3b96c51688	Merge branch '4.3' into 4.4	2019-08-02 11:24:45 +12:00
Will Rossiter	82cc8b40a4	Create SearchContext via Injector (#9156)	2019-08-01 14:39:58 +12:00
Guy Marriott	0abfed3e06	FIX Skip md5-ing the whole contents of a stream for etags	2019-07-30 08:25:03 +12:00
Robbie Averill	5c794dfcdd	FIX Prevent setting session value when no session exists yet	2019-07-29 17:16:01 +02:00
UndefinedOffset	40cd66852e	BUGFIX: Fixed issue where multiple relationship sort order columns would be lost in favor of only the last relationship column in the sort order	2019-07-26 11:54:10 -03:00
Robbie Averill	89eb6c88b2	FIX Do not try and load fixtures from directories, fixes PHP 7.4 build errors	2019-07-26 10:13:47 +02:00
Robbie Averill	d1c927ff23	FIX Remove curly brace access to string offsets, deprecated in PHP 7.4	2019-07-24 12:17:49 +02:00
Chee Wai	cb91f5fa06	NEW Added SRI support for Requirements::css, Requirements::javascript (#9139)	2019-07-21 09:51:22 +02:00
Robbie Averill	79fa61edf8	FIX Type safety on nullable argument, fixes PHP 7.4 test	2019-07-19 12:05:27 +02:00
Robbie Averill	2a1394bed7	Merge branch '4.4' into 4	2019-07-19 10:46:00 +02:00
Robbie Averill	40f06fafa9	Merge branch '4.3' into 4.4	2019-07-19 10:45:44 +02:00
Robbie Averill	c7b15eaef5	Merge branch '4.2' into 4.3	2019-07-19 10:45:29 +02:00
Simon Gow	22b514c421	#9114 - DBText::ContextSummary() cuts line breaks ... ContextSummary() was cutting the HTML which was added by nl2br because it expected plain text elements as it's stripping and replacing text. Instead this fix changes the behaviour to apply the nl2br after the text changes have been made. That way we can't cut anything in the middle of a HTML tag, but new lines, or paragraphs are replaced by BRs after, should they exist. - Added tests to ensure text is not cut in the middle of a sentence. - Added test to ensure that <br>'s are added in the correct place should the summary span between new lines.	2019-07-19 12:43:20 +12:00
Serge Latyntcev	29a663c65d	Merge branch '4.4' into 4	2019-07-15 09:24:49 +12:00
Serge Latyntcev	d667d64f13	Merge branch '4.3' into 4.4	2019-07-15 09:18:17 +12:00
Guy Marriott	ec66d366d2	NEW: Deprecated PDO in favour of native drivers (#9052) ... NEW: Deprecated PDO in favour of native drivers	2019-07-08 12:41:13 +12:00
Serge Latyntsev	7ef13e7ef6	FIX Confirmation components to respect SS_BASE_URL (#9074)	2019-07-05 16:05:41 +12:00
Robbie Averill	844d2ef134	NEW DBDate and DBDatetime now support modify() with a strtotime() style adjustment string (#9105)	2019-07-05 15:57:23 +12:00
Sam Minnee	404366909e	FIX: Fix MysqlStatement::rewind() ... Its implementation is more naive than Query’s and leads to unnecessary seek()ing. This causes issues with the previous commit.	2019-07-03 14:28:31 +12:00
Sam Minnee	96e7914f23	FIX: Fix MySQLQuery::seek() and Query::rewind() to fix repeated iteration ... API: Query::seek() and Query::rewind() no longer return a value. Although breaking an API inside a patch release may seem odd, this in fact is correcting a long-standing bug in our implementation of Iterator::rewind(), so I think it’s appropriate. https://github.com/silverstripe/silverstripe-framework/issues/9097	2019-07-03 09:20:05 +12:00
UndefinedOffset	571a4d9ace	NEW: Added support for config condition if PHP extension is loaded	2019-07-02 14:55:36 -03:00
Robbie Averill	ad050997fd	Merge pull request #9070 from kinglozzer/email-plaintext ... FIX: Email::render() generating object instead of string for plaintext part (fixes #9069)	2019-07-02 18:47:18 +12:00
Robbie Averill	fd88003646	Merge pull request #9100 from creative-commoners/pulls/4.4/dataobject-scaffolding-freedom ... Allow extensions to modify form scaffolder in DataObject	2019-07-02 18:46:39 +12:00
Guy Marriott	59ba9a717d	FIX Allow extensions to update form scaffolding on DataObjects	2019-06-28 16:11:16 +12:00
Guy Marriott	aeefb920e1	Allow displaying partial/full query message for debugging (#9020) ... Allow displaying partial/full query message for debugging	2019-06-28 15:15:33 +12:00
Robbie Averill	c76d3a5db1	FIX Protect against undefined index when using nullifyEmpty option	2019-06-26 09:26:36 +12:00
Loz Calver	b1551a687d	Catch Path::join() exceptions in findTemplate() (fixes #9084)	2019-06-21 09:40:18 +01:00
Saophalkun Ponlu	6a8c6703d1	Remove use_gzip from HTMLEditorField since it's been removed by TinyMCE codebase (#7261) ... * Remove `use_gzip` from HTMLEditorField * DOCS Mention remove use_gzip in changelog	2019-06-21 09:27:48 +12:00
Mario Sommereder	260c89fd54	Fix of delimiter not used bug ... See issue https://github.com/silverstripe/silverstripe-framework/issues/8881	2019-06-20 11:11:27 +12:00
Guy Marriott	bb5b610636	Merge branch '4.4' into 4	2019-06-17 08:58:50 +12:00
3Dgoo	7e12bee86a	Requirements_Backend.php API documentation fix ... The API documentation for Requirements_Backend is currently broken: https://api.silverstripe.org/4/SilverStripe/View/Requirements_Backend.html#method_customScript This is because there are unescaped start tags in the function documentation. This is the same as the recent #9060 PR, but for the Requirements_Backend class this time. This fix changes the tags to be escaped.	2019-06-15 10:37:49 +09:30
Loz Calver	8e87264864	FIX: Email::render() generating object instead of string for plaintext part (fixes #9069)	2019-06-14 11:39:47 +01:00
3Dgoo	8dcfa53109	Requirements.php API documentation fix ... The API documentation for Requirements is currently broken: https://api.silverstripe.org/4/SilverStripe/View/Requirements.html#method_customScript This is because there are unescaped start tags in the function documentation. This fix changes the tags to be escaped.	2019-06-13 09:21:12 +09:30
Sam Minnee	27ace03273	NEW: Deprecated PDO in favour of native drivers ... https://github.com/silverstripe/silverstripe-framework/issues/8598	2019-06-11 16:17:30 +12:00
Aaron Carlino	d04e54c1be	Merge branch '4.4' into 4	2019-06-10 17:33:30 +12:00
Aaron Carlino	c747b1f8d3	Merge branch '4.3' into 4.4	2019-06-10 17:32:07 +12:00
Aaron Carlino	f766555d61	Merge branch '4.2' into 4.3	2019-06-10 17:27:05 +12:00
Serge Latyntcev	ca56e8d78e	[CVE-2019-12246] Denial of Service on flush and development URL tools	2019-06-10 17:23:56 +12:00
Aaron Carlino	e2da7b0dc4	Merge branch '4.4' into 4	2019-06-10 16:37:16 +12:00
Sam Minnée	654156d46d	FIX: Fix bug when confirmed password is changed but not the password. (#9012) ... In this case the confirmed password field is not reflected. It’s unclear how often this situation would arise outside of test scenarios, but may come up if $form->loadDataFrom() is called more than once. Fixes #2496 (it’s a minor issue but I think this is why Dan flagged it as a regression). Originally introduced as part of Dan’s initial fix at 2a6f1f1949.	2019-06-10 15:48:29 +12:00
Robbie Averill	179a982f45	Merge pull request #9019 from rafaeldsousa/pull/include-cancreate-check-gridfield-rightgroupfield ... Including canCreate in if statement so that button gets removed if us…	2019-06-10 09:59:45 +12:00
Maxime Rainville	761f7d15ce	Merge pull request #9045 from open-sausages/pulls/4.4/in-memory-cache-opt-out ... Opt-out of in-memory caching factory	2019-06-07 12:40:46 +12:00
Ingo Schommer	8324235eda	API Opt-out of in-memory caching factory ... In-memory caches are typically more resource constrained (number of items and storage space). Give cache consumers an opt-out if they are expecting to create large caches with long lifetimes. Use case: https://github.com/silverstripe/silverstripe-assets/pull/282	2019-06-07 12:21:10 +12:00
Andre Kiste	1da181a3b3	Merge pull request #9022 from open-sausages/pulls/4.4/migrate-task-colours ... NEW Clearer file migration output with colours	2019-06-06 15:46:28 +12:00
Ingo Schommer	f4cdfb06c8	Update environment timeouts ... See https://github.com/silverstripe/silverstripe-framework/issues/9029	2019-06-06 15:18:12 +12:00
Robbie Averill	e8fa3d8750	DOCS Fix incorrect deprecation reference in MonologErrorHandler	2019-06-06 09:30:50 +12:00
Ingo Schommer	b21e5d9e57	Moved time limit increases from individual job ... Should apply to all file migration subtasks, not just the first one (see silverstripe/assets)	2019-06-05 15:10:46 +12:00
Ingo Schommer	2d4711de01	Fixed logging ... Broke loggers attached by queuedjobs because it wasn't using the global service. Since the stderr handler was set to bubble=false, those messages weren't picked up by queuedjobs. Removed preformatted handler since there's no longer an ability to run this stuff via web	2019-06-05 15:09:58 +12:00
Ingo Schommer	7301b375b8	NEW Clearer file migration output with colours	2019-06-05 11:41:06 +12:00
Jarkko Linnanvirta	9184056b5e	URLSegmentFilter: Remove : characters from url segments when multibyte characters are allowed.	2019-06-02 11:43:51 +03:00
Guy Marriott	0520d77461	API checkHistoricalPasswords(), characterStrength() and minLength() are now correctly deprecated from 4.5.0 onwards (#9008) ... API checkHistoricalPasswords(), characterStrength() and minLength() are now correctly deprecated from 4.5.0 onwards	2019-05-31 09:56:39 +12:00
Robbie Averill	6678f92681	Merge pull request #9025 from taoceanz/4 ... Removed unused use BadMethodCallException statement.	2019-05-30 09:38:47 +12:00
Robbie Averill	00fd74a0a1	Merge branch '4.4' into 4 ... # Conflicts: # src/Dev/Tasks/MigrateFileTask.php	2019-05-30 09:36:42 +12:00
Robbie Averill	14673ffd0a	Merge branch '4.3' into 4.4	2019-05-30 09:35:26 +12:00
Robbie Averill	188698dcee	Merge branch '4.2' into 4.3	2019-05-30 09:35:17 +12:00
Robbie Averill	7f69cc8f94	Merge branch '4.1' into 4.2	2019-05-30 09:35:06 +12:00
Robbie Averill	02864aba3f	Merge branch '4.0' into 4.1	2019-05-30 09:34:55 +12:00
Robbie Averill	3e2fc6aa0b	Automated phpcbf linting	2019-05-30 09:34:34 +12:00
Robbie Averill	a1f0d7a3bf	Merge pull request #9016 from sminnee/partial-fix-4622 ... FIX: Better message when form action handler not found.	2019-05-30 09:22:54 +12:00
Thomas Ocean	e30483a7dc	Removed unused use BadMethodCallException statement.	2019-05-30 09:08:33 +12:00
shoosah	80e4886c3f	Add getter and change visibility for whitelist_array property	2019-05-28 14:15:12 +12:00
Rafael Marins de Sousa	f7c1be7ac1	Including canCreate in if statement so that button gets removed if user isn't to be able to create new records	2019-05-28 12:28:00 +12:00
shoosah	d740998463	Improve displayQuery and benchmarkQuery functions and whitelist_array variable	2019-05-28 12:00:05 +12:00
shoosah	d684c69f09	Allow displaying partial/full query message for debugging	2019-05-28 12:00:05 +12:00
Andre Kiste	2c8c643ce3	MigrateFileTask now outputs "Done" when it has finished running (#8995)	2019-05-28 09:45:13 +12:00
Maxime Rainville	4f39e59aff	BUG Enable file hash caching when running the file migration task (#8993)	2019-05-28 09:37:45 +12:00
Maxime Rainville	5b6d0946f4	API Add extension points to MigrateFileTask (#8994) ... * API Add extension points to MigrateFileTask * Apply suggestions from code review Co-Authored-By: Guy Marriott <guy@scopey.co.nz>	2019-05-28 09:24:01 +12:00
Maxime Rainville	7ef604807c	BUG Enable file hash caching when running the file migration task (#8993)	2019-05-28 09:21:11 +12:00
Maxime Rainville	9bfce8c1a4	API Add extension points to MigrateFileTask (#8994) ... * API Add extension points to MigrateFileTask * Apply suggestions from code review Co-Authored-By: Guy Marriott <guy@scopey.co.nz>	2019-05-28 09:19:05 +12:00
Sam Minnee	7407096e99	FIX: List default items in the readonly view of ListboxField ... Adds tests for non-readonly default items too. Fixes #4142	2019-05-27 17:47:09 +12:00
Sam Minnee	983d36b7ee	FIX: Better message when form action handler not found. ... Fixes #4622 to some extent, although this fix will be most useful when https://github.com/silverstripe/silverstripe-errorpage/issues/30 is addressed also.	2019-05-27 15:00:10 +12:00
Robbie Averill	d873779956	API checkHistoricalPasswords(), characterStrength() and minLength() are now correctly deprecated from 4.5.0 onwards	2019-05-27 09:12:32 +12:00
Dylan Wagstaff	25aa3af032	FIX HeaderField requires the optional Title field ... FormField marks the Title constructor argument as optional, and DatalessField does not override the __construct method. HeaderField on the other hand goes against the grain of FormFields as a whole and requires the Title field, seemingly for no good reason (at least, not that the commit message for a68ba38478 indicates) - this seems like an accidental ommision. This commit looks to reinstate the optionality of this constructor argument for consistency's sake. Plus it broke a module I was investigating.	2019-05-24 13:44:01 +12:00
Robbie Averill	32c04ce765	Merge pull request #8979 from silverstripe-terraformers/feature/add-extension-for-schema-validation ... Add extend function in getSchemaValidation function	2019-05-16 11:22:45 +12:00
Guy Marriott	350888bf50	NEW Adding a shuffle method to ArrayList (#8984) ... * NEW Adding a shuffle method to ArrayList * API Add shuffle to DataList for ArrayList parity	2019-05-16 09:26:11 +12:00
Aaron Carlino	3f1479edbb	BUGFIX: DataQuery overwriting _SortColumn selects (#8974) ... * BUGFIX: DataQuery overwriting _SortColumn selects * FIX DataQuery _SortColumn handling	2019-05-15 11:42:10 +12:00
shoosah	4da8be3bf5	Add extend function in getSchemaValidation function ... This allows to create extensions which add validation list	2019-05-14 09:47:14 +12:00
Aaron Carlino	dfa90715f7	Merge branch '4.4' into 4	2019-05-13 16:08:05 +12:00
Guy Marriott	abaeeb9432	Merge branch '4.3' into 4.4	2019-05-13 15:56:41 +12:00
Guy Marriott	53cb804929	Merge branch '4.2' into 4.3	2019-05-13 15:56:23 +12:00
matt-in-a-hat	db0e6f7104	Fix password validation min length message ... When relying on static config instead of an explicitly set minLength then this message would show without the value, like "it must be or more characters long".	2019-05-13 13:43:29 +12:00
aNickzz	28be2b2263	Swap argument order for implode ... I noticed this squiggly red line while perusing the code. The PHP doc says `implode ( string $glue , array $pieces ) : string` > implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.	2019-05-11 00:32:23 +09:30
Aaron Carlino	2bdf1eac0a	Merge branch '4.4' into 4	2019-05-06 16:03:35 +12:00
Guy Marriott	856e841955	FIX Ensuring pagination buttons have a consistent state to work off of (#8957)	2019-05-06 14:42:25 +12:00
Guy Marriott	371588e8b1	Merge pull request #8961 from indygriffiths/patch-1 ... NEW Only get an authenticator if it's an object	2019-05-06 14:27:18 +12:00
Maxime Rainville	8ee50d2ba7	API Remove DataObjectSchema::getFieldMap() (#8960) ... Introduced as a less public API in https://github.com/silverstripe/silverstripe-assets/pull/227	2019-05-06 12:33:23 +12:00
Indy Griffiths	5dc57518c2	NEW Filter out authenticators that are falsy ... Use-case: if a module is defining its own authenticator and you want to disable it, as it seems we don't have `unregister_authenticator()` anymore and I can't spot how to remove YAML-based injected properties, then this lets you mark it as null or false to prevent it from erroring out when it attempts to call `supportedServices()`	2019-05-04 20:58:48 +12:00
Robbie Averill	5337e6d048	API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons (#8953) ... * FIX Add accessibility labels and titles to previous, next, and add new buttons in GridFields * API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons * FIX Previous and Next links are now correctly disabled when end of lists are reached * Add English translations	2019-05-03 15:03:59 +12:00
Guy Marriott	82c8225502	Merge branch '4.3' into 4.4	2019-05-03 09:45:25 +12:00
Ingo Schommer	1f78e8ae80	NEW Clean up secureassets module artefacts (#8948) ... See https://github.com/silverstripe/silverstripe-assets/issues/231	2019-05-02 21:05:19 +12:00
Andre Kiste	48db515fbd	NEW Fix folder permissions (#8950) ... * Add `FixFilePermissionsHelper` subtask * Changed name to folder permissions, added more loggin	2019-05-02 16:28:57 +12:00
Serge Latyntcev	3d777cfb8a	Backward compatible behaviour for SQLConditionalExpression::getJoins	2019-05-02 15:39:36 +12:00
Ingo Schommer	0696045e59	NEW Legacy thumbnail migration task (#8924) ... * NEW Legacy thumbnail migration task See https://github.com/silverstripe/silverstripe-assets/issues/235 Makes a start at https://github.com/silverstripe/silverstripe-assets/issues/219 as well * API Removed migrate_legacy_file support For the vast majority of sites, you really don't want to run your file migration as part of dev build. The step is involved enough to warrant it's own task. I don't think this is an API change, since the setting won't have affect for anyone who has already enabled it - they would've already done the one-off migration. See https://github.com/silverstripeltd/open-sourcerers/issues/91 and https://github.com/silverstripe/silverstripe-assets/issues/235	2019-05-02 09:33:53 +12:00
Guy Marriott	ecfe039e72	FIX Don't add "better buttons" previous and next without a paginator	2019-05-01 15:48:03 +12:00
Andre Kiste	0c6c57f1ef	Add getFieldMap method to retrieve a list of all fields for any giv… (#8892) ... * Add `getFieldMap` method to retrieve a list of all fields for any given class * Add `TagsToShortcodeTask` to upgrading guide Adding after the file migration part as this is where it makes the most sense to run it. * `getFieldMap` accepts an array * Move to `DataObjectSchema` * Add `HTMLVarchar` to documentation Minor refactoring * Add test for checking that `subclassesfor` works without the base class Add test `DataObjectSchema::getFieldMap` returns the correct array * Remove cms dependency	2019-04-30 10:43:14 +12:00
Andre Kiste	2bcf8b5ff3	More verbose file migration logging ... See https://github.com/silverstripeltd/open-sourcerers/issues/91 * Add `PreformattedEchoHandler` cherry-picked from 4c3f3e6bea99b46b689e5b23d1bd1498a4ac696c * Batch log messages for every 100 file. Also make logger work for stdout * Update src/Logging/PreformattedEchoHandler.php Co-Authored-By: bergice <bergice@users.noreply.github.com>	2019-04-30 08:54:48 +12:00
Robbie Averill	8c6bf7ce53	Merge branch '4.3' into 4.4	2019-04-21 11:09:25 +12:00
Robbie Averill	523456ae09	Merge pull request #8921 from creative-commoners/pulls/4.3/threshold-count-in-sql ... FIX Calculate threshold condition with SQL rather than PHP	2019-04-21 01:25:24 +12:00
Guy Marriott	80ad336e97	NEW Add API to create a generator from a DataList (#8931)	2019-04-18 15:31:41 +12:00
Aaron Carlino	c63eecc3e1	Merge branch '4.3' into 4	2019-04-18 11:57:36 +12:00
Guy Marriott	da1af3d8b0	FIX Postgres booleans should return as int for consistency	2019-04-17 15:15:17 +12:00
Sam Minnée	6a2762662b	MINOR: Change “Choose Page” to “Search or choose Page” (#8766) ... * MINOR: Change “Choose Page” to “Search or choose Page” Based on discussions with James Ford, it wasn’t clear that you could search. * Use new translation key	2019-04-16 16:06:37 +12:00
Guy Marriott	9d6b5048a6	FIX Table aliases are retained on base tables in queries built using SQLConditionalExpression (#8918) ... * Adding failing test for base table aliases using SQLSelect * FIX Retain table aliases applied to the base table on queries * FIX Move the trimmed alias outside of the condition so we can use it within the condition	2019-04-16 15:40:09 +12:00
Guy Marriott	7fd6e14423	Adding comment about the === 't' condition for supporting postgres	2019-04-16 12:10:13 +12:00
Guy Marriott	a48beac845	FIX Calculate threshold condition with SQL rather than PHP ... This is a performance fix. Modern SQL engines can avoid counting a whole result set (potentially thousands of records) when you are only interested if the count exceeds a threshold.	2019-04-15 16:48:44 +12:00
Sheila Bañez	63360f8048	BUG Replace substr with mb_substr to get the correct position	2019-04-15 16:38:52 +12:00
Guy Marriott	b1339f0d72	NEW Update FieldList::replaceField API to match removeByName (#8876) ... * API Update FieldList::replaceField API to match removeByName This specifically adds the parameter that `removeByName` has but `replaceField` does not. This parameter is set to `true` by default rather than inheriting the same default as `removeByField`. This is because the existing funtionality of `replaceField` was the same as if this parameter was set to `true`. This should be updated in SS5 to match the `removeByField` API. * Add dataFieldOnly to CompositeField	2019-04-15 16:22:54 +12:00
Ralph Slooten	66c372ce28	Include baseURL with relative setGetVar() links (#8834) ... * Return baseURL with setGetVar * Adjust testSetGetVar tests for base url	2019-04-15 14:50:46 +12:00
Robbie Averill	2c971eea83	Merge branch '4.3' into 4	2019-04-11 11:37:47 +12:00
Robbie Averill	f2f28586d9	Merge branch '4.2' into 4.3	2019-04-11 11:37:34 +12:00
Robbie Averill	116ea12783	Merge branch '4.1' into 4.2	2019-04-11 11:37:22 +12:00
Robbie Averill	f4a6115ee6	Merge branch '4.0' into 4.1	2019-04-11 11:36:40 +12:00
Robbie Averill	8a06682e31	Merge branch '4.3' into 4 ... # Conflicts: # src/ORM/Connect/DBSchemaManager.php	2019-04-11 11:24:17 +12:00
Robbie Averill	55cbacca86	Merge branch '4.2' into 4.3 ... # Conflicts: # src/Forms/GridField/GridFieldLevelup.php # src/includes/constants.php	2019-04-11 11:21:42 +12:00
Sam Minnee	f12fa62ad6	FIX: Better error message when GridFieldLevelup passed bad record details ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/3519	2019-04-08 18:09:51 +12:00
Loz Calver	594af77134	FIX: prevent unnecessary field alterations for enums with empty defaults	2019-04-05 16:17:41 +01:00
Robbie Averill	8b4b54f264	PHPCS linting error on indentation	2019-04-05 16:29:24 +13:00
Sam Minnee	c9c7c0c825	FIX: Fix PDO cached statement column coercion ... NEW: Add PDOStatementHandle class that is now what PDOQuery expects	2019-04-05 15:11:21 +13:00
Sam Minnee	45e1fcaf30	FIX: Correct type coercion of MySQL	2019-04-05 15:11:21 +13:00
Sam Minnee	adb6e9eb8d	FIX: Perform type coercion on PDO-based MySQL and SQLite connections ... It turns out that this is needed for decimal values on MySQL and all values on SQLite	2019-04-05 15:05:42 +13:00
Ingo Schommer	afb3c825c9	Merge pull request #8890 from open-sausages/pulls/4/get-installer-to-self-create-assets-folder ... BUG Update installer to create the assets folder if its missing	2019-04-05 14:41:01 +13:00
Ian Patel	759968bbe2	Fix Undefined variable: result when catch Exception	2019-04-05 11:33:01 +13:00
Guy Marriott	a9d57f5bfb	Merge pull request #8241 from creative-commoners/pulls/4.3/separate-logging ... Separate core error logging from standard LoggerInterface	2019-04-05 08:49:09 +13:00
Rafael Marins de Sousa	68337bd8be	Including is_array validation to getEnv method. When SS website is deployed to FortRabbit .env file is read as string what causes the website to crash, due to the lack of type check at getEnv method.	2019-04-04 15:41:13 +13:00
Maxime Rainville	c84ad4278f	BUG Update installer to create the assets folder if its missing	2019-03-29 17:56:39 +13:00
Aaron Carlino	fc6213c293	Merge branch '4.3' into 4	2019-03-27 13:25:57 +13:00
Aaron Carlino	9eac374b13	Use strcasecmp	2019-03-27 12:40:56 +13:00
Jonathon Menz	fae19c16b5	FIX has_one File form scaffolding ... Only allow selection of a single file when scaffolding has_one File relationship (fixes #8862)	2019-03-26 09:50:59 -07:00
Damian Mooyman	6dc41e50a0	MINOR Linting fixes	2019-03-26 17:35:58 +13:00
Damian Mooyman	83ec0b69fa	BUG Resolve issue where schema changes between enum / non-enum types	2019-03-26 14:16:05 +13:00
Loz Calver	8483a9644c	Merge pull request #8874 from johannesx75/fix-pdoconnector-generatedid-type-2 ... Fix PDOConnector GeneratedID return type	2019-03-22 09:09:23 +00:00
Daniel Hensby	6d4d332448	Merge pull request #8830 from ntd/pr7 ... Fix #8829: mention get_one does not escape field names	2019-03-21 14:38:34 +00:00
Johannes Hammersen	e1190e33d2	Fix PDOConnector GeneratedID return type	2019-03-21 09:26:14 +01:00
Kong Jin Jie	1d406c64b9	Fix: Allow editing of relation if item is created.	2019-03-20 12:51:49 +08:00
Aaron Carlino	f6a7bddd8d	Linting	2019-03-20 15:50:54 +13:00
Aaron Carlino	388baa01b4	Fix linting	2019-03-20 13:19:10 +13:00
Aaron Carlino	aa491d9294	Fix tests	2019-03-20 12:33:00 +13:00
Aaron Carlino	39a29fa2f6	ENHANCEMENT: has_extension() should allow injector overrides	2019-03-20 12:33:00 +13:00
Damian Mooyman	6b450395ce	API Allow empty arraylists to be typed (#8866) ... * API Allow empty arraylists to be typed * PHPCBF fixes	2019-03-20 11:46:35 +13:00
Robbie Averill	0777ab5ee7	Merge pull request #8847 from blueo/pulls/optional-test-teardown ... Add option to leave Temp DB when exiting	2019-03-19 15:58:31 +13:00
Bernard Hamlin	8d1a238e97	Add option to leave Temp DB when exiting	2019-03-19 14:37:13 +13:00
Loz Calver	ca781c684d	FIX: RequestHandler::__construct() should run after middlewares (fixes #8848)	2019-03-11 11:08:03 +00:00
Nicola Fontana	252397d8d1	Fix #8829: mention get_one does not escape field names	2019-03-08 08:20:47 +01:00
Dan Hensby	765d1568ab	Merge branch '4.3' into 4	2019-03-06 11:04:50 +00:00
Dan Hensby	a8605b04e0	Merge branch '4.2' into 4.3	2019-03-06 11:04:14 +00:00
Dan Hensby	7e34167ddf	Merge branch '4.1' into 4.2	2019-03-06 11:01:17 +00:00
Dan Hensby	625e6d5f54	Merge branch '4.0' into 4.1	2019-03-06 11:00:41 +00:00
Guy Marriott	f8f6983773	Merge pull request #8793 from wilr/pulls/orm-exception ... Throw error message when searchable_field does not return a object	2019-03-06 08:50:50 +13:00
Daniel Hensby	7416ce275b	FIX doInit comparison should be lowercased	2019-03-05 19:01:12 +00:00
Damian Mooyman	d1396b7dfe	BUG Fix writeBaseRecord with unique indexes ... Fixes #6819	2019-02-27 16:40:12 +13:00
Maxime Rainville	11b9429c34	Merge branch '4.3' into 4	2019-02-27 12:14:51 +13:00
Maxime Rainville	651d537196	Merge branch '4.2' into 4.3	2019-02-27 12:13:24 +13:00
Maxime Rainville	ed013fcfbb	Merge branch '4.1' into 4.2	2019-02-27 12:12:39 +13:00
Maxime Rainville	ac53f77115	Merge branch '4.0' into 4.1	2019-02-27 12:11:47 +13:00
Robbie Averill	7ab55a4948	Add LoggerState to disble user-configured logging during PHPUnit tests	2019-02-22 11:43:01 +07:00
Maxime Rainville	9a59f2f57d	BUG Renable the ability to do dynamic assignment with DBField	2019-02-22 11:08:43 +13:00
Robbie Averill	3e90fdf42f	Merge branch '4.3' into 4	2019-02-19 08:41:05 +07:00
Robbie Averill	ed74549c4f	Merge branch '4.2' into 4.3	2019-02-19 08:39:59 +07:00
Robbie Averill	79e44b42fa	Merge branch '4.1' into 4.2	2019-02-19 08:37:07 +07:00
Robbie Averill	cb7f15a681	Merge branch '4.0' into 4.1	2019-02-19 08:36:41 +07:00
Aaron Carlino	09c539e1c3	Merge branch '4.3' into 4	2019-02-19 12:21:24 +13:00
Maxime Rainville	25bba49923	[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation	2019-02-19 12:20:24 +13:00
Robbie Averill	7a508af387	Merge pull request #8795 from creative-commoners/pulls/4.3/improve-foreign-key-form-field-scaffolding ... FIX Caching the result of counting a foreign list for performance	2019-02-12 15:56:11 +07:00
Maxime Rainville	95505db7d6	[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation	2019-02-12 21:08:09 +13:00
Maxime Rainville	fd90cf6ceb	[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation	2019-02-12 20:44:17 +13:00
Guy Marriott	0ac43ce025	FIX Caching the result of counting a foreign list for performance	2019-02-12 15:28:03 +13:00
Will Rossiter	d4f6ff98c8	Throw error message when searchable_field does not return a object ... While upgrading 4.2 to 4.3 the behaviour of GridFieldFilterHeader has changed (example code: https://gist.github.com/wilr/7c59f577e1d072eb66e4c0c84cba6732). This patch doesn’t affect the behaviour (since the explict object is a better API) but it makes upgrading easier to identify the field.	2019-02-12 09:39:27 +13:00
Damian Mooyman	b8122f88c5	Merge pull request #8174 from creative-commoners/pulls/4.2/deprecated-fixture-state ... MINOR Replace use of deprecated getFixtureFactory() with FixtureTestState	2019-02-11 14:16:37 +13:00
Robbie Averill	a104b5b48f	Merge pull request #8769 from creative-commoners/pulls/4.0/escape_for_like ... FIX Escape wildcard characters when matching database name in databaseExists	2019-02-10 08:26:28 +03:00
Loz Calver	7c5b73881b	FIX: Prevent null->null being flagged as a value change (fixes #8774)	2019-02-06 13:24:18 +13:00
Guy Marriott	b2e18dda9c	Merge pull request #8783 from open-sausages/pulls/4/docs-dataobject-update ... DOC Clarify DataObject->update() use	2019-02-04 21:45:13 +13:00
Ingo Schommer	a78573b517	DOC Clarify DataObject->update() use	2019-02-04 20:47:27 +13:00
Robbie Averill	7775f82584	FIX Handle falsy return value when setting form field value in setAuthenticatorClass()	2019-02-01 19:39:15 +03:00
Robbie Averill	ebfab45e23	API LoginForm::authentiator_class is now deprecated, use getters or setters instead	2019-02-01 19:39:15 +03:00
Robbie Averill	3d5c330e17	Merge pull request #8558 from open-sausages/pulls/4/deprecating-declared-permissions ... API Deprecating Permission::$declared_permissions and related methods/props	2019-01-30 19:48:41 +02:00
Maxime Rainville	8ec9c50c58	DOCS Correct documentation for ExecMetricMiddleware	2019-01-30 13:58:09 +13:00
Maxime Rainville	868258926f	Implement feedback on PSR-19 compatibility	2019-01-30 11:57:17 +13:00
Guy Marriott	f918dcd36a	FIX Escape wildcard characters when matching database name in databaseExists	2019-01-30 09:31:13 +13:00
mikeyc7m	0491ca03cf	FIX prevent death on urls with querystrings & anchors	2019-01-29 13:15:14 +02:00
Robbie Averill	b0fc161235	Merge branch '4' into pulls/4/deprecating-declared-permissions	2019-01-29 09:33:44 +02:00
Andre Kiste	d2c8530fec	Merge pull request #8733 from open-sausages/pulls/4/add-exectmetric-url-debug-param ... NEW Add new execmetric debur URL parameter to print out exection time and peak memory usage	2019-01-29 18:49:10 +13:00
Maxime Rainville	c4bf06f600	NEW Add new execmetric debug URL parameter to print out exection time and peak memory usage	2019-01-29 17:28:28 +13:00
Maxime Rainville	a589bcb092	Merge pull request #8729 from emteknetnz/bugfix/htmlvalue-getcontent ... Ensure document is not falsey before attempting to clone it	2019-01-29 09:11:04 +13:00
Loz Calver	785e9f123f	Replace self:: with static:: for shortcode methods	2019-01-28 14:51:34 +00:00
Robbie Averill	dc9d1b9cc0	FIX GridFieldPrintButton no longer assumes that children of GridField would implement their own print template	2019-01-28 11:45:55 +02:00
Guy Marriott	fad221bf1c	Merge pull request #8756 from open-sausages/pulls/4/string-cast-dropdownfield-entry-title ... MINOR Always cast formfield display value as a string to avoid 0 being blank	2019-01-28 12:09:20 +13:00
Guy Marriott	7ee0dff391	Merge pull request #8745 from open-sausages/pulls/4/add-extra-message-to-MigrateFileTask ... MINOR Add message to inform user that the task can be run again	2019-01-28 09:24:00 +13:00
Maxime Rainville	db466fb013	MINOR Always cast formfield display value as a string to avoid 0 being blank	2019-01-25 13:34:36 +13:00
Benedikt Seidl	d530bc2fb6	fix user feedback when jquery could not be loaded	2019-01-24 20:51:48 +01:00
Robbie Averill	d8cd085190	Merge branch '4.3' into 4	2019-01-24 17:14:09 +02:00
Maxime Rainville	39297b8640	MINOR Add message to inform user that the task can be run again without issue	2019-01-23 18:40:15 +13:00
Simon Gow	c28670ebed	#8724 - Session timeout regression ... Only emit the session refresh cookie if the session timeout is set.	2019-01-18 10:07:53 +13:00
Simon Gow	af08328e8e	Existing sessions need to set a new cookie on each request, if the ... session exists, otherwise our expiry is never updated and sessions can't roll on every request.	2019-01-17 17:37:35 +13:00
Steve Boyd	7ea218aa1c	Ensure document is not falsey before attempting to clone it	2019-01-16 16:24:45 +13:00
Maxime Rainville	13486ca80e	MINOR Add unit test for Requirements::add_i18n_javascript()	2019-01-16 10:36:53 +13:00
Maxime Rainville	c6214b855f	MINOR Update add_i18n_javascript to load lowercase-dash language files	2019-01-15 15:04:39 +13:00
Damian Mooyman	34ac228029	BUG Fix issue with assertListEquals() ignoring field getters	2019-01-11 11:35:11 +13:00
Aaron Carlino	ab5bbda88c	Merge branch '4.3' into 4	2019-01-10 12:31:27 +13:00
Maxime Rainville	1e01deea39	NEW Make resources dir configurable (#8519) ... * NEW Make resources dir configurable. * Removing reference to old `resources` and updating doc #8519 * Rrtarget to 4.4 release. * DOC Reference SS_RESOURCES_DIR in Environment doc. * API Add a Resources method to SilverStripe\Core\Manifest\Module to read the resources-dir from composer.json * Clean up reference to SS_RESOURCES_DIR env var * Set default resources-dir * Update test to use RESOURCES_DIR const in expected resource url method * Correcting typos Co-Authored-By: maxime-rainville <maxime@rainville.me> * MINOR Correctubg minor typos * DOCS Document the intricacies of exposing static assets.	2019-01-09 15:35:45 +13:00
Robbie Averill	068c240d38	Update src/Core/CustomMethods.php ... Co-Authored-By: jchenevey <jchenevey@users.noreply.github.com>	2019-01-08 15:27:38 -05:00
Joe Chenevey	3730d84d18	Update CustomMethods.php ... Switch to an early `continue` rather than wrapping contents of `foreach` in an `if` and indenting.	2019-01-08 15:24:21 -05:00
Joe Chenevey	afceccb9a6	CustomMethods->removeMethodsFrom Warnings ... Check to ensure `self::$extra_methods[$class][$method]` exists before trying to retrieve its value. Silences warnings generated by updating a controller's failover.	2019-01-08 15:14:23 -05:00
Robbie Averill	7c96feef37	Merge branch '4.3' into 4	2019-01-08 12:27:48 +01:00
Robbie Averill	394dd4765c	NEW Scaffolded field labels now only have an uppercased first word	2019-01-07 17:52:28 +01:00
Kong Jin Jie	1667af8f5e	Add $disabledItems to check for disabled items instead of checking against $defaultItems ... Fixes #8688	2018-12-31 17:25:11 +08:00
Russell Michell	0397c54b5a	FIX: Fixes #8459 ... - Missing conditionals for optional constructor args - Missing calls to FieldList::setForm() - Missing guards around naive calls to Form::Fields()->foo()	2018-12-19 13:28:19 +13:00
Simon Gow	d01585cc98	#8543 Resolve Duplicate Headers ... - fix linting	2018-12-19 12:39:32 +13:00
Simon Gow	1edfa4d956	#8543 Resolve Duplicate Headers ... - Replace session name lookup with function to also check secure cookies - Added timeout which defaults to 0 (same as PHP) - Removed php7 style of session_start from PR - moved session_start into headers sent block to prevent warnings.	2018-12-19 12:39:32 +13:00
Simon Gow	4eb6669c08	#8543 Resolve Duplicate Headers ... Put cookie_lifetime back into the session parameters.	2018-12-19 12:39:32 +13:00
Simon Gow	2deb8f4176	Resolve Duplicate Headers ... Ensure only a single Set-Cookie header is returned from Session once we have data to save. Include backwards compatibility for PHP56	2018-12-19 12:39:32 +13:00
Maxime Rainville	7f6b80f87d	Correct session doc typo	2018-12-14 13:01:22 +13:00
Guy Marriott	87b74b9cc1	Correcting Max's eggrigious typos ... Co-Authored-By: maxime-rainville <maxime@rainville.me>	2018-12-13 13:50:35 +13:00
Maxime Rainville	6e214e2e8b	DOCS Updating Session doc to reflect that you need to operation on an instance.	2018-12-13 11:05:49 +13:00
Robbie Averill	470093de2f	Merge pull request #8650 from sminnee/nested-vendor ... FIX: Manifest should ignore vendor folders within packages contained in vendor	2018-12-12 19:52:03 +00:00
Aaron Carlino	ab116cd5d9	Merge branch '4.1' into 4.2	2018-12-12 15:56:53 +13:00
Robbie Averill	74698af402	[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection	2018-12-11 20:57:18 +13:00
Robbie Averill	8bd747d12a	[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection	2018-12-11 20:56:55 +13:00
Robbie Averill	fecedc2d98	[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection	2018-12-11 20:56:40 +13:00
Robbie Averill	48bd335648	[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection	2018-12-11 20:55:58 +13:00
Robbie Averill	5d7c5ffb07	Merge branch '4.3' into 4	2018-12-06 09:40:40 +00:00
Robbie Averill	08866f89d9	Merge branch '4.2' into 4.3	2018-12-06 09:40:05 +00:00
Robbie Averill	96bd17d469	Merge branch '4.1' into 4.2	2018-12-06 09:38:45 +00:00
Robbie Averill	3f532466d1	Merge branch '4.0' into 4.1	2018-12-06 09:37:52 +00:00
Guy Marriott	6edcbe9086	Merge pull request #8592 from open-sausages/pulls/4.0/tree-multiselect-null ... FIX TreeMultiselectField passes value 'unchanged' as null to ORM	2018-12-06 14:23:48 +13:00
Guy Marriott	c7b5b1efd2	FIX Switching to use Controller::curr as it was using previously	2018-11-30 15:40:45 +13:00
Guy Marriott	32d096d9e5	DOCS Moving interface subscription to the abstract and adding a changelog entry	2018-11-30 15:40:45 +13:00
Guy Marriott	ddaa22986f	Updating StateStore interface not to define a constructor & fixing GridFieldFilterHeader to add required attributes	2018-11-30 15:40:45 +13:00
Guy Marriott	b4c8f699eb	FIX Provide alternatives to session for storing GridField_FormAction state	2018-11-30 15:40:45 +13:00
Sam Minnee	0c17ffc944	FIX: Manifest should ignore vendor folders within packages contained in vendor ... Without this change vendor/silverstripe/framework/vendor/silverstripe/config will be pick up by the manifest, which is inappropriate. Although this doesn’t happen often, it can occur if you have run “composer install” within vendor/silverstripe/framework, which can be done either accidentally or (in my case) as part of running the framework tests isolated from the rest of your project (which is closer to the execution model on Travis) Note that the presence of the ‘nestedvendor.txt’ file tests that this works without any explicit changes to the PHP of the tests, since it’s merely confirming that such a file is *not* picked up.	2018-11-30 13:52:25 +13:00
Loz Calver	3f8551df41	Merge pull request #8462 from sminnee/nondestructive-enum ... FIX: Make all enums non-destructive, not just ClassName	2018-11-28 16:42:12 +01:00
Loz Calver	441d079647	Merge pull request #8637 from creative-commoners/pulls/4.4/falsy-detail-component ... FIX getComponentByType can return null - prevent null pointer errors	2018-11-26 18:28:26 +01:00
Robbie Averill	f22a4b980b	FIX getComponentByType can return null - prevent null pointer errors	2018-11-26 16:01:46 +01:00
Robbie Averill	efa427fc45	FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected	2018-11-26 12:42:47 +01:00
Robbie Averill	1f1c344272	Merge branch '4.3' into 4 ... # Conflicts: # tests/php/Forms/ConfirmedPasswordFieldTest.php	2018-11-26 12:15:17 +01:00
Robbie Averill	41dc9229bf	FIX Reverting ExtensionTestState and Extensible extra methods modifications to prevent PHP 5.6 segfault (#8581) ... * API Revert addition of Extensible::flush_extra_methods_cache() and change to ExtensionTestState This reverts the changes from #8465 and #8505 that relate to ExtensionTestState and the tracking of extra methods between unit tests. The existing test from #8465 testing overloaded Extensions after extra_methods are populated has been updated to show that you must re-add the extension to flush the extra_methods cache if you need this behaviour. * Revert change to InjectorTest::testExtendedExtensions * Revert "Add failing test to show that overloaded extensions are broken in Extensible" This reverts commit 55e79ffdfd. * DOCS Add docs for extending extensions, and upgrade guide note to 4.3 to avoid using PHP config to do so	2018-11-26 12:00:02 +13:00
Andre Kiste	1d9e40ba26	Use new plus icon (#8619) ... * Use new plus icon and refactor * MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level * - Merge `showPrevious` and `showNext` to `showPagination` for grid fields - Update documentation - Improve performance for next/previous buttons by not fetching all list records - Refactoring * Refactor to fail gracefully on GridFieldPaginator * Fix merge	2018-11-23 12:40:18 +13:00
Serge Latyntcev	9ce6d91b76	FIX / TreeMultiselectField::objectForKey handles list of IDs correctly	2018-11-22 12:11:18 +13:00
Maxime Rainville	d74af1c17e	FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621	2018-11-21 11:43:21 +13:00
Andre Kiste	cc712892a9	NEW Port betterbuttons to framework (#8569) ... * MINOR: Add `Previous`, `Next` and `Create New` actions in edit form If the form is opened via a grid field, the filters will be retained so the previous/next record opened will be correct * MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level * Fix invalid action when pressing the `New` button in an edit form unless `betterbuttons` module was installed * - Merge `showPrevious` and `showNext` to `showPagination` for grid fields - Update documentation - Improve performance for next/previous buttons by not fetching all list records - Refactoring * Refactor to fail gracefully on GridFieldPaginator	2018-11-19 11:06:47 +13:00
Robbie Averill	3b1e91eb59	Merge branch '4.2' into 4.3	2018-11-15 13:41:23 +02:00
Robbie Averill	ef0f9dff8a	Merge branch '4.1' into 4.2	2018-11-15 13:41:00 +02:00
Robbie Averill	c6e3a398c7	Merge branch '4.0' into 4.1	2018-11-15 13:40:08 +02:00
Loz Calver	b5bae137bd	FIX: Redirect loop with multiple confirmation tokens present (fixes #8607)	2018-11-15 10:59:42 +00:00
Robbie Averill	580214cc30	API Add PHP deprecation notices to setLogger and getLogger	2018-11-13 11:12:06 +02:00
Robbie Averill	8854f053c8	Fix rebase conflicts	2018-11-13 11:09:33 +02:00
Robbie Averill	a8853504b4	API API MonologErrorHandler::setLogger is deprecated, use MonologErrorHandler::pushLogger instead	2018-11-13 11:08:27 +02:00
Robbie Averill	0a672372ff	Update typos in PHPDocs and comments	2018-11-13 10:59:37 +02:00
Robbie Averill	d37551de34	NEW Setters in DebugViewFreindlyErrorFormatter are now chainable	2018-11-13 10:59:37 +02:00
Serge Latyntcev	15aaf9db9f	Fix a code style typo	2018-11-13 10:20:49 +13:00
Guy Marriott	b2dd22fb50	Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests ... NEW Adding a stack more unit tests for logging and some form fields	2018-11-11 10:31:24 +13:00
Sam Minnee	bd5a815909	FIX: Make all enums non-destructive, not just ClassName ... This change also renders a portion of DBSchemaManager irrelevant, that destructively “fixes” old values. This is in keeping with the non-destructive principle of dev/build, and some suggestions to move away from enum fields altogether. Fixes https://github.com/silverstripe/silverstripe-framework/issues/1387	2018-11-10 12:10:25 +13:00
Robbie Averill	0f2eebe5d4	NEW Change to variadic calls in ListDecorator and add unit tests	2018-11-09 13:59:14 +02:00
Loz Calver	bbb208e1dd	Merge pull request #8499 from sminnee/fix-1489 ... FIX: CheckboxSetField can now save into DBMultiEnum	2018-11-09 10:40:55 +01:00
Robbie Averill	24d6527845	Merge branch '4.3' into 4	2018-11-09 11:39:27 +02:00
Robbie Averill	10f502f0c7	Merge branch '4.2' into 4.3	2018-11-09 11:39:05 +02:00
Robbie Averill	5b7723df7f	Merge branch '4.1' into 4.2 ... # Conflicts: # lang/fi.yml # lang/nl.yml	2018-11-09 11:38:04 +02:00
Robbie Averill	df4d2bd838	Merge branch '4.0' into 4.1 ... # Conflicts: # lang/da.yml # lang/eo.yml # lang/fi.yml # lang/it.yml # lang/nl.yml # lang/sv.yml	2018-11-09 11:36:34 +02:00
Sam Minnee	0cc39af382	DOC: Added documentation for strict type changes	2018-11-09 11:08:36 +13:00
Sam Minnee	2615399535	FIX: Use PDO’s built-in transaction support in MySQLDatabase.	2018-11-09 10:31:19 +13:00
Sam Minnee	0111b98b18	FIX: Ensure that types are preserved fetching from database ... This ensures that numeric fields appear in PHP as int/float values rather than strings, which allows the development of more type-safe PHP code. This doesn’t work on the legacy mysql driver and this will now throw a notice-level error. It requires mysqlnd.	2018-11-09 10:31:19 +13:00
Serge Latyntcev	4b4fbabed5	FIX TreeMultiselectField passes value 'unchanged' as null to ORM for 'ID' column key	2018-11-08 15:41:46 +13:00
Robbie Averill	e7041cdfeb	Merge pull request #8584 from wernerkrauss/cleanup-convert ... Cleanup Convert	2018-11-07 21:51:13 +02:00
Robbie Averill	358cef0cdf	Merge pull request #8514 from wilr/pulls/lookup-injector ... FIX use Injector for FormField::castedCopy	2018-11-07 19:20:36 +02:00
Robbie Averill	9da2899d23	Merge pull request #8560 from creative-commoners/pulls/4.4/random-deprecations ... NEW Deprecate RandomGenerator::generateEntropy in favour of using random_bytes directly	2018-11-07 19:09:33 +02:00
Werner M. Krauß	bc0f17fb09	Cleanup Convert ... * remove unneeded parenthesis and double quotes * simplify flow / remove unneeded else	2018-11-07 17:45:01 +01:00
Werner M. Krauß	3f321f935a	Convert::memstring2bytes should return integer value ... bytes are by nature an integer fixes #8572	2018-11-07 17:01:36 +01:00
Aaron Carlino	76936d863d	Merge branch '4.3' into 4	2018-11-07 23:20:44 +13:00
Loz Calver	11fe5b3adf	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:33:24 +13:00
Robbie Averill	9aabe0a0f7	[SS-2018-018] Ignore arguments in mysqli::real_connect backtrace calls	2018-11-07 11:33:24 +13:00
Loz Calver	8d7c2dafab	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:33:24 +13:00
Loz Calver	02ad0f44aa	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:32:55 +13:00
Robbie Averill	5425195238	[SS-2018-018] Ignore arguments in mysqli::real_connect backtrace calls	2018-11-07 11:32:55 +13:00
Loz Calver	af000bea9b	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:32:55 +13:00
Loz Calver	5563537cc8	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:31:33 +13:00
Robbie Averill	214e28127f	[SS-2018-018] Ignore arguments in mysqli::real_connect backtrace calls	2018-11-07 11:31:33 +13:00
Loz Calver	0610f76da0	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:31:33 +13:00
Loz Calver	0877442c64	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:24:51 +13:00
Robbie Averill	637b4225c6	[SS-2018-018] Ignore arguments in mysqli::real_connect backtrace calls	2018-11-07 11:24:51 +13:00
Loz Calver	3dbb10625c	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:24:51 +13:00
Robbie Averill	64c2938c96	Merge branch '4.3' into 4	2018-11-06 11:05:22 +01:00
Robbie Averill	3c58ae009e	Merge branch '4.2' into 4.3	2018-11-06 11:05:08 +01:00
Robbie Averill	22c7fa2bc9	Merge branch '4.1' into 4.2	2018-11-06 11:04:43 +01:00
Robbie Averill	6d2665d687	Merge branch '4.0' into 4.1	2018-11-06 11:04:28 +01:00
Werner M. Krauß	adafd73943	Convert::memstring2bytes should preserve -1 ... fixes #8570	2018-11-06 10:22:13 +01:00
Aaron Carlino	0ba275cb40	Merge branch '4.2' into 4.3	2018-11-06 15:09:01 +13:00
Aaron Carlino	e60cea8561	Merge branch '4.1' into 4.2	2018-11-06 15:08:42 +13:00
Robbie Averill	47fbaebb92	Alter deprecation version numbers ... Co-Authored-By: ScopeyNZ <guy@scopey.co.nz>	2018-11-06 00:07:24 +13:00
Sam Minnee	67fe41d00b	FIX: Ensure that repeated setting/unsetting doesn’t corrode forceChange()	2018-11-05 23:09:24 +13:00
Sam Minnee	5bb2d9484a	FIX: Update “original” DataObject data to be the content of the last write ... FIX: Compare to original when determining fields changes This fixes a number of edge-case issues relating to change detection. Fixes #8443 Fixes #3821 Fixes #4561	2018-11-05 23:09:24 +13:00
Sam Minnée	536e2d6835	Merge pull request #8511 from jmfederico/patch-1 ... Update comment about locks in MySQL	2018-11-05 22:32:18 +13:00
Sam Minnee	76255c9fb5	FIX: CheckboxSetField can now save into DBMultiEnum ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489	2018-11-05 17:40:28 +13:00
Luke Edwards	97180c2612	Fix readonly grid state always being truthy (#8562)	2018-11-02 14:28:47 +13:00
Luke Edwards	8866e7674a	BUG: Fix duplicate plugins on HTML editor fields (#8559) ... * BUG: Fix duplicate plugins on HTML editor fields * Add new test	2018-11-02 12:26:53 +13:00
Guy Marriott	2ff7ee6752	NEW Deprecate RandomGenerator::generateEntropy in favour of using random_bytes directly	2018-11-01 19:51:15 +13:00
Michael Strong	55f95b7bc8	BUGFIX many many through not sorting by join table (#8534) ... * BUGFIX many many through not sorting by join table * #8534 added docs to support many many sorting fix * #8534 added test cases for many_many default sorting	2018-11-01 14:17:15 +13:00
Michael Strong	7086f2ea3a	BUGFIX many many through not sorting by join table (#8534) ... * BUGFIX many many through not sorting by join table * #8534 added docs to support many many sorting fix * #8534 added test cases for many_many default sorting	2018-11-01 13:42:27 +13:00
Luke Edwards	c7b8b80e8b	Persist GridField readonly state, add view button (#8535) ... * Persist GridField readonly state, add view button * Minor clarity fixes	2018-11-01 11:12:52 +13:00
Maxime Rainville	0703c1a94e	API Deprecating Permission::$declared_permissions and related methods/props	2018-11-01 09:28:05 +13:00
Robbie Averill	98c038688d	Add missing deprecation notices to Convert json methods	2018-10-29 22:15:22 +00:00
Andre Kiste	511c368e8c	Merge pull request #8521 from open-sausages/pulls/4.3/searching-for-legacy ... Add config to force legacy filter header globally	2018-10-29 14:57:21 +13:00
Robbie Averill	b02a6fa02d	FIX Replace usage of Convert JSON methods with json_encode	2018-10-28 21:15:29 +00:00
Robbie Averill	9724d1dd73	API Convert JSON methods are now deprecated, use json_encode or decode instead	2018-10-28 21:13:47 +00:00
Luke Edwards	3284bf48d6	Fix search filtering relations and clear filters (#8477)	2018-10-26 14:43:56 +13:00
Luke Edwards	d879148bff	Add config to force legacy filter header globally	2018-10-26 14:28:15 +13:00
Sam Minnée	e72fc9e3d0	FIX DataObject singleton creation (#8516) ... Ensure DataObject instances are aware they are singletons so functions like populateDefaults() can be skipped. (fixes #4878) Correctly applies https://github.com/silverstripe/silverstripe-framework/pull/7850 to the 4.x line This has already been fixed in 3.x	2018-10-25 11:42:45 +13:00
Will Rossiter	66a404ad1a	FIX use Injector for FormField::castedCopy ... Allows LookupField to be replaced with user specificed classes.	2018-10-24 12:13:14 +13:00
Federico Jaramillo Martínez	e9bffe4020	Update comment about locks in MySQL ... MySQL 5.7.5 and newer allow for multiple lock form the same session. This information is now reflected in the comment.	2018-10-22 22:33:16 -05:00
Maxime Rainville	af46381dca	MINOR Correct implementation of single lookup field when valueToLabel returns null	2018-10-23 11:54:26 +13:00
Robbie Averill	bea4101e21	Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet	2018-10-20 20:06:02 +02:00
Robbie Averill	449b2cf291	Add tests for DefaultFormFactory	2018-10-20 19:47:11 +02:00
Robbie Averill	9ceef59e1b	Merge branch '4.3' into 4	2018-10-20 18:31:04 +02:00
Robbie Averill	97209bc919	Add edge case unit tests for DateField	2018-10-20 18:15:42 +02:00
Daniel Hensby	88d78dfd95	Merge pull request #8505 from creative-commoners/pulls/4.3/defensive-extensions ... FIX getExtensionInstance can return null, add a case to handle that	2018-10-20 16:58:55 +01:00
Robbie Averill	c06cf4820e	BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config	2018-10-20 17:47:16 +02:00
Robbie Averill	d56bad7568	Add tests for edge cases in CurrencyField	2018-10-20 17:33:59 +02:00
Robbie Averill	8929b8204f	More validation tests for ConfirmedPasswordField	2018-10-20 17:21:25 +02:00
Robbie Averill	c418ee2915	NEW Add getters and setters for public properties in ConfirmPasswordField, add tests ... Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests	2018-10-20 16:43:49 +02:00
Robbie Averill	60b375d995	Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs	2018-10-20 15:44:23 +02:00
Robbie Averill	3cdb73bd44	NEW Add getLogger() to MonologErrorHandler and add test for exception without one	2018-10-20 15:00:08 +02:00
Robbie Averill	9911c9c9ef	Use single quotes and getters over direct prop access in HTTPOutputHandler	2018-10-20 14:51:08 +02:00
Robbie Averill	73df3166b7	Switch to short array syntax in DetailedErrorFormatter, add spaces between array values	2018-10-20 14:30:15 +02:00
Robbie Averill	e211e27470	Add more unit tests for DebugViewFriendlyErrorFormatter, tidy up Director::is_ajax() return	2018-10-20 14:27:57 +02:00
Robbie Averill	7f6f5c9ec9	FIX Flush extra methods cache on DataObjects after each unit test class has finished	2018-10-20 13:59:03 +02:00
Robbie Averill	311fd62d95	FIX getExtensionInstance can return null, add a case to handle that	2018-10-19 18:12:13 +02:00
bergice	a28e2e183e	BUG: Fix enum filter in Search component from adding Any as a filter ... Fixes #702	2018-10-19 17:05:12 +13:00
Robbie Averill	f4085300ce	Merge pull request #8495 from micmania1/bugfix/828-grapql-asset-admin-memory ... BUGFIX #828 optimised query in graphql asset admin	2018-10-18 11:36:51 +02:00
Sam Minnée	24b9dbc8ef	Merge pull request #8490 from creative-commoners/pulls/4.3/minor-db-tweaks ... NEW Some minor refactoring of the PDO and MySQLi connectors	2018-10-18 22:11:29 +13:00
micmania1	1e83dff4ed	BUGFIX #828 optimised query in graphql asset admin	2018-10-18 18:34:03 +13:00
bergice	a6a1743997	BUG: Fix ENTER not triggering form save button as GridFields used submit type buttons	2018-10-18 12:37:24 +13:00
Robbie Averill	437e53f2fe	NEW Some minor refactoring of the PDO and MySQLi connectors ... Some small performance optimisations (not using callables in loops, switch strval for string casting), Config call updates and replace call_user_func_array with direct variadic call. Also removes some redundant else statements after returns.	2018-10-17 12:54:42 +02:00
Aaron Carlino	57756f38cb	Revert bd6c4fd	2018-10-17 14:54:03 +13:00
Robbie Averill	c18e9b1298	Merge pull request #8439 from sminnee/consistent-limit ... FIX: Make ArrayList::limit() consistent with DataList::limit()	2018-10-16 12:05:11 +02:00
Aaron Carlino	7d201309ad	Merge branch '4.2' into 4	2018-10-15 13:42:55 +13:00
Robbie Averill	516267ed46	Merge pull request #8470 from kinglozzer/suf-fixing-the-suffix ... FIX: Re-instate missing SS_DATABASE_SUFFIX functionality (fixes #7966)	2018-10-12 23:11:54 +02:00
Robbie Averill	7215637673	Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield ... API Add a new GridFieldLazyLoader component	2018-10-11 13:43:10 +02:00
Loz Calver	dca2d47127	Merge pull request #8357 from creative-commoners/pulls/4.3/fix-i18n ... FIX Text collector translations now compile without errors	2018-10-11 13:16:23 +02:00
Loz Calver	26f2044533	Merge pull request #8437 from sminnee/faster-cleartable-ss4 ... FIX: Use DELETE FROM instead of TRUNCATE for clearTable	2018-10-11 12:32:31 +02:00
Loz Calver	ee21c42011	FIX: Re-instate missing SS_DATABASE_SUFFIX functionality (fixes #7966)	2018-10-11 10:50:56 +01:00
Sam Minnee	4740346ed8	FIX: Make ArrayList::limit() consistent with DataList::limit() ... This makes it easier to swap one fo the other without code breaking. Since it’s strictly a removed API, I’ve opted to throw a deprecation note in SS4 rather than throwing an InvalidArgumentException. Fixes #2949	2018-10-11 21:05:20 +13:00
Maxime Rainville	250d925810	MINOR Update CompositeField::__construct to call setChildren #8460	2018-10-11 15:25:34 +13:00
Maxime Rainville	98afbfe9b4	Implement Peer review feedback #8460	2018-10-11 14:56:06 +13:00
Maxime Rainville	ef439f9306	MINOR Correct GridField_DataManipulator PHPDOC to not assume DataList ... Tweak GridField_DataManipulator to not assume only DataList will be provided. Use the SS_List Interface instead. (#8460)	2018-10-11 12:06:21 +13:00
Maxime Rainville	2e2ca5a4a7	Make sure LazyLoader still woks after a readonly transofrmation (#8460)	2018-10-11 11:56:39 +13:00
Robbie Averill	eb0ef1c268	Merge pull request #8465 from creative-commoners/pulls/4.3/extensible-bug ... NEW Add method to flush extra_methods static cache data and implement into test state	2018-10-11 00:02:27 +02:00
Robbie Averill	3642e7aeae	Remove extensionsToRemove and extensionsToReapply, now obsolete	2018-10-10 22:19:15 +02:00
Robbie Averill	bd6c4fdda0	Merge pull request #8440 from creative-commoners/pulls/4.3/its-indestruc-tab-le ... NEW TabSet react component is no longer structural	2018-10-09 22:05:53 +02:00
Robbie Averill	56d5621934	FIX Flush extra_methods statics between test runs	2018-10-09 13:22:54 +02:00
Robbie Averill	d1281a571a	FIX Escape HTML in PHPDoc to fix API docs from rendering incorrectly	2018-10-09 10:46:45 +02:00
Maxime Rainville	fdb53311ba	Fix linting issue.	2018-10-09 17:32:42 +13:00
Maxime Rainville	bfb6518176	Tweak the logic to empty lazy list.	2018-10-09 17:32:42 +13:00
Maxime Rainville	d2a51471e9	Don't lazy load tab that are not in a TabSet.	2018-10-09 17:32:42 +13:00
Maxime Rainville	5276b6cbb1	API Add FieldList::getContainerField	2018-10-09 17:32:42 +13:00
Maxime Rainville	bdb53979aa	API Create a new GridFieldLazyLoader GridField component	2018-10-09 17:32:42 +13:00
Loz Calver	5426f34b4a	Merge pull request #8463 from creative-commoners/pulls/4.3/rm-cachedata ... FIX Remove unused cacheData prop from #8451	2018-10-08 15:12:14 +02:00
Loz Calver	e829ad78b1	Merge pull request #8429 from sminnee/fix-2950 ... FIX: Throw deprecation on limit=0	2018-10-08 15:11:52 +02:00
Robbie Averill	c4788803ee	FIX Remove unused cacheData prop from #8451	2018-10-08 12:05:29 +02:00
Maxime Rainville	36b1066413	Merge pull request #8451 from creative-commoners/pulls/4.3/memory-cache-findtemplate ... NEW Add memory cache to ThemeResourceLoader::findTemplate()	2018-10-08 10:38:07 +13:00
Sam Minnee	e5d3b28a4d	FIX: Don’t break validation on selects without a source. ... Fixes cases where there are no valid values or an empty-string value is manually added rather than using setEmptyString() Fixes #4849 Fixes #7159	2018-10-06 11:53:17 +13:00
Sam Minnée	7915fe0c0f	Merge pull request #8303 from hchokshi/pulls/4.2/viewable-data-customised-isset ... Implement __isset for ViewableData_Customised	2018-10-06 09:37:19 +13:00
Robbie Averill	98568262f2	Fixed phpcs violations	2018-10-05 16:07:33 +02:00
Robbie Averill	024762f03b	Move default themes lookup before cache check	2018-10-05 15:00:32 +02:00
Robbie Averill	da9301f241	Use SilverStripe cache API instead of memory cache, add tests and fix cache config indentation	2018-10-05 14:58:48 +02:00
Robbie Averill	172d8915b7	Clear cache between ThemeResourceLoader tests	2018-10-05 14:12:26 +02:00
Robbie Averill	9ea7b58a8f	NEW Add memory cache to ThemeResourceLoader::findTemplate() ... For large sites, this reduces the number of file_exists, Path::join, getThemePaths etc calls and can contribute to 26% reduction in TTFB load time	2018-10-05 14:12:26 +02:00
Sam Minnee	0fc06e51e5	FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour. ... Note that the medium date format depends on locale, with en_NZ being resolutely numeric. I’ve updated the test to verify a couple of locales to make this more obvious. Fixes #8121	2018-10-04 14:51:24 +13:00
Sam Minnee	638e6ec281	FIX: Throw deprecation notice on limit=0 ... The SS4 behaviour of limit=0 is unlikely to be the SS5 behaviour. To clear the limit limit=null is recommended. In addition, there’s a bit tighter type maintenance in the internal limit data (ensure things are int). Fixes #2950.	2018-10-04 10:38:15 +13:00
Robbie Averill	ee24413c30	Merge branch '4.2' into 4	2018-10-03 15:28:05 +02:00
Robbie Averill	b0871ebd75	Merge pull request #8417 from creative-commoners/pulls/4.3/many-many-through-sorting-tests ... Add more list sorting tests and fix many many through sorting	2018-10-03 13:30:20 +02:00
Robbie Averill	d2b646cc13	Merge pull request #8286 from wilr/patches/mysql-create-table-issue ... Check database has table before altering.	2018-10-03 13:24:59 +02:00
Robbie Averill	d74fed554a	Merge pull request #8427 from sminnee/fix-1397 ... FIX: Append any fields that don’t match name in insertBefore/insertAfter	2018-10-03 13:22:23 +02:00
Robbie Averill	6a5fb4999c	Merge pull request #8416 from lekoala/patch-14 ... raw2att accepts array, but sprintf doesn't	2018-10-03 13:21:43 +02:00
Robbie Averill	7f685b0bea	Merge pull request #8423 from creative-commoners/pulls/4.2/default-locale-for-members ... FIX New members now receive the configured default locale, not the current locale	2018-10-03 13:18:05 +02:00
Robbie Averill	79f9d6b733	Merge pull request #8428 from sminnee/fix-2636 ... FIX: Don’t change state in ArrayList::getIterator()	2018-10-03 13:11:39 +02:00
Raissa North	90afb2037a	NEW TabSet react component is no longer structural	2018-10-03 16:36:17 +13:00
Robbie Averill	cb2b9498fb	API Deprecate updateSearchContextCallback and updateSearchFormCallback	2018-10-03 13:47:40 +13:00
Luke Edwards	bf60a699a5	Add extension points for ModelAdmin search API	2018-10-03 13:47:40 +13:00
Sam Minnee	0cc72c91ad	FIX: Use DELETE FROM instead of TRUNCATE for clearTable ... clearTable is mainly used for clearing data between tests. In this case, there are very few or zero records, and DELETE FROM is quicker than TRUNCATE, which works by deleting and recreating the table. This materially speeds up test execution, at least on MySQL. Cherry-pick of SS3 ae9ab22a8f	2018-10-03 13:40:00 +13:00
Guy Marriott	5970fc2417	FIX Moving test to correct director	2018-10-03 10:47:17 +13:00
Robbie Averill	5a20bb5e20	Revert "FIX: Use DELETE FROM instead of TRUNCATE for clearTable" ... This reverts commit 79c2b5ad42.	2018-10-02 14:35:10 +02:00
Robbie Averill	c8e7672ede	Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict ... FIX Avoid having search fields with the same names as form elements	2018-10-02 13:43:59 +02:00
Robbie Averill	2ca089bcce	Merge pull request #8433 from sminnee/faster-cleartable ... FIX: Use DELETE FROM instead of TRUNCATE for clearTable	2018-10-02 10:43:54 +02:00
Sam Minnee	79c2b5ad42	FIX: Use DELETE FROM instead of TRUNCATE for clearTable ... clearTable is mainly used for clearing data between tests. In this case, there are very few or zero records, and DELETE FROM is quicker than TRUNCATE, which works by deleting and recreating the table. This materially speeds up test execution, at least on MySQL. Implemented in SS3 at 815da76b056a716c8831d22bbf93528912cbcb28	2018-10-02 18:00:38 +13:00
Sam Minnee	f2cbc1dfbb	FIX: Don’t use USE_FRM in MySQL repair. Fixes #6300. ... USE_FRM is a sufficiently dangerous option that it should require manual DBA activity to carry out. See http://dev.mysql.com/doc/refman/5.7/en/repair-table.html for more info.	2018-10-02 10:48:47 +13:00
Sam Minnee	71dad5f685	FIX: Append any fields that don’t match name in insertBefore/insertAfter ... Previous behaviour was to return false, which has been described as a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397 where the issue was identified.	2018-10-02 10:39:48 +13:00
Sam Minnee	ad87890b2e	FIX: Don’t change state in ArrayList::getIterator() ... This prevents the map-to-ArrayData conversion from changing object state and making the result of toArray() non-deterministic. Fixes #2636. Other solutions were suggested on that ticket, but there is no way of putting special code in for a SSViewer-specific iterator, and having object state pre-emptively converted to ArrayData would be an SS5-level change.	2018-10-02 09:56:09 +13:00
Maxime Rainville	755907d117	Merge pull request #8409 from open-sausages/pulls/4/treedropdown-caching ... MINOR Add caching to the TreeDropdownField tree action	2018-10-01 13:56:21 +13:00
Guy Marriott	c503dbd634	Prefixing search filters for the React search form context	2018-10-01 13:38:32 +13:00
Maxime Rainville	13c89d0ed0	Add a comment and only apply caching if using the standard NumChildrenMethod	2018-10-01 11:29:51 +13:00
Harsh Chokshi	60dd5f288b	Implement __isset for ViewableData_Customised ... Resolves #8302.	2018-10-01 09:40:12 +13:00
Robbie Averill	231d6d9a9f	FIX New members now receive the configured default locale, not the current locale	2018-09-28 16:25:10 +02:00
Robbie Averill	ac1fe5e9d5	FIX joinClass's default_sort is used when nothing else has been set already	2018-09-28 15:39:24 +02:00
Robbie Averill	4d14e9b6b1	Merge pull request #8421 from creative-commoners/pulls/4.3/psr-5-deprecations ... Update deprecation PHPDocs to be PSR-5 compliant	2018-09-28 14:18:54 +02:00
Loz Calver	10ff6c4f81	Merge pull request #8418 from creative-commoners/pulls/4.3/lower-complexity ... MINOR Reduce some code complexity, update array syntax and injected SQLSelect etc	2018-09-28 12:51:08 +02:00
Robbie Averill	e4768e44b0	Use splat over call_user_func_array and reduce calls to func_get_args()	2018-09-28 12:32:20 +02:00
Robbie Averill	e57edcd060	Merge pull request #8387 from sminnee/fix-start-session-without-headers ... FIX: Ensure existing session can be accessed if headers_sent()	2018-09-28 10:59:29 +02:00
Robbie Averill	f842ee2eec	Update deprecation PHPDocs to be PSR-5 compliant ... See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated	2018-09-28 10:49:14 +02:00
Loz Calver	aec562f048	Merge pull request #8419 from 3Dgoo/patch-1 ... minor i18nEntityProvider.php API documentation fix	2018-09-28 10:21:37 +02:00
Sam Minnee	b98c87a6c5	FIX: Ensure existing session can be accessed if headers_sent() ... If a session already exists, and Session::start() isn’t called until after a large enough block of content is output, then headers_sent() will be false. The previous code prevented the session from being started in this case. That might makes sense for the creation of a new session, but it prevent legitimate access to an existing session. This mostly manifested when running debugging tools such as showqueries, which may output content before the session is started.	2018-09-28 13:25:13 +12:00
3Dgoo	785b0c69da	minor i18nEntityProvider.php API documentation fix ... Fixing documentation typo.	2018-09-28 10:28:00 +10:00
Ingo Schommer	25759ffc5f	NEW Show file path on PHP parser exceptions	2018-09-28 08:58:47 +12:00
Robbie Averill	1b0293d8c5	Replace array syntax, use some strict comparison and remove unnecessary elseif	2018-09-27 17:37:37 +02:00
Robbie Averill	594fa30b82	Remove redundant elseif complexity and switch to short array syntax	2018-09-27 17:29:52 +02:00
Robbie Averill	adb4d1f92d	MINOR Reduce some code complexity, update array syntax and injected SQLSelect etc	2018-09-27 16:40:23 +02:00
Thomas Portelange	fdd5acff5d	raw2att accepts array, but sprintf doesn't ... it's not very likely to happen (it did in my case :-) ) but if the value is an array, sprintf will fail (because raw2att accepts array, but sprintf doesn't). i suggest to json encode any array data to ensure it's safely included in the html. Or we should throw proper exceptions to make sure invalid values do not result in a php error.	2018-09-27 12:12:59 +02:00
Guy Marriott	c54e7317d2	FIX Avoid having search fields with the same names as form elements	2018-09-27 17:39:50 +12:00
Thomas Portelange	f103648f8c	value can be something else than a string ... if the value is not a string (an array for instance), sprintf will fail	2018-09-26 11:35:40 +02:00
Sam Minnée	a31a496362	Merge pull request #8399 from lekoala/patch-12 ... var_export does not handle circular references	2018-09-26 20:58:25 +12:00
Maxime Rainville	77339b7e75	MINOR Add caching to the TreeDropdownField tree action	2018-09-26 17:24:06 +12:00
Robbie Averill	f5929d87e0	DOCS Update do blocks for DataQuery::having() to reflect correct input types	2018-09-25 17:46:42 +02:00
Sam Minnée	5b7a84141b	NEW: Add Hierarchy::prepopulate_numchildren_cache() (#8380) ... * NEW: Add Hierarchy::prepopulate_numchildren_cache() API: Hierarchy::stageChildren() customisations must be applied to the base class and not include record-specific behaviour. Adds the ability to prepopulate the cache for Hierarchy::numChildren() in a batch. Note that this optimisation means that stageChildren() is not called on each record in order to calculate numChildren(). This means that the structure of the stageChildren() query must be the same for all records and the behaviour cannot be customised only for a subclass of the base data class. For example, apply your customisations to SiteTree and not a subclass. This is an useful part of optimising the query count on tree generation. See https://github.com/silverstripe/silverstripe-framework/issues/8379 * NEW: Add Hierarchy::prepopulateTreeDataCache() This provides a more extensible way of preopulating caches for optimised tree generation. Fixes https://github.com/silverstripe/silverstripe-framework/issues/8391	2018-09-25 12:25:23 +12:00
Robbie Averill	3eacecbb1c	Merge pull request #8398 from open-sausages/pulls/4/test-flush ... FIX Don't flush manifests in tests by default	2018-09-25 00:19:32 +02:00
Robbie Averill	0276f6c089	FIX Revert semver break in adding GridField type hint to method signature	2018-09-24 13:39:33 +02:00
Thomas Portelange	72b25d1a97	var_export does not handle circular references ... this often happens in SilverStripe, a plain print_r is much safer	2018-09-24 12:31:06 +02:00
Loz Calver	f01473f1b3	Merge pull request #8390 from caffeineinc/bugfix/8389-login-attempt-performance-issues ... Performance issues with BasicAuth and LoginAttempts	2018-09-24 10:24:29 +02:00
Ingo Schommer	a2bb70c46d	FIX Don't flush manifests in tests by default ... It's massively slowing down test execution, particularly for rapid execution through test-driven-development (TDD)	2018-09-24 18:12:35 +12:00
Robbie Averill	d11911d4dd	Merge pull request #8394 from littlegiant/pulls/4.2/http-status-codes ... BUG Prevent error on valid response status codes	2018-09-21 13:19:29 +02:00
Andre Kiste	e8fd49b394	Merge pull request #8381 from open-sausages/pulls/4.2/sort-out-your-field ... BUG Changes being detected on TreeMulti as values not sorted	2018-09-21 16:38:56 +12:00
Luke Edwards	4ac4cdc91b	Merge pull request #8348 from caffeineinc/bugfix/3357 ... BUG Add GridField Readonly Transformation (#3357)	2018-09-21 14:54:37 +12:00
Damian Mooyman	1d5ecd342e	BUG Prevent error on valid response status codes	2018-09-21 14:54:26 +12:00
Simon Gow	c269a987d5	Performance issues with BasicAuth and LoginAttempts ... Two functions interact with the LoginAttempt object which when used in conjunction with BasicAuth result in significant performance degradation over time, as the LoginAttempts Table fills. This fix adds an index to the lookup column EmailHashed and removes the Email filter part of getByEmail() so it can use the index resulting in a much faster query. For more information see https://github.com/silverstripe/silverstripe-framework/issues/8389	2018-09-20 13:34:03 +12:00
Luke Edwards	3fc49dd4ce	Lint fixes and allow a few other components by default	2018-09-20 13:32:52 +12:00
Robbie Averill	3b7802bb51	Merge pull request #8388 from sminnee/showqueries-backtrace ... NEW: Add ?showqueries=backtrace	2018-09-19 11:21:36 +02:00
Sam Minnee	40dde226fd	NEW: Add ?showqueries=backtrace ... This variant of showqueries will include a backtrace after each query. This is extremely verbose but can be helpful when diagnosing where queries have come from. This is something that I have frequently added as a local hack on my environment, I figured that exposing it as a formal feature would be useful.	2018-09-19 14:28:40 +12:00
Luke Edwards	db63f55fbb	BUG Changes being detected on TreeMulti as values not sorted	2018-09-18 13:24:55 +12:00
Raissa North	588bf83e12	NEW Add hideNav flag to schema defaults	2018-09-18 10:45:36 +12:00
Luke Edwards	a33866ff4c	Merge pull request #8353 from open-sausages/pulls/4.2/2227-show-link-tracking ... API: Add Link Tracking section to Relations developer guide	2018-09-13 14:23:34 +12:00
bergice	01db5c9e98	API: Add Link Tracking section to Relations developer guide and describe show_sitetree_link_tracking, show_file_link_tracking. ... Refactor form scaffolder.	2018-09-13 11:02:09 +12:00
Robbie Averill	b555bb83b8	Merge pull request #8359 from creative-commoners/pulls/4/HTMLEditorSchema ... Add schema information for HTMLEditorField	2018-09-10 09:53:12 +02:00
Robbie Averill	373a8afeb5	Merge branch '4.2' into 4	2018-09-06 13:26:46 +02:00
Robbie Averill	270aba4007	Merge branch '4.1' into 4.2	2018-09-06 13:26:31 +02:00
Robbie Averill	b6ff21f72a	Merge branch '4.0' into 4.1	2018-09-06 13:26:13 +02:00
Dylan Wagstaff	f13ee4486d	Add schema information for HTMLEditorField ... This allows React form builders (or other such view layer builders in a headless environment) to obtain the details that would otherwise only be rendered in a PHP side template. Some of the details are critical for rendering correctly, and are necessary to be passed through - particularly when moving toward replacing the Entwine initiator for TinyMCE with a React component in `silverstripe/admin`. I new interface method has been added to the abstract class for HTML editor configs in order to facilitate this. It is not itself abstract as this would break backwards compatiblity with any existing custom config (aside from the TinyMCE one which we're editing here), which is most certainly not what we want.	2018-09-06 14:35:11 +12:00
Ingo Schommer	f7d85fe794	Make sure that CMS requests disable caching ... Original author: @dhensby Forward port from 3.7 fix at https://github.com/silverstripe/silverstripe-framework/pull/8318	2018-09-05 11:38:41 +12:00
Maxime Rainville	cc22024e9a	ADD New search component for GridFields (#1777)	2018-09-04 11:35:17 +12:00
Robbie Averill	b922c0d732	FIX Check scheme is truthy before setting it to the request	2018-09-03 08:59:37 +02:00
Robbie Averill	2254459310	FIX Text collector translations now compile without errors	2018-09-03 08:21:05 +02:00
Robbie Averill	94f5d32f41	Merge pull request #8351 from open-sausages/pulls/4.2/move-to-your-other-left ... BUG Use classes for TinyMCE alignment buttons	2018-08-31 10:18:03 +12:00
Luke Edwards	234b795f89	BUG Use classes for TinyMCE alignment buttons	2018-08-31 09:02:17 +12:00
Guy Marriott	610f17282f	DOCS Updating DataObject config documentation	2018-08-29 14:53:05 +12:00
Simon Gow	4c3a068859	Issue 3357 - Add GridField Readonly Transformation ... GridField doesn't have a valid readonly state if it's value is set to an Object without `forTemplate()`. The default behaviour is to render a ReadonlyField, but given GridField is a complex type this isn't suitable. This bugfix provides a transformation method to render only components that are whitelisted to provide a readonly state. @see #3357 - https://github.com/silverstripe/silverstripe-framework/issues/3357	2018-08-29 14:47:06 +12:00
Maxime Rainville	dd3379e68f	Merge pull request #8075 from creative-commoners/pulls/4.0/remap-polymorphics ... FIX Polymorphic relationship class columns have obsolete class names remapped	2018-08-28 17:03:39 +12:00
Robbie Averill	d651d0fbfc	FIX Use base class (not remapping target class) when looking up whether object is versioned	2018-08-28 14:15:02 +12:00
Maxime Rainville	e8261589e8	Merge pull request #8304 from micmania1/patch-12 ... BUGFIX Installer redirect to home/ (without domain)	2018-08-28 13:47:24 +12:00
Robbie Averill	83e461abbf	Merge branch '4.2' into 4	2018-08-27 16:15:57 +12:00
Robbie Averill	37a266f2f0	Merge branch '4.1' into 4.2	2018-08-27 16:14:24 +12:00
Scott Hutchinson	4da5569232	FIX ensure createFromVariables takes correct params on CLIRequestBuilder	2018-08-27 16:12:52 +12:00
Robbie Averill	66c09afc9c	Merge branch '4.0' into 4.1	2018-08-27 16:12:04 +12:00
Robbie Averill	3178fbf3bb	Merge pull request #8028 from andrewandante/pulls/4.0/unset_http_scheme_on_cli ... unset http scheme on CLIRequestBuilder	2018-08-27 16:11:42 +12:00
Robbie Averill	a87165c299	Merge pull request #8326 from creative-commoners/pulls/4.2/remove-double-encoding ... FIX Remove double escaping of HTML values in print views	2018-08-27 13:37:32 +12:00
Luke Edwards	6164d01d65	FIX GridField delete button to offer archive action if possible (#8325) ... * FIX GridField delete button to offer archive action if possible * Refactor archive action to versioned module * Fix GridFieldDeleteAction test	2018-08-24 13:13:32 +12:00
Robbie Averill	050afd79c1	Merge pull request #8316 from anhld/anhld-patch-1 ... Password changing notification issue on new member	2018-08-23 14:03:17 +12:00
Thomas Portelange	27ac001d5b	FIX email rendering should not include requirements ... If no body is defined, the email is rendered according to a template. Clearing requirements prevent unnecessary styles/scripts to be included in the html (and that needs to be processed/stripped down the line).	2018-08-23 14:01:27 +12:00
Robbie Averill	373326e49c	Merge pull request #8324 from creative-commoners/pulls/4.2/request-before-init ... FIX Pass request to dummy controller before calling init	2018-08-21 12:08:14 +12:00
Daniel Hensby	aa153cb5c7	Merge pull request #8315 from open-sausages/pulls/4.2/changing-change ... FIX Paginating a gridfield causing a change event	2018-08-20 17:59:50 +01:00
Robbie Averill	18fff5c16c	Remove past tense for "log in" in expired token message	2018-08-20 22:31:23 +12:00
Robbie Averill	dbab696690	FIX Message when changing password with invalid token now contains correct links to login ... The Security controller should be used to return these links rather than the ChangePasswordHandler	2018-08-20 22:30:12 +12:00
Robbie Averill	735c87b709	Merge pull request #8327 from dhensby/pulls/4/application-json ... FIX text/json is not a valid mimetype	2018-08-19 13:42:27 +12:00
maks	160d595e22	fix trailing whitespace	2018-08-17 18:16:17 +02:00
maks	16217f3655	fix accidentaly deleted comma	2018-08-17 15:13:13 +02:00
maks	aa1e576a3f	convert to php 5.4+ array syntax	2018-08-17 15:03:46 +02:00
Luke Edwards	9f5b0086cb	FIX Paginating a gridfield causing a change event	2018-08-17 09:35:57 +12:00
Daniel Hensby	d9154bffbf	FIX text/json is not a valid mimetype	2018-08-15 12:10:39 +01:00
Robbie Averill	0db594b2d3	FIX Remove double escaping of HTML values in print views ... Print view uses the SilverStripe templating to render values which means that values are safely escaped by default. This can be tested by chaing `$CellString` to `$CellString.RAW` in the GridField_print.ss template to see this escaping being disabled. This pull request removes double escaping of HTML in strings.	2018-08-15 17:57:40 +12:00
Robbie Averill	953153500d	FIX Polymorphic relationship class columns have obsolete class names remapped	2018-08-15 10:40:51 +12:00
Robbie Averill	873873dc30	FIX Pass request to dummy controller before calling init	2018-08-15 10:14:25 +12:00
Anh Le	68f75a9e25	Password changing notification issue on new member ... With `notify_password_change = true`, new member is receiving notification email regarding password changing when they should not.	2018-08-13 14:13:05 +07:00
Michael Strong	13372f9a37	BUGFIX Installer redirect to home/ (without domain) ... This fixes a bug where the installer redirects to home/ ('home' as the domain) as the url as opposed to localhost/home. To reproduce: * Use chrome (untested in other browsers) * composer create project silverstripe/installer * Run through the installer Expected: * Silverstripe installs and it takes you to the success page Actual: * SilverStripe installs and takes you to a different domain (ie. 'http://home') The problem seems to be, any URL starting with `//` (two slashes) is normalised by the browser to an absolute URL by removing both slashes meaning `//home` becomes just `home` (as in http://home)	2018-08-06 14:48:23 +12:00
Ingo Schommer	2d6964c243	Merge pull request #8261 from open-sausages/pulls/4/secure-remember-me-cookie ... NEW Option for secure "remember me" cookie	2018-07-31 09:19:15 +12:00
Daniel Hensby	4d83330981	Merge branch '4.2' into 4	2018-07-30 17:11:42 +01:00
Daniel Hensby	17dbb86257	Merge pull request #8293 from open-sausages/pulls/4.2/restore-default-delete-action-of-record-editor ... FIX Restore default delete action on GridFieldConfig_RecordEditor	2018-07-30 17:00:09 +01:00
Ingo Schommer	114b0a5ea7	NEW Option for secure "remember me" cookie ... Fixes #8234	2018-07-30 16:41:49 +01:00
Daniel Hensby	d0598c02c5	Merge branch '4.2' into 4	2018-07-30 11:07:15 +01:00
Daniel Hensby	ec5640cbd9	Merge tag '4.2.0' into 4.2 ... Release 4.2.0	2018-07-30 11:04:57 +01:00
Will Rossiter	9ec77ab9d3	Check database has table before altering. ... Work around to prevent several issues with silverstripe-framework#4451 and cwp#0031726. Throws a LogicException if the table does not exist.	2018-07-30 13:14:03 +12:00
Maxime Rainville	85b4b48fb5	FIX Restore default delete action on GridFieldConfig_RecordEditor	2018-07-27 17:19:09 +12:00
Mark Muller	e154aa170c	Make removeDuplicates() chainable ... Added the return to allow removeDuplicates to be chained.	2018-07-24 13:50:37 +01:00
Daniel Hensby	ae00147de1	Merge pull request #8280 from open-sausages/pulls/4/simpler-vary-header ... FIX: Remove X-Requested-With from default Vary header	2018-07-24 01:45:07 +01:00
Ingo Schommer	d12c2fe631	Properly deprecate HTTP.cache_control	2018-07-23 19:09:11 +01:00
Ingo Schommer	0f5420b6a5	Removed unused classes	2018-07-23 19:09:11 +01:00
Ingo Schommer	d426ecbb89	Add $maxAge arg for caching API ... See https://github.com/silverstripe/silverstripe-framework/issues/8272	2018-07-23 19:09:10 +01:00
Daniel Hensby	cc0320b2a7	Merge branch '4.2' into 4	2018-07-23 17:42:43 +01:00
Sam Minnee	bde3121a33	FIX: Remove X-Requested-With from default Vary header ... 3.x forward port of https://github.com/silverstripe/silverstripe-framework/pull/8242	2018-07-23 14:18:05 +01:00
Daniel Hensby	ccbbcd45a2	FIX Fixed bug in config merging priorities so that config values set by extensions are now least important instead of most important	2018-07-23 14:15:24 +01:00
Daniel Hensby	6e1c7c2781	FIX remove personal information from password reset confirmation screen	2018-07-23 14:13:52 +01:00
Maxime Rainville	c77042aa8b	Fix linting.	2018-07-23 14:12:44 +01:00
Maxime Rainville	7fda52b2cd	Add a MERGE_AS_SUBMITTED_VALUE flag for Form::loadDataFrom	2018-07-23 14:12:43 +01:00
Maxime Rainville	3fa2c056d7	FIX Don't reload form session data using FormField::setSubmittedValue (#8056)	2018-07-23 14:12:43 +01:00
Ingo Schommer	74b655d3fc	Fix tests on unset session data ... Thanks Robbie!	2018-07-23 14:09:42 +01:00
Ingo Schommer	76ac8465de	BUG Lazy session state (fixes #8267) ... Fixes regression from 3.x, where sessions where lazy started as required: Either because an existing session identifier was sent through with the request, or because new session data needed to be persisted as part of the request execution. Without this lazy starting, *every* request will get a session, which makes all those responses uncacheable by HTTP layers. Note that 4.x also changed the $data vs. $changedData payloads: In 3.x, they both contained key/value pairs. In 4.x, $data contains key/value, while $changedData contains key/boolean to declare isChanged. While this reduces duplication in the class, it also surfaced a bug which was latent in 3.x: When an existing session is lazily resumed via start(), $data is set back to an empty array. In 3.x, any changed data before this point was *also* retained in $changedData, ensuring it gets merged into existing $_SESSION data. In 4.x, this clears out data - hence the need for a more complex merge logic. Since isset($this->data) is no longer an accurate indicator of a started session, we introduce a separate $this->started flag. Note that I've chosen not to make lazy an opt-in (e.g. via start($request, $lazy=false)). We already have a distinction between lazy starting via init(), and force starting via start().	2018-07-23 14:09:42 +01:00
Daniel Hensby	e37b3b95f4	FIX updateValidatePassword calls need to be masked from backtraces	2018-07-23 14:08:26 +01:00
Daniel Hensby	a3687147fe	State default should be state enabled (no-cache is an enabled state)	2018-07-23 14:07:10 +01:00
Daniel Hensby	9f1471332d	Make augmentState method more efficient	2018-07-23 14:07:10 +01:00
Daniel Hensby	cebed776ab	FIX If theres a max-age set remove no-cache and no-store	2018-07-23 14:07:09 +01:00
Daniel Hensby	2b1c55bc4e	FIX Allow setNoCache(false) to remove no-cache directive	2018-07-23 14:07:09 +01:00
Daniel Hensby	842b39e988	FIX Add must-revalidate to default state so its common on all our core states	2018-07-23 14:07:09 +01:00
Daniel Hensby	997730aa7f	FIX Allow cache control changes to affect default state	2018-07-23 14:07:08 +01:00
Daniel Hensby	c52be7fe09	Consolidate disabling cache logic	2018-07-23 14:05:12 +01:00
Daniel Hensby	f7f567a12e	Make config private (notation isnt working)	2018-07-23 14:05:12 +01:00
Daniel Hensby	b78a89a76c	FIX Default cache state should be no-cache	2018-07-23 14:05:12 +01:00
Daniel Hensby	793aafae91	FIX Transaction depth should error if not implemented by child classes	2018-07-23 14:03:20 +01:00
Robbie Averill	1048520fbe	Restore check for zero or negative transaction nesting	2018-07-23 14:01:22 +01:00
Daniel Hensby	cbdf547c1b	Address feedback	2018-07-23 14:01:22 +01:00
Damian Mooyman	8ea3bb36a0	Maybe fix it?	2018-07-23 14:01:21 +01:00
Damian Mooyman	225e61dc67	BUG FIx manual resetDBSchema() calls breaking the database	2018-07-23 14:01:21 +01:00
Damian Mooyman	11e0a3de43	BUG Ensure that build includes extra classes	2018-07-23 14:01:21 +01:00
Damian Mooyman	95bcac796a	ENHANCEMENT Ensure test DB is flushed on either DDL or transaction-disabled tests ... Fixes #8182	2018-07-23 14:01:20 +01:00
Daniel Hensby	b984959170	Merge branch '4.1' into 4.2	2018-07-23 13:30:49 +01:00
Ingo Schommer	e415bcb44a	Fix tests on unset session data ... Thanks Robbie!	2018-07-19 13:32:08 +12:00
Ingo Schommer	93b0884e19	BUG Lazy session state (fixes #8267) ... Fixes regression from 3.x, where sessions where lazy started as required: Either because an existing session identifier was sent through with the request, or because new session data needed to be persisted as part of the request execution. Without this lazy starting, *every* request will get a session, which makes all those responses uncacheable by HTTP layers. Note that 4.x also changed the $data vs. $changedData payloads: In 3.x, they both contained key/value pairs. In 4.x, $data contains key/value, while $changedData contains key/boolean to declare isChanged. While this reduces duplication in the class, it also surfaced a bug which was latent in 3.x: When an existing session is lazily resumed via start(), $data is set back to an empty array. In 3.x, any changed data before this point was *also* retained in $changedData, ensuring it gets merged into existing $_SESSION data. In 4.x, this clears out data - hence the need for a more complex merge logic. Since isset($this->data) is no longer an accurate indicator of a started session, we introduce a separate $this->started flag. Note that I've chosen not to make lazy an opt-in (e.g. via start($request, $lazy=false)). We already have a distinction between lazy starting via init(), and force starting via start().	2018-07-19 13:32:04 +12:00
Daniel Hensby	921b98112e	Merge pull request #8262 from open-sausages/pulls/4/falsifying-tab-evidence ... MINOR removeField(s)FromTab no longer creates a tab if it doesn't exist	2018-07-16 17:26:41 +01:00
Gerald Baumeister	df5395b101	Added check for php-intl requirement	2018-07-16 18:08:25 +02:00
Loz Calver	b317bf163c	Merge pull request #8213 from creative-commoners/pulls/4.2/falsy-forms ... FIX FormField::Link works when no form is currently set	2018-07-16 13:53:58 +01:00
Robbie Averill	b93e94c0c3	FIX FormField::Link now throws a LogicException if no form is set yet	2018-07-16 13:02:58 +01:00
Daniel Hensby	1a634f5ba6	Merge pull request #8244 from altwohill/column-not-distinct ... Make column query not distinct	2018-07-16 13:01:32 +01:00
Al Twohill	3292a8b773	NEW Add columnUnique API SS_List classes.	2018-07-16 12:16:17 +01:00
Al Twohill	91068c23b5	FIX Make column query not distinct ... When selecting a column, it doesn't make sense to have it distinct. As an alternative, the API could be changed to give the end user the option (eg `->column($field, $distinct = false)`) However if we did that, we would need to make sure we do something similar with `SilverStripe\ORM\UnsavedRelationList` to ensure consistency.	2018-07-16 11:38:41 +01:00
Loz Calver	106ca6643a	Merge pull request #8263 from dhensby/pulls/4.1/mask-backtrace ... FIX updateValidatePassword calls need to be masked from backtraces	2018-07-16 10:30:22 +01:00
Damian Mooyman	c6952b46c4	Merge pull request #8245 from dhensby/pulls/4.2/http-cache-fixes ... HTTPCacheControlMiddleware fixes	2018-07-16 13:13:12 +12:00
Robbie Averill	d122995652	FIX Duplicate config values for cascade_duplicates no longer duplicate their duplicates ... Previously you could define identical values for this config prop via a DataExtension and on the base class, resulting in double duplication	2018-07-16 12:04:56 +12:00
Daniel Hensby	8703839eb1	FIX updateValidatePassword calls need to be masked from backtraces	2018-07-15 01:06:45 +01:00
Daniel Hensby	ac5c3416a4	Merge branch '4.2' into 4	2018-07-13 17:06:51 +01:00
Daniel Hensby	bd2abc7a12	Merge branch '4.1' into 4.2	2018-07-13 16:44:23 +01:00
Daniel Hensby	ec9281ee02	Merge branch '4.0' into 4.1	2018-07-13 16:42:00 +01:00
Luke Edwards	7ed056ec50	MINOR removeField(s)FromTab no longer creates a tab if it doesn't exist	2018-07-13 14:18:04 +12:00
Luke Edwards	599a4420bf	FIX Improve GridFieldViewButton to work with new Archive Admin (#8240) ... * Add gridfield restore action, enable view button in action menu * Abstract restore action and create test * Use more appropriate canRestoreToDraft and isArchived, move translations * Use Hierarchy to determine if a record should be restored to root * Move restore action to versioned	2018-07-13 10:45:13 +12:00
Daniel Hensby	4acec33562	FIX Fixed bug in config merging priorities so that config values set by extensions are now least important instead of most important	2018-07-12 00:55:39 +01:00
Daniel Hensby	fd8448889c	State default should be state enabled (no-cache is an enabled state)	2018-07-10 16:58:08 +01:00
Daniel Hensby	601bb4d768	Make augmentState method more efficient	2018-07-10 16:58:07 +01:00
Daniel Hensby	399ebd0031	FIX If theres a max-age set remove no-cache and no-store	2018-07-10 16:58:07 +01:00
Harsh Chokshi	6af736a9e1	Change DBCurrency scaffolded form field to CurrencyField (fixes #8246) ... Add test ensuring DBCurrency scaffolds CurrencyField	2018-07-09 10:57:01 +12:00
Ingo Schommer	2e6f29fea0	Merge pull request #8223 from dhensby/pulls/4.0/remove-email-from-pswdrecovery ... FIX remove personal information from password reset confirmation screen	2018-07-06 11:27:03 +12:00
Daniel Hensby	92f5ef31d8	FIX Allow setNoCache(false) to remove no-cache directive	2018-07-05 22:51:39 +01:00
Daniel Hensby	18b7dc235a	FIX Add must-revalidate to default state so its common on all our core states	2018-07-05 22:51:03 +01:00
Daniel Hensby	9e829c1607	FIX Allow cache control changes to affect default state	2018-07-05 22:50:35 +01:00
Daniel Hensby	560fe9820a	FIX remove personal information from password reset confirmation screen	2018-07-05 14:19:15 +12:00
Luke Edwards	fbf30ee747	Message reflect previous return type change	2018-07-04 10:55:20 +12:00
Daniel Hensby	3116b1f97c	Consolidate disabling cache logic	2018-07-02 15:13:46 +01:00
Daniel Hensby	b9b1a74b92	Make config private (notation isnt working)	2018-07-02 13:54:11 +01:00
Daniel Hensby	e4ef83bd2a	FIX Default cache state should be no-cache	2018-07-02 13:33:36 +01:00
Luke Edwards	9ee84fd515	MINOR: DataObject->fieldLabels() will only return an array	2018-07-02 13:53:59 +12:00
Robbie Averill	a39a221c4c	Merge branch '4.2' into 4	2018-06-25 13:45:03 +12:00
Daniel Hensby	27b60ae989	FIX Transaction depth should error if not implemented by child classes	2018-06-21 14:26:21 +01:00
Robbie Averill	df257686c1	Restore check for zero or negative transaction nesting	2018-06-20 14:46:50 +12:00
Daniel Hensby	d8430f549d	Address feedback	2018-06-20 14:46:50 +12:00
Damian Mooyman	6da72d686f	Maybe fix it?	2018-06-20 14:46:50 +12:00
Damian Mooyman	a116b5dad8	BUG FIx manual resetDBSchema() calls breaking the database	2018-06-20 14:46:50 +12:00
Damian Mooyman	f2c2ded27f	BUG Ensure that build includes extra classes	2018-06-20 14:46:50 +12:00
Damian Mooyman	fbfd454d65	ENHANCEMENT Ensure test DB is flushed on either DDL or transaction-disabled tests ... Fixes #8182	2018-06-20 14:46:50 +12:00
Robbie Averill	7d90a14f37	NEW Shift Embeddable and EmbedResource from asset-admin, lazy load Embed to allow injected dependencies (#8194)	2018-06-20 11:40:28 +12:00
Robbie Averill	725212a707	FIX Allow dispatcher in Embed to be configured with injector (#8192)	2018-06-20 11:37:35 +12:00
Daniel Hensby	a7a45559f0	Merge pull request #8188 from gelysis/array-lib ... Tweaks on the ArrayLib class	2018-06-19 15:06:39 +01:00
Robbie Averill	12cc2c68a5	Merge pull request #8023 from silverstripe-terraformers/feature/lookup_field_set_value_fix ... LookupField value handling corrected	2018-06-19 21:37:36 +12:00
Damian Mooyman	82634bf08c	Merge remote-tracking branch 'origin/4.2' into 4	2018-06-19 17:20:49 +12:00
Damian Mooyman	cfc3b851e7	Merge remote-tracking branch 'origin/4.1' into 4.2 ... # Conflicts: # lang/sv.yml	2018-06-19 17:20:25 +12:00
Maxime Rainville	3f80e2dc67	FIX Don't reload form session data using FormField::setSubmittedValue… (#8184)	2018-06-19 11:27:09 +12:00
Ingo Schommer	39a86e6d92	Merge pull request #8195 from dhensby/pulls/4.2/cache-default ... FIX Default cache state should be `no-cache`	2018-06-19 11:15:57 +12:00
Daniel Hensby	2f1c2992f8	FIX Default cache state should be no-cache	2018-06-18 21:45:38 +01:00
Aaron Carlino	05edb372f1	Revise per tractorcow review	2018-06-18 16:00:17 +12:00
jovenden	b0863fee91	Ensure tables are properly named on dontRequireTable()	2018-06-18 16:00:17 +12:00
Andreas Gerhards	59fe36ba04	Tweaked the other flattening method as well, allowing keys to be preserved	2018-06-18 11:16:20 +12:00
Andreas Gerhards	1753bb2d07	Improved speed on the recursive array flattening	2018-06-18 10:37:20 +12:00
Andreas Gerhards	f45cf75407	Implemented improved associative array check	2018-06-18 08:45:22 +12:00
Damian Mooyman	8181dc4fd2	ENHANCEMENT Ensure extensions are told the internal item request class for gridfield detail form (#8164) ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/8136	2018-06-15 17:58:53 +12:00
Robbie Averill	985c2b67ec	Add fixtureFactory prop assignment back with comment indicating purpose	2018-06-15 13:55:58 +12:00
Damian Mooyman	53dded8cff	API Remove @internal from new 4.2 methods	2018-06-15 13:14:42 +12:00
Robbie Averill	5fa5abf295	Merge branch '4.1' into 4 ... # Conflicts: # src/Forms/DateField.php	2018-06-15 11:52:07 +12:00
Damian Mooyman	b636587945	Respect semver and add tests	2018-06-15 11:04:12 +12:00
Damian Mooyman	310a259c5f	Add locale to Format ... Fix up some regressions	2018-06-14 17:28:16 +12:00
Ingo Schommer	1c5876acf0	Merge pull request #8179 from open-sausages/pulls/4/safer-test-clear ... BUG Make regression in #7839 safer	2018-06-14 17:28:13 +12:00
Ingo Schommer	bd84944c0d	Merge pull request #8166 from open-sausages/pulls/4/http-cache-middleware ... NEW Add better HTTP cache-control manipulation (4.x branch)	2018-06-14 17:19:54 +12:00
Damian Mooyman	d52c4dd602	BUG Make regression in #7839 safer	2018-06-14 16:45:09 +12:00
Damian Mooyman	b686b86c34	Session now prevents cache headers being sent unintentionally	2018-06-14 15:59:51 +12:00
Ingo Schommer	513e0891d3	Clarify function of registerModificationDate()	2018-06-14 14:13:28 +12:00
Damian Mooyman	6b8f63c4d5	Refactor redirect cache busting into middleware	2018-06-14 14:11:31 +12:00
Robbie Averill	acc8d48b11	FIX SapphireTest can load relative fixtures in subfolders, switch "needs db" priority check order ... A minute performance gain by checking instance properties for "uses database" before loading and parsing PHPDoc annotations for the same thing, rather than doing it afterwards.	2018-06-14 13:59:44 +12:00
Damian Mooyman	3ce8ab3adc	Improve handling of deprecated apis	2018-06-14 13:01:27 +12:00