tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-06-26 14:39:25 +02:00
Code Issues Projects Releases Wiki Activity

#8724 - Session timeout regression

Browse Source 
Only emit the session refresh cookie if the session timeout is set.
This commit is contained in:
Simon Gow 2019-01-18 10:07:53 +13:00
parent af08328e8e
commit c28670ebed
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Control/Session.php
View File

@ -325,9 +325,9 @@ class Session
session_start();
// Session start emits a cookie, but only if there's no existing session. If there is a session tied to
// this request, make sure the session is held for the entire timeout by refreshing the cookie age.
if ($this->requestContainsSessionId($request)) {
// Session start emits a cookie, but only if there's no existing session. If there is a session timeout
// tied to this request, make sure the session is held for the entire timeout by refreshing the cookie age.
if ($timeout && $this->requestContainsSessionId($request)) {
Cookie::set(session_name(), session_id(), $timeout / 86400, $path, $domain ?: null, $secure, true);
}
} else {