tonyair
/
silverstripe-framework
mirror of https://github.com/silverstripe/silverstripe-framework
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add edge case unit tests for DateField

This commit is contained in:
Robbie Averill 2018-10-20 18:15:42 +02:00
parent 0e2847e289
commit 97209bc919
2 changed files with 53 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Forms/DateField.php
View File

@ -10,7 +10,7 @@ use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\ORM\ValidationResult;
/**
* Form used for editing a date stirng
* Form used for editing a date string
*
* Caution: The form field does not include any JavaScript or CSS when used outside of the CMS context,
* since the required frontend dependencies are included through CMS bundling.

52
tests/php/Forms/DateFieldTest.php
View File

@ -5,8 +5,10 @@ namespace SilverStripe\Forms\Tests;
use IntlDateFormatter;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\DateField;
use SilverStripe\Forms\DateField_Disabled;
use SilverStripe\Forms\RequiredFields;
use SilverStripe\i18n\i18n;
use SilverStripe\ORM\FieldType\DBDate;
use SilverStripe\ORM\FieldType\DBDatetime;
/**
@ -225,4 +227,54 @@ class DateFieldTest extends SapphireTest
$dateField->setLocale('de_DE');
$dateField->Value();
}
public function testGetDateFormatHTML5()
{
$field = new DateField('Date');
$field->setHTML5(true);
$this->assertSame(DBDate::ISO_DATE, $field->getDateFormat());
}
public function testGetDateFormatViaSetter()
{
$field = new DateField('Date');
$field->setHTML5(false);
$field->setDateFormat('d-m-Y');
$this->assertSame('d-m-Y', $field->getDateFormat());
}
public function testGetAttributes()
{
$field = new DateField('Date');
$field
->setHTML5(true)
->setMinDate('1980-05-10')
->setMaxDate('1980-05-20');
$result = $field->getAttributes();
$this->assertSame('1980-05-10', $result['min']);
$this->assertSame('1980-05-20', $result['max']);
}
public function testSetSubmittedValueNull()
{
$field = new DateField('Date');
$field->setSubmittedValue(false);
$this->assertNull($field->Value());
}
public function testPerformReadonlyTransformation()
{
$field = new DateField('Date');
$result = $field->performReadonlyTransformation();
$this->assertInstanceOf(DateField_Disabled::class, $result);
$this->assertTrue($result->isReadonly());
}
public function testValidateWithoutValueReturnsTrue()
{
$field = new DateField('Date');
$validator = new RequiredFields();
$this->assertTrue($field->validate($validator));
}
}