tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-06-28 23:49:26 +02:00
Code Issues Projects Releases Wiki Activity

Performance issues with BasicAuth and LoginAttempts

Browse Source 
Two functions interact with the LoginAttempt object which when used in conjunction with BasicAuth result in significant performance degradation over time, as the LoginAttempts Table fills.

This fix adds an index to the lookup column EmailHashed and removes the Email filter part of getByEmail() so it can use the index resulting in a much faster query.

For more information see https://github.com/silverstripe/silverstripe-framework/issues/8389
This commit is contained in:
Simon Gow 2018-09-19 14:53:12 +12:00
parent 270aba4007
commit c269a987d5
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Security/LoginAttempt.php
View File

@ -46,6 +46,10 @@ class LoginAttempt extends DataObject
'Member' => Member::class, // only linked if the member actually exists
);
private static $indexes = array(
"EmailHashed" => true
);
private static $table_name = "LoginAttempt";
/**
@ -86,7 +90,6 @@ class LoginAttempt extends DataObject
public static function getByEmail($email)
{
return static::get()->filterAny(array(
'Email' => $email,
'EmailHashed' => sha1($email),
));
}