tonyair
/
silverstripe-framework
mirror of https://github.com/silverstripe/silverstripe-framework
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use single quotes and getters over direct prop access in HTTPOutputHandler

This commit is contained in:
Robbie Averill 2018-10-20 14:51:08 +02:00
parent 2694a47c45
commit 9911c9c9ef
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Logging/HTTPOutputHandler.php
View File

@ -18,7 +18,7 @@ class HTTPOutputHandler extends AbstractProcessingHandler
/**
* @var string
*/
private $contentType = "text/html";
private $contentType = 'text/html';
/**
* @var int
@ -155,8 +155,8 @@ class HTTPOutputHandler extends AbstractProcessingHandler
// If headers have been sent then these won't be used, and may throw errors that we wont' want to see.
if (!headers_sent()) {
$response->setStatusCode($this->statusCode);
$response->addHeader("Content-Type", $this->contentType);
$response->setStatusCode($this->getStatusCode());
$response->addHeader('Content-Type', $this->getContentType());
} else {
// To supress errors aboot errors
$response->setStatusCode(200);
@ -165,6 +165,6 @@ class HTTPOutputHandler extends AbstractProcessingHandler
$response->setBody($record['formatted']);
$response->output();
return false === $this->bubble;
return false === $this->getBubble();
}
}