tonyair
/
silverstripe-framework
mirror of https://github.com/silverstripe/silverstripe-framework
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour. 

Note that the medium date format depends on locale, with en_NZ being
resolutely numeric. I’ve updated the test to verify a couple of locales
to make this more obvious.

Fixes #8121
This commit is contained in:
Sam Minnee 2018-10-04 14:51:24 +13:00
parent ee24413c30
commit 0fc06e51e5
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ORM/FieldType/DBDatetime.php
View File

@ -223,7 +223,7 @@ class DBDatetime extends DBDate implements TemplateGlobalProvider
* @param int $timeLength
* @return IntlDateFormatter
*/
public function getFormatter($dateLength = IntlDateFormatter::MEDIUM, $timeLength = IntlDateFormatter::MEDIUM)
public function getFormatter($dateLength = IntlDateFormatter::MEDIUM, $timeLength = IntlDateFormatter::SHORT)
{
return parent::getFormatter($dateLength, $timeLength);
}

9
tests/php/ORM/DBDatetimeTest.php
View File

@ -88,9 +88,14 @@ class DBDatetimeTest extends SapphireTest
public function testNice()
{
$date = DBDatetime::create_field('Datetime', '2001-12-31 22:10:59');
$date = DBDatetime::create_field('Datetime', '2001-12-11 22:10:59');
// note: Some localisation packages exclude the ',' in default medium format
$this->assertRegExp('#31/12/2001(,)? 10:10:59 PM#i', $date->Nice());
i18n::set_locale('en_NZ');
$this->assertRegExp('#11/12/2001(,)? 10:10 PM#i', $date->Nice());
i18n::set_locale('en_US');
$this->assertRegExp('#Dec 11(,)? 2001(,)? 10:10 PM#i', $date->Nice());
}
public function testDate()