1022 Commits

Author	SHA1	Message	Date
Robbie Averill	64c2938c96	Merge branch '4.3' into 4	2018-11-06 11:05:22 +01:00
Robbie Averill	3c58ae009e	Merge branch '4.2' into 4.3	2018-11-06 11:05:08 +01:00
Robbie Averill	22c7fa2bc9	Merge branch '4.1' into 4.2	2018-11-06 11:04:43 +01:00
Robbie Averill	6d2665d687	Merge branch '4.0' into 4.1	2018-11-06 11:04:28 +01:00
Werner M. Krauß	adafd73943	Convert::memstring2bytes should preserve -1 ... fixes #8570	2018-11-06 10:22:13 +01:00
Aaron Carlino	0ba275cb40	Merge branch '4.2' into 4.3	2018-11-06 15:09:01 +13:00
Aaron Carlino	e60cea8561	Merge branch '4.1' into 4.2	2018-11-06 15:08:42 +13:00
Sam Minnee	67fe41d00b	FIX: Ensure that repeated setting/unsetting doesn’t corrode forceChange()	2018-11-05 23:09:24 +13:00
Sam Minnee	5bb2d9484a	FIX: Update “original” DataObject data to be the content of the last write ... FIX: Compare to original when determining fields changes This fixes a number of edge-case issues relating to change detection. Fixes #8443 Fixes #3821 Fixes #4561	2018-11-05 23:09:24 +13:00
Sam Minnee	76255c9fb5	FIX: CheckboxSetField can now save into DBMultiEnum ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489	2018-11-05 17:40:28 +13:00
Sam Minnee	78ceca6934	MINOR: Add test for defaults on subclasses ... This was raised in https://github.com/silverstripe/silverstripe-framework/issues/8567 and wasn’t covered by a test.	2018-11-05 16:09:49 +13:00
Luke Edwards	8866e7674a	BUG: Fix duplicate plugins on HTML editor fields (#8559) ... * BUG: Fix duplicate plugins on HTML editor fields * Add new test	2018-11-02 12:26:53 +13:00
Michael Strong	55f95b7bc8	BUGFIX many many through not sorting by join table (#8534) ... * BUGFIX many many through not sorting by join table * #8534 added docs to support many many sorting fix * #8534 added test cases for many_many default sorting	2018-11-01 14:17:15 +13:00
Michael Strong	7086f2ea3a	BUGFIX many many through not sorting by join table (#8534) ... * BUGFIX many many through not sorting by join table * #8534 added docs to support many many sorting fix * #8534 added test cases for many_many default sorting	2018-11-01 13:42:27 +13:00
Robbie Averill	b02a6fa02d	FIX Replace usage of Convert JSON methods with json_encode	2018-10-28 21:15:29 +00:00
Sam Minnée	e72fc9e3d0	FIX DataObject singleton creation (#8516) ... Ensure DataObject instances are aware they are singletons so functions like populateDefaults() can be skipped. (fixes #4878) Correctly applies https://github.com/silverstripe/silverstripe-framework/pull/7850 to the 4.x line This has already been fixed in 3.x	2018-10-25 11:42:45 +13:00
Robbie Averill	bea4101e21	Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet	2018-10-20 20:06:02 +02:00
Robbie Averill	449b2cf291	Add tests for DefaultFormFactory	2018-10-20 19:47:11 +02:00
Robbie Averill	fd50ce6295	Add more edge case tests for disabled DateFields and DatetimeField	2018-10-20 18:29:07 +02:00
Robbie Averill	97209bc919	Add edge case unit tests for DateField	2018-10-20 18:15:42 +02:00
Robbie Averill	0e2847e289	Add tests for DatalessField	2018-10-20 17:59:55 +02:00
Robbie Averill	c06cf4820e	BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config	2018-10-20 17:47:16 +02:00
Robbie Averill	d56bad7568	Add tests for edge cases in CurrencyField	2018-10-20 17:33:59 +02:00
Robbie Averill	8929b8204f	More validation tests for ConfirmedPasswordField	2018-10-20 17:21:25 +02:00
Robbie Averill	c418ee2915	NEW Add getters and setters for public properties in ConfirmPasswordField, add tests ... Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests	2018-10-20 16:43:49 +02:00
Robbie Averill	60b375d995	Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs	2018-10-20 15:44:23 +02:00
Robbie Averill	3cdb73bd44	NEW Add getLogger() to MonologErrorHandler and add test for exception without one	2018-10-20 15:00:08 +02:00
Robbie Averill	5bd05a2deb	Reduce setUp visibility and remove check for CLI - tests always run on CLI now	2018-10-20 14:51:53 +02:00
Robbie Averill	2694a47c45	Add more tests for DetailedErrorFormatter	2018-10-20 14:41:45 +02:00
Robbie Averill	e211e27470	Add more unit tests for DebugViewFriendlyErrorFormatter, tidy up Director::is_ajax() return	2018-10-20 14:27:57 +02:00
Robbie Averill	c18e9b1298	Merge pull request #8439 from sminnee/consistent-limit ... FIX: Make ArrayList::limit() consistent with DataList::limit()	2018-10-16 12:05:11 +02:00
Aaron Carlino	7d201309ad	Merge branch '4.2' into 4	2018-10-15 13:42:55 +13:00
Robbie Averill	7215637673	Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield ... API Add a new GridFieldLazyLoader component	2018-10-11 13:43:10 +02:00
Robbie Averill	46c50577a4	Expect BEM class names in tests, fix PSR-2 line lengths, add ArrayList import	2018-10-11 12:04:23 +02:00
Sam Minnee	4740346ed8	FIX: Make ArrayList::limit() consistent with DataList::limit() ... This makes it easier to swap one fo the other without code breaking. Since it’s strictly a removed API, I’ve opted to throw a deprecation note in SS4 rather than throwing an InvalidArgumentException. Fixes #2949	2018-10-11 21:05:20 +13:00
Maxime Rainville	250d925810	MINOR Update CompositeField::__construct to call setChildren #8460	2018-10-11 15:25:34 +13:00
Maxime Rainville	2e2ca5a4a7	Make sure LazyLoader still woks after a readonly transofrmation (#8460)	2018-10-11 11:56:39 +13:00
Robbie Averill	56d5621934	FIX Flush extra_methods statics between test runs	2018-10-09 13:22:54 +02:00
Robbie Averill	55e79ffdfd	Add failing test to show that overloaded extensions are broken in Extensible	2018-10-09 12:35:32 +02:00
Maxime Rainville	fdb53311ba	Fix linting issue.	2018-10-09 17:32:42 +13:00
Maxime Rainville	a13a2cdd40	Add unit test for FieldList::getContainerField()	2018-10-09 17:32:42 +13:00
Maxime Rainville	51ba787ffb	Finish writting unit test for GridFieldLazyLoader.	2018-10-09 17:32:42 +13:00
Loz Calver	e829ad78b1	Merge pull request #8429 from sminnee/fix-2950 ... FIX: Throw deprecation on limit=0	2018-10-08 15:11:52 +02:00
Maxime Rainville	36b1066413	Merge pull request #8451 from creative-commoners/pulls/4.3/memory-cache-findtemplate ... NEW Add memory cache to ThemeResourceLoader::findTemplate()	2018-10-08 10:38:07 +13:00
Sam Minnee	8c7459a708	FIX: Fix CompositeField test that relied on a DropdownField bug ... A DropdownField without a source no longer returns a validation error.	2018-10-06 19:14:34 +13:00
Sam Minnee	e5d3b28a4d	FIX: Don’t break validation on selects without a source. ... Fixes cases where there are no valid values or an empty-string value is manually added rather than using setEmptyString() Fixes #4849 Fixes #7159	2018-10-06 11:53:17 +13:00
Sam Minnée	7915fe0c0f	Merge pull request #8303 from hchokshi/pulls/4.2/viewable-data-customised-isset ... Implement __isset for ViewableData_Customised	2018-10-06 09:37:19 +13:00
Robbie Averill	98568262f2	Fixed phpcs violations	2018-10-05 16:07:33 +02:00
Robbie Averill	da9301f241	Use SilverStripe cache API instead of memory cache, add tests and fix cache config indentation	2018-10-05 14:58:48 +02:00
Robbie Averill	172d8915b7	Clear cache between ThemeResourceLoader tests	2018-10-05 14:12:26 +02:00
Sam Minnee	0fc06e51e5	FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour. ... Note that the medium date format depends on locale, with en_NZ being resolutely numeric. I’ve updated the test to verify a couple of locales to make this more obvious. Fixes #8121	2018-10-04 14:51:24 +13:00
Sam Minnee	638e6ec281	FIX: Throw deprecation notice on limit=0 ... The SS4 behaviour of limit=0 is unlikely to be the SS5 behaviour. To clear the limit limit=null is recommended. In addition, there’s a bit tighter type maintenance in the internal limit data (ensure things are int). Fixes #2950.	2018-10-04 10:38:15 +13:00
Robbie Averill	ee24413c30	Merge branch '4.2' into 4	2018-10-03 15:28:05 +02:00
Robbie Averill	b0871ebd75	Merge pull request #8417 from creative-commoners/pulls/4.3/many-many-through-sorting-tests ... Add more list sorting tests and fix many many through sorting	2018-10-03 13:30:20 +02:00
Robbie Averill	d1f30a20c2	Merge pull request #8408 from dhensby/pulls/4/test-cleanup ... Test cleanup	2018-10-03 13:28:59 +02:00
Robbie Averill	d74fed554a	Merge pull request #8427 from sminnee/fix-1397 ... FIX: Append any fields that don’t match name in insertBefore/insertAfter	2018-10-03 13:22:23 +02:00
Guy Marriott	5970fc2417	FIX Moving test to correct director	2018-10-03 10:47:17 +13:00
Robbie Averill	c8e7672ede	Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict ... FIX Avoid having search fields with the same names as form elements	2018-10-02 13:43:59 +02:00
Sam Minnee	71dad5f685	FIX: Append any fields that don’t match name in insertBefore/insertAfter ... Previous behaviour was to return false, which has been described as a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397 where the issue was identified.	2018-10-02 10:39:48 +13:00
Robbie Averill	bfe2a7b7e6	Update testSearchFieldSchema to expect namespaced search fields	2018-10-01 12:44:19 +02:00
Harsh Chokshi	60dd5f288b	Implement __isset for ViewableData_Customised ... Resolves #8302.	2018-10-01 09:40:12 +13:00
Dan Hensby	3584598d7a	Minor improvements	2018-09-29 22:51:26 +01:00
Dan Hensby	b0e0566c93	Formatting	2018-09-29 22:51:26 +01:00
Dan Hensby	5a3cc9503b	Formatting	2018-09-29 22:51:26 +01:00
Dan Hensby	2ef63ddbc1	Remove unused function args	2018-09-29 22:51:26 +01:00
Dan Hensby	7a18cd98e0	Improve assertion type	2018-09-29 22:51:26 +01:00
Dan Hensby	90e74a608e	Throwing and catcing an error in tests is mad	2018-09-29 22:51:26 +01:00
Dan Hensby	3c532cea0c	Minor cleanup of DirectorTest	2018-09-29 22:51:26 +01:00
Dan Hensby	3a007d52e6	Code formatting	2018-09-29 22:51:18 +01:00
Robbie Averill	231d6d9a9f	FIX New members now receive the configured default locale, not the current locale	2018-09-28 16:25:10 +02:00
Robbie Averill	d18b8eb9fb	Add more tests for descending sort orders	2018-09-28 15:42:45 +02:00
Robbie Averill	4aa7fb70ee	Add tests that show that joinClass default_sort is not used and order is honoured	2018-09-28 15:38:37 +02:00
Robbie Averill	f842ee2eec	Update deprecation PHPDocs to be PSR-5 compliant ... See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated	2018-09-28 10:49:14 +02:00
Robbie Averill	0c7ced1513	Refactor sorting tests to use a dataprovider	2018-09-27 17:18:19 +02:00
Robbie Averill	c7d522ff6d	Add tests for sorting HasManyList	2018-09-27 17:09:24 +02:00
Robbie Averill	3321c6b39d	Add tests for sorting many many through list without a table alias	2018-09-27 14:34:37 +02:00
Dan Hensby	b3d2d4c1b1	Remove redundant code	2018-09-26 10:11:28 +01:00
Dan Hensby	db43d57618	Remove commented out test	2018-09-26 10:11:28 +01:00
Dan Hensby	fe5b431200	Use Member::actAs rather than setting and unsetting member	2018-09-26 10:11:20 +01:00
Dan Hensby	6b618b44c9	Remove regex in favour of simple assertContains	2018-09-26 00:36:58 +01:00
Dan Hensby	cb361e8caf	Remove unused code from ControllerTest	2018-09-26 00:30:20 +01:00
Dan Hensby	15bf13daa9	Dont use willReturn assertions to assert argument types	2018-09-26 00:21:37 +01:00
Dan Hensby	7d15d0af70	Refactor email validation into provider based test	2018-09-25 23:15:18 +01:00
Sam Minnée	5b7a84141b	NEW: Add Hierarchy::prepopulate_numchildren_cache() (#8380) ... * NEW: Add Hierarchy::prepopulate_numchildren_cache() API: Hierarchy::stageChildren() customisations must be applied to the base class and not include record-specific behaviour. Adds the ability to prepopulate the cache for Hierarchy::numChildren() in a batch. Note that this optimisation means that stageChildren() is not called on each record in order to calculate numChildren(). This means that the structure of the stageChildren() query must be the same for all records and the behaviour cannot be customised only for a subclass of the base data class. For example, apply your customisations to SiteTree and not a subclass. This is an useful part of optimising the query count on tree generation. See https://github.com/silverstripe/silverstripe-framework/issues/8379 * NEW: Add Hierarchy::prepopulateTreeDataCache() This provides a more extensible way of preopulating caches for optimised tree generation. Fixes https://github.com/silverstripe/silverstripe-framework/issues/8391	2018-09-25 12:25:23 +12:00
Robbie Averill	d11911d4dd	Merge pull request #8394 from littlegiant/pulls/4.2/http-status-codes ... BUG Prevent error on valid response status codes	2018-09-21 13:19:29 +02:00
Damian Mooyman	1d5ecd342e	BUG Prevent error on valid response status codes	2018-09-21 14:54:26 +12:00
Luke Edwards	3fc49dd4ce	Lint fixes and allow a few other components by default	2018-09-20 13:32:52 +12:00
Maxime Rainville	cc22024e9a	ADD New search component for GridFields (#1777)	2018-09-04 11:35:17 +12:00
Simon Gow	4c3a068859	Issue 3357 - Add GridField Readonly Transformation ... GridField doesn't have a valid readonly state if it's value is set to an Object without `forTemplate()`. The default behaviour is to render a ReadonlyField, but given GridField is a complex type this isn't suitable. This bugfix provides a transformation method to render only components that are whitelisted to provide a readonly state. @see #3357 - https://github.com/silverstripe/silverstripe-framework/issues/3357	2018-08-29 14:47:06 +12:00
Robbie Averill	83e461abbf	Merge branch '4.2' into 4	2018-08-27 16:15:57 +12:00
Luke Edwards	6164d01d65	FIX GridField delete button to offer archive action if possible (#8325) ... * FIX GridField delete button to offer archive action if possible * Refactor archive action to versioned module * Fix GridFieldDeleteAction test	2018-08-24 13:13:32 +12:00
Robbie Averill	dbab696690	FIX Message when changing password with invalid token now contains correct links to login ... The Security controller should be used to return these links rather than the ChangePasswordHandler	2018-08-20 22:30:12 +12:00
Daniel Hensby	d9154bffbf	FIX text/json is not a valid mimetype	2018-08-15 12:10:39 +01:00
Daniel Hensby	d0598c02c5	Merge branch '4.2' into 4	2018-07-30 11:07:15 +01:00
Daniel Hensby	ec5640cbd9	Merge tag '4.2.0' into 4.2 ... Release 4.2.0	2018-07-30 11:04:57 +01:00
Ingo Schommer	d12c2fe631	Properly deprecate HTTP.cache_control	2018-07-23 19:09:11 +01:00
Ingo Schommer	d426ecbb89	Add $maxAge arg for caching API ... See https://github.com/silverstripe/silverstripe-framework/issues/8272	2018-07-23 19:09:10 +01:00
Daniel Hensby	cc0320b2a7	Merge branch '4.2' into 4	2018-07-23 17:42:43 +01:00
Daniel Hensby	ccbbcd45a2	FIX Fixed bug in config merging priorities so that config values set by extensions are now least important instead of most important	2018-07-23 14:15:24 +01:00
Daniel Hensby	6e1c7c2781	FIX remove personal information from password reset confirmation screen	2018-07-23 14:13:52 +01:00
Maxime Rainville	c77042aa8b	Fix linting.	2018-07-23 14:12:44 +01:00
Maxime Rainville	7fda52b2cd	Add a MERGE_AS_SUBMITTED_VALUE flag for Form::loadDataFrom	2018-07-23 14:12:43 +01:00
Maxime Rainville	3fa2c056d7	FIX Don't reload form session data using FormField::setSubmittedValue (#8056)	2018-07-23 14:12:43 +01:00
Ingo Schommer	73026292bf	Test coverage for session data change	2018-07-23 14:09:43 +01:00
Daniel Hensby	e37b3b95f4	FIX updateValidatePassword calls need to be masked from backtraces	2018-07-23 14:08:26 +01:00
Daniel Hensby	540c9aba69	TEST Add tests for (im)mutablity of states	2018-07-23 14:07:11 +01:00
Damian Mooyman	8ea3bb36a0	Maybe fix it?	2018-07-23 14:01:21 +01:00
Daniel Hensby	b984959170	Merge branch '4.1' into 4.2	2018-07-23 13:30:49 +01:00
Ingo Schommer	c541283093	Test coverage for session data change	2018-07-20 15:13:26 +12:00
Daniel Hensby	921b98112e	Merge pull request #8262 from open-sausages/pulls/4/falsifying-tab-evidence ... MINOR removeField(s)FromTab no longer creates a tab if it doesn't exist	2018-07-16 17:26:41 +01:00
Loz Calver	b317bf163c	Merge pull request #8213 from creative-commoners/pulls/4.2/falsy-forms ... FIX FormField::Link works when no form is currently set	2018-07-16 13:53:58 +01:00
Robbie Averill	b93e94c0c3	FIX FormField::Link now throws a LogicException if no form is set yet	2018-07-16 13:02:58 +01:00
Daniel Hensby	1a634f5ba6	Merge pull request #8244 from altwohill/column-not-distinct ... Make column query not distinct	2018-07-16 13:01:32 +01:00
Al Twohill	3292a8b773	NEW Add columnUnique API SS_List classes.	2018-07-16 12:16:17 +01:00
Al Twohill	91068c23b5	FIX Make column query not distinct ... When selecting a column, it doesn't make sense to have it distinct. As an alternative, the API could be changed to give the end user the option (eg `->column($field, $distinct = false)`) However if we did that, we would need to make sure we do something similar with `SilverStripe\ORM\UnsavedRelationList` to ensure consistency.	2018-07-16 11:38:41 +01:00
Damian Mooyman	c6952b46c4	Merge pull request #8245 from dhensby/pulls/4.2/http-cache-fixes ... HTTPCacheControlMiddleware fixes	2018-07-16 13:13:12 +12:00
Luke Edwards	c8b338b0a3	Add findTab test	2018-07-16 11:59:08 +12:00
Daniel Hensby	8703839eb1	FIX updateValidatePassword calls need to be masked from backtraces	2018-07-15 01:06:45 +01:00
Daniel Hensby	ac5c3416a4	Merge branch '4.2' into 4	2018-07-13 17:06:51 +01:00
Daniel Hensby	bd2abc7a12	Merge branch '4.1' into 4.2	2018-07-13 16:44:23 +01:00
Daniel Hensby	ec9281ee02	Merge branch '4.0' into 4.1	2018-07-13 16:42:00 +01:00
Daniel Hensby	4acec33562	FIX Fixed bug in config merging priorities so that config values set by extensions are now least important instead of most important	2018-07-12 00:55:39 +01:00
Daniel Hensby	28f2ceac6f	TEST Add tests for (im)mutablity of states	2018-07-10 16:58:08 +01:00
Harsh Chokshi	6af736a9e1	Change DBCurrency scaffolded form field to CurrencyField (fixes #8246) ... Add test ensuring DBCurrency scaffolds CurrencyField	2018-07-09 10:57:01 +12:00
Daniel Hensby	560fe9820a	FIX remove personal information from password reset confirmation screen	2018-07-05 14:19:15 +12:00
Robbie Averill	a39a221c4c	Merge branch '4.2' into 4	2018-06-25 13:45:03 +12:00
Damian Mooyman	6da72d686f	Maybe fix it?	2018-06-20 14:46:50 +12:00
Robbie Averill	7d90a14f37	NEW Shift Embeddable and EmbedResource from asset-admin, lazy load Embed to allow injected dependencies (#8194)	2018-06-20 11:40:28 +12:00
Robbie Averill	12cc2c68a5	Merge pull request #8023 from silverstripe-terraformers/feature/lookup_field_set_value_fix ... LookupField value handling corrected	2018-06-19 21:37:36 +12:00
Damian Mooyman	cfc3b851e7	Merge remote-tracking branch 'origin/4.1' into 4.2 ... # Conflicts: # lang/sv.yml	2018-06-19 17:20:25 +12:00
Maxime Rainville	3f80e2dc67	FIX Don't reload form session data using FormField::setSubmittedValue… (#8184)	2018-06-19 11:27:09 +12:00
Robbie Averill	5fa5abf295	Merge branch '4.1' into 4 ... # Conflicts: # src/Forms/DateField.php	2018-06-15 11:52:07 +12:00
Damian Mooyman	b636587945	Respect semver and add tests	2018-06-15 11:04:12 +12:00
Damian Mooyman	c414388220	FIX DatetimeFieldTest	2018-06-14 18:14:12 +12:00
Ingo Schommer	1c5876acf0	Merge pull request #8179 from open-sausages/pulls/4/safer-test-clear ... BUG Make regression in #7839 safer	2018-06-14 17:28:13 +12:00
Damian Mooyman	d52c4dd602	BUG Make regression in #7839 safer	2018-06-14 16:45:09 +12:00
Damian Mooyman	c271a43904	Linting fixes	2018-06-14 12:19:55 +12:00
Damian Mooyman	163f1523e9	Add upgrade rule for HTTPCacheControl	2018-06-14 11:55:05 +12:00
Damian Mooyman	59ba208df0	Fix HTTPTest	2018-06-14 11:46:28 +12:00
Damian Mooyman	687d0a6af1	Refactor everything out of HTTP and into separate middlewares	2018-06-13 17:56:47 +12:00
Damian Mooyman	6f32762268	Fix unit tests	2018-06-13 14:09:31 +12:00
Damian Mooyman	aa1ba0ef90	Fix inverted condition ... Remove unnecessary yml block Deprecate HTTP::set_cache_age()	2018-06-13 13:56:47 +12:00
Daniel Hensby	e76cf93514	Migrate tests	2018-06-13 11:33:46 +12:00
Damian Mooyman	6c985c4e5f	Merge remote-tracking branch 'origin/4.1' into 4	2018-06-13 11:25:20 +12:00
Daniel Hensby	ce58890baf	Merge branch '4.0' into 4.1	2018-06-11 09:27:42 +01:00
Robbie Averill	27e24a4728	Merge pull request #8142 from open-sausages/pulls/4.0/fix-injector-empty ... BUG Safely handle empty injector factory responses	2018-06-11 15:20:24 +12:00
Damian Mooyman	77a45c0dbc	Merge remote-tracking branch 'origin/4.1' into 4 ... # Conflicts: # src/Forms/HTMLEditor/HTMLEditorSanitiser.php # src/ORM/DataObjectSchema.php # src/ORM/Queries/SQLSelect.php # src/View/Parsers/ShortcodeParser.php	2018-06-11 10:19:04 +12:00
Damian Mooyman	546c6c3e22	Merge pull request #8125 from open-sausages/pulls/4/date-field-tweaks ... Remove legacy logic from DateField_Disabled	2018-06-11 09:23:33 +12:00
Daniel Hensby	e260319823	Merge branch '4.0' into 4.1	2018-06-08 23:05:24 +01:00
Daniel Hensby	cfe93b7f23	Merge branch '3.6' into 4.0	2018-06-08 14:41:04 +01:00
Daniel Hensby	1d6d601050	Use chaining syntax for setting up middleware	2018-06-08 14:00:59 +01:00
Maxime Rainville	582c69d32f	BUG Fix issue with Disabled DateField always display (not set).	2018-06-08 13:51:22 +01:00
Ingo Schommer	48304fd6f0	Merge pull request #8102 from creative-commoners/pulls/4.1/response-assertion ... Add test assertion for response instance	2018-06-08 14:08:25 +12:00
Damian Mooyman	e37e3e1746	BUG Fix test that relies on implicit ID order breaking postgres	2018-06-08 11:23:24 +12:00
Aaron Carlino	31ad3cdaab	BUGFIX: Allow buttons to opt out of display (#8113) ... * Allow buttons to opt out of display * Linting * Remove redundant function call * Add test for group delete action * Add menu group check and test for delete action * Fix linting	2018-06-06 21:14:29 +12:00
Damian Mooyman	c070e989c4	BUG Safely handle empty injector factory responses ... Fixes issue with ImageBackendFactory returning null and breaking injector	2018-06-06 16:45:16 +12:00
Damian Mooyman	0aa13da0d9	BUG Backport bugfix for belongs_many_many with many_many through. ... Partial backport of #7928 Fixes #8131	2018-06-06 09:43:04 +12:00
Daniel Hensby	0bec6e07dc	Merge pull request #8111 from open-sausages/pulls/4/7.2-is-just-out-of-each ... BUGFIX: Refactor difflib to not use each()	2018-06-04 12:47:59 +01:00
Robbie Averill	8064ed8220	FIX Minor updates to unit tests to pass with HTML5 parser and various themes	2018-06-01 17:47:03 +12:00
Maxime Rainville	adb64c074a	✅ Making our diff unit test a bit more forgiving of spaces. ... #8053	2018-06-01 13:02:49 +12:00
Maxime Rainville	33b14e7ec2	✅ Test updated no-each logic ... Added a test that trigger the DiffEngine::diag. This test when run against the old `each` loop under PHP 7.2 triggers a deprecated warning. #8053	2018-06-01 11:16:03 +12:00
Damian Mooyman	2510935b53	Merge pull request #8065 from dhensby/pulls/4/mmtl-jointable ... NEW Add getJoinTable to MMTL	2018-06-01 10:33:46 +12:00
Robbie Averill	e0993043f8	Merge branch '4.1' into 4	2018-05-30 15:08:39 +12:00
Robbie Averill	c8b0bc0ad7	Merge branch '4.0' into 4.1 ... # Conflicts: # src/ORM/DataObject.php # tests/php/ORM/DataObjectDuplicationTest.php # tests/php/ORM/DataObjectDuplicationTest/Class1.php	2018-05-30 14:52:07 +12:00
Robbie Averill	7a8a24d175	Reset force SSL domain/patterns in setup to prevent global state pollution	2018-05-29 17:34:22 +12:00
Robbie Averill	063d765e94	Add test assertion for response instance ... This prevents middlewares that return null (like the example delegate in this test) from killing a testsuite	2018-05-29 17:26:29 +12:00
Luke Edwards	385e9e105c	Create GridField Actions Menu component (#8083) ... * WIP GridField action menu work, the gist of the idea is using a new gridfield component * Add delete action to actions menu * Actions are added automatically to action menu (allows for extension) * Add test and minor changes * Add docs and minor changes * Refactor ActionMenuItem into distinct types, general ActionMenu cleanup * Add icons and fix title * Pass columnName, so it can be used by components * Update test to open and find action menu buttons * Add section in changelog upgrade section for GridField_ActionMenu	2018-05-29 16:10:52 +12:00
Robbie Averill	c3e5ab2258	Merge pull request #65 from silverstripe-security/pulls/4.2/ss-2018-009 ... [SS-2018-009] Allow forced redirects to HTTPS for responses with basic authentication	2018-05-28 18:57:38 +12:00
Robbie Averill	ea16e28aa7	Merge branch '4.1' into 4	2018-05-28 18:33:56 +12:00
Robbie Averill	6d98a912c9	Merge branch 'heads/4.1.1' into 4.1	2018-05-28 18:26:20 +12:00
Robbie Averill	3a537bc745	Merge branch 'heads/4.0.4' into 4.0	2018-05-28 17:50:07 +12:00
Robbie Averill	722202fef4	Merge remote-tracking branch 'origin/4.0.4' into 4.1.1 ... # Conflicts: # src/Control/Director.php	2018-05-24 15:41:11 +12:00
Robbie Averill	e7e32d13a3	FIX Add namespace and encryptor to tests that expect blowfish to be available	2018-05-24 11:24:56 +12:00
Daniel Hensby	1a57c7c1d0	NEW Add getJoinTable to MMTL	2018-05-14 11:19:24 +01:00
Aaron Carlino	f847f186b1	[ss-2018-013] Remove password text from session data on failed submission	2018-05-14 17:14:38 +12:00
Robbie Averill	5887201dd5	Merge pull request #64 from silverstripe-security/pulls/4.0/ss-2018-010 ... [SS-2018-010] Fix regression of SS-2017-002	2018-05-14 17:12:45 +12:00
Robbie Averill	beec0c0d47	[SS-2018-010] Fix regression of SS-2017-002	2018-05-14 17:12:07 +12:00
Robbie Averill	1e6790bfb6	Merge pull request #62 from silverstripe-security/pulls/4.0/ss-2018-001 ... [ss-2018-001] Restrict non-admins from being assigned to admin groups	2018-05-14 17:11:03 +12:00
Damian Mooyman	e409d6f673	[ss-2018-001] Restrict non-admins from being assigned to admin groups	2018-05-14 17:10:22 +12:00
Robbie Averill	39b62e5fbb	Merge pull request #61 from silverstripe-security/pulls/4.0/ss-2018-008 ... [ss-2018-008] Validate against malformed urls	2018-05-14 17:07:09 +12:00
Damian Mooyman	9053014a7e	[ss-2018-008] Validate against malformed urls	2018-05-14 17:06:47 +12:00
Robbie Averill	6f50728b18	Merge pull request #59 from silverstripe-security/pulls/4.0/ss-2018-006 ... [ss-2018-006] Prevent code execution in template value resolution	2018-05-14 17:06:04 +12:00
Damian Mooyman	2e13ae746f	[ss-2018-006] Prevent code execution in template value resolution	2018-05-14 17:05:31 +12:00
Damian Mooyman	d935140a95	[ss-2018-005] Prevent unauthenticated isDev / isTest being allowed	2018-05-14 17:03:39 +12:00
Daniel Hensby	80bf0fc487	FIX bad syntax	2018-05-02 11:43:12 +01:00
Daniel Hensby	d5e2d3fa67	Merge branch '3.6' into 4.0	2018-05-01 21:47:17 +01:00
Robbie Averill	30e2d9c4df	[SS-2018-009] Allow forced redirects to HTTPS for responses with basic authentication	2018-04-24 14:44:29 +12:00
Mojmir Fendek	07372d388e	LookupField value handling corrected (atomic values are no longer thrown away).	2018-04-23 15:15:40 +12:00
UndefinedOffset	fe4b90edc0	FIX: Duplicating many_many relationships looses the extra fields in 4.0	2018-04-18 11:49:20 -03:00
Damian Mooyman	9a12fac218	BUG Prevent password validator min score producing false negatives ... Replaces #7995	2018-04-18 10:35:31 +12:00
Robbie Averill	af2c3886b9	Merge branch '4.1' into 4	2018-04-10 16:27:00 +12:00
Will Rossiter	09cc75a656	MINOR Add visiblity to SelectionGroup test functions	2018-04-05 10:33:27 +12:00
Will Rossiter	2512761587	Fix invalid markup in SelectionGroup selected values	2018-04-05 10:16:25 +12:00
Ingo Schommer	983a724ea5	Merge pull request #7399 from dhensby/pulls/4/reduce-dependence-on-session-for-reading-mode ... Reduce dependence on session state for accessing draft stages	2018-03-23 16:19:26 +13:00
Damian Mooyman	df9e0e40d3	Deprecate useDraftStage	2018-03-22 17:23:50 +13:00
Damian Mooyman	257ff69e32	API Implement many_many through polymorphic (from only) (#7928) ... * API Support many_many through polymorphic relations (from side only) Fixes #7911 Fixes #3136 * Add extra docs and allow optional arguments * ENHANCEMENT Enable quiet to be turned off * BUG Fix issue with manymanythroughlist duplication	2018-03-22 10:26:25 +13:00
Damian Mooyman	8b9c292509	Merge remote-tracking branch 'origin/4.1' into 4	2018-03-13 14:26:39 +13:00
Damian Mooyman	625f7b4eee	Merge remote-tracking branch 'origin/4.0' into 4.1	2018-03-13 14:26:18 +13:00
Damian Mooyman	3a1c813b28	API Add getContentCSS() / setContentCSS() to allow per-config customisation of content_css ... Fixes #7873	2018-03-05 16:10:44 +13:00
Roman Schmid	40c2e299a0	Fix "mb_stripos(): Empty delimiter" warning when no search-keywords are given for DBText::ContextSummary. ... Add unit-test to cover that case.	2018-03-01 11:39:30 +01:00
Daniel Hensby	9006daf20b	Cleaning up PR and adding tests	2018-02-28 13:31:56 +00:00
Aaron Carlino	0863bac29a	Update getVariables to return a copy of globals rather than including the reference in an array merge	2018-02-27 09:52:36 +13:00
Daniel Hensby	722f2d178a	Merge branch '4.1' into 4	2018-02-26 10:57:52 +00:00
Aaron Carlino	d91648dd6e	Update getVariables to return a copy of globals rather than including the reference in an array merge	2018-02-23 16:25:41 +13:00
Daniel Hensby	ced2ba1f64	API Move CSV writing/reading to league/csv library	2018-02-22 09:22:37 +13:00
Daniel Hensby	dace2f179d	Merge branch '4.1' into 4	2018-02-21 13:58:45 +00:00
Daniel Hensby	c04ff8c55a	Merge branch '4.0' into 4.1	2018-02-21 13:40:30 +00:00
Damian Mooyman	0e26c06644	BUG Fix behaviour towards versioned but unstagable records	2018-02-20 12:20:18 +13:00
Damian Mooyman	12e701c8ed	Merge remote-tracking branch 'origin/4.1' into 4	2018-02-15 09:28:14 +13:00
Damian Mooyman	34233c0470	Update reference to TestAssetStore	2018-02-14 16:24:12 +13:00
Damian Mooyman	0b7cf80331	BUG Fix incorrect convert slashes argument	2018-02-13 16:33:35 +13:00
Daniel Hensby	16d3498a56	Merge branch '4.1' into 4	2018-02-12 10:26:07 +00:00
Daniel Hensby	7ec5fa2c8d	Merge branch '4.0' into 4.1	2018-02-09 15:19:15 +00:00
Daniel Hensby	e298fcc345	Merge branch '3.6' into 4.0	2018-02-09 14:32:58 +00:00
Chris Joe	95308e1af6	Merge pull request #7849 from open-sausages/pulls/4.0/fix-debug-string-class-cli ... BUG Fix issue with CLIDebugView failing on class name of existing class	2018-02-09 15:41:18 +13:00
Daniel Hensby	d3278d5470	FIX Add Nested DB transaction support (#7848) ... * TEST Prove nested transactions break * Add nested transaction support	2018-02-09 10:28:32 +13:00
Damian Mooyman	0a486b8f57	BUG Fix issue with CLIDebugView failing on class name of existing class ... Fixes #7827	2018-02-09 09:52:32 +13:00
Robbie Averill	dd82820242	NEW Allow GridFieldConfig::addComponents to accept an array (#7844)	2018-02-08 11:06:27 +13:00
Andrew Aitken-Fincham	860fa2a05a	API Add excludeAny() and tests for complicated excludes/filters (#7838)	2018-02-08 09:20:17 +13:00
Damian Mooyman	2f1f5c0caa	Merge remote-tracking branch 'origin/4.0' into 4	2018-02-07 11:48:46 +13:00
Daniel Hensby	660dfd34a8	FIX Issue where default admin has no password encryption	2018-02-06 20:18:32 +00:00
Daniel Hensby	62057befdb	Merge branch '4.0' into 4	2018-02-06 10:08:17 +00:00
Daniel Hensby	28ca11dd7e	FIX Regex range identifier correctly escaped	2018-02-05 15:17:20 +00:00
Damian Mooyman	e359948eb3	Merge remote-tracking branch 'origin/4.0' into 4 ... # Conflicts: # src/Core/CoreKernel.php	2018-02-05 17:52:38 +13:00
Damian Mooyman	db9aa2c5c7	BUG Fix regression in has_one getters breaking DataDifferencer	2018-02-05 16:16:07 +13:00
Damian Mooyman	aa2c71424d	API Implement cascade_duplications ... API Add DataObject::setComponent() API Support unary components as getter and setter fields API ManyManyList::add() now supports unsaved records ENHANCEMENT Animal farm	2018-02-05 12:04:57 +13:00
Damian Mooyman	288aaf083c	BUG Fix issue with DebugView failing on class name of existing class ... Fixes #7827	2018-02-05 10:45:49 +13:00
Damian Mooyman	740c3326e9	BUG Fix critical issue with incorrectly saved session data	2018-02-02 15:08:52 +13:00
Christopher Joe	456871fd91	Enhancement Updated PasswordValidator to fallback to config options - still retains instance variables	2018-01-31 10:54:43 +13:00
Robbie Averill	3d7ecc5240	FIX Allow cleanup marker regex to handle self closing HTML5 tags	2018-01-30 11:16:21 +13:00
Damian Mooyman	76d2db12b0	Merge pull request #7794 from kinglozzer/id-like-to-place-an-ordinal ... NEW: Add support for ordinals in DBDate::Format()	2018-01-26 09:27:46 +13:00
Loz Calver	fcf5022550	NEW: Add support for ordinals in DBDate::Format()	2018-01-25 09:41:06 +00:00
Damian Mooyman	bca47029c4	Merge remote-tracking branch 'origin/4.0' into 4 ... # Conflicts: # src/Control/SimpleResourceURLGenerator.php # tests/php/Control/SimpleResourceURLGeneratorTest.php	2018-01-25 12:53:15 +13:00
Roman Schmid	6fafce766e	Fixed Rfc3339 implementation of Date and Datetime	2018-01-24 16:58:12 +01:00
Dylan Wagstaff	943821f984	Add a test for external resource support ... `SimpleResourceURLGenerator` has been altered to allow absolute URLs to be loaded directly, as so is now also tested to ensure the added functionality is true to design.	2018-01-23 17:43:01 +13:00
Damian Mooyman	04050b2753	API Director::host() now formally includes port in host ... API Add Director::hostName() and Director::port() Fixes #7685	2018-01-23 12:19:09 +13:00
Damian Mooyman	c32b3dd5ba	BUG Prevent versioned from breaking gridfield tests	2018-01-23 09:29:42 +13:00
Damian Mooyman	a3c52f901a	Merge remote-tracking branch 'origin/4.0' into 4 ... # Conflicts: # src/Core/TempFolder.php # src/ORM/DataObject.php # src/View/ThemeResourceLoader.php # src/includes/constants.php # tests/php/Control/SimpleResourceURLGeneratorTest.php # tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php # tests/php/View/RequirementsTest.php	2018-01-22 14:57:05 +13:00
Daniel Hensby	db610aaf3b	Fixing string concat CS issues	2018-01-16 18:39:30 +00:00
Daniel Hensby	c959160375	FIX Misnamed test namespaces	2018-01-16 17:41:18 +00:00
Werner M. Krauß	422857f381	SapphireTestTest: use named data providers and more error messages ... * use keys for naming each data set * adding error messages * clean up a bit	2018-01-16 15:25:40 +00:00
Daniel Hensby	ebeaf3e40d	Merge branch '3' into 4	2018-01-16 11:47:39 +00:00
Loz Calver	daac577e62	Merge pull request #7763 from creative-commoners/pulls/4.0/fix-remove-header ... FIX HTTPResponse::removeHeader incorrectly converts header name to lowercase	2018-01-16 11:04:03 +00:00
Robbie Averill	cc90cb0125	FIX HTTPResponse::removeHeader incorrectly converts header name to lowercase	2018-01-16 23:20:52 +13:00
Daniel Hensby	e4b936c7c7	Merge branch '4.0' into 4	2018-01-12 14:40:33 +00:00
Damian Mooyman	8d077203d4	API Implement support for public/ webroot folder (#7741) ... * API Implement support for public/ webroot folder * Bugfixes and refactor based on feedback	2018-01-12 16:25:02 +13:00
Daniel Hensby	de6afd4405	TEST Cant reliably use Injector to replace Extensions	2018-01-11 14:08:29 +00:00
Damian Mooyman	f885101a1b	BUG Fix basic auth in PHP-CGI ... Fixes #7717	2017-12-21 14:58:19 +13:00
Damian Mooyman	c4ff8443bb	API Shift basic auth checking into middleware ... Fixes #7554	2017-12-20 11:39:04 +13:00
Damian Mooyman	3bd4aae521	Merge remote-tracking branch 'origin/4.0' into 4	2017-12-19 10:02:41 +13:00
Chris Joe	4ad9ceca6b	Merge pull request #7702 from open-sausages/pulls/4/fix-message-casting-permissions ... BUG Fix message casting for html security messages	2017-12-18 15:43:35 +13:00
Damian Mooyman	623daed5ab	Merge pull request #6472 from silbinarywolf/feat-fieldlist-nestedfields ... feat(FieldList): Add nestedFields() function to return a flat array of all deeply nested fields in a FieldList.	2017-12-18 13:43:36 +13:00
Robbie Averill	aa7ab0c494	Update test assertions to be more readable	2017-12-17 16:22:26 +13:00
Robbie Averill	ea8ed5067d	FIX Allow Requirements::block to handle module resource paths	2017-12-17 16:09:22 +13:00
Damian Mooyman	c5bd9bb424	BUG Fix incorrect BASE_DIR inferred in CLI ... BUG Fix Director::mockRequest() mocking incorrect $url Fixes #7689	2017-12-15 17:20:48 +13:00
Daniel Hensby	e4bf9a31ed	Merge branch '4.0' into 4	2017-12-14 21:20:11 +00:00
Daniel Hensby	1c72d6946d	Merge branch '3.6' into 4.0	2017-12-14 21:01:35 +00:00
Jake Bentvelzen	da9c133c1b	ENHANCEMENT Add flattenFields() function to iterate over all deeply nested fields in a form	2017-12-14 14:23:00 +00:00
Damian Mooyman	140ed72e2a	BUG Fix message casting for html security messages	2017-12-14 14:49:58 +13:00
Damian Mooyman	529e341dbc	Merge pull request #7699 from open-sausages/pulls/4/html-in-security-msg ... ENHANCEMENT Allow html in security failure message	2017-12-14 14:30:09 +13:00
Damian Mooyman	1c8576cee7	Linting cleanup	2017-12-14 14:18:41 +13:00
Damian Mooyman	ed6561d9f5	BUG Fix incorrect merge of associative / non-associative summary fields ... Fixes #7696	2017-12-14 14:17:19 +13:00
Damian Mooyman	8b1b9f022b	Fix linting issues	2017-12-14 13:50:52 +13:00
Damian Mooyman	33b2d50d59	Cache warming in InheritedPermissions::getCachePermissions() ... Simplify Group::Members() code Remove cms-only config	2017-12-12 09:01:43 +13:00
Aaron Carlino	2be902ef2f	Adapt to new MemberCacheFlusher interface	2017-12-11 17:50:11 +13:00
Aaron Carlino	aefb0aeaa8	Make InheritedPermissions use cache and implement cache flushing	2017-12-11 17:50:11 +13:00
Damian Mooyman	ee27329728	Minor linting / style updates	2017-12-11 16:46:59 +13:00
Aaron Carlino	86458941be	Refactor to MemberCacheFlusher	2017-12-11 16:46:59 +13:00
Aaron Carlino	4857816c9e	Revisions per robbieaverill	2017-12-11 16:46:59 +13:00
Aaron Carlino	eecb9f64d3	Add new InheritedPermissionFlusher extension, CacheFlusher service	2017-12-11 16:46:59 +13:00
Damian Mooyman	eba6129c07	Merge pull request #7677 from open-sausages/pulls/4/textarea-maxlength ... Enable max length for textarea field	2017-12-11 10:34:29 +13:00
Saophalkun Ponlu	381ad756f2	Fix tests	2017-12-08 09:58:52 +13:00
Damian Mooyman	6b384f4b35	Merge branch '4.0' into 4	2017-12-07 13:52:00 +13:00
Saophalkun Ponlu	442f2bb762	Enable max length for textarea field	2017-12-07 12:52:28 +13:00
Damian Mooyman	286271a1e1	Merge pull request #56 from silverstripe-security/pulls/4.0/ss-2017-009 ... [ss-2017-009] Prevent disclosure of sensitive information via LoginAttempt (4.0 branch)	2017-12-06 18:22:47 +13:00
Damian Mooyman	99e772b361	Merge pull request #51 from silverstripe-security/pulls/4.0/ss-2017-007 ... [ss-2017-007] Ensure xls formulae are safely sanitised on output (4.0)	2017-12-06 18:22:11 +13:00
Chris Joe	0e8d288240	Merge pull request #7667 from open-sausages/pulls/4.0/better-tinymce-locales ... BUG Ensure that all tinymce_lang mappings are valid	2017-12-06 11:24:02 +13:00
Loz Calver	91bd92df31	FIX: Remove some unnecessary ClassInfo calls in DataObjectSchema	2017-12-05 12:23:10 +00:00
Daniel Hensby	eb55c27124	Merge branch '4.0' into 4	2017-12-05 12:14:22 +00:00
Damian Mooyman	69295a6e22	BUG Ensure that all tinymce_lang mappings are valid	2017-12-01 15:00:39 +13:00
Damian Mooyman	cfe1d4f481	[ss-2017-007] Ensure xls formulae are safely sanitised on output ... CSVParser now strips leading tabs on cells	2017-12-01 10:24:49 +13:00
Damian Mooyman	f1dd3d6f03	[ss-2017-009] Prevent disclosure of sensitive information via LoginAttempt	2017-11-30 17:00:49 +13:00
Damian Mooyman	5bfc0c43eb	Merge pull request #7648 from creative-commoners/pulls/4.0/support-some-class-collection ... FIX Support self::class text collection	2017-11-29 11:37:06 +13:00
Damian Mooyman	2fe59680e3	Merge pull request #7620 from open-sausages/pulls/4.0/its-too-big-to-fit ... BUG Added warning for auto-generated table_name	2017-11-28 09:42:12 +13:00
Robbie Averill	b7ea05900e	FIX Support self::class text collection	2017-11-27 23:20:29 +13:00
Christopher Joe	cc72b5c852	BUG Added warning for auto-generated table_name for non-test classes	2017-11-27 20:22:37 +13:00
Damian Mooyman	6e7fb4747e	Restore legacy $ThemeDir support	2017-11-27 15:24:40 +13:00
Daniel Hensby	6d5cbe0a0e	Merge branch '4.0' into 4	2017-11-25 17:19:31 +00:00
Daniel Hensby	07a0f75426	Merge branch '3.6' into 4.0	2017-11-25 16:56:50 +00:00
Daniel Hensby	333ecc201c	Merge pull request #7583 from open-sausages/pulls/4/relation-object-navigation ... BUG Ensure relObject() safely bails on empty objects	2017-11-23 12:48:57 +00:00
Damian Mooyman	d9e7a92b3c	BUG Fix regressions in asset resize behaviour change	2017-11-22 14:36:24 +13:00
Christopher Joe	2b6b877327	Merge branch '4.0' of https://github.com/silverstripe/silverstripe-framework into 4	2017-11-21 15:08:30 +13:00
Chris Joe	d8ca223e15	Merge pull request #7605 from open-sausages/pulls/4.0/fix-enum-defaults ... BUG Fix DBEnum ignoring empty defaults	2017-11-20 11:32:45 +13:00
Damian Mooyman	cbf9e40115	BUG Fix postgres / PDO support	2017-11-17 12:35:55 +13:00
Damian Mooyman	ef58799103	BUG Fix DBEnum ignoring empty defaults ... FIxes #7582	2017-11-17 12:35:39 +13:00
Christopher Joe	2bc7edbf47	BUG Fix don't treat zero-date as invalid	2017-11-16 13:30:15 +13:00
Damian Mooyman	eae3d0cfaa	Merge remote-tracking branch 'origin/4.0' into 4	2017-11-16 10:16:44 +13:00
Chris Joe	bee3c404fa	Merge pull request #7545 from open-sausages/pulls/4.0/deprecated-each ... BUG Remove usage of deprecated each() and use a helper method instead	2017-11-15 16:30:20 +13:00
Damian Mooyman	c9921447b3	Merge pull request #7539 from colintucker/fix-broken-paginated-list ... Fixed array/object mismatch bug in PaginatedList	2017-11-15 15:17:15 +13:00
Damian Mooyman	f863573d1c	API Add getShortName to DBClassName ... Fixes #7586	2017-11-15 11:27:58 +13:00
Daniel Hensby	cf321895ba	Merge branch '4.0' into 4	2017-11-14 13:24:15 +00:00
Damian Mooyman	ba2c5b48f7	BUG Ensure relObject() safely bails on empty objects ... BUG Remove assignment of IDs to singletons API relation methods can take an optional $id parameter to get relations from specific parents API Added UnsavedRelationList::relation() method	2017-11-10 15:27:02 +13:00
Colin Tucker	f952ef747b	Fixed array/object mismatch bug in PaginatedList	2017-11-06 11:23:41 +00:00
Sam Minnee	d8b4ca91d9	FIX: Fix ContextSummary behaviour with UTF8 chars ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/1396 Ensure that DBTextTest has UTF8 test cases	2017-11-06 12:09:08 +13:00
Damian Mooyman	420041f2b6	Merge remote-tracking branch 'origin/4.0' into 4	2017-11-03 17:04:44 +13:00
Damian Mooyman	6a73466b41	BUG Fix basicauth	2017-11-03 12:08:38 +13:00
Damian Mooyman	0b3ed7ff15	Merge 4.0 -> 4	2017-11-02 16:52:05 +13:00
Damian Mooyman	5bc4f3d1fc	BUG Remove usage of deprecated each() and use a helper method instead	2017-11-01 16:04:35 +13:00
Damian Mooyman	9d3277f3d3	BUG Fix forceWWW and forceSSL not working in _config.php ... API Introduce CanonicalURLMiddleware BUG Fix Director::makeRelative() failing on multi-domain sites	2017-10-30 14:42:36 +13:00
Damian Mooyman	324bdad48c	ENHANCEMENT Ensure DBVarchar scaffolds text field with TextField with appropriate max length ... Fixes #1413	2017-10-26 16:21:51 +13:00
Damian Mooyman	68c3279fd9	BUG Ensure readonly tree dropdown is safely encoded ... Removed legacy entwine dead code Added soft-deprecation to label field	2017-10-26 13:04:30 +13:00
Sam Minnee	4bec62ba51	Merge branch '4.0' into 4	2017-10-20 18:45:16 +13:00
Damian Mooyman	b9cb1e69e6	BUG Replace phpdotenv with thread-safe replacement	2017-10-20 18:43:11 +13:00
Christopher Joe	dabdc905ce	BUG Fix enable email subclasses to use their respective templates	2017-10-19 14:44:04 +13:00
Chris Joe	cafa3fc29a	BUG switch to trigger_error() when a resource is not found (#7468) ... * BUG switch to `trigger_error()` when a resource is not found rather than throw an exception * Add unit test for module url failing	2017-10-16 16:11:42 +13:00
Daniel Hensby	c09dec5958	Merge pull request #7456 from open-sausages/pulls/4.0/decimal-scaffolding ... BUG Fix decimal scaffolding	2017-10-10 15:46:38 +01:00
Damian Mooyman	6a55dcfc16	Fix references to resource paths / urls	2017-10-10 16:51:47 +13:00
Damian Mooyman	fd630a99b0	BUG Fix decimal scaffolding ... Fixes #7454	2017-10-10 10:13:26 +13:00
Damian Mooyman	311811a261	Merge pull request #7451 from open-sausages/pulls/4.0/whats-temporary-could-turn-path ... rename TEMP_FOLDER to TEMP_PATH	2017-10-09 14:16:06 +13:00
Damian Mooyman	994689ab54	Merge pull request #7450 from open-sausages/rename-assertDOS-to-assertList ... API Rename assert dos to assert list	2017-10-09 13:47:18 +13:00
Christopher Joe	3560a0418d	rename TEMP_FOLDER to TEMP_PATH	2017-10-09 12:41:34 +13:00
Damian Mooyman	313f8c7ac3	Merge pull request #7439 from creative-commoners/pulls/4.0/trim-injector-names ... FIX Trim whitespace off names in Injector	2017-10-09 12:31:11 +13:00
Werner M. Krauß	f686b50824	API Rename assert dos to assert list	2017-10-09 11:53:11 +13:00
Chris Joe	566d7baa48	Merge pull request #7437 from open-sausages/pulls/4.0/stateless-extensions ... API Extensions are now stateless	2017-10-09 11:45:33 +13:00
Daniel Hensby	d8f49a1bda	Merge pull request #7426 from silverstripe/filefield-accept-attr ... NEW: Implement accept attribute in FileField (closes #7279)	2017-10-06 15:01:12 +01:00
Robbie Averill	3bdc8c7e65	FIX Trim whitespace off names in Injector	2017-10-06 15:52:44 +13:00
Damian Mooyman	b996e2c22c	API Extensions are now stateless ... ENHANCEMENT Injector now lazy-loads services more intelligently	2017-10-06 14:53:44 +13:00
Damian Mooyman	168db412de	Merge pull request #7424 from creative-commoners/pulls/4.0/extensible-change-password ... NEW Make Member::changePassword extensible	2017-10-05 13:18:53 +13:00
Damian Mooyman	4dbd727206	BUG Config updates are now applied after middleware not before	2017-10-05 12:30:21 +13:00
Robbie Averill	6b52412693	NEW Make Member::changePassword extensible	2017-10-05 11:18:34 +13:00
Damian Mooyman	1b6d0144c5	BUG Fix resource mapping for TinyMCE ... API add ModuleResource::getRelativeResource()	2017-10-04 17:44:04 +13:00
Loz Calver	43ec2f87ed	NEW: Implement accept attribute in FileField (closes #7279)	2017-10-03 16:48:49 +01:00
Damian Mooyman	16f4345124	Remove unnecessary FRAMEWORK_DIR constants	2017-10-03 14:52:23 +13:00
Damian Mooyman	f4a77649a4	Fix requirements tests	2017-10-03 14:21:24 +13:00
Damian Mooyman	5ffe64f024	Fix tinymce plugins	2017-10-03 14:08:24 +13:00
Damian Mooyman	fa57deeba4	ENHANCEMENT Allow vendor modules with url rewriting ... API Introduce ModuleResource feature	2017-09-29 10:28:38 +13:00
Christopher Joe	53b2fcd1ea	Fix amend TinyMCE combined generator's unit test to be more lenient with encoding	2017-09-28 16:47:13 +13:00
Christopher Joe	7e92b053f4	Enhancement Add setter and getter for certain classes, so that LeftAndMain no longer updates config during init	2017-09-28 16:47:13 +13:00
Damian Mooyman	da27948777	Merge pull request #7373 from dhensby/pulls/4/rate-limit-security ... NEW RateLimiter for Security controller	2017-09-28 11:01:37 +13:00
Damian Mooyman	e4fd9b4ff7	Code style fixes	2017-09-28 09:54:29 +13:00
Daniel Hensby	5f739c111e	added ratelimiter tests	2017-09-27 16:42:04 +01:00
Daniel Hensby	060c2d62d3	Merge pull request #7408 from ajoneil/fix-paginated-list-get-vars ... Prior to this change, if there were already GET vars on a page with a PaginatedList, the links would include a mix of '&' and '&'.	2017-09-27 09:41:32 +01:00
Andrew O'Neil	c7cbbb29f4	Fix links on paginated lists when there are GET vars ... Prior to this change, if there were already GET vars on a page with a PaginatedList, the links would include a mix of '&' and '&'.	2017-09-27 15:41:08 +10:00
Daniel Hensby	28552155c3	NEW Add actWithPermission to SapphireTest for shortcut to perform actions with specific permissions	2017-09-26 13:39:31 +01:00
Damian Mooyman	261302a121	ENHANCEMENT Don't force all class names to lowercase ... Speeds up autoloading because composer psr-4 works properly now	2017-09-20 15:14:55 +12:00
Mike Cochrane	41d1b2a882	Test fix: Don't hard code the security page_class controller	2017-09-16 11:27:16 +12:00
Sacha Judd	c707fccf69	NEW Allow GridFieldEditButton to have configurable HTML classes. Change edit icon.	2017-09-13 13:11:17 +12:00
Andrew Aitken-Fincham	6613826ed8	FIX SSViewer::add_themes() to properly prepend	2017-09-12 13:34:56 +01:00
Damian Mooyman	4c84f22b2e	Merge pull request #7325 from xini/patch-3 ... use html5 mark tag to highlight search parameter	2017-09-05 13:38:42 +12:00
Florian Thoma	d1f7e6959f	update tests and doc	2017-09-05 09:42:08 +10:00
Saophalkun Ponlu	08fa3d6e3d	Enable TinyMCE list buttons	2017-09-04 09:30:07 +12:00
Damian Mooyman	98c10b089c	ENHANCEMENT Allow <% include %> to fallback outside of the Includes folder ... Fixes #7108	2017-08-29 16:15:46 +12:00
Andrew Aitken-Fincham	4d098fc2ad	add test for backslash on Convert::raw2htmlid	2017-08-24 11:15:44 +01:00
Chris Joe	deec9b411b	Merge pull request #7300 from open-sausages/pulls/4.0/flush-live-backurl ... BUG Capture errors after a reload token redirect to login url	2017-08-24 14:00:33 +12:00
Damian Mooyman	47fced8880	BUG Capture errors after a reload token redirect to login url ... Fixes #7289	2017-08-24 12:55:04 +12:00
Robbie Averill	595ba75a50	API Make FormField::hasClass return a boolean instead of an int	2017-08-23 16:23:28 +12:00
Damian Mooyman	9b4d689bb2	Lazy-load custom methods and extensions on CustomMethods and Extensible traits ... No longer need constructExtensions()	2017-08-22 15:47:24 +12:00
Damian Mooyman	ce5e15df6e	BUG Fix issue with multiple editors breaking plugins	2017-08-18 16:33:16 +12:00
Daniel Hensby	33c2c7bfe7	Merge branch '3' into 4	2017-08-17 15:06:00 +01:00
Christopher Joe	9dc11eff43	Enhancement Add a path option for the schema data, so a full tree is not required for this data	2017-08-17 16:08:27 +12:00
Daniel Hensby	c0211927aa	Merge branch '3' into 4	2017-08-14 21:18:03 +01:00
Damian Mooyman	323644c7bb	API Implement cascade_deletes	2017-08-09 15:14:00 +12:00
Damian Mooyman	0681567102	BUG Fix flushing on live mode (#7241) ... * BUG Fix flushing on live mode Fixes #7217 * Clarify injector service documentation	2017-08-07 13:53:23 +12:00
Damian Mooyman	f7bebdd8f8	BUG Fix install issue with IIS ... Fixes #7218	2017-08-07 10:15:40 +12:00
Chris Joe	6ebc333e00	Merge pull request #7238 from open-sausages/pulls/4.0/flush-tinymce-cache ... ENHANCEMENT Ensure flush destroys temp tinymce files	2017-08-03 19:13:54 +12:00
Damian Mooyman	b6a8e45888	BUG Ensure mocked controller has request assigned ... Fixes #7237	2017-08-03 15:52:31 +12:00
Damian Mooyman	06efd2ac12	ENHANCEMENT Ensure flush destroys temp tinymce files	2017-08-03 13:21:48 +12:00
Robbie Averill	e307f067ed	FIX Replace deprecated %s placeholders in translations with named placeholders ... * Remove the use of sprintf and %s placeholders in the i18n tests	2017-08-02 13:03:55 +12:00
Damian Mooyman	ae97c15e42	ENHANCEMENT Soft-code CSS explicit height and compute against rows	2017-08-01 15:46:49 +12:00
Damian Mooyman	078a508d71	API Replace legacy tiny_mce_gzip compressor with asset generator ... Fixes https://github.com/silverstripe/silverstripe-admin/issues/74	2017-08-01 13:43:30 +12:00
Damian Mooyman	47f24ce05b	Fixup test linting	2017-07-27 12:05:27 +12:00
Aaron Carlino	74873096bd	New getSummary() API for SearchContext	2017-07-27 11:56:37 +12:00
Daniel Hensby	6aeab571db	Merge pull request #7195 from open-sausages/pulls/4.0/missing-unnested-from ... BUG Fix unassigned nestedFrom	2017-07-24 17:07:07 +01:00
Daniel Hensby	4a1fb37d0f	Rename badly named test helper	2017-07-21 15:59:14 +01:00
Damian Mooyman	2385b73855	BUG fix config rules to match updated Except	2017-07-21 15:02:27 +12:00
Damian Mooyman	6fd6a38949	BUG Fix unassigned nestedFrom ... Fixes #7194	2017-07-21 08:58:19 +12:00
Daniel Hensby	d7095c2213	Merge branch '3' into 4	2017-07-18 14:19:16 +01:00
Damian Mooyman	ed0ed89865	Merge pull request #7055 from robbieaverill/pulls/4.0/polymorphic-has-one-indexes ... NEW Ensure polymorphic has_one fields are indexed	2017-07-18 16:39:45 +12:00
Damian Mooyman	de7b746094	Merge pull request #7180 from robbieaverill/pulls/4.0/remove-config-update-use ... Use merge and set instead of update for config calls	2017-07-18 09:16:20 +12:00
Daniel Hensby	be7b2d4970	Merge pull request #7179 from robbieaverill/pulls/4.0/is-cli-for-phpdbg ... FIX Ensure phpdbg calls are registered by SilverStripe core as a CLI call	2017-07-17 14:26:39 +01:00
Robbie Averill	da4e46e4de	FIX Use merge and set instead of update for config calls	2017-07-17 17:59:40 +12:00
Robbie Averill	ea4181166f	FIX Ensure phpdbg calls are registered by SilverStripe core as a CLI call	2017-07-17 16:56:01 +12:00
Robbie Averill	bd5782adca	NEW Allow index type to be configured per DBField instance	2017-07-17 14:36:47 +12:00
Robbie Averill	c9c4390619	NEW Ensure polymorphic has_one fields are indexed ... * Add tests for config based indexing on composite DBFields * Allow fields to have "indexed" option passed via field spec	2017-07-17 14:36:29 +12:00
Robbie Averill	1a38feff22	FIX Version provider uses early bound config getter, move LeftAndMain config to admin module	2017-07-16 16:49:10 +12:00
Daniel Hensby	7fd316d405	Merge branch 3 into 4	2017-07-15 13:20:37 +01:00
Loz Calver	aafd2a573d	Update Convert::memstring2bytes() logic	2017-07-14 09:16:05 +01:00
Christopher Joe	ccda816f90	API added flatList argument for generating the json tree list with a context string property	2017-07-13 17:04:35 +12:00
Aaron Carlino	2b266276c2	API Implement new module sorting pattern	2017-07-13 10:27:27 +12:00
Damian Mooyman	85359ad59e	BUG Ensure that installer can create an initial admin account ... Fixes #7124	2017-07-06 13:30:04 +12:00
Daniel Hensby	2c5e237a93	Merge pull request #7103 from dnadesign/fix-numericfield-null	2017-07-05 11:45:45 +01:00
Daniel Hensby	2f551c91d7	Merge pull request #6922 from kinglozzer/debugview-styles ... Update DebugView styles	2017-07-05 11:35:04 +01:00
Daniel Hensby	24a7a64c39	Merge pull request #6440 from open-sausages/pulls/4.0/requirements-module-resource-port	2017-07-05 11:31:43 +01:00
Loz Calver	713b01ebc7	Update DebugView styles	2017-07-05 09:14:26 +01:00
Aaron Carlino	c836a2e2d2	BUGFIX: Module resource regex does not allow ports	2017-07-05 13:26:30 +12:00
John Milmine	f14e6bae2c	fix numeric field for null values	2017-07-05 07:35:13 +12:00
Damian Mooyman	ed26b251c8	ENHANCEMENT: Better output type detection for debugging	2017-07-04 17:33:49 +12:00
Damian Mooyman	085cdb3671	Remove non-existant classes from .upgrade.yml	2017-07-03 14:14:56 +12:00
Damian Mooyman	f65e3627dc	BUG Implement or exclude all pending upgrader deltas	2017-07-03 12:21:47 +12:00
Daniel Hensby	c69a565b08	Merge pull request #7046 from andrewandante/FEAT/add_inGroup_to_Group ... add inGroup(s) methods to Group	2017-06-30 16:38:55 +01:00
Andrew Aitken-Fincham	ab60a167e6	add inGroup(s) methods to Group	2017-06-30 12:47:37 +01:00
Damian Mooyman	ee05c586b6	Merge pull request #7083 from sminnee/get-one-miss-null ... FIX: DataObject::get_one() misses return null, not false	2017-06-30 13:08:20 +12:00
Aaron Carlino	ad9d4e6820	Pulls/4.0/shortcode namespacing (#7085) ... * New shortcode providers, update config, docs * Use new ImageShortcodeProvider * Move tests * New shortcodes namespace * Move file and image shortcode registrations from framework to assets	2017-06-29 18:45:17 +12:00
Daniel Hensby	30986b4ea3	[SS-2017-002] FIX Lock out users who dont exist in the DB	2017-06-29 13:58:55 +12:00
Sam Minnee	2c8790ca7d	FIX: DataObject::get_one() misses return null, not false ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/5441	2017-06-29 13:51:52 +12:00
Daniel Hensby	e7df10dc52	Merge branch '3'	2017-06-28 18:59:08 +01:00
Sam Minnee	741166e369	API: ModulePath template global now takes any composer package name. ... NEW: URL generation now handled by pluggable ResourceURLGenerator service. NEW: Requirements::javascript() and Requirements::css() now support “vendor/package:resource” syntax. These changes will make it easier to us to fully abstract: - file access from module location - file location from URL generation API: ModulePath template global now takes any composer package name. NEW: URL generation now handled by pluggable ResourceURLGenerator service. NEW: Requirements::javascript() and Requirements::css() now support “vendor/package:resource” syntax. These changes will make it easier to us to fully abstract: - file access from module location - file location from URL generation	2017-06-28 16:59:28 +12:00
Saophalkun Ponlu	288de2eb14	BUG Add flag on form whether to notify user when there's unsaved changes	2017-06-28 11:14:12 +12:00
Damian Mooyman	cf758ddd4f	Merge pull request #7052 from sminnee/director-middleware ... Allow application of HTTPMiddleware to Director.	2017-06-27 14:21:23 +12:00
Ingo Schommer	daed8cb056	Merge pull request #7061 from jonom/errorpage-separation ... Removed ErrorPage	2017-06-27 14:00:43 +12:00
Damian Mooyman	f699650b5f	Update based on feedback	2017-06-27 13:32:39 +12:00
Damian Mooyman	d20ab50f9d	API Stronger Injector service unregistration ... BUG Fix up test regressions FIX director references to request object API Move all middlewares to common namespace API Implement RequestHandlerMiddlewareAdapter ENHANCEMENT Improve IP address parsing Fix up PHPDoc / psr2 linting BUG Fix property parsing in TrustedProxyMiddleware BUG Fix Director::is_https()	2017-06-27 13:32:39 +12:00
Sam Minnee	67887febc5	fix - session now uses request	2017-06-27 13:32:39 +12:00
Sam Minnee	e855622890	NEW: Replace FlushRequestFilter with FlushMiddleware	2017-06-27 13:32:39 +12:00
Sam Minnee	95a266c6b9	FIX: Add tests for middleware	2017-06-27 13:32:39 +12:00
Ingo Schommer	60a3c8754a	Simplify SecurityTest redirect assertion ... It causes inexplicable failures in the installer test, while it's passing running in framework standalone. This might be related to the cms module being present (with framework tests executed). Either way, testing that FunctionalTest can follow a redirect and correctly display the "/" homepage isn't really the point of this test. It should limit its assertion to the presence of a redirect. See https://travis-ci.org/silverstripe/silverstripe-installer/jobs/246703789	2017-06-27 09:23:37 +12:00
Jonathon Menz	d0da319004	Removed ErrorPage ... Removed references to ErrorPage so it can be split off in to a separate module. (#4149)	2017-06-26 10:03:03 -07:00
Franco Springveldt	d3d426bdfc	NEW restored Extension::__construct()	2017-06-26 17:34:43 +12:00
Ingo Schommer	12c2edc1d5	Fix DeprecationTest ... The $project use has changed in 3873e4ba00. The test isn't really reliant on $project anyway, it just tests that any other module identifier doesn't interfere with core notification settings.	2017-06-23 10:22:26 +12:00
Ingo Schommer	fb09e0b65f	Fix merge error	2017-06-23 09:27:46 +12:00
Ingo Schommer	e592bed3e5	Fixed merge error	2017-06-22 23:07:58 +12:00
Damian Mooyman	3873e4ba00	API Refactor bootstrap, request handling ... See https://github.com/silverstripe/silverstripe-framework/pull/7037 and https://github.com/silverstripe/silverstripe-framework/issues/6681 Squashed commit of the following: commit 8f65e56532 Author: Ingo Schommer <me@chillu.com> Date: Thu Jun 22 22:25:50 2017 +1200 Fixed upgrade guide spelling commit 76f95944fa Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 16:38:34 2017 +1200 BUG Fix non-test class manifest including sapphiretest / functionaltest commit 9379834cb4 Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:50:47 2017 +1200 BUG Fix nesting bug in Kernel commit 188ce35d82 Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 15:14:51 2017 +1200 BUG fix db bootstrapping issues commit 7ed4660e7a Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 14:49:07 2017 +1200 BUG Fix issue in DetailedErrorFormatter commit 738f50c497 Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:49:19 2017 +1200 Upgrading notes on mysite/_config.php commit 6279d28e5e Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 11:43:28 2017 +1200 Update developer documentation commit 5c90d53a84 Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 22 10:48:44 2017 +1200 Update installer to not use global databaseConfig commit f9b2ba4755 Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 21:04:39 2017 +1200 Fix behat issues commit 5b59a912b6 Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 17:07:11 2017 +1200 Move HTTPApplication to SilverStripe\Control namespace commit e2c4a18f63 Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 16:29:03 2017 +1200 More documentation Fix up remaining tests Refactor temp DB into TempDatabase class so it’s available outside of unit tests. commit 5d235e64f3 Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 21 12:13:15 2017 +1200 API HTTPRequestBuilder::createFromEnvironment() now cleans up live globals BUG Fix issue with SSViewer Fix Security / View tests commit d88d4ed4e4 Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:39:43 2017 +1200 API Refactor AppKernel into CoreKernel commit f7946aec33 Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 16:00:40 2017 +1200 Docs and minor cleanup commit 12bd31f936 Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 20 15:34:34 2017 +1200 API Remove OutputMiddleware API Move environment / global / ini management into Environment class API Move getTempFolder into TempFolder class API Implement HTTPRequestBuilder / CLIRequestBuilder BUG Restore SS_ALLOWED_HOSTS check in original location API CoreKernel now requires $basePath to be passed in API Refactor installer.php to use application to bootstrap API move memstring conversion globals to Convert BUG Fix error in CoreKernel nesting not un-nesting itself properly. commit bba9791146 Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 18:07:53 2017 +1200 API Create HTTPMiddleware and standardise middleware for request handling commit 2a10c2397b Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:42:42 2017 +1200 Fixed ORM tests commit d75a8d1d93 Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 17:15:07 2017 +1200 FIx i18n tests commit 06364af3c3 Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 16:59:34 2017 +1200 Fix controller namespace Move states to sub namespace commit 2a278e2953 Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 19 12:49:45 2017 +1200 Fix forms namespace commit b65c21241b Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:56:48 2017 +1200 Update API usages commit d1d4375c95 Author: Damian Mooyman <damian@silverstripe.com> Date: Thu Jun 15 18:41:44 2017 +1200 API Refactor $flush into HTPPApplication API Enforce health check in Controller::pushCurrent() API Better global backup / restore Updated Director::test() to use new API commit b220534f06 Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 22:05:57 2017 +1200 Move app nesting to a test state helper commit 603704165c Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 21:46:04 2017 +1200 Restore kernel stack to fix multi-level nesting commit 2f6336a15b Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 17:23:21 2017 +1200 API Implement kernel nesting commit fc7188da7d Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:43:13 2017 +1200 Fix core tests commit a0ae723514 Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:23:52 2017 +1200 Fix manifest tests commit ca03395251 Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 15:00:00 2017 +1200 API Move extension management into test state commit c66d433977 Author: Damian Mooyman <damian@silverstripe.com> Date: Tue Jun 13 14:10:59 2017 +1200 API Refactor SapphireTest state management into SapphireTestState API Remove Injector::unregisterAllObjects() API Remove FakeController commit f26ae75c6e Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 18:04:34 2017 +1200 Implement basic CLI application object commit 001d559662 Author: Damian Mooyman <damian@silverstripe.com> Date: Mon Jun 12 17:39:38 2017 +1200 Remove references to SapphireTest::is_running_test() Upgrade various code commit de079c041d Author: Damian Mooyman <damian@silverstripe.com> Date: Wed Jun 7 18:07:33 2017 +1200 API Implement APP object API Refactor of Session	2017-06-22 22:50:45 +12:00
Loz Calver	5d27dccd60	NEW: Add CSRF token to logout action	2017-06-21 15:42:13 +01:00
Damian Mooyman	64e802f795	API Move createTag to HTML class ... ENHANCEMENT Better HTML generation behaviour for Requirements_Backend	2017-06-16 12:22:05 +12:00
Damian Mooyman	62d095305b	API Update DefaultAdmin services ... API Improve validation of authentication process	2017-06-15 15:53:57 +12:00
Simon Erkelens	576eee72dc	Remove DefaultAdmin things from Security and Member into the MemberAuthenticator, unifying and removing duplicate code.	2017-06-15 14:20:29 +12:00
Damian Mooyman	d89bd15330	Move authentication hooks to SapphireTest	2017-06-09 16:25:40 +12:00
Simon Erkelens	082db89550	Feedback from Damian. ... - Move the success and message to a validationresult - Fix tests for validationresult return - We need to clear the session in Test logOut method - Rename to MemberAuthenticator and CMSMemberAuthenticator for consistency. - Unify all to getCurrentUser on Security - ChangePasswordHandler removed from Security - Update SapphireTest for CMS login/logout - Get the Member ID correctly, if it's an object. - Only enable "remember me" when it's allowed. - Add flag to disable password logging - Remove Subsites coupling, give it an extension hook to disable itself - Change cascadeLogInTo to cascadeInTo for the logout method logic naming - Docblocks - Basicauth config	2017-06-08 17:50:20 +12:00
Simon Erkelens	2b26cafcff	Separate out the log-out handling. ... Repairing tests and regressions Consistently use `Security::getCurrentUser()` and `Security::setCurrentUser()` Fix for the logout handler to properly logout, some minor wording updates Remove the login hashes for the member when logging out. BasicAuth to use `HTTPRequest`	2017-06-07 21:11:58 +12:00
Sam Minnee	f9ea752bae	NEW: Add AuthenticationHandler interface ... NEW: Add IdentityStore for registering log-in / log-out data NEW: Add AuthenticationRequestFilter for managing login NEW: Add Security:setCurrentUser() / Security::getCurrentUser() NEW: Add FunctionalTest::logOut()	2017-06-07 21:11:55 +12:00
Simon Erkelens	c4194f0ed2	CMS Login Handling ... Move to canLogin in the authentication check. Protected isLockedOut Enable login to be called with a different login service (CMSLogin), enabling CMS Log in. Seems the styling and/or output is still broken. logOut could be managed from the Authenticator instead of the member	2017-06-07 21:11:54 +12:00
Sam Minnee	7af7e6719e	API: Security.authenticators is now a map, not an array ... Authenticators is now a map of keys -> service names. The key is used in things such as URL segments. The “default_authenticator” value has been replaced with the key “default” in this map, although in time a default authenticator may not be needed. IX: Refactor login() to avoid code duplication on single/multiple handlers IX: Refactor LoginHandler to be more amenable to extension IX: Fixed permissionFailure hack his LoginHandler is expected to be the starting point for other custom authenticators so it should be easier to repurpose components `of it. IX: Fix database-is-ready checks in tests. IX: Fixed MemberAuthenticatorTest to match the new API IX: Update security URLs in MemberTest	2017-06-07 21:11:53 +12:00
Sam Minnee	e226b67d06	Refactoring of authenticators ... Further down the line, I'm only returning the `Member` on the doLogin, so it's possible for the Handler or Extending Handler to move to a second step. Also cleaned up some minor typos I ran in to. Nothing major. This solution works and is manually tested for now. Supports multiple login forms that end up in the correct handler. I haven't gotten past the handler yet, as I've yet to refactor my Yubiauth implementation. FIX: Corrections to the multi-login-form support. Importantly, the system provide a URL-space for each handler, e.g. “Security/login/default” and “Security/login/other”. This is much cleaner than identifying the active authenticator by a get parameter, and means that the tabbed interface is only needed on the very first view. Note that you can test this without a module simply by loading the default authenticator twice: SilverStripe\Security\Security: authenticators: default: SilverStripe\Security\MemberAuthenticator\Authenticator other: SilverStripe\Security\MemberAuthenticator\Authenticator FIX: Refactor delegateToHandler / delegateToHandlers to have less duplicated code.	2017-06-07 21:11:52 +12:00
Daniel Hensby	13ee3148d9	FIX Bracket should implement TestOnly	2017-05-30 22:44:24 +01:00
Damian Mooyman	e7d87add9f	API Remove legacy HTMLEditor classes	2017-05-30 11:01:28 +12:00
Damian Mooyman	963d9197d3	API Ensure that all DataQuery joins are aliased based on relationship name	2017-05-26 13:38:58 +12:00
Daniel Hensby	3e556b5966	NEW Move index generation to DataObjectSchema and solidify index spec	2017-05-25 23:29:12 +01:00
Damian Mooyman	9c63a8c8ce	BUG Fix race conditions in DatetimeFieldTest	2017-05-25 12:13:04 +12:00
Damian Mooyman	906a4c444b	API Add streamable response object	2017-05-23 16:32:29 +12:00
Damian Mooyman	fba8e2c245	API Remove Object class ... API DataObjectSchema::manyManyComponent() return array is now associative array	2017-05-23 13:50:35 +12:00
Damian Mooyman	f7e7fa5847	Fix linting issues	2017-05-23 09:13:50 +12:00
Damian Mooyman	7bc8172bc1	Merge pull request #6937 from caffeineinc/2930-checkboxfield-invalid-html ... CheckboxField creates invalid HTML when required #2939	2017-05-22 13:44:58 +12:00
Damian Mooyman	ba89c0804a	Add missing _config folder	2017-05-22 12:16:57 +12:00
Ingo Schommer	a433e5f4a8	Find root modules with _config.php ... When modules are installed as the webroot, manifest generation should behave the same way as when they're in a subfolder. Which means accepting the module folder both with a _config/ folder and a _config.php file present.	2017-05-22 12:16:57 +12:00
Simon Gow	cdc03602ed	CheckboxField creates invalid HTML when required #2939 ... - Updated CheckboxField, CheckboxSetField, DropdownField, OptionsetField to validate with HTML5 attributes & aria-required. https://www.w3.org/TR/wai-aria/states_and_properties#aria-required	2017-05-22 12:15:28 +12:00
Damian Mooyman	2aa3b5d5fa	Merge pull request #6934 from robbieaverill/pulls/4.0/consistent-instance-method ... API Consistent use of inst() naming across framework	2017-05-22 11:57:20 +12:00
Robbie Averill	f2cbe86f03	Remove CustomMethods::createMethod and create_function implementations, replace with closures	2017-05-19 15:56:44 +12:00
Robbie Averill	ad43a82923	API Consistent use of inst() naming across framework	2017-05-19 14:38:06 +12:00
Ingo Schommer	100048da33	API PSR-11 compliance (fixes #6594) (#6931) ... Note that our usage of `$asSingleton` in `get()` is fine. Quote from the PSR: > Two successive calls to get with the same identifier SHOULD return the same value. However, depending on the implementor design and/or user configuration, different values might be returned, so user SHOULD NOT rely on getting the same value on 2 successive calls.	2017-05-19 13:45:07 +12:00
Daniel Hensby	db3e3d51fd	Merge pull request #6928 from open-sausages/pulls/4.0/form-action-handler-regression ... Process actions on Form subclasses	2017-05-18 12:09:28 +01:00
Ingo Schommer	adbf9d9f71	Process actions on Form subclasses ... Regression introduced through https://github.com/silverstripe/silverstripe-framework/issues/6362. Quote from the RFC: ``` Thus the order of action precedence becomes action callback action on the Form action on the FormRequestHandler action on any parent controller (if given) ```	2017-05-18 22:47:39 +12:00
Daniel Hensby	3495c0826e	Cleanup SapphireTest and time related tests (#6898) ... * Test databases now include timestamp for easier debugging * Use classname::class instead of string literal classnames * Remove DataObject::get_one() from SapphireTest * More fixes to ICU DB inconsitency for time formatting * Correctly restore PHPUnits error handler	2017-05-18 22:01:55 +12:00
Damian Mooyman	8ed675d29b	Merge pull request #4542 from patricknelson/issue-4417-validator-remove-validation-master ... FIX for #4417: Ensuring ->removeValidation() is defined on instances of Validator. Setup new API for enabling/disabling validation. Documentation and better type handling.	2017-05-18 09:27:48 +12:00
Patrick Nelson	5fa3c85280	FIX for #4417: Ensuring ->removeValidation() is defined on instances of Validator. Setup new API for enabling/disabling validation. Documentation and better type handling.	2017-05-16 12:58:00 +01:00
Damian Mooyman	f5f6fdce12	API Duplication of many_many relationships now defaults to many_many only ... Fixes https://github.com/silverstripe/silverstripe-cms/issues/1453	2017-05-16 23:26:39 +12:00
Damian Mooyman	259f957ce8	API Rename services to match FQN of interface / classes	2017-05-16 14:15:49 +12:00
Saophalkun Ponlu	a975b88661	Pass autofocus flag to front-end	2017-05-16 11:53:23 +12:00
Damian Mooyman	7a8dfd2785	Add lint-clean and cleanup code linting	2017-05-16 05:01:51 +12:00
Daniel Hensby	e741af9127	Merge branch 'pull/6905'	2017-05-12 12:21:02 +01:00
Damian Mooyman	0b70b008b3	API Implement InheritedPermission calculator (#6877) ... * API Implement InheritedPermission calculator * API Rename RootPermissions to DefaultPermissionChecker API Refactor inherited permission fields into InheritedPermissionExtension API Introduce PermissionChecker interface	2017-05-11 21:07:27 +12:00
Ingo Schommer	36214343f0	Merge pull request #6902 from open-sausages/pulls/4/remove-jsmin ... Pulls/4/remove jsmin	2017-05-11 11:54:14 +12:00
Aaron Carlino	5b46461879	Remove JSMinifier implementation	2017-05-11 10:40:00 +12:00
Aaron Carlino	7fa47e234f	New API for minified files using injectable service	2017-05-11 10:14:16 +12:00
Christopher Joe	17ddfab877	Fix Test form factories use the new interface	2017-05-11 09:57:55 +12:00
Aaron Carlino	4af71b9ed7	Pulls/4/remove reliance on admin dir (#6876) ... * Stop relying on external constants * Revise getTinyMCEPath method to throw exception when no path can be computed * Throw exception on no gzip, better admin module check	2017-05-10 13:18:44 +12:00
Saophalkun Ponlu	fd51f35bc2	Update tests	2017-05-09 16:52:32 +12:00
Damian Mooyman	a136b8ad44	Merge pull request #6885 from open-sausages/pulls/4.0/fix-intl-test-consistency ... Fix intl ICU inconsistencies	2017-05-09 15:52:22 +12:00
Ingo Schommer	0d9b383631	API Removed legacy form fields (fixes #6099)	2017-05-09 11:16:41 +12:00
Aaron Carlino	afd1575267	ENHANCEMENT GridField passes in context for canCreate	2017-05-09 09:15:09 +12:00
Ingo Schommer	493556e497	More robust datetime ICU tests ... Some ICU versions (e.g. on CentOS 7.2 with PHP 5.6) use lowercase rather than uppercase AM/PM indicators	2017-05-08 21:34:56 +12:00
Ingo Schommer	20c6066391	Remove flakey swedish intl test ... The intl extension relies on system ICU libraries. Which seems to behave differently on CentOS 7.2 with PHP 5.6 (returns as '53.292:18 US$'). See http://stackoverflow.com/questions/3991814/php-pecl-extension-intl-giving-garbled-results-for-swedish-ordinal-numbers/8691743#8691743 It's a redundant test, let's just avoid this noise.	2017-05-08 21:31:14 +12:00
Damian Mooyman	d2c6c539d2	Merge pull request #6872 from sminnee/fixture-by-table ... NEW: Allow SapphireTest::objFromFixture() to accept either table or class	2017-05-05 15:14:01 +12:00
Sam Minnee	a05958b3ea	FIX: i18n test fixtures stricter for Symfony3	2017-05-05 14:32:07 +12:00
Damian Mooyman	942c0257b7	API Upgrade to behat 3	2017-05-05 14:32:07 +12:00
Sam Minnee	1691e90fbd	NEW: Allow SapphireTest::objFromFixture() to accept either table or class ... Right now SapphireTest::objFromFixture() requires a class as the first argument. This is fine when your fixture file uses classes as the keys, but if populating a fixture via tables, objFromFixture() won’t work. This patch lets you specify either the table name or the class name as the key. The benefit here is that you can build fixtures as raw inserts, which is substantially quicker, and is likely to be a useful tool in building more efficient test suites.	2017-05-05 10:53:49 +12:00
Damian Mooyman	1f8de20ce7	Fix FormSchemaTest.php linting issues	2017-05-04 13:56:54 +12:00
Damian Mooyman	8b9f41d4f4	BUG Fix ApcuCache and MemCache namespace	2017-05-04 12:17:33 +12:00
Damian Mooyman	0c52ea067c	BUG Fix incorrect text collection of __CLASS__ following an Name::class constant (#6868)	2017-05-04 10:19:05 +12:00
Damian Mooyman	12fc690d80	Merge pull request #6850 from robbieaverill/bugfix/i18n-lang-region-same ... FIX IntlLocales::validate when lang and region are the same e.g. de_DE	2017-05-01 08:41:44 +12:00
Robbie Averill	3a372a1f41	FIX IntlLocales::validate when lang and region are the same e.g. de_DE	2017-04-28 17:19:27 +12:00
Damian Mooyman	699d5d6a42	Fix i18nTextCollector handling of special string characters	2017-04-28 14:59:42 +12:00
Damian Mooyman	2ae8fde2d3	Fix tests	2017-04-28 14:59:42 +12:00
Uncle Cheese	d51c4891e2	New namespaced i18n keys	2017-04-28 14:59:42 +12:00
Uncle Cheese	494cbd1875	Ran upgrader for lang files	2017-04-28 14:59:42 +12:00
Ingo Schommer	daed727acc	Fixed form schema validation	2017-04-28 08:30:59 +12:00
Ingo Schommer	a2ee6a76a0	Fixed formschematest	2017-04-27 21:44:28 +12:00
Ingo Schommer	60706c8efd	Store $value in ISO and server timezone consistently, fix min/max timezone handling	2017-04-27 14:59:11 +12:00
Ingo Schommer	de8abe1167	API rename	2017-04-27 11:53:43 +12:00
Ingo Schommer	9b41350f64	More min/max setter tests	2017-04-27 11:53:34 +12:00
Ingo Schommer	958736502a	Removed “T” str_replace, more comments	2017-04-27 10:32:22 +12:00
Ingo Schommer	a73abbfcb8	unit test cleanup	2017-04-27 09:18:38 +12:00
Ingo Schommer	1ec2abe75f	Fixed timezone and normalised ISO handling ... A few observations: - ISO says “T” is optional (https://en.wikipedia.org/wiki/ISO_8601#cite_note-21), - WHATWG says in the HTML5 spec that it’s optional (https://html.spec.whatwg.org/multipage/infrastructure.html#local-dates-and-times) - W3C says it’s reqiured in 1997 (https://www.w3.org/TR/NOTE-datetime), but then later says it’s optional in its HTML5 spec (https://www.w3.org/TR/html5/infrastructure.html#floating-dates-and-times). - Chrome doesn’t parse values with whitespace separators (requires "T") - DataObject DBDatetime values and database columns use whitespace separators (and will have many devs relying on this format) - MySQL only supports whitespace separators (https://dev.mysql.com/doc/refman/5.7/en/datetime.html) - SQLite can parse both ways (https://sqlite.org/lang_datefunc.html) So the goal here is to retain ORM/database compatibility with 3.x (whitespace separator), while exposing "T" separators to the browser in HTML5 mode. Regarding timezones, this fixes a regression where setValue() would not actually apply the timezone (last $value assignment is ineffective now that sub fields are removed).	2017-04-26 22:55:29 +12:00
Ingo Schommer	a279d00e81	Min/max validations	2017-04-26 22:45:12 +12:00
Ingo Schommer	e97783b057	Better second handling	2017-04-26 22:45:08 +12:00
Saophalkun Ponlu	dba1f61f13	Fix tests related to date time	2017-04-26 22:45:07 +12:00
Christopher Joe	1f74221c2d	Fix unit tests	2017-04-26 16:03:52 +12:00
Simon Erkelens	ff3ad6eb6b	Use Config for authenticator settings	2017-04-22 14:48:56 +12:00
Damian Mooyman	2548bfba1e	API Replace SS_HOST with SS_BASE_URL ... API Remove Director::$test_servers / $dev_servers API Remove MODULES_PATH / MODULES_DIR constants ENHANCEMENT Injector backtick syntax now supports environment variables as well as constants Fixes #6588	2017-04-20 22:28:57 +12:00
Damian Mooyman	136b67f597	API Major refactor of Hierarchy into MarkedSet	2017-04-13 16:27:13 +12:00
Damian Mooyman	f2768c85b1	API Enable namespaced-localisation keys in templates ... BUG Fix whitespaces in SSTemplateParser.peg	2017-04-11 18:07:53 +12:00