tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUG Added warning for auto-generated table_name for non-test classes

Browse Source
This commit is contained in:
Christopher Joe 2017-11-27 20:14:10 +13:00
parent 7c3997344a
commit cc72b5c852
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/ORM/DataObjectSchema.php
View File

@ -6,6 +6,7 @@ use Exception;
use SilverStripe\Core\Injector\Injectable;
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\FieldType\DBComposite;
use SilverStripe\Core\ClassInfo;
use SilverStripe\Core\Config\Config;
@ -126,6 +127,7 @@ class DataObjectSchema
}
return null;
}
/**
* Returns the root class (the first to extend from DataObject) for the
* passed class.
@ -301,11 +303,26 @@ class DataObjectSchema
$table = Config::inst()->get($class, 'table_name', Config::UNINHERITED);
// Generate default table name
if (!$table) {
$separator = DataObjectSchema::config()->uninherited('table_namespace_separator');
$table = str_replace('\\', $separator, trim($class, '\\'));
if ($table) {
return $table;
}
if (strpos($class, '\\') === false) {
return $class;
}
if (!ClassInfo::classImplements($class, TestOnly::class)) {
trigger_error(
"It is recommended to define a table_name for your '$class'." .
' Not defining a table_name may cause subsequent table names to be too long and may not be supported' .
' by your current database engine, the generated naming scheme will also change when upgrading to' .
' SilverStripe 5.0 and potentially break.',
E_USER_WARNING
);
}
$separator = DataObjectSchema::config()->uninherited('table_namespace_separator');
$table = str_replace('\\', $separator, trim($class, '\\'));
return $table;
}

4
tests/php/Core/ClassInfoTest/ChildClass.php
View File

@ -2,7 +2,9 @@
namespace SilverStripe\Core\Tests\ClassInfoTest;
class ChildClass extends BaseClass
use SilverStripe\Dev\TestOnly;
class ChildClass extends BaseClass implements TestOnly
{
}