tonyair
/
silverstripe-framework
mirror of https://github.com/silverstripe/silverstripe-framework
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

API Make FormField::hasClass return a boolean instead of an int

This commit is contained in:
Robbie Averill 2017-08-23 14:16:54 +12:00
parent 9b4d689bb2
commit 595ba75a50
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Forms/FormField.php
View File

@ -1247,17 +1247,16 @@ class FormField extends RequestHandler
}
/**
* Returns whether the current field has the given class added
*
* @param string $class
*
* @return int
* @return bool
*/
public function hasClass($class)
{
$patten = '/' . strtolower($class) . '/i';
$subject = strtolower(static::class . ' ' . $this->extraClass());
return preg_match($patten, $subject);
$classes = explode(' ', strtolower($this->extraClass()));
return in_array(strtolower(trim($class)), $classes);
}
/**

11
tests/php/Forms/FormFieldTest.php
View File

@ -373,4 +373,15 @@ class FormFieldTest extends SapphireTest
$schema['message']['value']
);
}
public function testHasClass()
{
$field = new FormField('Test');
$field->addExtraClass('foo BAr cool-banana');
$this->assertTrue($field->hasClass('foo'));
$this->assertTrue($field->hasClass('bAr'));
$this->assertFalse($field->hasClass('banana'));
$this->assertTrue($field->hasClass('cool-BAnana'));
}
}