Dev
1c755a4bf4
lint
2024-02-07 09:34:08 +00:00
Dev
2f0513edff
Update gifts.json to include plates/soft inserts for armors + mods for weapons
2024-02-07 09:33:47 +00:00
Azrael1123
7a4b27bbe1
Better fix for SPT-AKI/Issues#417 ( !215 )
...
[The wiki specifies](https://escapefromtarkov.fandom.com/wiki/Scavs#Scav_karma ) that, between 6 and 8, Fence rep is reset to 6 before penalties are applied (i.e. killing someone at 7.5 rep leaves you at 5.9), but the current fix just subtracts a flat 1 reputation instead (i.e. a kill at 7.5 leaves you at 6.4)
this should change that.
Co-authored-by: Azrael <Azrael@noneofyourbusiness.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/215
Co-authored-by: Azrael1123 <azrael1123@noreply.dev.sp-tarkov.com>
Co-committed-by: Azrael1123 <azrael1123@noreply.dev.sp-tarkov.com>
2024-02-07 08:18:18 +00:00
Refringe
ebbc3e2029
Refactored InsuranceController
for Better Attachment Handling
...
Made several improvements to the `InsuranceController` to ensure a more reliable and logical handling of insured items and their attachments.
- Updates `parentAttachmentsMap` declaration to `let` for mutability, enabling dynamic updates during processing.
- Updates `parentAttachmentsMap` to initially include all attachments (including attachments that should not be in-raid moddable).
- Updates `processRegularItems` logic to include `parentAttachmentsMap` in its parameters and logic. Now better ensures that attachments are correctly identified and processed alongside their parent items.
- Adds `removeNonModdableAttachments` method to filter out non-moddable attachments from processing.
- Updates deletion logic to better handle cases where items, such as armour vests and their non-removable plates, are processed to prevent orphaned items post-deletion.
Resolves #401
2024-02-07 01:16:46 -05:00
Refringe
2aa0054833
Insurance Package Removal Issue
...
Resolved an issue that caused insurance packages that were created/lost in the same raid with different traders to be removed all at once instead of one-by-one after they were processed. This shouldn't have been causing any notable issues as the packages were already cached/queued up for processing elsewhere in the code, but it was never the original intent to have them removed before they were processed. The fix was simply to also match the trader ID when the package removal takes place.
Possibly related to #401 #425
2024-02-06 20:08:14 -05:00
Refringe
6714d2d172
Forgot Instance of Parent Update
...
Updates the `replaceIDs` method call in the `LocationGenerator` class to be inline with the changes in the parent commit.
2024-02-06 18:50:42 -05:00
Refringe
42dabc057b
Improved replaceIDs
Method in ItemHelper
...
- Implemented deep cloning of input Items to prevent mutation.
- Reordered parameters: Items (required) now precede PMC data (optional).
- Updated method calls to bring them inline with these changes.
2024-02-06 18:39:06 -05:00
Refringe
c29482394b
(More) Simple Parameter Reassignment Issues
...
Addresses some of the simple linting errors regarding the reassignment of function parameters.
2024-02-06 18:35:11 -05:00
Dev
d8fe911464
Cleanup dynamic loot selection, armors have their children stored in loose loot json, use existing code to pull children out instead of generating it
2024-02-06 23:17:41 +00:00
Dev
cb10ec4148
When generating armors for static loot, try and use default preset first before generating randomly
2024-02-06 23:00:39 +00:00
Dev
1101927768
Improve fence price calculation code. Prices now take into account removed item mods + mod durability
2024-02-06 20:44:40 +00:00
Dev
f48ad01b38
Add thermalvision price limit to fence
2024-02-06 19:52:10 +00:00
Dev
e20c89301d
Adjust low level PMC ammos
2024-02-06 17:30:04 +00:00
Dev
4e02384e04
PMC mod spawn chance adjustments
2024-02-06 17:27:00 +00:00
Dev
1681e452bb
Force muzzle devices to be a required slot
...
Lower muzzle chance for PMCs level 20+
2024-02-06 17:21:33 +00:00
Dev
f2865e7675
Experimental; flag mod_muzzle
as required for PMCs
2024-02-06 16:59:58 +00:00
Dev
b40e41bd3d
Improve sellChance logic
...
Two changes:
Calcualte the quality of an item and its mods, not just root item
Calcualte the average price of an offer using item + mods, not just root item
2024-02-06 15:52:22 +00:00
Dev
fcf7ff5c3d
Update trader assorts, include missing armor inserts on items not dumped from live yet (prapor and ragman)
2024-02-06 14:53:10 +00:00
Dev
5f873e73b8
Move handbook override code into HandbookHelper.hydrate()
- changes now apply to ragfair
2024-02-06 12:52:56 +00:00
Dev
62f51be3aa
Improve readability of valid item check
2024-02-06 12:18:41 +00:00
Dev
5c52e13064
Add presents to chiristmas seasonal event gift
2024-02-06 12:18:16 +00:00
Dev
e9daf61013
Implement christmas gift system.
...
Gifts now give rewards, bigger the gift = bigger the possible reward
2024-02-06 12:17:41 +00:00
Dev
7bc9fdbe95
Add system to override handbook price, add christmas gift items small/med/large
2024-02-06 12:16:26 +00:00
Dev
72345abb4a
Force plates to spawn in armor items found inside PMC backpacks
2024-02-06 10:53:08 +00:00
Dev
ddac44f79d
Divide roubles calculated inside calculateCostOfScavInventoryAndMailMoneyToPlayer()
by half
2024-02-06 10:33:59 +00:00
Dev
023697ed74
Partial fix for items flagged as being never lost on death coming back as insurance.
...
Items will not return but plates inside them still do
2024-02-06 10:10:56 +00:00
Dev
c6de12e6f8
Rename variables/comments for clarity
2024-02-06 09:49:51 +00:00
Deadly Alden
4fc012b422
Revamp structure of socket debug messages ( !214 )
...
**Description**
This pull request changes the WebSocket connection `handle lost` log message in the `wsOnConnection` method of the `GameSocket` class. The original log message was:
```typescript
this.logger.debug(this.localisationService.getText("websocket-socket_lost_deleting_handle");
>>> [WS] Socket lost, deleting handle, status: %s
```
Which was inconsistent with most other languages. It can be understood from context that the socket was lost, therefor deleted and closed. Instead now;
```typescript
this.logger.debug(this.localisationService.getText("websocket-socket_lost_deleting_handle");
>>> [WS] Socket lost, deleting handle
```
This is achieved through editing the languages one by one and removing the "`status: %s`" component.
**Related**
- Closes: https://dev.sp-tarkov.com/SPT-AKI/Issues/issues/421
Co-authored-by: Deadly <info.saddiki@gmail.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/214
Co-authored-by: Deadly Alden <deadly@noreply.dev.sp-tarkov.com>
Co-committed-by: Deadly Alden <deadly@noreply.dev.sp-tarkov.com>
2024-02-06 09:07:23 +00:00
Refringe
807ba04967
Resolves Bot Generation Error
...
- Resolves an issue in bot generation caused by a missing parameter when calling the `shouldModBeSpawned` method.
- Adds a optional chaining operator within a condition to safeguard against undefined errors.
Contributed by: barlog_m
Thank you! :D
2024-02-05 19:16:36 -05:00
Refringe
cd6e40b66c
Error Message Propagation Issue
...
Resolves an issue where the error message in `getItemsToListOnFleaFromInventory` did not propagate as expected due to the pass-by-value behaviour in JavaScript. The solution was to refactor the method to return an object that includes both the items and the error message.
2024-02-05 19:03:26 -05:00
Refringe
3a2b24b9b8
Simple Parameter Reassignment Issues
...
Addresses some of the more simple linting errors regarding the reassignment of function parameters.
2024-02-05 19:03:26 -05:00
Refringe
34121182a1
Biome Linting Issues
...
Fixed some instances of:
- Unordered imports
- Reassigning function parameters
- Modifying values in assignment/return statements
- Array.forEach being used instead of for...of
- Simplified control logic
2024-02-05 19:03:26 -05:00
Dev
d0ed738c0b
lint bot json
2024-02-05 22:07:33 +00:00
Dev
9a1ef8daa2
Add missing locale
2024-02-05 22:02:19 +00:00
Dev
b7d74f1dec
Add system to flag weapon slot ids as required.
...
Applies to stocks/recievers for PMCs
recievers for exusec/raider
2024-02-05 22:02:03 +00:00
Dev
32862866aa
Remove some debug logging
2024-02-05 19:53:59 +00:00
Dev
d36593ca57
Rework fence service to handle armor/weapons separately,
...
made config work with a weapon/equipment min/max value
Improve price filtering system to work with weapons/equipment
2024-02-05 19:52:46 +00:00
Dev
3653ab9f83
Apply a duribility price modifier to items sold on flea
2024-02-05 19:49:42 +00:00
Dev
ce27f58664
FIx weapons/armors not showing on fence
2024-02-05 18:21:02 +00:00
Dev
f429cbd663
Update locales
2024-02-05 15:46:00 +00:00
Dev
e0cb167272
Update PMC mod item data
2024-02-05 15:37:01 +00:00
Dev
422b7878ab
Add getMatchingPreset()
and add workaround for silenced DVL choosing wrong barrel mods
2024-02-05 15:36:05 +00:00
Dev
a04a05996d
Adjust calculateFenceStandingChangeFromKills()
to take into account rep loss when fence rep between 6 and 8 or rep > 8
2024-02-05 14:44:31 +00:00
Dev
bf5f3316b1
Rename cloned variables to help with readability
2024-02-05 14:43:46 +00:00
Dev
183e71370a
Reworked buyItem()
to use addItemsToStash()
to ensure it performs a space check prior to adding any items to stash
2024-02-05 14:07:21 +00:00
Dev
2f673d12b9
Improve weapon/equipment item purchase filtering
2024-02-05 11:38:04 +00:00
Dev
0f6b34605b
Prevent duplicate equipment builds occuring when renaming an existing build
2024-02-05 09:13:37 +00:00
Dev
946172d20c
Add additional helmet soft inserts to getSoftInsertSlotIds()
2024-02-05 09:02:58 +00:00
Dev
a2668a9618
Rework insurance to not duplicate items + still return soft_inserts
...
Added missing groin_back to `itemRequiresSoftInserts()`
2024-02-04 22:41:11 +00:00
Dev
e5bc45c6d4
Adjusted front/rear loot item plate chance to be 100%:
2024-02-04 20:30:10 +00:00
Dev
af0c6b9ee9
Add missing initialLoyaltyLevel values to standard account templates
2024-02-04 19:58:57 +00:00
Dev
d9bcb3fce8
Fix deleting an item from mail before receiving all kills server
2024-02-04 19:51:19 +00:00
Dev
9fa0bf53e5
Rework sell all scav gear button to send money as mail
2024-02-04 19:27:35 +00:00
Dev
5bde733e7b
Lower airdrop weapon crate count max to 2 for mixed type crates
2024-02-04 17:01:04 +00:00
Dev
09a76f5c3f
Replace placehold quest assorts with live data taken on 15th of jan
2024-02-04 15:52:44 +00:00
Dev
b6b659d2d7
Increase chance of Pscav name on scavs to 20%
2024-02-04 14:43:58 +00:00
Dev
63603f5d9a
Reduce grizzly count added to PMC secure to 1 + morphine to 2
2024-02-04 14:43:37 +00:00
Dev
c43c06d2b5
Increase chance PMCs 1-15 have backpacks
2024-02-04 14:37:08 +00:00
Dev
2fb15dab94
Adjust PMC 1-15 backpack loot values - tiny chance of 10 items + weight 2/3 items more heavily
2024-02-04 14:35:22 +00:00
Dev
6d300c9d4d
Add chance for 1-15 PMCs to have 2 healing items on their person
2024-02-04 14:31:26 +00:00
Dev
ef623de2d7
Increate 1-14 PMC chance to have a grenade to 44%
2024-02-04 14:30:13 +00:00
Dev
ba94183f86
Blacklist Ultralink quest item from airdrops
2024-02-04 14:10:03 +00:00
Dev
cfe470029f
Refactor insurance item checking code into 2 functions to allow checking if any items were lost before sending Insurance lost
mail
2024-02-04 10:19:57 +00:00
Dev
afce41d68b
Improve lost insurance message system, only send lost insurance when an insured item was lost
2024-02-04 09:52:56 +00:00
Dev
8b90373965
Removed Out of Time
quest
2024-02-04 09:40:52 +00:00
Dev
193161f786
Fix preset buy searches not filtering items based on search criteria/player level
2024-02-04 09:31:00 +00:00
Dev
ff4b1f95be
Fixed Rhys-T helmet not having inserts for PMCs
2024-02-04 09:24:39 +00:00
Dev
2c4278cd96
Show debug message as warning + fix incorrect prapor quest assort ids
2024-02-04 09:12:27 +00:00
Dev
f2ed957579
Expand server version debug logging
2024-02-04 09:04:12 +00:00
Dev
4d88b2a94a
Prevent developer profile changes bleeding into non-dev accounts
2024-02-03 23:40:20 +00:00
Dev
3dacbc98b2
Remove redundant .some()
call
2024-02-03 23:11:36 +00:00
Dev
d362e17e1b
prevent failQuest()
from failing when no repeatable quest is found
2024-02-03 23:10:42 +00:00
Dev
714386c793
Update generateEquipment()
to return true when it adds item
2024-02-03 20:29:31 +00:00
Dev
3c371a6c16
Add search criteria filtering to required search
...
Pull out`isDisplayableOffer` from`passesSearchFilterCriteria`
2024-02-03 20:23:26 +00:00
Dev
36d6e56d89
Improve comments
2024-02-03 19:47:39 +00:00
Dev
747510e5d2
Remove bleeds/breaks after 30 mins offline
2024-02-03 19:45:42 +00:00
Dev
1a9dc1ea2b
Cleanup of setHideoutAreasAndCraftsTo40Secs
to more central location
2024-02-03 19:42:49 +00:00
Dev
48e6f3052d
Add item limit of 1 for TerraGroup Labs access keycard
to bosskojaniy
2024-02-03 17:41:05 +00:00
Dev
ec9a877cd4
Force item limits to be used with special loot items
2024-02-03 17:34:08 +00:00
Dev
fcd7e463aa
Merge branch '3.8.0' of https://dev.sp-tarkov.com/SPT-AKI/Server into 3.8.0
2024-02-03 17:00:04 +00:00
Dev
34d761a14f
Fix edge case when getModPoolForSlot()
gets default handguard for mp5 when the reciever is set to the mp5sd. Now uses correct default template
2024-02-03 16:59:54 +00:00
CWXDEV
27927dd456
Fix dev profiles on creation not having correct "shortened" crafting times
...
new call only happens when a creation of profile happens
2024-02-03 16:39:20 +00:00
Dev
f17d385d56
Add missing easy start bear data
2024-02-03 16:06:23 +00:00
Dev
b7f6cf5e36
Reorder profile presets to have standard first, EoD last
2024-02-03 15:55:23 +00:00
Dev
b6a57553de
Enhance profile template initial trader standing system to be per trader
2024-02-03 15:53:28 +00:00
Dev
acbfc3bd81
Merge branch '3.8.0' of https://dev.sp-tarkov.com/SPT-AKI/Server into 3.8.0
2024-02-03 15:29:53 +00:00
Dev
579a846212
Set easy start profiles to have traders level 2
2024-02-03 15:29:39 +00:00
CWXDEV
06ce2c090e
Fix Required Search
2024-02-03 15:26:15 +00:00
Dev
0d21eac38f
Extend snow till the 10th of feb
2024-02-03 15:14:26 +00:00
Dev
e4df0581c6
Update starting ammo in profile templates
2024-02-03 15:14:03 +00:00
Dev
fc6d8b487a
Add empty locales
2024-02-03 15:03:14 +00:00
Dev
5e1da93a69
Allow seasonal events to trigger after profile creation
2024-02-03 14:39:37 +00:00
Dev
164bf08b08
FIx armor filtering code to correctly return non-armored rigs when requested
2024-02-03 14:00:47 +00:00
Dev
8d2eaf2485
Copy over stackobject count from original reward
2024-02-03 12:47:52 +00:00
Dev
f7651fe003
fix colliding var names
2024-02-03 12:18:11 +00:00
Dev
0a6a866ae8
Correctly clone and remap default preset before returning
2024-02-03 12:15:20 +00:00
Dev
e3cf4c3c92
Fix starting quest armor rewards not showing correctly
2024-02-03 11:41:30 +00:00
Dev
055f8176d8
Remove Hippocratic Oath quest - no longer in live
2024-02-03 11:14:57 +00:00
Dev
12a9cb5ded
Fix processReward()
incorrectly trying to add mods to armor items without slots
...
Add `itemHasSlots` to itemHelper and consolodate its use across code
2024-02-03 11:00:30 +00:00
Dev
47bedcb526
improve filtering of required item
searches on flea - Fixes locked items being shown in search results
...
Improve type usage inside `getRequiredItemsById()`
2024-02-03 10:33:11 +00:00
Dev
f2cae309ec
Merge branch '3.8.0' of https://dev.sp-tarkov.com/SPT-AKI/Server into 3.8.0
2024-02-03 10:02:22 +00:00
Dev
e801b30d98
Fix trader assorts with an UnlimitedCount
value not having a stack size of 9999999 - fixes unlimited item on prapor having stack size of 100
2024-02-03 10:01:44 +00:00
Kaeno
9f9febd624
Add missing quest images
2024-02-03 00:30:01 +00:00
Kaeno
1c00c2bb13
Keep bonus.value from text_bonus bonuses
2024-02-02 20:11:09 +00:00
Refringe
69a1723646
Fixes Linting Issues
...
- Reorders imports
- Removes unnecessary `else` control statements
- Simplifies some logic
- Converts key access to dot notation
- Converts Array.forEach loops to for...of loops
2024-02-02 15:00:21 -05:00
Refringe
90492f3aa2
Formatting
...
Have you been using the recommended VSCode extensions? ;)
2024-02-02 15:00:21 -05:00
Kaeno
8227e06d77
Black list Sacred Amulet from scav case also
2024-02-02 19:25:14 +00:00
Dev
5136d69050
Implement flea required searching
2024-02-02 19:23:08 +00:00
Kaeno
ef958a115d
Blacklist Lightkeepers amulet from airdrops and fence
2024-02-02 19:02:46 +00:00
Dev
6a4330557f
Add PMC name
2024-02-02 17:58:31 +00:00
Dev
36d16f0917
Add english fallback locale
2024-02-02 17:53:23 +00:00
Dev
ca02aa6a50
Fix stackable hideout crafts not being added to stash in correct format
2024-02-02 17:31:52 +00:00
Dev
83c3cd5f8b
Remove unused function
2024-02-02 17:22:49 +00:00
Dev
796d63b3e2
Fix fence item not being removed after purchase
2024-02-02 17:22:12 +00:00
Dev
e6e77d49a5
Cleanup of fence offer generation, no longer errors when buying items from high level fence offer page
2024-02-02 17:15:28 +00:00
Dev
034ac83a10
Improve handling of buying less than max stacksize from fence
2024-02-02 15:56:37 +00:00
Dev
8dab47b3fd
Fix selling to trader an amount above stack size causing currency to not stack
2024-02-02 15:35:02 +00:00
Dev
a1e84992a2
update english locale
2024-02-02 14:18:45 +00:00
Dev
8d59ab7c77
Replace use of dialogueHelper.addDialogueMessage inside sendInsuredItems() with MailSendService.sendMessage()
2024-02-02 11:57:10 +00:00
Kaeno
e0b5d43fd5
Fix fence generating items with same IDs causing Fence Trader to break client
2024-02-01 21:02:39 +00:00
Dev
5b04bc530e
Update locales
2024-02-01 20:19:06 +00:00
Dev
ded87b3881
Show first 7 characters of commit server was built against in version label
2024-02-01 16:58:23 +00:00
Dev
31942b96eb
Add marksman rifles to elimination dailies
...
Add weapon filtering based on range requirement of elimination quest:
> 50 = no pistols/shotguns
< 20 = no DMR/MarksmanRifles
2024-02-01 14:37:02 +00:00
Dev
a38cf7fa69
Remove redundant else from toggleItem()
2024-02-01 13:58:06 +00:00
Dev
5e94e3fef0
Cleanup of getExaminedItemTpl()
2024-02-01 13:53:36 +00:00
Dev
6032573815
Comment improvements
2024-02-01 13:31:36 +00:00
Dev
5f500655be
openRandomLootContainer()
Remove item after contents have successfully been added to stash
2024-02-01 13:26:18 +00:00
Dev
3587becf76
Update openRandomLootContainer()
to use addItemsToStash()
2024-02-01 13:23:03 +00:00
Dev
704b337a3c
removeResourceFromArea()
Pass found item in slot directly to addToStash requst for small optimisation
2024-02-01 12:53:30 +00:00
Dev
d920dceb53
Remove redundant returns from various hideout functions used inside takeProduction()
2024-02-01 12:47:48 +00:00
Dev
3bf44b7863
Update handleScavCase()
to use addItemsToStash()
2024-02-01 12:42:02 +00:00
Dev
d564a7a992
Comment improvements
2024-02-01 12:35:18 +00:00
Dev
16cb48ad70
Improvements to handleRecipe()
...
Cleaner handling of stackable rewards
Moved task condition counter lookup to own function
2024-02-01 12:31:48 +00:00
Dev
44560991b0
Improve handleRecipe()
...
Better handling of item rewards that need to be split into root + child (ammo boxes)
Use `addItemsToStash()`
move `recipe.isEncoded` check to earlier in function
make use of `getItem()` inside `splitStack()` instead of direct db access
2024-02-01 11:23:32 +00:00
Dev
92d949b445
Comment improvements
2024-02-01 10:24:10 +00:00
Dev
8c99b25df0
Rename interface to IOwnerInventoryItems
2024-02-01 09:58:20 +00:00
Dev
1e4d07937b
Update getBTC()
to make use of new function
2024-02-01 09:58:04 +00:00
Dev
406c59789a
Add interface
2024-02-01 09:50:50 +00:00
Dev
8d8baec766
Add new addItemsToStash()
function to InventoryHelper
2024-02-01 09:48:46 +00:00
Dev
69735b5037
Check inventory has space before adding bitcoins from craft
2024-01-31 23:39:01 +00:00
Kaeno
0973c1cdad
Add missing quest item ID to forcedLootSingleSpawnById
2024-01-31 23:30:28 +00:00
Kaeno
23ceca5279
Blacklist Quest Items from Scav Case
2024-01-31 22:52:55 +00:00
Kaeno
0a16e06c89
Removed Duplicate key. Fixed some formatting
2024-01-31 21:24:05 +00:00
Kaeno
0d78bc22f0
Potential fix to bots freezing. Needs testing
2024-01-31 20:58:41 +00:00
Dev
c7ce7e57cb
Update items.json
2024-01-31 18:30:02 +00:00
Dev
dbea338a8f
Add missing FiR properties
2024-01-31 17:07:50 +00:00
Dev
d2e8af3341
Update JSONs
2024-01-31 17:01:46 +00:00
Dev
78e62229cc
Update trader assorts
...
10 missing trader quest assorts replaced with placeholders
2024-01-31 16:57:40 +00:00
Dev
8be7e5b2b7
Update quest data
2024-01-31 16:39:48 +00:00
Dev
95dd27038d
improve accuracy of daily quest system
...
Keep completed dailies inside "activeQuests" array until dailies are refreshed
Adjust post-raid quest handling to ensure previously completed/failed quests keep their original status
2024-01-31 14:38:18 +00:00