470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revamp structure of socket debug messages (!214)

Browse Source 
**Description**
This pull request changes the WebSocket connection `handle lost` log message in the `wsOnConnection` method of the `GameSocket` class. The original log message was:

```typescript
this.logger.debug(this.localisationService.getText("websocket-socket_lost_deleting_handle");
>>> [WS] Socket lost, deleting handle, status: %s
```

Which was inconsistent with most other languages. It can be understood from context that the socket was lost, therefor deleted and closed. Instead now;

```typescript
this.logger.debug(this.localisationService.getText("websocket-socket_lost_deleting_handle");
>>> [WS] Socket lost, deleting handle
```

This is achieved through editing the languages one by one and removing the "`status: %s`" component.

**Related**
- Closes: https://dev.sp-tarkov.com/SPT-AKI/Issues/issues/421

Co-authored-by: Deadly <info.saddiki@gmail.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/214
Co-authored-by: Deadly Alden <deadly@noreply.dev.sp-tarkov.com>
Co-committed-by: Deadly Alden <deadly@noreply.dev.sp-tarkov.com>
This commit is contained in:
Deadly Alden 2024-02-06 09:07:23 +00:00 committed by chomp
parent 807ba04967
commit 4fc012b422
10 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
project/assets/database/locales/server/cs.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Vyzvánění hráče: %s",
"websocket-player_connected": "[WS] Hráč: %s se připojil",
"websocket-received_message": "[WS] Obdržená zpráva od uživatele %s ",
"websocket-socket_lost_deleting_handle": "[WS] Socket ztracen, odstraňuji přezdívku, stav: %s",
"websocket-socket_lost_deleting_handle": "[WS] Socket ztracen, odstraňuji přezdívku",
"websocket-started": "Spuštěn websocket na %s",
"pmcresponse-victim_positive_1": "Dobrá trefa",
"pmcresponse-victim_positive_2": "Skvělá trefa",

2
project/assets/database/locales/server/de.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Spieler wird angepingt: %s",
"websocket-player_connected": "[WS] Spieler: %s hat eine Verbindung hergestellt",
"websocket-received_message": "[WS] Nachricht von Benutzer %s erhalten ",
"websocket-socket_lost_deleting_handle": "[WS] Socket verloren, Handle wird gelöscht. Status: %s",
"websocket-socket_lost_deleting_handle": "[WS] Socket verloren, Handle wird gelöscht",
"websocket-started": "Websocket auf %s gestartet",
"pmcresponse-victim_positive_1": "Gute Schuss",
"pmcresponse-victim_positive_2": "Toller Schuss",

2
project/assets/database/locales/server/el.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Έλεγχος διαθεσιμότητας παίκτη: %s",
"websocket-player_connected": "[WS] Παίκτης: Το %s έχει συνδεθεί",
"websocket-received_message": "[WS] Ελήφθη μήνυμα από τον χρήστη %s ",
"websocket-socket_lost_deleting_handle": "[WS] Η υποδοχή χάθηκε, διαγραφή της λαβής, κατάσταση: %s",
"websocket-socket_lost_deleting_handle": "[WS] Η υποδοχή χάθηκε, διαγραφή της λαβής",
"websocket-started": "Ξεκίνησε ο διακομιστής ιστού στο %s",
"pmcresponse-victim_positive_1": "Ωραία βολή",
"pmcresponse-victim_positive_2": "Εξαιρετική βολή",

2
project/assets/database/locales/server/en.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Pinging player: %s",
"websocket-player_connected": "[WS] Player: %s has connected",
"websocket-received_message": "[WS] Received message from user %s ",
"websocket-socket_lost_deleting_handle": "[WS] Socket lost, deleting handle, status: %s",
"websocket-socket_lost_deleting_handle": "[WS] Socket lost, deleting handle",
"websocket-started": "Started websocket at %s",
"pmcresponse-victim_positive_1": "Nice shot",
"pmcresponse-victim_positive_2": "Great shot",

2
project/assets/database/locales/server/id.json
View File

@ -229,7 +229,7 @@
"websocket-pinging_player": "[WS] notifikasikan player: %s",
"websocket-player_connected": "[WS] Player: %s tersambung",
"websocket-received_message": "[WS] Menerima pesan dari pengguna %s ",
"websocket-socket_lost_deleting_handle": "[WS] Soket hilang, menghapus pegangan, status: %s",
"websocket-socket_lost_deleting_handle": "[WS] Soket hilang, menghapus pegangan",
"websocket-started": "Websocket mulai di %s",
"pmc-name_prefix_42": "Palsu",
"pmc-name_prefix_47": "Besar",

2
project/assets/database/locales/server/it.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Pingando il giocatore: %s",
"websocket-player_connected": "[WS] Giocatore: %s si è connesso",
"websocket-received_message": "[WS] Ricevuto messaggio dall'utente %s ",
"websocket-socket_lost_deleting_handle": "[WS] Socket perso, cancellazione dell'handle, status: %s",
"websocket-socket_lost_deleting_handle": "[WS] Socket perso, cancellazione dell'handle",
"websocket-started": "Websocket partito all'indirizzo %s",
"pmcresponse-victim_positive_1": "Bel colpo",
"pmcresponse-victim_positive_2": "Gran colpo",

2
project/assets/database/locales/server/no.json
View File

@ -210,7 +210,7 @@
"websocket-pinging_player": "[WS] Pinger spiller: %s",
"websocket-player_connected": "[WS] Spiller: %s har koblet til",
"websocket-received_message": "[WS] Mottatt melding fra bruker %s ",
"websocket-socket_lost_deleting_handle": "[WS] Socket tapt, sletter handle, status: %s",
"websocket-socket_lost_deleting_handle": "[WS] Socket tapt, sletter handle",
"websocket-started": "Startet webserver på %s",
"pmcresponse-victim_positive_1": "Bra skudd",
"pmcresponse-victim_positive_2": "Bra skudd",

2
project/assets/database/locales/server/pt-br.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Pingando o jogador: %s",
"websocket-player_connected": "[WS] Jogador: %s se conectou",
"websocket-received_message": "[WS] Mensagem recebida do usuário %s",
"websocket-socket_lost_deleting_handle": "[WS] Soquete perdido, excluindo o identificador, status: %s",
"websocket-socket_lost_deleting_handle": "[WS] Soquete perdido, excluindo o identificador",
"websocket-started": "Iniciando o websocket em %s",
"pmcresponse-victim_positive_1": "Belo tiro",
"pmcresponse-victim_positive_2": "Excelente tiro",

2
project/assets/database/locales/server/pt-pt.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Pingando jogador: %s",
"websocket-player_connected": "[WS] Jogador: %s conectou-se",
"websocket-received_message": "[WS] Mensagem recebida do utilizador %s ",
"websocket-socket_lost_deleting_handle": "[WS] Socket perdido, excluindo handle, status: %s",
"websocket-socket_lost_deleting_handle": "[WS] Socket perdido, excluindo handle",
"websocket-started": "Websocket iniciado em %s",
"pmcresponse-victim_positive_1": "Belo tiro",
"pmcresponse-victim_positive_2": "Ótimo tiro",

2
project/assets/database/locales/server/tr.json
View File

@ -260,7 +260,7 @@
"websocket-pinging_player": "[WS] Oyuncuya ping atılıyor: %s",
"websocket-player_connected": "[WS] Oyuncu: %s bağlandı",
"websocket-received_message": "[WS] Kullanıcıdan mesaj alındı %s ",
"websocket-socket_lost_deleting_handle": "[WS] Soket kayboldu, tanıtıcı siliniyor, durum: %s",
"websocket-socket_lost_deleting_handle": "[WS] Soket kayboldu, tanıtıcı siliniyor",
"websocket-started": "Websocket %s'de başlatıldı",
"pmcresponse-victim_positive_1": "Güzel atış",
"pmcresponse-victim_positive_2": "Harika atış",