Commit Graph

137 Commits

Author SHA1 Message Date
Damian Mooyman
77bad9b943
Use getShouldLazyLoad() accesser 2018-09-18 09:12:44 +12:00
Damian Mooyman
ce8ba85182
Revert default argument change 2018-09-17 18:24:03 +12:00
Damian Mooyman
690f0cc793
BUG Fix for $source left null
BUG Fix missing imports
Semver compatible setSource()
2018-09-17 18:18:40 +12:00
Simon Gow
024e648e5a Added getSource() function to populate source inline with the api.
Source isn't populated to the parent because it's transformed directly
to an array. Instead we're lazy loading the source when it's requested.
2018-09-13 11:18:55 +12:00
Simon Gow
fa754f3fd3
TagField lazy load shouldnt render Options
TagField should only render options if the lazy load value isn't set. Options from here come from subsequent POSTs, and rendering the options for every request significantly slows down both the form generation and render.
2018-09-07 17:28:05 +12:00
Simon Gow
3797049a31
Resolve Performance issues with TagField
TagField hydrates the entire result set because a parent class calls `toArray()` on the $source. 
This fix changes the source to an empty array, so no such manipulation can be made.
2018-09-06 18:16:06 +12:00
Robbie Averill
705c7fb525 Remove obsolete branch alias 2018-06-11 11:49:15 +12:00
Robbie Averill
778282d1fd Merge branch '2.0' 2018-05-25 15:20:01 +12:00
Robbie Averill
058bc8c3d5 Remove obsolete branch alias 2018-05-25 15:19:40 +12:00
Robbie Averill
c836b7f914
Merge pull request #109 from jakxnz/master
Set "title field" at a meaningful point in TagField instantiation
2018-04-06 14:42:29 +12:00
Jackson
1e40d07a98 Set "title field" at a meaningful point in TagField instantiation
* Switch diet to dogfood
2018-04-06 14:18:14 +12:00
Jackson
7a286d432d Set "title field" at a meaningful point in TagField instantiation
* Added parameter to SilverStripe\TagFieldTagField::__construct()
* Modified SilverStripe\TagFieldTagField::getOptions() to use assigned title field
* Modified SilverStripe\TagFieldTagField::getValue() to use assigned title field
2018-04-06 13:47:49 +12:00
Nivanka Fonseka
7691fc27c6 Tag field to look similar to list field (#108)
* updated the CSS of the tag field to match with 

the dropdown fields / list fields

* resolve with of the field to the style attr of 

dropdown

* added style width

* removed the empty lines

* changed to the correct classname readonly tag field

* fixed the tag field signature

* removed the whitespace ending in line 352
2018-02-20 13:39:58 +00:00
Daniel Hensby
80d8cf6a04
Merge pull request #106 from SilverStripers/master
Fixed performReadonlyTransformation
2018-01-24 18:00:10 +00:00
priyashantha
a5dd9682a1 tiny updates for coding standards 2018-01-24 12:16:15 +05:30
priyashantha
94fba0d260 fixed php lint issues 2018-01-23 11:06:09 +05:30
Nivanka Fonseka
6d7d6ff9e2 readonly field namespaces are corrected and updated the unit tests with cases covering performReadonlyTrasnformation 2018-01-19 13:07:55 +05:30
Robbie Averill
f2186a5ce8 Merge pull request #100 from creative-commoners/pulls/2.0/ss4-updates
FIX Update module for latest SS4, vendorise
2017-10-18 14:38:58 +13:00
Robbie Averill
e2aea4e0eb FIX Update module for latest SS4, vendorise
* Update Scrutinizer configuration
* Update Travis and code coverage build badges, update example code
2017-10-18 14:19:15 +13:00
Loz Calver
09db27ade8 Merge pull request #97 from icecaster/master
declaring allowed actions as private as per RequestHandler
2017-08-07 15:59:04 +01:00
tim
7fcf5333ae declaring allowed actions as private as per RequestHandler, fixes SS4beta2 compat issues 2017-08-07 18:54:55 +12:00
Daniel Hensby
663264ac83 Merge pull request #95 from robbieaverill/pulls/2.0/ss4-compat-fixes
FIX SS4 compatibility updates, PSR-4 in tests, table_name in stubs
2017-06-26 16:38:28 +01:00
Robbie Averill
ee1d87ba50 FIX Include versioned in composer requirements 2017-06-22 17:36:24 +12:00
Robbie Averill
3b3db01efc FIX Remove PHP 5.5 from Travis build configuration, add 7.1 2017-06-22 17:21:24 +12:00
Robbie Averill
cde9dc917a FIX SS4 compatibility updates, PSR-4 in tests, table_name in stubs 2017-06-22 17:15:17 +12:00
Daniel Hensby
f741c0d2b0 Merge pull request #92 from oilee80/master
Remove `Requirements::javascript()` for Framework src JS
2017-03-10 09:49:03 +00:00
Lee Bradley
ad28757338 Remove Requirements::javascript() for Framework src JS
As jQuery is bundled in the frameworks vendor.js having
  these calls causes a duplicate of the jQuery library

This also means plugins link with the wrong library etc.
  Noticed with `jQuery.dialog()` from a Page edit screen
  going to an associated DataObject edit screen
2017-02-24 11:08:52 +00:00
Daniel Hensby
57bf2c15ce Merge pull request #91 from open-sausages/pulls/4.0/compat
BUG Fix issue with initial save
2017-01-26 09:07:54 +00:00
Damian Mooyman
2129f9f997
BUG Fix issue with initial save 2017-01-26 18:10:14 +13:00
Robbie Averill
518189e2ef SilverStripe 4 compatibility (#87)
* Update composer constraint and branch alias to support SS4 testing

* Add namespaces, update DataList quirk with getSourceList

* Add PSR-4 autoloader definition

* Move template to correct namespace location, update requirement paths

* FIX Visibility on allowed actions

* FIX Update chosen class names to match updates in framework

* Update Travis configuration for 4.x builds. Update docs for namespaced classes.

* Use "4" for the release instead of master.

* FIX Selected tag height. Move Readonly to own class.
2017-01-13 19:11:59 +00:00
Daniel Hensby
4ce0560d6e
Updating composer alias 2016-12-20 15:26:40 +00:00
Damian Mooyman
5f3f458398 BUG Resolve issue with numeric tags being saved
Removed is_numeric check in SaveInto function
2016-11-24 13:26:46 +13:00
Myles Derham
a75eab8801 Update TagFieldTest.php 2016-11-24 12:18:35 +13:00
Daniel Hensby
00c950eecf Merge pull request #83 from sanderha/fix-missing-can-create-methods-stringtagfield
added missing cancreate methods and property to StringTagField.
2016-08-22 10:56:00 +01:00
Sander Hagenaars
f6a56982c0 added missing cancreate methods and property to StringTagField. 2016-08-21 12:34:19 +02:00
Christopher Pitt
35773d4a56 Merge pull request #81 from robbieaverill/feature/apply-can-create-to-select2
Apply canCreate permissions to Select2 for tags
2016-08-08 14:31:09 +12:00
Robbie Averill
e3c42727e4 Apply canCreate permissions to Select2 for tags
* Resolves #80
2016-07-22 08:52:17 +12:00
Damian Mooyman
d3563cebbc Update changelog for 1.3.0 2016-05-19 11:53:13 +12:00
Damian Mooyman
d80d0a83c2 Merge pull request #75 from praxisnetau/readonly-modifications
API Addition of a readonly TagField for archived pages
2016-02-26 14:47:15 +13:00
Colin Tucker
d8b8c875bb Formatting fix 2016-02-25 13:18:56 +11:00
Colin Tucker
d3e636e647 Filters selected options and renders as readonly 2016-02-25 13:06:21 +11:00
Colin Tucker
47392c5dde Initial readonly field modifications 2016-02-25 12:32:29 +11:00
Myles Beardsmore
59078749bb Updated tests to work with new logic (numeric tags). 2016-02-11 08:44:20 +13:00
Damian Mooyman
ddb56be86f Alias master as 1.2.x-dev 2016-02-04 17:43:50 +13:00
Damian Mooyman
df34386bb1 Add changelog for 1.2.2 release 2016-02-04 17:42:28 +13:00
Myles Beardsmore
65f6d7531b converted tabs to spaces as per psr-2 2016-02-04 16:07:15 +13:00
Myles Beardsmore
76c10d8df2 Updated TagField to work with numeric tags 2016-02-04 12:08:34 +13:00
Myles Beardsmore
d7ca8caa83 Removed is_numeric check in SaveInto function 2016-01-27 15:49:36 +13:00
Daniel Hensby
f0b48d12c4 Merge pull request #68 from micschk/patch-1
Bugfix: show source tags if not lazyloading
2016-01-06 01:25:27 +03:00
Ingo Schommer
dbdbdd7cc2 Merge pull request #70 from dhensby/pulls/fix-hard-coded-tests
FIX Tests with hard coded IDs
2016-01-06 11:19:35 +13:00