tonyair
/
silverstripe-tagfield
mirror of https://github.com/silverstripe/silverstripe-tagfield
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove `Requirements::javascript()` for Framework src JS 

As jQuery is bundled in the frameworks vendor.js having
  these calls causes a duplicate of the jQuery library

This also means plugins link with the wrong library etc.
  Noticed with `jQuery.dialog()` from a Page edit screen
  going to an associated DataObject edit screen
This commit is contained in:
Lee Bradley 2017-02-24 11:08:52 +00:00
parent 57bf2c15ce
commit ad28757338
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/StringTagField.php
View File

@ -153,8 +153,6 @@ class StringTagField extends DropdownField
Requirements::css(TAG_FIELD_DIR . '/css/select2.min.css');
Requirements::css(TAG_FIELD_DIR . '/css/TagField.css');
Requirements::javascript(ADMIN_THIRDPARTY_DIR . '/jquery/jquery.js');
Requirements::javascript(ADMIN_THIRDPARTY_DIR . '/jquery-entwine/dist/jquery.entwine-dist.js');
Requirements::javascript(TAG_FIELD_DIR . '/js/select2.js');
Requirements::javascript(TAG_FIELD_DIR . '/js/TagField.js');

2
src/TagField.php
View File

@ -201,8 +201,6 @@ class TagField extends DropdownField
Requirements::css(TAG_FIELD_DIR . '/css/select2.min.css');
Requirements::css(TAG_FIELD_DIR . '/css/TagField.css');
Requirements::javascript(ADMIN_THIRDPARTY_DIR . '/jquery/jquery.js');
Requirements::javascript(ADMIN_THIRDPARTY_DIR . '/jquery-entwine/dist/jquery.entwine-dist.js');
Requirements::javascript(TAG_FIELD_DIR . '/js/select2.js');
Requirements::javascript(TAG_FIELD_DIR . '/js/TagField.js');