tonyair
/
silverstripe-tagfield
mirror of https://github.com/silverstripe/silverstripe-tagfield
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

readonly field namespaces are corrected and updated the unit tests with cases covering performReadonlyTrasnformation

This commit is contained in:
Nivanka Fonseka 2018-01-19 13:07:55 +05:30
parent f2186a5ce8
commit 6d7d6ff9e2
4 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/TagField/Readonly.php → src/ReadonlyTagField.php
View File

@ -1,9 +1,8 @@
<?php
namespace SilverStripe\TagField\TagField;
namespace SilverStripe\TagField;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\TagField\TagField;
/**
* A readonly extension of TagField useful for non-editable items within the CMS.
@ -11,7 +10,7 @@ use SilverStripe\TagField\TagField;
* @package forms
* @subpackage fields
*/
class Readonly extends TagField
class ReadonlyTagField extends TagField
{
/**
* {@inheritDoc}

1
src/StringTagField.php
View File

@ -368,4 +368,5 @@ class StringTagField extends DropdownField
return $this;
}
}

5
src/TagField.php
View File

@ -7,7 +7,6 @@ use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\DataObject;
@ -67,7 +66,7 @@ class TagField extends DropdownField
* @param null|DataList $source
* @param null|DataList $value
*/
public function __construct($name, $title = '', $source = null, $value = null)
public function __construct($name, $title = '', $source = array(), $value = null)
{
$this->setSourceList($source);
parent::__construct($name, $title, $source, $value);
@ -447,7 +446,7 @@ class TagField extends DropdownField
*/
public function performReadonlyTransformation()
{
$copy = $this->castedCopy(TagFieldReadonly::class);
$copy = $this->castedCopy(ReadonlyTagField::class);
$copy->setSourceList($this->getSourceList());
return $copy;
}

15
tests/TagFieldTest.php
View File

@ -7,12 +7,15 @@ use SilverStripe\Dev\SapphireTest;
use SilverStripe\Dev\TestOnly;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\Form;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\DataObject;
use SilverStripe\TagField\ReadonlyTagField;
use SilverStripe\TagField\TagField;
use SilverStripe\TagField\Tests\Stub\TagFieldTestBlogPost;
use SilverStripe\TagField\Tests\Stub\TagFieldTestBlogTag;
use SilverStripe\TagField\Tests\Stub\TagFieldTestController;
use SilverStripe\View\ArrayData;
/**
* @mixin PHPUnit_Framework_TestCase
@ -342,4 +345,16 @@ class TagFieldTest extends SapphireTest
$record->Tags()->first()->ID
);
}
/**
* Test read only fields are returned
*/
public function testReadonlyTransformation()
{
$field = new TagField('Tags', '', TagFieldTestBlogTag::get());
$readOnlyField = $field->performReadonlyTransformation();
$this->assertEquals(ReadonlyTagField::class, get_class($readOnlyField));
}
}