silverstripe-reports/code
Stig Lindqvist 45046f08e8 Bug: CMS tree filters doesn't count the correct number of children for deleted pages
This is a bug that combines Hierarchy, Versioned and LeftAndMain admins and CMSSiteTreeFilters.

This bug can be reproduced by having a large site tree with enough deleted pages in it so it doesn't
pre load all the children pages when initially opening an admin. Filter by either 'All pages including deleted'
or 'Deleted pages'. For CMS users it will look like deleted pages are gone.

The solution involves a couple of smaller fixes in both CMS and framework modules.

1) Ensure that 'numHistoricalChildren' are used instead of 'numChildren' when dealing with deleted pages
2) LeftAndMain::currentPage() deletes all the 'marking' cache previously built up by Hierarchy::markPartialTree()
3) Use Versioned::get_included_deleted() instead of raw DB queries against the DataObject tables when calculating parents in CMSSiteTreeFilter
2014-07-25 16:18:54 +12:00
..
batchactions Method visibility according to coding conventions 2012-09-20 10:41:50 +02:00
controllers Bug: CMS tree filters doesn't count the correct number of children for deleted pages 2014-07-25 16:18:54 +12:00
forms Numerous PHPDoc fixes. 2014-02-10 15:35:13 -05:00
model Bug: CMS tree filters doesn't count the correct number of children for deleted pages 2014-07-25 16:18:54 +12:00
reports FIX: Reports with Parameter fields override ReportTitle and ReportDescription 2014-03-16 19:09:47 +13:00
search FIX: Rename search locale variable to avoid conflicts with locale switcher. 2013-05-11 19:31:02 +12:00