mirror of
https://github.com/silverstripe/silverstripe-reports
synced 2024-10-22 11:05:53 +02:00
45046f08e8
This is a bug that combines Hierarchy, Versioned and LeftAndMain admins and CMSSiteTreeFilters. This bug can be reproduced by having a large site tree with enough deleted pages in it so it doesn't pre load all the children pages when initially opening an admin. Filter by either 'All pages including deleted' or 'Deleted pages'. For CMS users it will look like deleted pages are gone. The solution involves a couple of smaller fixes in both CMS and framework modules. 1) Ensure that 'numHistoricalChildren' are used instead of 'numChildren' when dealing with deleted pages 2) LeftAndMain::currentPage() deletes all the 'marking' cache previously built up by Hierarchy::markPartialTree() 3) Use Versioned::get_included_deleted() instead of raw DB queries against the DataObject tables when calculating parents in CMSSiteTreeFilter |
||
|---|---|---|
| .. | ||
| AssetAdmin.php | ||
| CMSFileAddController.php | ||
| CMSMain.php | ||
| CMSPageAddController.php | ||
| CMSPageEditController.php | ||
| CMSPageHistoryController.php | ||
| CMSPagesController.php | ||
| CMSPageSettingsController.php | ||
| CMSSettingsController.php | ||
| CMSSiteTreeFilter.php | ||
| ContentController.php | ||
| ErrorPageControllerExtension.php | ||
| LeftAndMainPageIconsExtension.php | ||
| ModelAsController.php | ||
| NestedController.php | ||
| OldPageRedirector.php | ||
| ReportAdmin.php | ||
| RootURLController.php | ||
| SilverStripeNavigator.php | ||