tonyair
/
silverstripe-reports
mirror of https://github.com/silverstripe/silverstripe-reports
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

FIX: Reports with Parameter fields override ReportTitle and ReportDescription 

Fixes #696
This commit is contained in:
Simon Welsh 2014-03-16 19:09:47 +13:00
parent 79da34ff6e
commit 5024a48f89
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
code/reports/Report.php
View File

@ -219,8 +219,8 @@ class SS_Report extends ViewableData {
}
// Add search fields is available
if($this->hasMethod('parameterFields') && $fields = $this->parameterFields()) {
foreach($fields as $field) {
if($this->hasMethod('parameterFields') && $parameterFields = $this->parameterFields()) {
foreach($parameterFields as $field) {
// Namespace fields for easier handling in form submissions
$field->setName(sprintf('filters[%s]', $field->getName()));
$field->addExtraClass('no-change-track'); // ignore in changetracker