Commit Graph

375 Commits

Author SHA1 Message Date
Robbie Averill
192ddbb4b5 API Use concrete Handler implementations for Spam and Approve bulk editing 2018-02-26 23:24:34 +13:00
Daniel Hensby
b90ec7715e
Merge pull request #228 from benwrighton/master 2018-02-02 10:45:48 +00:00
Unknown
ae59e82021 Improve A11y of comment reply.
Currently this is a link. Users will expect this link to take them to another part of the page or another page altogether. 

There is no indication that it opens or closes an associated form on the same page, nor does it indicate the current state of the “reply to” form.

So, instead of a link, use a button. Add to that button an aria-controls attribute that references the id of the associated form’s container, and an aria-expanded attribute that indicates (true or false) the state of the associated form.
2018-02-01 16:27:30 +13:00
Robbie Averill
17714f221a
Merge pull request #227 from creative-commoners/pulls/3.0/tx-me-js
FIX: update javascript requirements so user JS doesn't error
2018-01-29 16:06:27 +13:00
Dylan Wagstaff
a25668eba0 Remove SS 2.x upgrade code that runs every build 2018-01-29 15:26:16 +13:00
Dylan Wagstaff
7b38707fde FIX: update javascript requirements so user JS doesn't error 2018-01-29 13:04:34 +13:00
Robbie Averill
4bf0a83ad3 FIX Update CommentAdmin test to create a mock session and not assert missing translation 2017-12-19 09:32:56 +13:00
Robbie Averill
b02928e02a Merge branch '2' 2017-12-19 09:14:47 +13:00
Robbie Averill
4136bd7a63 Update branch alias for 2.x-dev 2017-12-18 18:18:32 +13:00
Robbie Averill
b68ff56624 Merge branch '2.0' into 2.1 2017-12-18 18:17:06 +13:00
Robbie Averill
4e2965e86b Remove PHP 5.3 from Travis builds 2017-12-18 18:16:58 +13:00
Robbie Averill
85c9981962 Remove Transifex configuration. Commit directly to lang files for SS3. 2017-12-18 18:14:53 +13:00
Robbie Averill
82c4a1b9be
DOCS Update readme badges and add version support note 2017-12-18 14:11:51 +13:00
Dylan Wagstaff
3501ef7490
Merge pull request #224 from creative-commoners/pulls/3.0/fix-comments-admin
FIX Duplicated tabset, invalid Pjax request, update translations and Spam/Approve buttons
2017-12-15 10:09:32 +13:00
Robbie Averill
75d7de9aa6 FIX Add extra DataObject stub to CommentsGridFieldActionTest and update expectations 2017-12-14 17:57:03 +13:00
Robbie Averill
216ad8eb54 FIX Duplicated tabset, invalid Pjax request, update translations and Spam/Approve buttons 2017-12-14 16:08:43 +13:00
Daniel Hensby
118de6b595
Merge pull request #222 from creative-commoners/pulls/2.0/vendorise
NEW Convert to vendor module, add table_name to test stubs and add PHP 7.2 to travis
2017-12-13 12:07:34 +00:00
Robbie Averill
3f6f651eea FIX Replace French translation in CommentAdminTest now that it's available 2017-12-12 17:12:10 +13:00
Robbie Averill
c6f8973342 NEW Convert to vendor module, add table_name to test stubs and add PHP 7.2 to travis 2017-12-12 17:03:04 +13:00
Dylan Wagstaff
8919f6da2a Merge pull request #220 from sheadawson/patch-1
FIX SS4: use SilverStripe\CMS\Model\SiteTree in Comment.php
2017-10-26 14:16:05 +13:00
Shea Dawson
b1e9722320 use SilverStripe\CMS\Model\SiteTree; 2017-10-26 13:54:49 +13:00
Will Rossiter
8c43e097cd Merge pull request #216 from fullscreeninteractive/pulls/travis-fix
Travis, 4.0 API fixes
2017-10-10 09:49:13 +13:00
Robbie Averill
7700d88d4a FIX Remove base path assertions from tests which behave differently using phpdbg 2017-10-10 09:26:17 +13:00
Robbie Averill
fa61608c7d FIX Merge config in tests, add phpcs and add HTML purifier to Travis builds 2017-10-09 17:26:07 +13:00
Will Rossiter
f294ab26d6 Update tests and lang’s for 4.0 2017-09-18 14:16:24 +12:00
Will Rossiter
9366ef603e Split comment form out to its’ own class 2017-09-16 09:06:03 +12:00
Will Rossiter
d9333b3160 Test fixes 2017-09-14 11:12:07 +12:00
Will Rossiter
7fff17b317 Correct extra dataobjects array name 2017-09-14 10:28:29 +12:00
Will Rossiter
73a981456f Use trusty 2017-09-14 10:09:21 +12:00
Will Rossiter
2fc7e7a004 Add phpunit, lint fixes and removed compass for webpack 2017-09-14 10:01:09 +12:00
Will Rossiter
0c964d1ed8 Composer lint 2017-09-14 09:41:11 +12:00
Will Rossiter
82c139e30a Travis fix 2017-09-13 09:12:09 +12:00
Will Rossiter
18761879cf Remove old email 2017-09-13 08:52:41 +12:00
Will Rossiter
4e2d22e16d Merge pull request #214 from fullscreeninteractive/wilr-patch-1
If user cannot view record then prevent comment
2017-09-13 08:36:18 +12:00
Franco Springveldt
8e79a1368e Update translations 2017-08-28 16:35:55 +12:00
Will Rossiter
85e8384151 If user cannot view record then prevent comment 2017-07-28 17:12:01 +12:00
Daniel Hensby
fb3cc1b861 Add .codecov.yml file 2017-07-19 16:04:34 +01:00
Robbie Averill
4df49c8db7 Merge pull request #201 from rasstislav/patch-1
Added missing translation to Comments TabSet Title
2017-07-06 10:31:38 +12:00
Daniel Hensby
06439dde1f Merge pull request #209 from andrewandante/FIX/update_session
update thirdpartydir and session non-statics
2017-07-05 11:50:02 +01:00
Daniel Hensby
d74bc59b98 Merge pull request #210 from dhensby/pulls/remove-travis-5.5
Remove PHP 5.5 build from travis
2017-07-05 11:49:34 +01:00
Daniel Hensby
f276983611
Remove PHP 5.5 build from travis 2017-07-05 11:02:59 +01:00
Andrew Aitken-Fincham
e7c358f730 update thirdpartydir and session non-statics 2017-07-04 15:53:38 +01:00
Daniel Hensby
8383ff1f81 Stop codecov comments 2017-06-18 01:04:58 +01:00
Daniel Hensby
bd5b007394 Merge pull request #206 from creative-commoners/pulls/2.1/remove-broken-i18n-tests
FIX Remove providePermissions tests and update Travis build configuration
2017-06-15 19:24:00 +01:00
Robbie Averill
8ede35e6bd Update Travis build matrix to include PHP 7.1, SS 3.5, 3.6 and 3.x-dev explicitly 2017-06-13 11:13:48 +12:00
Robbie Averill
c02d851500 FIX Remove providePermissions tests
Removed the testProvidePermissions case since it is testing localisations that do not exist, and a localisation that belongs to the framework which should not be tested here.
2017-06-13 11:09:56 +12:00
Rastislav Brandobur
9912285761 added CommentsExtension.COMMENTSTABSET definition to lang subfolder 2017-06-12 23:59:13 +02:00
Robbie Averill
f27b357b06 Update translations 2017-05-12 15:06:51 +12:00
Rastislav Brandobur
79e16d5661 Added missing translation to Comments TabSet Title 2017-04-14 17:09:33 +02:00
Paul
2d076e4267 Merge pull request #200 from robbieaverill/bugfix/improve-delete-message
FIX Improve delete reply confirmation message
2017-03-16 09:14:14 +13:00