Commit Graph

290 Commits

Author SHA1 Message Date
Daniel Hensby
b7eb89cd17 Adding .editorconfig 2014-12-04 17:02:13 +00:00
Sean Harvey
05faf24483 Merge pull request #17 from halkyon/int_fix2
Fixing use of "bigint" and "decimal" for pure integer types.
2014-07-15 09:25:39 +12:00
Sean Harvey
093df443ea Fixing use of "bigint" and "decimal" for pure integer types.
See https://github.com/silverstripe/silverstripe-mssql/issues/14
for more info.

"bigint" doesn't work for PHP 32-bit, as the integer could get too big
for PHP to be able to interpret the value as an integer type. In that
case it would try to approximate it as a float, but that could lead
to a bad assumption for identity columns.

For compatibility, stick with standard "int" type which has a maximum
value of 2147483647.

Note that MySQLAdapter already has this maximum, so changing it to
this keeps this database adapter consistent with MySQL.
2014-07-11 13:46:44 +12:00
Sean Harvey
a6a9b25901 Removing reference to postgres, it doesn't belong in the mssql module. 2014-07-11 13:41:45 +12:00
Simon Welsh
73976c111a Merge pull request #7 from tractorcow/3.2-pdo-connector
API Upgraded module to use new database ORM
2014-07-11 09:31:06 +10:00
Simon Welsh
d50ba80512 Merge pull request #15 from tractorcow/pulls/alias-master
Alias master as 1.0
2014-07-11 09:21:54 +10:00
Damian Mooyman
0bf7212b6e Alias master as 1.0 2014-07-11 09:49:04 +12:00
Damian Mooyman
758fe810a5 API Upgraded module to use new database ORM 2014-07-11 09:46:32 +12:00
Simon Welsh
a9b1e03202 Minimum version is now 3.2 2014-07-09 19:39:10 +10:00
Sean Harvey
752664613e Merge pull request #13 from nikrolls/bug_indexes-not-fully-escaped
BUG: Indexes were not being fully escaped
2014-01-20 13:39:45 -08:00
Nik Rolls
e884a1cc31 BUG: Indexes were not being fully escaped (the parent table name was, but if the relational table is also namespaced then it would trigger an error). 2014-01-18 21:30:27 +13:00
Sean Harvey
e3db6f916d Updating README with more up to date instructions and requirements. 2013-09-13 16:33:34 +12:00
Sean Harvey
fc58ae6571 Removing redundant information from README 2013-09-13 16:16:30 +12:00
Sean Harvey
988d36d0d3 Upping requirements to 3.0+ in latest version of the module. 2013-09-13 16:10:35 +12:00
Sean Harvey
91a2a6ceb4 Merge branch '3.0-index-fixes' of git://github.com/tractorcow/silverstripe-mssql into tractorcow-3.0-index-fixes 2013-09-13 15:15:10 +12:00
Sean Harvey
696c889fc1 Merge pull request #6 from ss23/patch-1
Update MSSQLDatabaseConfigurationHelper.php
2013-06-20 20:04:47 -07:00
Sean Harvey
01d376f501 BUG Fixing problem where duplicate items appear on pages
Reverts 13cdb07539 and instead calls
setLimitItems(false) on PaginatedList to tell it we've already
limited the number of items to be shown.
2013-05-27 15:21:24 +12:00
Sean Harvey
1560bad60c Free the result when at the end of a set using mssql drivers 2013-05-22 22:38:05 +12:00
Sean Harvey
7119d5ac80 Merge pull request #11 from mattgunn/patch-1
Removing paging subset occuring before pagination is set
2013-05-16 17:07:27 -07:00
Matt Gunn
13cdb07539 Removing paging subset occuring before pagination is set 2013-05-17 11:45:15 +12:00
Sean Harvey
9ae0cecc36 Revert fc3df54eab 2013-04-25 11:33:54 +12:00
Sean Harvey
55c56b9b66 default float spec to 53 so dev/build doesn't continually show as changed
otherwise it continually shows as changed from "float(53) not null..." to
"float not null"
2013-04-25 11:28:05 +12:00
Sean Harvey
fc3df54eab Removing dropping of indexes, has problems with running dev/build twice 2013-04-05 17:23:13 +13:00
Stephen Shkardoon
e500b024e3 Update MSSQLDatabaseConfigurationHelper.php
In preparation for https://github.com/silverstripe/sapphire/pull/1319
Probably should accept this at the same time.

If someone knows of the relevant ALTER permissions in MSSQL, feel free to implement.
2013-03-24 03:05:04 +13:00
Sean Harvey
bd18c0a1f3 removing double up of quotes in getIndexSqlDefinition() 2013-01-07 17:40:30 +13:00
Sean Harvey
d6a075f9c7 Fixing MSSQLDatabase to conform to dev/build change detection
This involves changing a few things around so that it's closer to
how the MySQLDatabase adapter works. indexList() should return an
array in the same format instead of using arbitrary "indexname"
and "spec". indexNames() has also been introduced to MSSQLDatabase
so that we can drop all indexes (except for fulltext and primary key
indexes) on a table when altering the table columns, this helps when
constraints not directly related to a modified column refuse to allow changes.
2013-01-07 16:25:31 +13:00
Sean Harvey
91548f76be Checking for underscore in SortColumn just to be sure 2012-12-20 16:04:44 +13:00
Sean Harvey
7c369a383a BUG Fix SortColumn ORDER BY not working when using a limit
MSSQL doesn't support putting an alias into the OVER clause,
something which is required when limiting results with an offset.
The workaround is to just put the aggregate inline, taken from
the select list.
2012-12-20 15:57:50 +13:00
Sean Harvey
baf3d39cc0 Adding location of known issues to README.md 2012-12-19 20:56:41 +13:00
Sean Harvey
e527665c5c Show the last error a bit more clearly if available 2012-12-19 11:39:51 +13:00
Sean Harvey
f64c662124 Tidying up error reporting in databaseError() and adding getLastError()
Whenever databaseError() is called when a database problem occurred
then the last error is automatically appended to the end of the
general error message.
2012-12-19 11:27:49 +13:00
Sean Harvey
f34996ae1c BUG Remove "empty" keywords when building search SQL 2012-12-19 11:19:48 +13:00
Ingo Schommer
d17ae37411 BUG Support for case sensitive searches
Through newly added Database->comparisonClause() API
2012-12-11 01:47:35 +01:00
Sean Harvey
334c2634ac Removed deprecated transaction methods on MSSQLDatabase 2012-11-16 14:25:13 +13:00
Sam Minnee
37b4005052 Added composer file 2012-11-03 14:14:17 +13:00
Damian Mooyman
93eab9c132 FIXED: Repaired failing test cases (DataObjectSchemaGenerationTest)
FIXED: Incorrect implementation of alterIndex
UPDATED: Improved parsing of index specification by including code borrowed from the postgres database connector module. Possibly a candidate for refactor into SS_Database.
2012-09-24 15:36:59 +12:00
Sean Harvey
4de7829e4c Use more robust Format() in test instead of strtotime() 2012-09-07 16:23:59 +12:00
Sean Harvey
08eea5cde3 Ensure date test is Y-m-d 2012-09-07 16:21:13 +12:00
Sean Harvey
a74470ff52 Merge pull request #3 from silverstripe-rebelalliance/7813
BUG: open ticket 7813 fixing dobule quoting issue in getIndexSqlDefiniti...
2012-08-28 16:28:20 -07:00
Kirk Mayo
357482d6c9 BUG: open ticket 7813 fixing dobule quoting issue in getIndexSqlDefinition 2012-08-27 15:05:37 +12:00
Ingo Schommer
530c97f671 Added supportsTimezoneOverride() method 2012-07-06 11:36:07 +02:00
Ingo Schommer
e752144a6e Added Macports locations to README 2012-07-02 10:24:25 +03:00
Sam Minnee
05e706ea18 BUG: Fixed MSSQL index name generation for tables with \ in the name.
Right now the name of a table with a namespace will contain a '\' character.  The internal index name generated clashes with this, so we've dealt with it by turning the '\' into a '_'
2012-06-26 14:52:18 +12:00
Sam Minnee
22d53b036b BUG: Fixed index generation to meet new SS3 expectations.
In SS3, the column lists passed through for index specifications are now quoted.  The database adaptor needed to be updated to meet this change.
2012-06-26 14:35:59 +12:00
Sean Harvey
0465f1b1a2 MINOR Performance optimisation in MSSQLDatabase::nextRecord() by
building field meta-data only on construct of MSSQLQuery
2012-06-12 13:31:29 +12:00
Sean Harvey
a4c269bf62 BUGFIX Fixing date/datetime handling in MSSQLDatabase
Fixing the date type to actually be "date", and not "datetime" so
that values are returned as "Y-m-d" for dates, and not "Y-m-d H:i:s".

Additionally, fixing a case where using the mssql functions would
return strange datetime formats. We need the datetime field values
in Y-m-d H:i:s. To get this working, we need to inspect the field type
when retrieving rows from the database and re-format the datetime
value at this point. This is done in MSSQLQuery::nextRecord()
2012-06-12 12:57:53 +12:00
Sean Harvey
49625242c1 MINOR Updating README to include error message 2012-06-12 10:05:40 +12:00
Sean Harvey
84ec3a2014 BUGFIX Fixed undefined notice regression 2012-05-08 17:41:01 +12:00
Sean Harvey
f1daa29592 BUGFIX Fixing MSSQLDatabase to work with latest SQLQuery changes in SS3 2012-05-07 16:40:47 +12:00
Sean Harvey
05d24b0843 BUGFIX Ensure DateTime objects are handled correctly 2012-05-04 21:58:48 +12:00