tonyair/silverstripe-mssql
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-mssql synced 2024-10-02 06:08:43 +02:00
Code Issues Projects Releases Wiki Activity

BUG Fixing problem where duplicate items appear on pages

Browse Source 
Reverts 13cdb07539 and instead calls
setLimitItems(false) on PaginatedList to tell it we've already
limited the number of items to be shown.
This commit is contained in:
Sean Harvey 2013-05-27 15:21:24 +12:00
parent 1560bad60c
commit 01d376f501
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
code/MSSQLDatabase.php
View File

@ -1418,7 +1418,11 @@ class MSSQLDatabase extends SS_Database {
$objects = array();
foreach ($result as $row) {
$current++;
$objects[] = DataObject::get_by_id($row['Source'], $row['ID']);
// Select a subset for paging
if ($current >= $start && $current < $start + $pageLength) {
$objects[] = DataObject::get_by_id($row['Source'], $row['ID']);
}
}
if(isset($objects)) $results = new ArrayList($objects);
@ -1427,6 +1431,10 @@ class MSSQLDatabase extends SS_Database {
$list->setPageStart($start);
$list->setPageLength($pageLength);
$list->setTotalItems($current+1);
// The list has already been limited by the query above
$list->setLimitItems(false);
return $list;
}