Commit Graph

23358 Commits

Author SHA1 Message Date
Bernie Hamlin e5eb98cc34 Use field editorconfig when sanitising content 2023-10-25 12:08:46 +13:00
Sabina Talipova 071d8b7b09
Merge pull request #10959 from creative-commoners/pulls/4.13/add-fixed-fields
FIX Ensure all fixed fields are added
2023-09-26 12:00:59 +13:00
Guy Sartorelli 7bb72eb7c5
FIX Ensure all fixed fields are added 2023-09-25 15:35:34 +13:00
Guy Sartorelli 58696e3ed5
FIX Set tableName on DBField before calling addToQuery (#10946) 2023-09-14 11:01:36 +12:00
Guy Sartorelli 95944448a3
Merge pull request #10942 from tjbwsk/4.13
added missing returns (fluent setter)
2023-09-13 09:57:32 +12:00
Rastislav Brandobur 17733aa84a added missing returns (fluent setter) 2023-09-11 10:58:11 +02:00
Guy Sartorelli 7ea25bf9e1
FIX Call addToQuery on all DBFields (#10936) 2023-09-05 15:06:53 +12:00
Sabina Talipova c5be3fc487
Merge pull request #10931 from tjbwsk/4.13
added missing maxLength validation
2023-08-31 08:45:10 +12:00
Rastislav Brandobur 7ae7e9ff47 added maxLength validation tests 2023-08-30 10:56:21 +02:00
Loz Calver 2c577aa17f
Merge pull request #10921 from forsdahl/php8.2-compatibility
PHP 8.2 compatibility fixes
2023-08-29 09:16:00 +01:00
Rastislav Brandobur d6c39e7d36 added missing maxLength validation 2023-08-28 10:51:43 +02:00
Niklas Forsdahl 88c70b3234 Fixed deprecation notices in php 8.2 by using the AllowDynamicProperties
annotation on classes that set dynamic properties
2023-08-25 11:07:48 +03:00
Guy Sartorelli 2e92b89b54
Merge pull request #10923 from kinglozzer/10821-mmtl-changetracking
FIX: Stop ManyManyThroughList join records incorrectly showing as changed (fixes #10821)
2023-08-24 09:05:38 +12:00
Loz Calver 1fd495449b FIX: Stop ManyManyThroughList join records incorrectly showing as changed (fixes #10821) 2023-08-23 16:43:56 +01:00
Guy Sartorelli 5ee77b69f1
Merge pull request #10924 from kinglozzer/10689-typo-in-test-class-name
FIX: Typo in CheckboxSetFieldMultiEnumTest class name (closes #10689)
2023-08-23 11:11:14 +12:00
Loz Calver 57cb55d6ae FIX: Typo in CheckboxSetFieldMultiEnumTest class name (closes #10689) 2023-08-21 15:49:09 +01:00
Guy Sartorelli 3e72f5e694
ENH Update translations (#10920) 2023-08-21 12:32:21 +12:00
Guy Sartorelli c7cd26299a
Fix ArrayList canFilterBy to work with ArrayData (#10915) 2023-08-15 11:31:20 +12:00
Guy Sartorelli cdbc50cb7e
Merge pull request #10913 from lekoala/dbcomposite
DBComposite::writeToManipulation() is never called
2023-08-15 10:52:05 +12:00
Thomas Portelange 637859a1f4
Update tests/php/ORM/DBCompositeTest.php
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
2023-08-14 09:26:33 +02:00
Thomas Portelange 0d4231abb8
comment test for ss4 2023-08-11 13:24:01 +02:00
Thomas d621d00eea
DBComposite::writeToManipulation() is never called 2023-08-11 09:56:37 +12:00
Sabina Talipova 597d97bf0a
Merge pull request #10907 from creative-commoners/pulls/4.13/new-fields-validator
NEW Add FieldsValidator to ensure fields get validated
2023-08-10 10:50:57 +12:00
Guy Sartorelli 4f6ab330f5
Merge pull request #10903 from creative-commoners/pulls/4.13/fix-multi-html-entities-in-shortcode
FIX Multi HTML entities in short codes
2023-08-08 13:20:17 +12:00
Sabina Talipova 037168a4fe FIX Multi HTML entities in shortcodes 2023-08-08 13:08:19 +12:00
Guy Sartorelli 5a52484d88
NEW Add FieldsValidator to ensure fields get validated 2023-08-08 13:02:27 +12:00
Guy Sartorelli 2a56cc3ea4
MNT Run ORM tests in parallel to other tests (#10901) 2023-08-07 11:57:23 +12:00
Guy Sartorelli 9e5411e905
Merge pull request #10885 from creative-commoners/pulls/4.13/search-in-non-existing-fields
FIX Image in summaryfields breaks search
2023-08-03 15:11:49 +12:00
Sabina Talipova d24095aba8 FIX Image in summaryfields breaks search 2023-08-03 14:48:55 +12:00
Guy Sartorelli b90d606427
Merge pull request #10834 from lekoala/patch-36
SessionAuthenticationHandler doesn't cache member query
2023-08-03 11:54:50 +12:00
Guy Sartorelli 0a1c46e69f
Merge pull request #10895 from creative-commoners/pulls/4.13/cve-2023-32302
[CVE-2023-32302] Require password field to be non-empty
2023-07-31 11:24:46 +12:00
Steve Boyd 7b21b38ac4 [CVE-2023-32302] Require password field to be non-empty 2023-07-31 11:14:22 +12:00
Guy Sartorelli cb7be276e7
Merge pull request #10882 from creative-commoners/pulls/4.13/tx-1689897618
ENH Update translations
2023-07-21 12:23:39 +12:00
Steve Boyd 93acba0535 ENH Update translations 2023-07-21 12:00:18 +12:00
Guy Sartorelli c2a30d9b3b
Merge pull request #10881 from creative-commoners/pulls/4.13/double-assignement
MNT Tidy up double assignment
2023-07-21 09:36:04 +12:00
Steve Boyd a16b268ff7 MNT Tidy up double assignment 2023-07-20 18:19:14 +12:00
Guy Sartorelli ec99be0fd5
Merge pull request #10877 from creative-commoners/pulls/4.13/short-array-enum
FIX Short-array syntax for Enum
2023-07-20 16:41:29 +12:00
Steve Boyd 7daa3fdb08 FIX Short-array syntax for Enum 2023-07-20 16:06:01 +12:00
Dylan Wagstaff 8c3ba81052
FIX PHP 8.1 support in MySQLiConnector::query errors (#10570)
* FIX PHP 8.1 support in MySQLiConnector::query errors

The default error reporting mode in PHP 8.1 has changed from using
errors reported on the connection handle to throwing
mysqli_sql_exception. query() makes no allowance for this, and
functions up the call stack expect to catch
Silverstripe\ORM\Connect\DatabaseException instead - resulting in the
MySQLi exception going all the way up to halt the system.

We can use a try, catch, and finally to retain backwards compatibility,
no matter which setting (e.g. PHP version default) someone has enabled.

* Move MySQLConnector test skip call into setUp()

As review feedback; marking the test as skipped in a private function
obfuscated where the call was happening and made it harder to skimread
the tests. Moving this into a setUp function makes it obvious the check
is run before each test case, and skipped if necessary.
2023-07-07 15:56:31 +12:00
Thomas Portelange 9391e696bb
use Member::class 2023-06-23 09:35:34 +02:00
Thomas Portelange 2e73b5eeca
Use cached query
Fixes https://github.com/silverstripe/silverstripe-framework/issues/10833
2023-06-22 11:04:26 +02:00
Guy Sartorelli ab4802caaf
Merge pull request #10829 from creative-commoners/pulls/4.13/fix-last-page
FIX LastPage method returns true if TotalPages equals 0
2023-06-22 11:16:57 +12:00
Sabina Talipova ad9df97626 FIX LastPage method returns true if TotalPages equals 0 2023-06-22 10:50:41 +12:00
Guy Sartorelli 5303e08d34
Merge pull request #10820 from creative-commoners/pulls/4.13/tx-1686724699
ENH Update translations
2023-06-15 10:06:37 +12:00
Steve Boyd 2ea66922cd ENH Update translations 2023-06-14 18:38:19 +12:00
josephlewisnz b6a3e3a951
added an additional filter to remove empty array items (#10803)
* ENH Added filter to remove empty/null from Path::join parts

This is to ensure null values are removed and trim() deprecated warnings are not thrown
Fixes #10802

* FIX revert public signature

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>

---------

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2023-06-14 15:46:23 +12:00
Guy Sartorelli 6fd7694cbc
Merge pull request #10816 from creative-commoners/pulls/4.13/updatebool
FIX Show correct default value
2023-06-14 13:32:09 +12:00
Steve Boyd 35a8d79f62 FIX Show correct default value 2023-06-14 11:25:34 +12:00
Bram de Leeuw 33c62033fe
Fix translation key for DataObject.GENERALSEARCH (#10805)
* MNT Use gha-dispatch-ci

* Update DataObject.php

Fix typo in GENERALSEARCH localisation

* Update en.yml

remove unnecessary localisation line

* Update nl.yml

remove unnecessary localisation line

* Update eo.yml

remove unnecessary localisation line

* Update ci.yml
2023-06-09 13:44:00 +12:00
Steve Boyd a211b5eeb5 Merge branch '4.12' into 4.13 2023-05-31 15:49:15 +12:00