tonyair
/
silverstripe-framework
mirror of https://github.com/silverstripe/silverstripe-framework
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

FIX: Stop ManyManyThroughList join records incorrectly showing as changed (fixes #10821)

This commit is contained in:
Loz Calver 2023-08-21 15:46:05 +01:00
parent 4f6ab330f5
commit 1fd495449b
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ORM/ManyManyThroughList.php
View File

@ -87,7 +87,8 @@ class ManyManyThroughList extends RelationList
if ($joinRow) {
$joinClass = $this->manipulator->getJoinClass();
$joinQueryParams = $this->manipulator->extractInheritableQueryParameters($this->dataQuery);
$joinRecord = Injector::inst()->create($joinClass, $joinRow, false, $joinQueryParams);
$creationType = empty($joinRow['ID']) ? DataObject::CREATE_OBJECT : DataObject::CREATE_HYDRATED;
$joinRecord = Injector::inst()->create($joinClass, $joinRow, $creationType, $joinQueryParams);
$record->setJoin($joinRecord, $joinAlias);
}

15
tests/php/ORM/ManyManyThroughListTest.php
View File

@ -514,4 +514,19 @@ class ManyManyThroughListTest extends SapphireTest
$relation->removeAll();
$this->assertEquals(sort($remove), sort($removedIds));
}
public function testChangedFields()
{
/** @var ManyManyThroughListTest\TestObject $parent */
$parent = $this->objFromFixture(ManyManyThroughListTest\TestObject::class, 'parent1');
$item1 = $parent->Items()->first();
// Nothing has changed yet
$this->assertEmpty($item1->getChangedFields());
$this->assertFalse($item1->isChanged('Title'));
// Change a field, ensure change is flagged
$item1->Title = 'a test title';
$this->assertTrue($item1->isChanged('Title'));
}
}