Damian Mooyman
4453caf32b
API Let extensions control folder selector in HtmlEditorField_Toolbar
2014-07-21 15:52:10 +12:00
Sean Harvey
2a76be490d
Merge pull request #3304 from kinglozzer/pulls/filefield-validator-shortcuts
...
Move validator “shortcut” methods from UploadField to FileField (fixes #3258 )
2014-07-18 10:04:57 +12:00
Loz Calver
a322f93971
Move validator shortcut methods from UploadField to FileField
2014-07-17 21:40:30 +01:00
Simon Welsh
c14d58f585
Merge branch '3.1'
...
Conflicts:
.travis.yml
model/ManyManyList.php
model/fieldtypes/DBField.php
2014-07-16 21:24:02 +10:00
Damian Mooyman
d8e9af8af8
API New Database abstraction layer. Ticket #7429
...
Database abstraction broken up into controller, connector, query builder, and schema manager, each independently configurable via YAML / Injector
Creation of new DBQueryGenerator for database specific generation of SQL
Support for parameterised queries, move of code base to use these over escaped conditions
Refactor of SQLQuery into separate query classes for each of INSERT UPDATE DELETE and SELECT
Support for PDO
Installation process upgraded to use new ORM
SS_DatabaseException created to handle database errors, maintaining details of raw sql and parameter details for user code designed interested in that data.
Renamed DB static methods to conform correctly to naming conventions (e.g. DB::getConn -> DB::get_conn)
3.2 upgrade docs
Performance Optimisation and simplification of code to use more concise API
API Ability for database adapters to register extensions to ConfigureFromEnv.php
2014-07-09 18:04:05 +12:00
Tyler Kidd
16f5ef147e
Updated HtmlEditorField Field()
...
I had a need to use onBeforeRender on a DataExtension of
HtmlEditorField and noticed it wasn't there. Added return
parent::Field($properties) use FormField::Field which utilizes
onBeforeRender.
2014-07-03 08:54:37 -05:00
Damian Mooyman
ef03dfdd5b
Merge remote-tracking branch 'origin/3.1'
2014-06-17 18:17:24 +12:00
Damian Mooyman
11cc27f700
Merge pull request #2967 from halkyon/formfield_readonly
...
Fixing FormField not setting readonly attribute on setReadonly(true)
2014-06-17 14:48:56 +12:00
Ingo Schommer
bb03f6ba2f
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
forms/HtmlEditorField.php
2014-06-15 22:50:20 +12:00
Stig Lindqvist
332c2c3db0
Merge pull request #3129 from dnadesign/formFieldContainerFieldList
...
added in a containerFieldList getter
2014-06-14 17:06:15 +12:00
Mateusz Uzdowski
741ab96418
Fetch the nearest Controller instead of relying on global state.
...
Controller:curr() in this context are equivalent to calling
getToplevelController() which already solves the issue of nested
GridFields.
2014-06-12 16:47:49 +12:00
Mateusz Uzdowski
18b6870cf2
BUG Sanitise the PHP output.
2014-06-11 11:34:31 +12:00
Phill Price
b2455f2d20
Update Form.php
...
tiny typo
2014-06-10 13:50:28 +01:00
Phill Price
5b60646e55
Update DropdownField.php
...
An error in the example (missing comma) spotted by michaelcslweb
2014-05-28 11:36:51 +01:00
John Milmine
da67f9109d
added in a getter
2014-05-28 13:58:40 +12:00
Devlin
5f7ebd3c23
API UploadField: move replaceFile to the front end config
2014-05-21 12:03:26 +02:00
Damian Mooyman
ec578e5c8a
Merge remote-tracking branch 'origin/3.1'
2014-05-12 11:32:22 +12:00
Ingo Schommer
802b46bd0a
GridFieldDetailForm_ItemRequest->getRecord()
2014-05-07 23:49:04 +12:00
Damian Mooyman
df28ccb59f
BUG Better checking of existing files
...
[ref: CWPBUG-158]
2014-05-06 14:06:16 +12:00
Damian Mooyman
e9c3ff933f
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
.travis.yml
composer.json
2014-05-06 10:22:09 +12:00
Damian Mooyman
892b440115
API Make default gridfield paging configurable
...
Documentation improved
2014-04-28 15:13:01 +12:00
Hamish Friedlander
f2c4a629a7
FIX: ConfirmedPasswordField used to expose existing hash
2014-04-17 11:57:57 +12:00
Simon Welsh
fe8dc50ffc
Merge branch '3.1'
...
Conflicts:
tests/view/SSViewerTest.php
2014-03-30 18:17:24 +13:00
Sean Harvey
f11adcfe2e
Fixing FormField not setting readonly attribute on setReadonly(true)
2014-03-24 08:59:35 +13:00
Damian Mooyman
7c60c73dbb
API Polymorphic has_one behaviour
2014-03-18 09:18:04 +13:00
Simon Welsh
cbbce430e1
Merge pull request #2297 from colymba/htmleditorconfig-mode-fix
...
HtmlEditorConfig default TinyMCE mode is now none
2014-03-17 08:22:14 +13:00
colymba
9b5e5e812e
HtmlEditorConfig default TinyMCE mode is now none
2014-03-16 13:48:01 +02:00
Simon Welsh
8f31352039
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
.travis.yml
2014-03-16 09:36:48 +13:00
Loz Calver
a73c3574e2
FieldList->insertBefore/After now accept arguments in either order ( fixes #2737 )
2014-03-15 11:32:51 +00:00
Simon Welsh
bc8d2d638e
Merge pull request #2875 from kinglozzer/2361-gridfield-column-header-css
...
FIX: Ensure valid CSS classes for GridField header (fixes #2361 )
2014-03-15 21:39:42 +13:00
Simon Welsh
b145e96d27
Merge pull request #2818 from tractorcow/pulls/gridstate_data-error-test
...
BUG GridState_Data doesn't hold falsey values - Fixes #2813
2014-03-15 21:29:56 +13:00
Simon Welsh
3b330a065b
Merge pull request #2800 from phptek/issue/2795
...
BUG Ensure TreeMultiSelectField doesn't populate menus with "unchanged".
2014-03-15 21:27:33 +13:00
Simon Welsh
310e90d412
Merge pull request #2751 from axyr/patch-1
...
formHtmlContent() uses missing FormEncType() call
2014-03-15 21:12:44 +13:00
Simon Welsh
279b927df1
Merge pull request #2903 from tractorcow/pulls/fix-fileupload-fileexists
...
BUG Fix issues with uploading to /assets
2014-03-15 21:02:36 +13:00
Simon Welsh
bdd936d078
Set the response to 403 on error
2014-03-15 20:58:47 +13:00
Simon Welsh
5beaebc43a
Merge pull request #2718 from silverstripe-rebelalliance/2503
...
BUG: Fixes performReadonlyTransformation for OptionSetField
Closes #2503
2014-03-15 20:45:04 +13:00
Simon Welsh
42c90aebb9
Merge pull request #2344 from colymba/uploadfield-upload-validation
...
FIX UploadField server validation error display
2014-03-15 20:24:58 +13:00
Simon Welsh
18661005ee
Corrects merge errors.
...
Closes #2937
2014-03-11 07:04:24 +13:00
Simon Welsh
d431e98ecf
Merge branch '3.1'
...
Conflicts:
forms/Form.php
forms/FormField.php
security/Member.php
security/MemberLoginForm.php
2014-03-10 22:58:49 +13:00
Damian Mooyman
0cbad41d3b
Rewrote usages of error suppression operator
2014-03-05 15:48:55 +13:00
Damian Mooyman
6d5d3d8cb7
Rewrote usages of error suppression operator
2014-03-05 14:22:19 +13:00
Will Rossiter
c74137e679
FIX: getMessageFromSession returning null on first access
2014-02-28 21:24:16 +13:00
Damian Mooyman
c1e0f98f87
BUG Fix case where setFolder('/') would break UploadField::fileexists
...
BUG Prevent Upload from writing to the site root folder
2014-02-27 14:23:32 +13:00
Ingo Schommer
85972dcf6d
Merge pull request #2878 from tractorcow/pulls/fix-folder-find-illegalpath
...
BUG Fixed critical issue with Folder::find_or_make failing to handle invalid filename characters
2014-02-22 20:57:09 +13:00
Thomas Speak
c7e57e0087
DOC: DropdownField __construct
...
Current docs make PHPStorm spew errors about data types.
`new CheckboxSetField('Countries'...);`
Causes `Expected The, got string`.
Simple restructure.
2014-02-20 23:04:53 +00:00
Damian Mooyman
ebeb663ddf
BUG Fixed critical issue with Folder::find_or_make failing to handle invalid filename characters
...
BUG Fix UploadField duplicate checking with invalid folderName
2014-02-21 09:11:34 +13:00
Loz Calver
90952e7bd4
FIX: Ensure valid CSS classes for GridField header ( fixes #2361 )
2014-02-19 21:17:52 +00:00
Sean Harvey
03f14565b5
Merge pull request #2841 from chillu/pulls/dateformat-simplified
...
API Default to "yyyy-MM-dd" for date format
2014-02-17 14:05:39 +13:00
Ingo Schommer
6906c9bd1a
API Removed auto-detection for i18n date/time formats
...
Default to "yyyy-MM-dd" for date format, and "H:mm" for time_format.
Switched to config API for setting/getting values.
Avoid using "MMM" in particular, since it causes
inconsistencies in month names between jQuery UI and Zend_Locale_Format.
Fixes https://github.com/silverstripe/silverstripe-cms/issues/544
2014-02-16 23:57:49 +13:00
Sean Harvey
9048eab4a2
Merge branch '3.1'
2014-02-12 11:06:54 +13:00
Ingo Schommer
5e38ef9e55
Merge pull request #2835 from kinglozzer/1891-csrf-friendly-error
...
NEW: Forms with invalid/expired SecurityIDs are repopulated (fixes #1891 )
2014-02-12 09:44:03 +13:00
Loz Calver
058219c0ee
NEW: Forms with invalid/expired SecurityIDs are repopulated ( fixes #1891 )
2014-02-09 10:19:24 +00:00
Ingo Schommer
0f1ae75dd8
Correct JS i18n in UploadField ( fixes #2370 )
2014-02-09 20:43:08 +13:00
Damian Mooyman
cd213ab488
BUG Fixed handing of false values in GridState_Data
...
API Added ability to unset values
2014-02-04 10:26:26 +13:00
Ingo Schommer
0d7e9a9692
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
_config/routes.yml
docs/en/topics/datamodel.md
forms/DropdownField.php
2014-02-04 08:19:04 +13:00
Ingo Schommer
ab070944d5
Merge branch 'pulls/apidocs-package-list' of https://github.com/madmatt/silverstripe-framework into madmatt-pulls/apidocs-package-list
...
Conflicts:
view/SSTemplateParser.php
view/SSTemplateParser.php.inc
2014-01-31 15:15:59 +13:00
Kirk Mayo
44a8537f68
BUG: #2503 Fixes performReadonlyTransformation for OptionSetField
...
NEW: Adding unit test for performReadonlyTransformation #nd fixing OptionSetField #2503
BUG: Fixing undefined variables and function parameters for PerformReadonlyTransformation unit tests
NEW: Adding unit test to OptionsetField for read only fields
2014-01-30 16:09:55 +13:00
Will Rossiter
93085b9660
Correct whitespace / phpdoc
2014-01-28 20:00:47 +13:00
Russell Michell
9e2c7b6572
BUG Ensure TreeMultiSelectField doesn't populate menus with "unchanged".
...
TreeMultiSelectField's default for its value property is 'unchanged'
which causes menus to not load and generates console errors. Fixes #2795
2014-01-28 08:45:15 +13:00
Ingo Schommer
55608d57f6
Merge pull request #2767 from HARVS1789UK/2766-moneyfield-set-readonly
...
BUG: #2766 Corrects MoneyField::performReadonlyTransformation()
2014-01-22 22:08:16 +13:00
Joe Harvey
405426799b
Issue #2766 - Moves logic to return ReadonlyField versions of MoneyFields child fields to performReadonlyTransformation() method and reverts changes to MoneyField::setReadonly() as per Wilr’s ( https://github.com/wilr ) request
2014-01-13 08:35:40 +00:00
Will Rossiter
e7266535c5
FIX: Allow empty checkboxes through setValue(null) ( #1392 )
2014-01-12 17:28:09 +13:00
Will Rossiter
4ea62b44f9
FIX: Ensure GridFieldDetailForm has the current record validator.
...
Currently the validator is only set through
ModelAdmin and not through GridField
directly. This will set the validator based on the
record unless a custom validator has been
provided.
http://www.silverstripe.org/data-model-questions/show/34650?start=8#post331958
2014-01-12 16:08:31 +13:00
Will Rossiter
f433b5000f
FIX: Resolve issue when selected value is zero. ( #2530 )
...
$this->value is stored as string internally. In
the special case that the option value is 0, the
type comparison fails to resolve 0 == '0',
see http://www.php.net/manual/en/types.comparisons.php .
2014-01-11 13:25:40 +13:00
Joe Harvey
611d571b65
BUG corrects MoneyField::setReadonly() method in order to return ReadonlyField instances of its child fields
...
Issue #2766 - This causes our cloned MoneyField to actually contain two ReadonlyFields for currency and amount.
2014-01-10 15:38:06 +00:00
Simon Welsh
39d42e4ea3
Merge branch '3.1'
2014-01-09 08:22:47 +13:00
Jeremy Shipman
8d8f3abace
FIX: ConfirmedPasswordField setName failed to set names of child fields.
...
FIX: ConfirmedPasswordField relied on POST variables. These should instead come from setValue().
Added all important tests for validating the field: valid if passwords match, invalid if passwords differ.
2014-01-07 17:17:55 +13:00
colymba
02bceca9b4
FIX UploadField validation error and styles
...
UploadField now return the validator's error message instead of 403. Plus nicer layout for error messages.
2014-01-04 22:30:35 +02:00
Martijn
180bae826a
formHtmlContent() uses missing FormEncType() call
...
it needs to call $this->getEncType() instead..
2014-01-02 10:44:00 +01:00
Will Rossiter
770e23f8e1
Merge pull request #2270 from ARNHOE/3.1-updatedfieldgroup
...
BUG Updated fieldgroup class and example code
2013-12-20 19:14:21 -08:00
Will Rossiter
87b5451d2d
Consistent API for SelectionGroup constructor.
2013-12-21 14:55:53 +13:00
Will Rossiter
5728fc3a9a
Merge pull request #2484 from nedmas/fix-creditcardfield-to-use-attributeshtml
...
FIX: Change CreditCardField to use AttributesHTML
2013-12-20 16:50:15 -08:00
Ingo Schommer
60333f68ee
NEW UploadField lists all files, shows path info
...
It doesn't make a lot of sense to limit the listing
to assets/Uploads/, which is the default set through FileField->folderName.
Showing all files regardless of folder makes them easier
to find, users can still opt-in to filtering by folder
through the TreeDropdownField.
2013-12-20 01:00:36 +01:00
Ingo Schommer
03b2e9dc74
"alt" and "title" attrs for images from URLs ( fixes #2723 )
2013-12-19 19:43:46 +01:00
Ingo Schommer
323364bc85
Fixed merge errors
2013-12-06 15:44:24 +01:00
Ingo Schommer
740560c487
Fixed merge errors
...
- HTML identifier changes in master breaking tests
- Regression from b6b3cd9889
in GridFieldSortableHeader (var capitalisation)
2013-12-06 15:37:51 +01:00
Ingo Schommer
6176d65bd2
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
forms/gridfield/GridFieldSortableHeader.php
model/DataList.php
model/fieldtypes/Enum.php
2013-12-02 20:49:34 +01:00
Ingo Schommer
73eae2990f
Merge pull request #2683 from tractorcow/pulls/2682-fix-gridfieldsortableheader
...
BUG Fixes #2682 - Regression in #2595
2013-11-29 09:17:39 -08:00
madmatt
bebe0f6e37
Updating @package and @subpackage doc tags
2013-11-29 17:49:30 +13:00
Ingo Schommer
eaa390b1de
Merge pull request #2692 from sheadawson/formfieldhook
...
MINOR added onBeforeRender extension hook to FormField
2013-11-28 16:48:18 -08:00
sheadawson
759cb2dd6d
MINOR added onBeforeRender extension hook to FormField
2013-11-29 11:20:30 +11:00
Damian Mooyman
7636699c9f
BUG Fixes #2682 - Regression in #2595 causing gridfield headers to break on summary_fields containing field methods
2013-11-27 18:43:27 +13:00
Ingo Schommer
7e291133a0
Merge pull request #2663 from ajshort/has-many-prepopulate
...
NEW: Pre-populate and disable foreign key field on has many lists.
2013-11-22 11:18:11 -08:00
Ingo Schommer
053258b984
Merge pull request #2595 from kinglozzer/gridfield-sort-relation
...
NEW: GridField can sort on relation columns
2013-11-22 11:14:12 -08:00
Ian Walls
b906442a9c
Fixes issue #2669
...
Add local setName() function to DatetimeField, which also sets Name
on the constituent DateField, TimeField and timezoneField.
2013-11-15 14:18:48 -05:00
Loz Calver
a1a402224f
NEW: GridField can sort on relation columns
...
Slightly improved logic
Add support for relations more than one 'level' apart
Add unit tests
Fixing PostgreSQL support
Throw exception if attempting to sort on a has_many/many_many relation
2013-11-13 10:33:00 +00:00
Andrew Short
fc773c5c22
NEW: Pre-populate and disable foreign key field on has many lists.
...
This is a common use case, and by default a form field is added which
has no effect. While this coupling is undesirable, it makes the default
behaviour much more sensible.
See #2662 , #2651 , #2637 for more information.
2013-11-13 16:21:18 +11:00
Andrew Short
bedf292612
Merge branch '3.1'
...
Conflicts:
docs/en/reference/execution-pipeline.md
lang/nl.yml
2013-11-11 18:18:25 +11:00
Zauberfisch
2df5269ae5
disable source_file_comments in GridFieldAddExistingAutocompleter->doSearch() because they would be displayed as plaintext in the dropdown
2013-11-08 08:34:22 +00:00
Zauberfisch
54a58eff27
Replace HTML entities in GridFieldAddExistingAutocompleter->doSearch() with actual charaters as the DropDown does not play nicely with HTML entities
2013-11-08 07:54:47 +00:00
Ingo Schommer
61f99fa1ef
UploadField changeDetection optional ( fixes #2638 )
2013-11-06 23:34:29 +01:00
Maks Feltrin
0e05353efc
make setHeadingLevel a chainable method
2013-11-02 01:21:56 +01:00
Sean Harvey
8e36290b56
Merge pull request #2205 from jthomerson/pulls/fix_gridfield_class_name
...
FIX: wrong class name being returned
2013-10-31 18:19:05 -07:00
Damian Mooyman
fbf64c8c48
Merge pull request #2603 from chillu/pulls/htmleditor-upload-replace
...
Default UploadField to replace files
2013-10-31 15:25:22 -07:00
Will Rossiter
9633f49aaf
Merge pull request #2612 from AlphaCactus/patch-1
...
Replace new *Field with *Field::create()
2013-10-29 23:15:05 -07:00
Damian Mooyman
4102cc64a0
BUG Issues with CMSForm not consistently respecting new form naming scheme.
...
Fixes for failing CMSFormTest cases
2013-10-30 17:08:31 +13:00
Simon Welsh
60bb9d81c5
Merge pull request #2411 from simonwelsh/circ_ref
...
Revert "Merge pull request #2390 from phptek/2389"
2013-10-28 14:05:13 -07:00
AlphaCactus
133c6dd089
Replace some new *Field with *Field::create()
...
Specifically intended to change new TreeDropdownField with TreeDropdownField::create but also replaced a few others as well. This allows class replacement of TreeDropdownField in order to extend its functionality without having to override HTMLEditorField.
2013-10-25 12:49:41 -07:00
Ingo Schommer
2266d77237
Revert "Style destructive actions destructively"
...
This reverts commit 3851ef9f2c
.
Breaks button alignment in CMS.
2013-10-24 11:37:40 +02:00
Damian Mooyman
b6b3cd9889
API GridState_Data values can have default values specified during retrieval.
...
Fixes issues with GridStata_Data being returned from various states when value types are necessary.
Pruning of dead code from GridFieldAddExistingAutocompleter
Documentation for GridState
2013-10-24 16:15:33 +13:00
Ingo Schommer
5dadb5a74f
Default UploadField to replace files
...
Honours the $overwriteWarning setting, rather than warning
about overwritten files, and when that warning is acknowledged by the user,
create a new file instead. We need to set this as close to
the Upload->load() call as possible, since it depends
on non-deterministic config state.
2013-10-23 23:07:53 +02:00
Ingo Schommer
739d591e45
Merge pull request #2558 from chillu/pulls/uploadfield-874
...
HTML attr encoding for UploadField config
2013-10-23 13:00:39 -07:00
Ingo Schommer
b56ca812dc
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
tests/security/MemberTest.php
2013-10-23 14:53:29 +02:00
Ingo Schommer
d7e10e620a
Merge pull request #2537 from wilr/membervalidator
...
FIX: Use Injector API for managing Member_Validator instance.
2013-10-23 03:01:15 -07:00
Ingo Schommer
3f479ad282
Merge pull request #2575 from dhensby/patch-2
...
FIX #2496 `ConfirmedPasswordField` mismatch passwords saved
2013-10-23 02:29:42 -07:00
Ingo Schommer
ea5b3e4269
Merge pull request #2520 from wilr/destructivestyles
...
Style destructive actions destructively
2013-10-22 17:07:38 -07:00
Loz Calver
e9fdfb05b2
GridField 'Add existing' action styling improvements
2013-10-22 16:44:28 +01:00
Daniel Hensby
2a6f1f1949
FIX #2496 ConfirmedPasswordField
mismatch passwords saved
...
Fixes #2496
Also fixes another issue where 'Password' is hard coded as field name in `validate()`
2013-10-21 22:27:41 +01:00
Ingo Schommer
25b6175e67
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
.travis.yml
forms/FormField.php
2013-10-20 13:52:56 +02:00
Nathan J. Brauer
fee54c75f0
API: Change DropdownField::getSource() to not return the emptyString value.
2013-10-18 11:16:27 +13:00
Will Rossiter
1c983bc16d
API: LookupField::Field now returns an HTMLText instance.
...
Moved LookupField into a template, removed getSource() as the DropdownField getSource() has been simplified to just a getter
2013-10-18 10:28:17 +13:00
Ingo Schommer
e1b7df38ef
HTML attr encoding for UploadField config
...
Also fixed UploadField operation with canUpload=false,
which broke the JS because no config could be found,
since the <input> field wasn't present. We can't put the data-config
attribute on the field holder, since fields can be rendered
without their field holder through FormField->SmalLFieldHolder().
Fixes https://github.com/silverstripe/silverstripe-cms/issues/874
2013-10-17 10:55:11 +02:00
Ingo Schommer
b6c16fcbf1
Merge pull request #2554 from tractorcow/pulls/3.1-moneyfield-style-fix
...
BUG Fixed incorrect CSS class on MoneyField holder
2013-10-17 01:22:01 -07:00
Damian Mooyman
24950692cd
BUG Fixes serious issue with FieldList::addFieldsToTab failing to accept multiple field groups.
...
Additional groups beyond the first are ignored.
Test cases included.
2013-10-17 15:38:22 +13:00
Damian Mooyman
702b6c94c4
BUG Fixed incorrect CSS class on MoneyField holder
2013-10-17 13:28:27 +13:00
Will Rossiter
813d34b15e
FIX: Use Injector API for managing Member_Validator instance.
...
Updates the CMS profile page and SecurityAdmin to give developers a few ways to customise the required fields.
Added extension hook updateValidator for getValidator for things like modules to inject required fields to go along with Injector for replacing the entire class for project specific use.
2013-10-16 11:29:43 +13:00
Ingo Schommer
1bcd4c9a6a
Merge pull request #2531 from ajshort/pull-5
...
Correct some incorrect PHPDoc definitions.
2013-10-13 01:36:16 -07:00
Andrew Short
c082dc3bd1
Correct some incorrect PHPDoc definitions.
2013-10-13 18:59:53 +11:00
Will Rossiter
3851ef9f2c
Style destructive actions destructively
2013-10-11 20:00:11 +13:00
Ingo Schommer
d485faf0c9
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
.travis.yml
forms/Form.php
2013-10-08 11:17:06 +02:00
Ingo Schommer
aa6ca49651
Merge pull request #2493 from kinglozzer/2449-form-validation-exemptions
...
NEW: Allow setting of specific form actions that do not require validation on CMSForm
2013-10-08 01:51:11 -07:00
Ingo Schommer
6e8ec778c3
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
admin/templates/Includes/LeftAndMain_Menu.ss
lang/en.yml
2013-10-07 16:19:40 +02:00
Ingo Schommer
795d3e4b3b
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
dev/install/install.php5
docs/en/index.md
tests/core/CoreTest.php
2013-10-07 16:18:20 +02:00
Ingo Schommer
60fc7e5346
Merge remote-tracking branch 'origin/3.1'
2013-10-06 19:07:39 +02:00
Loz Calver
3172c7732e
Allow setting of specific form actions that do not require validation
...
Move validation exemptions into CMSForm
Also fix buttonClicked() to skip CompositeField
Whitespace
Adding unit tests
2013-10-04 10:30:20 +01:00
Ingo Schommer
dcf9f2c133
Merge pull request #2311 from unclecheese/patch-12
...
API Change: Make GridFieldConfig objects decoratable
2013-10-03 16:46:13 -07:00
Sean Harvey
5e5a2f8845
Merge pull request #2288 from chillu/pulls/browser-spellcheck
...
API Disable discontinued Google Spellcheck in TinyMCE (#2213 )
2013-10-03 14:42:45 -07:00
Tom Densham
37e032df86
API: Change CreditCardField to use AttributeHTML
2013-10-03 15:26:31 +01:00
Ingo Schommer
bb7c973e34
Merge pull request #2468 from nedmas/make-creditcardfield-use-template
...
FIX: Make CreditCardField use template
2013-10-03 03:22:06 -07:00
Tom Densham
d79d50770c
FIX: Make CreditCardField use template
2013-10-03 10:51:39 +01:00
Loz Calver
9b0564b7d6
FIX: Undefined variable in TreeDropdownField.php
...
I'm guessing this was just a simple typo. Checked this by searching on SiteTree, behaves as expected after this change.
2013-10-02 15:41:39 +01:00
Ingo Schommer
837304b81b
Query param support in TreeMultiselectField ( fixes #2438 )
...
Thanks to @bummzack for the initial fix
2013-10-02 15:42:29 +02:00
Loz Calver
6b3b61873a
FEATURE: Disable specific tree nodes in TreeDropdownField
...
DO NOT MERGE: to be reviewed.
This feature request was born out of wanting the ability to disable (for example) a top level page from being selected, while still being able to select a child page. Using setFilterFunction() simply removes the node and its children.
Extra styling for disabled nodes
Disable ability to select a disabled node for TreeDropdownField
Disable hover CSS changes
Fixing merge conflict during rebase
Return a boolean for nodeIsDisabled()
2013-10-02 12:53:23 +01:00
Ingo Schommer
9709a5cd8c
Merge remote-tracking branch 'origin/3.1.0' into 3.1
2013-10-01 01:45:27 +02:00
Ingo Schommer
deadc154ca
Don't link record in GridField form message
...
This is no longer allows through Form->sessionMessage() to avoid XSS.
2013-10-01 00:00:37 +02:00
Ingo Schommer
bda56eb9b0
Don't link record in GridField form message
...
This is no longer allows through Form->sessionMessage() to avoid XSS.
2013-09-30 23:55:32 +02:00
Ingo Schommer
298de5a67d
FIX Escape breadcrumbs in SecurityAdmin (SS-2013-007)
2013-09-30 22:53:43 +02:00
Ingo Schommer
d8d07d971e
FIX Auto-escape titles in TreeDropdownField
...
Related to SS-2013-009. While the default "TreeTitle" was escaped
within the SiteTree->TreeTitle() getter, other properties like SiteTree->Title
weren't escaped. The new logic uses the underlying casting helpers
on the processed objects.
2013-09-30 22:53:21 +02:00
Ingo Schommer
a338e608b8
API Escape form validation messages (SS-2013-008)
2013-09-30 22:53:07 +02:00
Daniel Hensby
6c943007a1
removeRequiredField() limits field ( fixes #2165 )
...
Added tests to RequiredFields and fixed bugs that were found
Now you:
1. Can't add the same field name many times
2. Can use append RequiredFields correctly without fear of duplicates
I've also added a Deprecation warning to $useLabels as it's not used
*anywhere* in framework
2013-09-27 19:58:59 +02:00
Ingo Schommer
d3aa38f4b4
$.data() for GridField autocomplete ( fixes #2440 )
2013-09-27 19:51:32 +02:00
Ingo Schommer
455e550d9a
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
docs/en/topics/testing/create-silverstripe-test.md
forms/Form.php
i18n/i18n.php
model/Image.php
2013-09-27 19:22:14 +02:00
Ingo Schommer
2e3511bc5f
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
docs/en/changelogs/3.0.6.md
forms/Form.php
forms/FormField.php
forms/TreeDropdownField.php
2013-09-27 18:50:47 +02:00
Ingo Schommer
debd81d380
Merge pull request #2453 from chillu/pulls/escape-3.1.0
...
Escaping 3.1
2013-09-25 16:02:45 -07:00
Ingo Schommer
c243418597
API Escape form validation messages (SS-2013-008)
2013-09-24 21:54:31 +02:00
Ingo Schommer
2b7a2a289e
API Escape form validation messages (SS-2013-008)
2013-09-24 21:41:21 +02:00
Ingo Schommer
f3ef04a432
FIX Auto-escape titles in TreeDropdownField
...
Related to SS-2013-009. While the default "TreeTitle" was escaped
within the SiteTree->TreeTitle() getter, other properties like SiteTree->Title
weren't escaped. The new logic uses the underlying casting helpers
on the processed objects.
2013-09-24 21:41:21 +02:00
Ingo Schommer
78ce99be09
FIX Escape breadcrumbs in SecurityAdmin (SS-2013-007)
2013-09-24 21:41:18 +02:00
Ingo Schommer
114fb59107
FIX Auto-escape titles in TreeDropdownField
...
Related to SS-2013-009. While the default "TreeTitle" was escaped
within the SiteTree->TreeTitle() getter, other properties like SiteTree->Title
weren't escaped. The new logic uses the underlying casting helpers
on the processed objects.
2013-09-24 21:40:17 +02:00
Sean Harvey
b383a07f90
BUG Fixing tabindex added to CreditCardField when tabindex is NULL
...
The tabindex increment *should* only be done if there is a tabindex
that has been set on a CreditCardField already, otherwise it breaks
the tab ordering.
2013-09-24 21:40:17 +02:00
Ingo Schommer
48021e9fd3
Merge pull request #2166 from dhensby/patch-2
...
FormFields now allow setting of extra CSSClasses en masse
2013-09-24 11:50:01 -07:00
Ingo Schommer
d291a96326
Merge pull request #2152 from dhensby/patch-1
...
FIX Empty Datefield with defined min or max has non-object error thrown
2013-09-24 11:48:05 -07:00
Ingo Schommer
1bb993b0b3
Form errors in LeftAndMain response negotiation
...
The session key for form errors changed from "Form_EditForm" to "CMSForm_EditForm",
causing a mismatch. See https://github.com/silverstripe/silverstripe-framework/pull/2084/files#r6338249 for discussion
2013-09-18 14:30:37 +02:00
Simon Welsh
6df6cb719d
Revert "Merge pull request #2390 from phptek/2389"
...
This reverts commit 58da57dd1b
, reversing
changes made to 8864256601
.
2013-09-13 08:22:32 +12:00
Ingo Schommer
c2b312d76f
Merge remote-tracking branch 'origin/3.1.0' into 3.1
2013-09-12 17:24:42 +02:00
Sean Harvey
c309867a1c
Merge pull request #2373 from chillu/pulls/treedropdown-searchfield-default
...
Default TreeDropdown to "Title" search if $labelField isn't in DB
2013-09-10 21:45:40 -07:00
Russell Michell
abcb2ef40b
FIX: Modified fix for #2389 to ensure existing tests pass.
2013-09-06 08:48:32 +12:00
Russell Michell
128c33b82c
FIX: Fixes #2389
...
- Prevent circular references in `GridFieldAddExistingAutocompleter` when linking DataObjects whose ID matches the current object to which the gridfield is attached.
2013-09-05 13:55:47 +12:00
Ingo Schommer
1c31c098ee
FIX Correct Zend_Locale fallbacks in i18n/DateField/DateTimeField
...
Due to the recent change of translations to transifex, some
locales changed their names, which prompted a fix to
i18n::get_available_translations() (see 00ffe7294
).
This caused a regression where short locales are determined
from the YAML file names (e.g. "en"), but weren't matched up
with fully qualified locales from get_available_translations() (e.g. "en_US").
Since this list is used in the admin/myprofile dropdown for the Member.Locale value,
it didn't match up with any entries and defaulted to the first one ("Africaans").
Note that the behaviour of admin/myprofile is still a bit weird:
It defaults the locale on new members to the one set for the current administrator.
So if a site defaults to en_US in _config.php, but the admin happens to view
his backend in de_DE, all members he creates default to de_DE as well.
Thanks to @tractorcow for contributing and peer reviewing!
2013-08-30 10:18:00 +02:00
Ingo Schommer
20b49e215c
Merge pull request #2136 from nedmas/fix-remove-export-button-padding
...
FIX: GridField button styling
2013-08-30 00:24:21 -07:00
Ingo Schommer
79cab42a91
Default TreeDropdown to "Title" search if $labelField isn't in DB
...
This is a workaround in order to ensure the field stays operational
for SiteTree and File records with the new $showSearch=true default.
Previously it was necessary to use setSearchCallback(), otherwise
the SQL query would fail. One limitation to keep this change generic
is that "MenuTitle" won't be used to search, since its SiteTree specific,
while the "Title" and "Name" fields are generally regarded as
model conventions (e.g. they're used in DataObject->getTitle() as well).
See https://github.com/silverstripe/silverstripe-framework/pull/2364
2013-08-29 17:12:01 +02:00
Naomi Guyer
8b5f89f3b9
API: Treedropdownfield showsearch default true, provide better ui
...
Set search option true on treedropdown fields by default, to provide a
fallback solution when trees fail to render (too many children errors)
Provide better indication/more meaningful styling to search (match
chosen styles for consistency)
2013-08-29 16:21:04 +12:00
Ingo Schommer
5249664833
More consistent English grammar
2013-08-22 16:07:27 +02:00
Ingo Schommer
a4c6ae3e90
Merge remote-tracking branch 'origin/3.1'
2013-08-22 13:56:33 +02:00
Ingo Schommer
40c239076b
Merge remote-tracking branch 'origin/3.0' into 3.1.0
...
Conflicts:
model/Hierarchy.php
2013-08-22 12:55:47 +02:00
Simon Welsh
c66cc952d2
Correct line length and indentation
2013-08-21 21:27:16 +12:00
Simon Welsh
151baeede1
Correct line length and indentation
2013-08-21 18:54:05 +12:00
Ingo Schommer
a6da1f5570
Merge pull request #2294 from wilr/fixgridexport
...
FIX: Remove limit on GridField export
2013-08-20 14:08:18 -07:00
Ingo Schommer
351c1168b6
Merge pull request #2314 from mateusz/required-attrs
...
HTML5 required attributes on default fields, add validator to the login form
2013-08-20 06:40:58 -07:00
Ingo Schommer
02cc662aaf
More specific entwine rule for delete alert in GridField
...
The rule didn't apply in Firefox because of how it handles specificity,
so made it a bit more specific (added "button" and ".action")
2013-08-16 16:06:31 +02:00
Ingo Schommer
7ae75c1a89
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
forms/HtmlEditorField.php
2013-08-16 13:37:44 +02:00
Ingo Schommer
acc07e67ea
Merge pull request #2318 from micmania1/2317-gridfieldfilterheader-duplicate-fields
...
Added gridField->getName() to field names to avoid duplication
2013-08-15 15:44:17 -07:00
Mateusz Uzdowski
090f07d978
BUG Apply HTML5 required attributes when fields are required.
2013-08-12 09:32:03 +12:00
micmania1
8ce50c3ae6
Added gridField->getName() to field names to avoid duplication
2013-08-09 22:57:48 +01:00
Hamish Friedlander
0918cd2092
Remove SiteTree link tracking out of HtmlEditorField
2013-08-09 11:24:10 +02:00
unclecheese
4385264aa9
API Change: Make GridFieldConfig objects decoratable
...
This change promotes GridFieldConfig objects to first-class Object descendants, making them extendable through the decorator pattern.
Relevant discussion in the dev group: https://groups.google.com/forum/#!topic/silverstripe-dev/Z6tu1k05ZmA
2013-08-08 17:12:40 +12:00
Will Rossiter
65d96e8d7c
FIX: Remove limit on GridField export
...
Allow DataList::limit() to take a null value to remove the limit.
Added tests for limit(). Note the one failure, currently the ORM doesn't support unlimited values with an offset.
2013-08-05 19:59:12 +12:00
Ingo Schommer
0e7231ff60
API Disable discontinued Google Spellcheck in TinyMCE
...
Replaced by browser-based spellchecking if available (Chrome, Firefox),
with instructions on how to use PSpell as an alternative.
2013-08-03 16:16:45 +02:00
Arno Poot
b68cd6610c
Updated fieldgroup class and example code
2013-07-26 16:01:24 +02:00
Hamish Friedlander
0a79ac3592
Merge branch 'origin/3.1'
...
Conflicts:
templates/forms/CheckboxSetField.ss
templates/forms/FormField_holder.ss
templates/forms/OptionsetField.ss
2013-07-19 16:25:38 +12:00
Hamish Friedlander
d38bd7d5cb
Merge branch 'origin/3.0' into 3.1
2013-07-19 14:18:49 +12:00
Ingo Schommer
920edf88e7
Test allowedExtensions in UploadField, return correct HTTP status
2013-07-12 13:16:34 +02:00
Ingo Schommer
cc33427218
Merge pull request #2123 from willmorgan/forajaxtemplate-session-message
...
MINOR clear session message whenever forAjaxTemplate is used
2013-07-10 16:04:48 -07:00
Jeremy Thomerson
dbb2efcbb3
FIX: wrong class name being returned
...
This resulted in an error since the returned class name did not exist.
Note that this only happened when someone subclassed GridFieldDetailForm
and did not subclass GridFieldDetailForm_ItemRequest.
2013-07-09 20:59:56 +00:00
Andrew Short
bfdf14fafa
Merge branch '3.1'
2013-07-09 13:42:32 +10:00
Daniel Hensby
e225cffcf8
FIX Empty Datefield with defined min or max has non-object error thrown
...
When submitting a Datefield with no value but with a min / max config date, the validate() function attempts to access a function on $this->valueObj (which is a non-object)
2013-07-08 16:07:21 +01:00
Sam Minnée
0173707cd1
Merge pull request #2164 from tractorcow/3.1-datetimefield-fixes
...
BUG Fixed DateTimeField where time value was being parsed incorrectly.
2013-07-06 19:03:33 -07:00
Simon Welsh
fbce9fd7cd
Merge branch '3.1'
...
Conflicts:
.travis.yml
docs/en/misc/contributing/code.md
javascript/HtmlEditorField.js
2013-07-05 10:22:58 +12:00
Mateusz U
3ac22ed638
Merge pull request #2182 from hafriedlander/fix/sanitise
...
FIX HtmlEditorField not re-checking sanitisation server side
2013-07-04 14:56:37 -07:00
Damian Mooyman
a862b4da99
BUG Fixed missing allowed_actions on UploadField_SelectHandler
2013-07-04 12:38:57 +12:00
Hamish Friedlander
dacb2aa638
FIX HtmlEditorField not re-checking sanitisation server side
2013-07-04 08:53:23 +12:00
Ingo Schommer
d003c96c62
Fixed HTMLEditorField extension call ("updateFieldsForOembed")
2013-07-03 10:15:46 +02:00
Daniel Hensby
336ddf1a55
FormFields now allow setting of extra CSSClasses en masse
...
Each CSS class passed in to `addExtraClass` or `removeExtraClass` will be set as their own key in the `extraClasses` array
Also make `Form` consistent with `FormField`
2013-06-29 13:27:26 +01:00
Damian Mooyman
feb03f5443
BUG Fixed issue where time value was being parsed incorrectly in some locales
2013-06-28 16:45:33 +12:00
Ingo Schommer
09b31c642f
Allow Form->forTemplate() URL access ( fixes #788 )
...
Need to specifically whitelist URL-accessible actions now.
Used in "Insert Link" form in HtmlEditorField.
Regression from 1edf45fbed
2013-06-25 16:33:00 +02:00
jonom
ffc764dc3c
NEW: Allow configuration of initial insertion width for images and media
...
Moved default insertion dimensions logic from JS to PHP to allow setting through config API
2013-06-24 14:25:16 -06:00
Ingo Schommer
fb784af738
API Enforce $allowed_actions in RequestHandler->checkAccessAction()
...
See discussion at https://groups.google.com/forum/?fromgroups#!topic/silverstripe-dev/Dodomh9QZjk
Fixes an access issue where all public methods on FormField were allowed,
and not checked for $allowed_actions. Before this patch you could e.g.
call FormField->Value() on the first field by using action_Value.
Removes the following assertion because it only worked due to RequestHandlingTest_AllowedControllerExtension
*not* having $allowed_extensions declared: "Actions on magic methods are only accessible if explicitly allowed on the controller."
2013-06-24 14:50:40 +02:00
Tom Densham
3596892001
FIX: GridField button styling
...
Remove all top/bottom margins from buttons and apply to GridFieldButtonRow component. Ensure that all buttons are added to a suitable GridFieldButtonRow in ModelAdmin, SecurityAdmin and Group.
2013-06-21 14:22:00 +01:00
Ingo Schommer
da0cc25c3b
Merge pull request #2129 from tractorcow/3.1-htmleditor-mediaform-fixes
...
BUG Fixed issue in file upload via the HTML Editor media dialogue
2013-06-20 02:10:16 -07:00
Damian Mooyman
f47383f52e
BUG Fixed issue where file upload via the HTML Editor media dialogue would not prompt users to overwrite existing files
2013-06-20 15:21:18 +12:00