Damian Mooyman
25f2689833
Merge pull request #4202 from jonom/fix-treedropdown-folders
...
FIX: TreeDropdownField Folder expansion
2015-05-29 10:14:46 +12:00
Damian Mooyman
e733efa195
Merge pull request #4206 from gregsmirnov/pulls/localised-moneyfield-fix
...
BUG Fixed handling of numbers in certain locales
2015-05-29 09:21:43 +12:00
Damian Mooyman
50e33b8e5e
Merge remote-tracking branch 'origin/3.1.13' into 3.1
2015-05-28 19:08:12 +12:00
Damian Mooyman
0a8f328947
Fix merge / test regressions
2015-05-28 16:59:05 +12:00
Damian Mooyman
22a35e48a9
BUG Fix malformed urls redirecting to external sites
2015-05-28 10:12:18 +12:00
Jonathon Menz
a56d08b1ae
FIX: TreeDropdownField Folder expansion
...
When viewing a Folder tree, an expansion icon was shown if the Folder had *any* children, but it should be restricted to children that are Folders.
2015-05-27 09:22:42 -07:00
3Dgoo
23c098cd20
Fixed typo in GridField API doc
2015-05-27 10:04:16 +09:30
Loz Calver
68d8df4e04
FIX: DropdownField didn't consider disabled items
2015-05-22 21:14:11 +01:00
Loz Calver
dfb9b76b95
Add validation for GroupedDropdownField ( closes #3923 )
2015-05-22 20:55:54 +01:00
Gregory Smirnov
f9bdf61b6f
BUG Fixed handling of numbers in certain locales
2015-05-20 12:18:34 +01:00
Kamran Vighio
20c9d6f02e
Implement validate() method for TextField to validate max length ( closes #4073 )
2015-05-19 09:36:51 +01:00
Jonathon Menz
c6bcfea3e3
BUG: FieldList::changeFieldOrder() leftovers discarded
...
Logical error. Use of + operator means items from second array are only merged if the key does not already appear in the first array. The first array has numeric keys 0,1,2 etc. The second array is keyed by field name, but array_values() resets the keys to be numberic starting at 0. This means that some or all leftovers are discarded instead of appended.
2015-05-17 09:09:35 -07:00
Stevie Mayhew
9e8a5c9ba5
FIX: remove validation type constraint from form fields for 3.2 release
2015-05-11 12:32:00 +12:00
Will Rossiter
828ad6eeca
FIX: Modifications to GridFieldExportButton to allow ArrayList use in SS_Report
2015-05-07 08:43:22 +12:00
Damian Mooyman
4cacebdb88
Merge pull request #4128 from assertchris/clean-up-label-field
...
Clean up LabelField
2015-05-01 10:10:12 +12:00
Christopher Pitt
e1df8ec2fc
Clean up LabelField
2015-04-30 16:21:33 +12:00
Christopher Pitt
05c2d04b42
Clean up HeaderField
2015-04-30 16:19:58 +12:00
Christopher Pitt
f1524d9d31
Clean up HiddenField
2015-04-30 11:53:50 +12:00
Christopher Pitt
4c6ec7afd9
Clean up LiteralField
2015-04-30 11:53:02 +12:00
Christopher Pitt
7963a0b870
Clean up EmailField
2015-04-30 11:52:49 +12:00
Christopher Pitt
53cf2929d4
Clean up TextareaField
2015-04-30 11:52:37 +12:00
Christopher Pitt
c59eb1bb70
Clean Up ToggleCompositeField
2015-04-30 11:52:21 +12:00
Christopher Pitt
fe08447fc0
Clean up PasswordField
2015-04-30 11:20:46 +12:00
Stevie Mayhew
0d94cf15a5
UPDATE: change all instances of $this->request to use appropriate getter/setter
2015-04-30 11:04:08 +12:00
Ingo Schommer
4c165d42fe
Merge pull request #4110 from assertchris/clean-up-text-field
...
Clean up TextField
2015-04-27 12:11:18 +12:00
Christopher Pitt
3e3139d7c7
Clean up TextField
2015-04-27 12:02:34 +12:00
Christopher Pitt
6d19006cab
Clean up Validator
2015-04-27 11:39:18 +12:00
Patrick Nelson
bfd8b6663a
FIX for #4104 , minor revision of error messages in ListboxField (more intuitive).
2015-04-25 18:26:11 -04:00
Damian Mooyman
e0b7bc9cda
Merge pull request #4054 from dnadesign/fixToPrintButton
...
fixing print functionality if passed arrayData
2015-04-22 09:34:22 +12:00
Christopher Pitt
5231dc7cc7
Abstracting GridField row class generation
2015-04-20 15:34:10 +12:00
Christopher Pitt
2d9a003168
Add row and cell generator methods
2015-04-17 12:45:45 +12:00
John Milmine
c5006be3d6
fixing print functionality if passed array data
2015-04-01 21:55:24 +13:00
Damian Mooyman
43f49e8434
Merge remote-tracking branch 'origin/3.1' into 3
...
Conflicts:
admin/code/ModelAdmin.php
control/Director.php
model/SQLQuery.php
security/Member.php
tests/control/HTTPTest.php
tests/model/SQLQueryTest.php
tests/security/SecurityTest.php
tests/view/SSViewerTest.php
2015-03-31 19:54:15 +13:00
Daniel Hensby
aba0b70964
FIX GridFieldDetailForm::setItemEditFormCalback broke chaining
2015-03-23 15:16:09 +00:00
Loz Calver
c58f4c469d
Replace core uses of DataObject::has_one/has_many/many_many
2015-03-13 16:16:12 +00:00
Damian Mooyman
319b96b48b
Merge remote-tracking branch 'origin/3.1' into 3
...
Conflicts:
docs/en/02_Developer_Guides/09_Security/04_Secure_Coding.md
docs/en/05_Contributing/01_Code.md
forms/TreeDropdownField.php
model/DataObject.php
security/Member.php
tests/model/DataObjectTest.php
2015-03-11 11:40:06 +13:00
Patrick Nelson
f5f41b2f0e
FIX: Ensuring custom CMS validator uses Object->hasMethod() to respect extension decorator pattern.
2015-03-09 13:53:08 -04:00
Damian Mooyman
1770fab206
BUG Fix gridfield generating invalid session keys
2015-03-09 11:44:39 +13:00
Ingo Schommer
1a9c206d15
Merge pull request #3871 from patbolo/3173-folder-treedropdownfield
...
BUGFIX Use correct query when searching for items managed by a tree drop...
2015-03-08 23:23:03 +13:00
Damian Mooyman
87adc44469
BUG Fix serialised stateid exceeding request length
2015-03-05 15:00:38 +13:00
Jean-Fabien Barrois
f9d493dff5
BUGFIX Fixes case insensitive search for postgres databases
2015-03-02 09:55:29 +13:00
Jean-Fabien Barrois
bbe27999eb
BUGFIX Use correct query when searching for items managed by a tree dropdown field #3173
2015-02-27 11:18:27 +13:00
Damian Mooyman
8b2ad80c8f
Merge pull request #3921 from chillu/pulls/remove-grouped-dropdown-validate
...
Remove GroupedDropdownField::validate() (regression)
2015-02-23 08:39:50 +13:00
John Milmine
fa9cbb74ce
checking for destroy
...
needed if field is passed array data rather than objects.
2015-02-21 23:03:34 +13:00
Ingo Schommer
750e81b7cf
Remove GroupedDropdownField::validate() (regression)
...
Regression caused by 41ea83b337
,
which introduced field validation in the parent class without
also adapting this subclass.
Fixing the immediate issue (can't save this field type),
as a first step to the actual fix (implementing validate).
See https://github.com/silverstripe/silverstripe-translatable/issues/179
2015-02-21 16:15:03 +13:00
Damian Mooyman
dff65867cc
Merge remote-tracking branch 'origin/3.1' into 3
...
Conflicts:
control/HTTP.php
control/HTTPResponse.php
docs/en/05_Contributing/01_Code.md
forms/CompositeField.php
forms/FormAction.php
forms/FormField.php
forms/InlineFormAction.php
forms/NumericField.php
forms/TreeDropdownField.php
forms/TreeMultiselectField.php
templates/forms/TreeDropdownField.ss
tests/core/CoreTest.php
tests/forms/NumericFieldTest.php
tests/model/DataDifferencerTest.php
2015-02-20 10:17:19 +13:00
Phill Price
907944cdf3
Update CheckboxSetField.php
...
Updated example to work in api - as DropdownField does.
2015-02-17 10:05:27 +00:00
Phill Price
9971de6eff
Update InlineFormAction.php
...
typo fix
2015-02-16 20:19:53 +00:00
Sean Harvey
cebc0d08c5
Merge pull request #3894 from tractorcow/pulls/3.1/encoding-fixes
...
BUG Lots of encoding fixes
2015-02-16 09:18:41 +13:00
Ben Speakman
f9a61a6802
Use double quotes to escape quotes in CSV export
...
Resolves #3895
2015-02-13 10:10:52 +00:00
Damian Mooyman
1db08bac88
BUG Fix FormAction title encoding
...
BUG Fix TreeMultiSelectField using the wrong label
BUG Fix encoding of selected title on TreeDropdownField
BUG Fix DataDifferencer trying to compare non-comparable fields (non-dbfield objects)
BUG: Fix issue with TreeMultiSelectField not saving
BUG: Fix issue with GridFieldPrintButton
ENHANCEMENT Instead of using multiple api calls to encode dbfield values, delegate this operation to the individual fields via forTemplate
Instead of using a new API to communicate html encoding to treeselect, just ensure all content is HTML encoded, and enable html_titles in jstree.
2015-02-13 15:50:45 +13:00
Daniel Hensby
89c14d079d
Making TreeMultiSelectField consistent with parent class
...
NEW TreeDropdownField sanatiser helper added
Use config for default_cast of objects
FIX Determine if Diffed value should be escaped
Forcing casting for core DB fields
Fixing permissions labels
2015-02-13 11:12:30 +13:00
Damian Mooyman
518045257e
BUG Fixed handling of numbers in certain locales.
...
Fixes #2161
2015-02-13 10:50:00 +13:00
Ingo Schommer
5f31983ded
NEW: updateAttributes hook in FormField
2015-02-08 19:14:31 +13:00
Daniel Hensby
a0f9535dd4
FIX issue where empty composite fields created a fieldlist with empty items
2015-02-06 10:58:01 +00:00
Loz Calver
bea6107f67
Merge pull request #3793 from dhensby/pulls/default-form-attributes
...
API Adding default_classes config option for Form and FormField
2015-02-03 14:08:24 +00:00
Will Rossiter
abd1e6b856
FIX GridFieldExportButton should honour can method.
2015-02-03 16:21:37 +13:00
Will Rossiter
e724d6f578
BUG notice level error when value is not set on CreditCardField
2015-01-31 11:15:52 +13:00
Daniel Hensby
6103d66116
Fix issue where TreeDropdownField loses value on show/hide
...
Fixes https://github.com/silverstripe/silverstripe-cms/issues/1157
2015-01-27 11:53:53 +00:00
Daniel Hensby
5d4c2c4b34
API Adding default_classes to FormField
2015-01-20 13:36:32 +00:00
Daniel Hensby
6d0002780d
API Adding default_classes to Form
2015-01-20 13:36:31 +00:00
Damian Mooyman
88fdc75456
Merge remote-tracking branch 'composer/3.1' into 3
...
Conflicts:
.editorconfig
docs/en/00_Getting_Started/00_Server_Requirements.md
docs/en/00_Getting_Started/01_Installation/04_Other_installation_Options/Windows_IIS7.md
docs/en/00_Getting_Started/01_Installation/04_Other_installation_Options/Windows_Platform_Installer.md
docs/en/00_Getting_Started/04_Directory_Structure.md
docs/en/00_Getting_Started/index.md
docs/en/01_Tutorials/01_Building_A_Basic_Site.md
docs/en/01_Tutorials/02_Extending_A_Basic_Site.md
docs/en/01_Tutorials/03_Forms.md
docs/en/01_Tutorials/04_Site_Search.md
docs/en/01_Tutorials/05_Dataobject_Relationship_Management.md
docs/en/01_Tutorials/index.md
docs/en/02_Developer_Guides/00_Model/01_Data_Model_and_ORM.md
docs/en/02_Developer_Guides/00_Model/11_Scaffolding.md
docs/en/02_Developer_Guides/01_Templates/06_Themes.md
docs/en/02_Developer_Guides/03_Forms/How_Tos/Simple_Contact_Form.md
docs/en/02_Developer_Guides/05_Extending/05_Injector.md
docs/en/02_Developer_Guides/09_Security/04_Secure_Coding.md
docs/en/02_Developer_Guides/10_Email/index.md
docs/en/02_Developer_Guides/11_Integration/01_RestfulService.md
docs/en/02_Developer_Guides/12_Search/01_Searchcontext.md
docs/en/02_Developer_Guides/14_Files/index.md
docs/en/02_Developer_Guides/15_Customising_the_Admin_Interface/03_CMS_Layout.md
docs/en/02_Developer_Guides/15_Customising_the_Admin_Interface/06_Javascript_Development.md
docs/en/02_Developer_Guides/15_Customising_the_Admin_Interface/How_Tos/Customise_CMS_Tree.md
docs/en/02_Developer_Guides/15_Customising_the_Admin_Interface/How_Tos/Customise_Site_Reports.md
docs/en/02_Developer_Guides/18_Cookies_And_Sessions/01_Cookies.md
docs/en/04_Changelogs/3.1.9.md
docs/en/05_Contributing/00_Issues_and_Bugs.md
docs/en/05_Contributing/02_Release_Process.md
docs/en/05_Contributing/03_Documentation.md
filesystem/File.php
filesystem/GD.php
model/DataDifferencer.php
model/Versioned.php
security/BasicAuth.php
security/Member.php
tests/filesystem/FileTest.php
tests/forms/uploadfield/UploadFieldTest.php
tests/model/VersionedTest.php
tests/security/BasicAuthTest.php
2015-01-15 18:52:46 +13:00
Elvinas L
cee7adc12c
FIX. Placeholder isn't completely translated
2015-01-15 14:15:03 +13:00
Damian Mooyman
7816875e92
Fix file and uploadfield permissions
2015-01-12 10:56:25 +13:00
Elvinas L
5637431a3f
FIX: The method 'name' does not exist on 'Form'
2015-01-07 20:59:05 +00:00
Loz Calver
6ad8f7c3dd
NEW: Subject line for email links in HtmlEditorField
2014-12-15 21:56:10 +00:00
Gordon Anderson
fba688018f
ENHANCEMENT: Additional extension points for Tiny MCE editing, for when images are regenerated and manipulating the HTML prior to a save
2014-12-10 14:54:12 +07:00
Damian Mooyman
6bdd30c19d
BUG Fix gridfield storing duplicate data in session
2014-12-09 10:38:42 +13:00
Phill Price
ff67b5ba84
Update DropdownField.php
...
Update to DropdownField::create, and in one instance set the Empty Title on the instantiation, rather than afterwards.
2014-11-22 21:01:08 +00:00
Damian Mooyman
0b1f297873
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
.travis.yml
README.md
admin/code/LeftAndMain.php
admin/css/screen.css
admin/scss/screen.scss
api/RestfulService.php
conf/ConfigureFromEnv.php
control/injector/ServiceConfigurationLocator.php
control/injector/SilverStripeServiceConfigurationLocator.php
core/ClassInfo.php
core/Object.php
css/AssetUploadField.css
css/ComplexTableField_popup.css
dev/CSSContentParser.php
dev/DevelopmentAdmin.php
docs/en/changelogs/index.md
docs/en/misc/contributing/code.md
docs/en/reference/execution-pipeline.md
filesystem/GD.php
filesystem/ImagickBackend.php
filesystem/Upload.php
forms/Form.php
forms/FormField.php
forms/HtmlEditorConfig.php
forms/gridfield/GridFieldDetailForm.php
forms/gridfield/GridFieldSortableHeader.php
lang/en.yml
model/Aggregate.php
model/DataList.php
model/DataObject.php
model/DataQuery.php
model/Image.php
model/MySQLDatabase.php
model/SQLQuery.php
model/fieldtypes/HTMLText.php
model/fieldtypes/Text.php
scss/AssetUploadField.scss
search/filters/SearchFilter.php
security/Authenticator.php
security/LoginForm.php
security/Member.php
security/MemberAuthenticator.php
security/MemberLoginForm.php
security/Security.php
tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsFormsContext.php
tests/control/HTTPTest.php
tests/control/RequestHandlingTest.php
tests/filesystem/UploadTest.php
tests/forms/FormTest.php
tests/forms/NumericFieldTest.php
tests/model/DataListTest.php
tests/model/DataObjectTest.php
tests/model/TextTest.php
tests/security/MemberAuthenticatorTest.php
tests/security/SecurityDefaultAdminTest.php
tests/view/SSViewerCacheBlockTest.php
tests/view/SSViewerTest.php
2014-11-18 12:45:54 +13:00
Stevie Mayhew
41ea83b337
FEATURE: add validation to form field subclasses
2014-11-17 08:17:38 +13:00
Damian Mooyman
8aee968ab1
Merge pull request #3634 from jedateach/pr/gridfield-footer-simple
...
NEW: Make the record count in GridFieldFooter optional
2014-11-14 10:36:25 +13:00
Damian Mooyman
7f2161d7a0
Merge pull request #3599 from kinglozzer/numericfield-whitespace
...
Fix whitespace issues in NumericField/NumericFieldTest
2014-11-14 10:31:21 +13:00
Jeremy Shipman
d7eb2757fe
NEW: Make the record count in GridFieldFooter optional
2014-11-14 09:56:39 +13:00
Loz Calver
b9ef20799f
Update HtmlEditorConfig::enablePlugins() to return instance
2014-11-10 10:07:45 +00:00
Loz Calver
76b833dfbb
Fix whitespace issues in NumericField/NumericFieldTest
2014-11-03 09:13:54 +00:00
muskie9
082c49c1b5
Bugfix NumericField shows (none) for 0 on readonly
2014-11-02 20:57:20 -06:00
Stephen McMahon
20af30ed98
FIX GridFieldExportButton exporting only Paginated list when using ArrayList as source
2014-10-27 11:03:00 +11:00
Damian Mooyman
5d27ea4be1
BUG File attach handler is no longer accessible if attachment is disallowed or disabled
2014-10-24 11:31:33 +13:00
Michael
f131f0f561
Update DropdownField.php
2014-10-23 11:42:59 +01:00
Damian Mooyman
53c40a94fa
API Enable re-authentication within the CMS if a user session is lost
...
BUG Resolve issue with error redirection being ignored within CMS
BUG Fix issue with invalid securityID being re-emitted on failure
2014-10-14 15:19:48 +13:00
Milan Jelicanin
bad9aa1a48
FIX: i18n support in LookupField
...
Fixed i18n support in LookupField when value is empty (read-only complement of DropdownField)
2014-10-09 17:43:29 +02:00
Thierry François
bbc1cb8270
FIX #3458 iframe transport multi file upload FIX #3343 , FIX #3148
...
UploadField now handles multiple file upload through iframe transport
correctly (mainly for IE) as well as upload errors on a per file basis.
2014-09-26 10:48:41 +03:00
Sean Harvey
f7af0d8955
Merge pull request #3398 from dnadesign/fixsortableheader
...
API: Add ClassInfo::table_for_object_field to return the table name for ...
2014-09-26 11:14:33 +12:00
Will Rossiter
920978df99
API: Add ClassInfo::table_for_object_field
...
Returns the table name for a field in a class hierarchy.
This issue raised itself with GridFieldSortableHeader not supporting sorting on fields from parent class fields.
2014-09-26 10:38:31 +12:00
Will Rossiter
265a34141e
GridFieldDeleteAction missing button text without icons
...
The text on the button is hidden from view via CSS already. This allows the button to have text in the event that the GridField does not provide icons (and likely is better for your screen readers).
2014-09-01 21:58:07 +12:00
Will Rossiter
3644110349
FIX: Ensure that columns are unique within a gridfield
2014-09-01 21:50:36 +12:00
Will Rossiter
0991477e5a
Add support for directly saving into a File object
...
saveInto() assumed you were either saving into a hasOne or if you wanted to create a new object.
This made it impossible to have a FileField on an object that you wanted to upload to. This adds a check so that if the local object is a file, save to that.
2014-08-31 15:59:17 +12:00
Sean Harvey
07eef2ece2
Removing deprecated class/functions marked for deprecation in 3.0/3.1
2014-08-25 12:06:05 +12:00
Sean Harvey
0e07f1a7f5
Merge remote-tracking branch 'origin/3.0' into 3.1
2014-08-22 17:50:36 +12:00
Ingo Schommer
1661213e5b
FIX Opt-out pf form message escaping ( fixes #2796 )
...
This fixes a limitation introduced through http://www.silverstripe.org/ss-2013-008-xss-in-numericfield-validation/ .
Form messages used to accept HTML, now they’re escaped by default, effectively removing the ability
to pass in HTML and take care of escaping manually.
We pass through HTML to message in core through the CTF system, so this needs to be fixed.
It’s an alternative fix to https://github.com/silverstripe/silverstripe-framework/pull/2803 .
2014-08-22 16:59:34 +12:00
Damian Mooyman
eb069e605d
Remove all redundant whitespace
2014-08-19 09:17:15 +12:00
Sean Harvey
404478b07f
Removing @deprecated 3.1 functionality and classes.
...
Changelog has been updated to include what was removed in terms of
major functionality, and what to use as a replacement.
2014-08-18 16:00:13 +12:00
Mateusz Uzdowski
efbc3b3a81
Move the link-tracking into the cms to remove the SiteTree dependency.
...
Depends on 8996b67c13a773c3339f45d91bf2378a39e5178a in the cms module.
2014-08-14 10:13:14 +12:00
Mateusz Uzdowski
8bf3853887
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
docs/en/misc/contributing/issues.md
docs/en/reference/uploadfield.md
forms/HtmlEditorField.php
i18n/i18n.php
javascript/HtmlEditorField.js
model/DB.php
model/Image.php
model/SQLQuery.php
2014-08-14 09:08:26 +12:00
John Milmine
e7d5537f34
Added hasMethod so that you can pass ArrayData to GridField
2014-08-07 20:55:34 +10:00
Sean Harvey
1759d5d017
API Use "number" HTML5 type for NumericField by default
2014-08-04 14:27:35 +12:00
Mateusz Uzdowski
31c9fb52d1
BUG Fix the anchor selector to work for internal pages.
...
Currently it will only default to pulling in anchors from the current
page, from the editor.
2014-08-01 10:36:34 +12:00
Damian Mooyman
0e78e3f3dc
API Let update interval of tinymce be changed or disabled
2014-07-28 13:54:02 +12:00
Will Rossiter
5a14b7227c
Moved checkboxset option list generation to separate method
...
This allows subclasses and extensions time to modify the list of options and their configuration without having to override the entire Field method.
A more flexible way to implement silverstripe#3311
2014-07-25 11:27:14 +12:00