Commit Graph

21319 Commits

Author SHA1 Message Date
Andre Kiste
1ac8665aa9
Merge pull request #8510 from open-sausages/pulls/4/remove-legacy-article
DOC Remove buggy example form the _Show Help Text on CMS Form Fields_
2018-10-26 14:21:08 +13:00
Andre Kiste
bed1906f73
Fix typo 2018-10-25 15:59:02 +13:00
Sam Minnée
e72fc9e3d0 FIX DataObject singleton creation (#8516)
Ensure DataObject instances are aware they are singletons so functions like populateDefaults() can be skipped. (fixes #4878)

Correctly applies https://github.com/silverstripe/silverstripe-framework/pull/7850 to the 4.x line
This has already been fixed in 3.x
2018-10-25 11:42:45 +13:00
Daniel Hensby
b47d9abd7c
Merge pull request #8488 from open-sausages/pulls/4/update-pattern-lib-doc
MINOR Update doc to explain how to use and build the pattern lib
2018-10-24 17:33:46 +01:00
Aaron Carlino
a3a4f48cb7 MINOR Update doc to explain how to use and build the pattern lib 2018-10-24 16:48:29 +13:00
Maxime Rainville
4e62698391 Add entry to change log about CMSPageHistoryController deprecation. (#8508)
* Add entry to change log about CMSPageHistoryController deprecation.

* Correct typo #8508

* Tweaking CMS History controller changelog entry #8508
2018-10-24 15:27:15 +13:00
Will Rossiter
66a404ad1a FIX use Injector for FormField::castedCopy
Allows LookupField to be replaced with user specificed classes.
2018-10-24 12:13:14 +13:00
Luke Fromhold
364eb41754 Adding $Up. prefix to $ColumnCount references within $Fieldlist loops 2018-10-23 19:06:55 +11:00
Federico Jaramillo Martínez
e9bffe4020
Update comment about locks in MySQL
MySQL 5.7.5 and newer allow for multiple lock form the same session. This information is now reflected in the comment.
2018-10-22 22:33:16 -05:00
Maxime Rainville
40e542de2d DOC Remove buggy example form the _Show Help Text on CMS Form Fields_ article 2018-10-23 16:04:54 +13:00
Maxime Rainville
022e0b971e
Merge pull request #8492 from open-sausages/pulls/4.3/fix-single-look-up-field-value
MINOR Correct implementation of single lookup
2018-10-23 13:20:38 +13:00
Maxime Rainville
af46381dca MINOR Correct implementation of single lookup field when valueToLabel returns null 2018-10-23 11:54:26 +13:00
Robbie Averill
bea4101e21 Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet 2018-10-20 20:06:02 +02:00
Robbie Averill
449b2cf291 Add tests for DefaultFormFactory 2018-10-20 19:47:11 +02:00
Robbie Averill
9ceef59e1b Merge branch '4.3' into 4 2018-10-20 18:31:04 +02:00
Robbie Averill
fd50ce6295 Add more edge case tests for disabled DateFields and DatetimeField 2018-10-20 18:29:07 +02:00
Robbie Averill
97209bc919 Add edge case unit tests for DateField 2018-10-20 18:15:42 +02:00
Robbie Averill
0e2847e289 Add tests for DatalessField 2018-10-20 17:59:55 +02:00
Daniel Hensby
88d78dfd95
Merge pull request #8505 from creative-commoners/pulls/4.3/defensive-extensions
FIX getExtensionInstance can return null, add a case to handle that
2018-10-20 16:58:55 +01:00
Robbie Averill
c06cf4820e BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config 2018-10-20 17:47:16 +02:00
Robbie Averill
d56bad7568 Add tests for edge cases in CurrencyField 2018-10-20 17:33:59 +02:00
Robbie Averill
8929b8204f More validation tests for ConfirmedPasswordField 2018-10-20 17:21:25 +02:00
Robbie Averill
c418ee2915 NEW Add getters and setters for public properties in ConfirmPasswordField, add tests
Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests
2018-10-20 16:43:49 +02:00
Robbie Averill
60b375d995 Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs 2018-10-20 15:44:23 +02:00
Robbie Averill
3cdb73bd44 NEW Add getLogger() to MonologErrorHandler and add test for exception without one 2018-10-20 15:00:08 +02:00
Robbie Averill
5bd05a2deb Reduce setUp visibility and remove check for CLI - tests always run on CLI now 2018-10-20 14:51:53 +02:00
Robbie Averill
9911c9c9ef Use single quotes and getters over direct prop access in HTTPOutputHandler 2018-10-20 14:51:08 +02:00
Robbie Averill
2694a47c45 Add more tests for DetailedErrorFormatter 2018-10-20 14:41:45 +02:00
Robbie Averill
73df3166b7 Switch to short array syntax in DetailedErrorFormatter, add spaces between array values 2018-10-20 14:30:15 +02:00
Robbie Averill
e211e27470 Add more unit tests for DebugViewFriendlyErrorFormatter, tidy up Director::is_ajax() return 2018-10-20 14:27:57 +02:00
Robbie Averill
7f6f5c9ec9 FIX Flush extra methods cache on DataObjects after each unit test class has finished 2018-10-20 13:59:03 +02:00
Robbie Averill
311fd62d95 FIX getExtensionInstance can return null, add a case to handle that 2018-10-19 18:12:13 +02:00
Robbie Averill
aa93598c30
DOCS Change upgrade.yml to legacy.yml to avoid confusion with .upgrade.yml from the upgrader tool 2018-10-19 17:59:55 +02:00
Robbie Averill
f40da0d552
Merge pull request #8504 from open-sausages/pulls/4.3/702-fix-enum-search-filter
BUG: Fix enum filter in Search component adding `Any` as a filter
2018-10-19 11:34:17 +02:00
bergice
a28e2e183e BUG: Fix enum filter in Search component from adding Any as a filter
Fixes #702
2018-10-19 17:05:12 +13:00
Robbie Averill
f4085300ce
Merge pull request #8495 from micmania1/bugfix/828-grapql-asset-admin-memory
BUGFIX #828 optimised query in graphql asset admin
2018-10-18 11:36:51 +02:00
Sam Minnée
24b9dbc8ef
Merge pull request #8490 from creative-commoners/pulls/4.3/minor-db-tweaks
NEW Some minor refactoring of the PDO and MySQLi connectors
2018-10-18 22:11:29 +13:00
micmania1
1e83dff4ed BUGFIX #828 optimised query in graphql asset admin 2018-10-18 18:34:03 +13:00
Luke Edwards
b8bb4f7f4e
Merge pull request #8483 from open-sausages/pulls/4/666-fix-enter-form-submission
BUG: Fix `ENTER` not triggering form save button as `GridField`s used `submit` type buttons
2018-10-18 15:07:37 +13:00
bergice
a6a1743997 BUG: Fix ENTER not triggering form save button as GridFields used submit type buttons 2018-10-18 12:37:24 +13:00
Robbie Averill
e4078821a8
Merge pull request #8469 from open-sausages/pulls/4/sense-and-extensibility
DOCS: New nested fields, args for ApolloGraphQLManager
2018-10-18 00:24:30 +02:00
Aaron Carlino
3fcbeaddef Reverse argument signature of pathed query properties 2018-10-18 11:22:51 +13:00
Aaron Carlino
1f6a84bd8b Add docs for new args/fields API 2018-10-18 11:22:51 +13:00
Robbie Averill
7ebcb7f30e
Merge pull request #8489 from open-sausages/pulls/4.3/reduxaposition
REGRESSION: TabSet no longer structural
2018-10-17 23:01:46 +02:00
Robbie Averill
437e53f2fe NEW Some minor refactoring of the PDO and MySQLi connectors
Some small performance optimisations (not using callables in loops, switch strval for string
casting), Config call updates and replace call_user_func_array with direct variadic call.
Also removes some redundant else statements after returns.
2018-10-17 12:54:42 +02:00
Robbie Averill
ee23a70ae6
Merge pull request #8486 from open-sausages/pulls/4.3/just-turning-a-page
BUG Gridfield pagination detected as form change
2018-10-17 11:35:26 +02:00
Aaron Carlino
57756f38cb Revert bd6c4fd 2018-10-17 14:54:03 +13:00
Luke Edwards
c35e18110b BUG Gridfield pagination detected as form change 2018-10-17 11:54:32 +13:00
Robbie Averill
7be9e6e9c1
Merge pull request #8485 from DorsetDigital/patch-8
Update admin example code
2018-10-16 14:47:57 +02:00
DorsetDigital
97091db863
Update admin example code
Added an additional config block to the example code to set the AdminRootController.url_base config option as well and updated the description.
2018-10-16 11:45:02 +01:00