ca56e8d78e
[CVE-2019-12246] Denial of Service on flush and development URL tools
2019-06-10 17:23:56 +12:00
654156d46d
FIX: Fix bug when confirmed password is changed but not the password. ( #9012 )
...
In this case the confirmed password field is not reflected. It’s
unclear how often this situation would arise outside of test scenarios,
but may come up if $form->loadDataFrom() is called more than once.
Fixes #2496 (it’s a minor issue but I think this is why Dan flagged it
as a regression). Originally introduced as part of Dan’s initial fix
at 2a6f1f1949
2019-06-10 15:48:29 +12:00
9184056b5e
URLSegmentFilter: Remove : characters from url segments when multibyte characters are allowed.
2019-06-02 11:43:51 +03:00
00fd74a0a1
Merge branch '4.4' into 4
...
# Conflicts:
# src/Dev/Tasks/MigrateFileTask.php
2019-05-30 09:36:42 +12:00
14673ffd0a
Merge branch '4.3' into 4.4
2019-05-30 09:35:26 +12:00
188698dcee
Merge branch '4.2' into 4.3
2019-05-30 09:35:17 +12:00
3e2fc6aa0b
Automated phpcbf linting
2019-05-30 09:34:34 +12:00
f97ca26e76
Merge pull request #9014 from sminnee/fix-4142
...
FIX: List default items in the readonly view of ListboxField
2019-05-27 20:13:20 +12:00
7407096e99
FIX: List default items in the readonly view of ListboxField
...
Adds tests for non-readonly default items too.
Fixes #4142
2019-05-27 17:47:09 +12:00
2c71daacfe
MINOR: Add tests for GroupedDropdownField empty strings
...
These bugs were never present in SS4 as the relevant code had a
substantial rewrite at the same time they were introduced in SS3.
In SS3, test C still fails.
Fixes #4705
Fixes #4987
Fixes #4793
2019-05-27 17:46:03 +12:00
350888bf50
NEW Adding a shuffle method to ArrayList ( #8984 )
...
* NEW Adding a shuffle method to ArrayList
* API Add shuffle to DataList for ArrayList parity
2019-05-16 09:26:11 +12:00
3f1479edbb
BUGFIX: DataQuery overwriting _SortColumn selects ( #8974 )
...
* BUGFIX: DataQuery overwriting _SortColumn selects
* FIX DataQuery _SortColumn handling
2019-05-15 11:42:10 +12:00
8ee50d2ba7
API Remove DataObjectSchema::getFieldMap() ( #8960 )
...
Introduced as a less public API in https://github.com/silverstripe/silverstripe-assets/pull/227
2019-05-06 12:33:23 +12:00
82c8225502
Merge branch '4.3' into 4.4
2019-05-03 09:45:25 +12:00
3d777cfb8a
Backward compatible behaviour for SQLConditionalExpression::getJoins
2019-05-02 15:39:36 +12:00
0c6c57f1ef
Add `getFieldMap` method to retrieve a list of all fields for any giv… ( #8892 )
...
* Add `getFieldMap` method to retrieve a list of all fields for any given class
* Add `TagsToShortcodeTask` to upgrading guide
Adding after the file migration part as this is where it makes the most sense to run it.
* `getFieldMap` accepts an array
* Move to `DataObjectSchema`
* Add `HTMLVarchar` to documentation
Minor refactoring
* Add test for checking that `subclassesfor` works without the base class
Add test `DataObjectSchema::getFieldMap` returns the correct array
* Remove cms dependency
2019-04-30 10:43:14 +12:00
c63eecc3e1
Merge branch '4.3' into 4
2019-04-18 11:57:36 +12:00
155a9bb1f9
Merge pull request #8934 from creative-commoners/pulls/4.4/pdostgresql-boolean-consistency
...
FIX Postgres booleans should return as int for consistency
2019-04-17 15:43:35 +12:00
da1af3d8b0
FIX Postgres booleans should return as int for consistency
2019-04-17 15:15:17 +12:00
cc1fdf603b
Resolve incorrect empty string assertion in tests
2019-04-17 13:29:54 +12:00
9d6b5048a6
FIX Table aliases are retained on base tables in queries built using SQLConditionalExpression ( #8918 )
...
* Adding failing test for base table aliases using SQLSelect
* FIX Retain table aliases applied to the base table on queries
* FIX Move the trimmed alias outside of the condition so we can use it within the condition
2019-04-16 15:40:09 +12:00
66c372ce28
Include baseURL with relative setGetVar() links ( #8834 )
...
* Return baseURL with setGetVar
* Adjust testSetGetVar tests for base url
2019-04-15 14:50:46 +12:00
8a06682e31
Merge branch '4.3' into 4
...
# Conflicts:
# src/ORM/Connect/DBSchemaManager.php
2019-04-11 11:24:17 +12:00
d295888838
MINOR: Improve type testing
2019-04-05 15:11:21 +13:00
2625cea5e3
MINOR: Add a test that 0 is falser on int, decimal, currency
...
Validates that https://github.com/silverstripe/silverstripe-framework/issues/3473 has been fixed
The bug was fixed in #8448
2019-04-05 15:11:21 +13:00
4f4153c834
MINOR: Test test to validate that multiple GreaterThan filters in a filterAny work.
...
Confirms https://github.com/silverstripe/silverstripe-framework/issues/3995 isn’t a bug.
2019-04-05 15:05:42 +13:00
123d483213
MemberTest and SecurityTest now set the default authenticator to use
2019-04-05 11:26:29 +13:00
a9d57f5bfb
Merge pull request #8241 from creative-commoners/pulls/4.3/separate-logging
...
Separate core error logging from standard LoggerInterface
2019-04-05 08:49:09 +13:00
fc6213c293
Merge branch '4.3' into 4
2019-03-27 13:25:57 +13:00
e1190e33d2
Fix PDOConnector GeneratedID return type
2019-03-21 09:26:14 +01:00
388baa01b4
Fix linting
2019-03-20 13:19:10 +13:00
aa491d9294
Fix tests
2019-03-20 12:33:00 +13:00
6b450395ce
API Allow empty arraylists to be typed ( #8866 )
...
* API Allow empty arraylists to be typed
* PHPCBF fixes
2019-03-20 11:46:35 +13:00
765d1568ab
Merge branch '4.3' into 4
2019-03-06 11:04:50 +00:00
a8605b04e0
Merge branch '4.2' into 4.3
2019-03-06 11:04:14 +00:00
d1396b7dfe
BUG Fix writeBaseRecord with unique indexes
...
Fixes #6819
2019-02-27 16:40:12 +13:00
11b9429c34
Merge branch '4.3' into 4
2019-02-27 12:14:51 +13:00
651d537196
Merge branch '4.2' into 4.3
2019-02-27 12:13:24 +13:00
ed013fcfbb
Merge branch '4.1' into 4.2
2019-02-27 12:12:39 +13:00
ac53f77115
Merge branch '4.0' into 4.1
2019-02-27 12:11:47 +13:00
6ff319a0e1
BUG Implement peer review feedback,
2019-02-27 11:14:47 +13:00
9a59f2f57d
BUG Renable the ability to do dynamic assignment with DBField
2019-02-22 11:08:43 +13:00
3e90fdf42f
Merge branch '4.3' into 4
2019-02-19 08:41:05 +07:00
ed74549c4f
Merge branch '4.2' into 4.3
2019-02-19 08:39:59 +07:00
79e44b42fa
Merge branch '4.1' into 4.2
2019-02-19 08:37:07 +07:00
cb7f15a681
Merge branch '4.0' into 4.1
2019-02-19 08:36:41 +07:00
09c539e1c3
Merge branch '4.3' into 4
2019-02-19 12:21:24 +13:00
25bba49923
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-19 12:20:24 +13:00
95505db7d6
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-12 21:08:09 +13:00
fd90cf6ceb
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-12 20:44:17 +13:00
7c5b73881b
FIX: Prevent null->null being flagged as a value change ( fixes #8774 )
2019-02-06 13:24:18 +13:00
d116b9a8d2
Add test for shortcode parsing with querystring and anchor
2019-01-29 13:15:17 +02:00
a589bcb092
Merge pull request #8729 from emteknetnz/bugfix/htmlvalue-getcontent
...
Ensure document is not falsey before attempting to clone it
2019-01-29 09:11:04 +13:00
d00c59c383
Fix tests not loading fixtures and loading themes in CWP recipe kitchen sink
2019-01-28 13:34:52 +02:00
d28552915d
Add unit test for an invalid HTMLValue
2019-01-25 15:55:03 +13:00
d8cd085190
Merge branch '4.3' into 4
2019-01-24 17:14:09 +02:00
e087e564e1
Fix tests not loading fixtures and loading themes in CWP recipe kitchen sink
2019-01-24 16:45:38 +02:00
13486ca80e
MINOR Add unit test for Requirements::add_i18n_javascript()
2019-01-16 10:36:53 +13:00
34ac228029
BUG Fix issue with assertListEquals() ignoring field getters
2019-01-11 11:35:11 +13:00
1e01deea39
NEW Make resources dir configurable ( #8519 )
...
* NEW Make resources dir configurable.
* Removing reference to old `resources` and updating doc #8519
* Rrtarget to 4.4 release.
* DOC Reference SS_RESOURCES_DIR in Environment doc.
* API Add a Resources method to SilverStripe\Core\Manifest\Module to read the resources-dir from composer.json
* Clean up reference to SS_RESOURCES_DIR env var
* Set default resources-dir
* Update test to use RESOURCES_DIR const in expected resource url method
* Correcting typos
Co-Authored-By: maxime-rainville <maxime@rainville.me>
* MINOR Correctubg minor typos
* DOCS Document the intricacies of exposing static assets.
2019-01-09 15:35:45 +13:00
7c96feef37
Merge branch '4.3' into 4
2019-01-08 12:27:48 +01:00
394dd4765c
NEW Scaffolded field labels now only have an uppercased first word
2019-01-07 17:52:28 +01:00
7d1aa44786
Merge pull request #8654 from creative-commoners/pulls/4.3/password-complexity-test-fixes
...
Update tests to pass in CWP kitchen sink context
2018-12-13 16:50:25 +13:00
470093de2f
Merge pull request #8650 from sminnee/nested-vendor
...
FIX: Manifest should ignore vendor folders within packages contained in vendor
2018-12-12 19:52:03 +00:00
fcc37350a1
Merge branch '4.3' into 4
2018-12-12 12:17:37 +00:00
f7846fc34c
FIX behat CmsUiContext waits for cms-loading-container after step
2018-12-10 16:49:57 +13:00
5d7c5ffb07
Merge branch '4.3' into 4
2018-12-06 09:40:40 +00:00
08866f89d9
Merge branch '4.2' into 4.3
2018-12-06 09:40:05 +00:00
96bd17d469
Merge branch '4.1' into 4.2
2018-12-06 09:38:45 +00:00
3f532466d1
Merge branch '4.0' into 4.1
2018-12-06 09:37:52 +00:00
6edcbe9086
Merge pull request #8592 from open-sausages/pulls/4.0/tree-multiselect-null
...
FIX TreeMultiselectField passes value 'unchanged' as null to ORM
2018-12-06 14:23:48 +13:00
1ac36611a6
Update tests to pass in CWP kitchen sink context
2018-12-02 23:04:34 +00:00
0c17ffc944
FIX: Manifest should ignore vendor folders within packages contained in vendor
...
Without this change vendor/silverstripe/framework/vendor/silverstripe/config
will be pick up by the manifest, which is inappropriate.
Although this doesn’t happen often, it can occur if you have run
“composer install” within vendor/silverstripe/framework, which can be
done either accidentally or (in my case) as part of running the
framework tests isolated from the rest of your project (which is closer
to the execution model on Travis)
Note that the presence of the ‘nestedvendor.txt’ file tests that this
works without any explicit changes to the PHP of the tests, since it’s
merely confirming that such a file is *not* picked up.
2018-11-30 13:52:25 +13:00
4ee63eb4e7
TreeMultiselectFieldTest / make scrutinizer happy
2018-11-29 12:13:56 +13:00
38f8217f01
TreeMultiselectFieldTest / setUp is protected in PHPUnit5
2018-11-29 09:55:28 +13:00
3f8551df41
Merge pull request #8462 from sminnee/nondestructive-enum
...
FIX: Make all enums non-destructive, not just ClassName
2018-11-28 16:42:12 +01:00
1f1c344272
Merge branch '4.3' into 4
...
# Conflicts:
# tests/php/Forms/ConfirmedPasswordFieldTest.php
2018-11-26 12:15:17 +01:00
41dc9229bf
FIX Reverting ExtensionTestState and Extensible extra methods modifications to prevent PHP 5.6 segfault ( #8581 )
...
* API Revert addition of Extensible::flush_extra_methods_cache() and change to ExtensionTestState
This reverts the changes from #8465 and #8505 that relate to ExtensionTestState and the
tracking of extra methods between unit tests. The existing test from #8465 testing
overloaded Extensions after extra_methods are populated has been updated to show that you
must re-add the extension to flush the extra_methods cache if you need this behaviour.
* Revert change to InjectorTest::testExtendedExtensions
* Revert "Add failing test to show that overloaded extensions are broken in Extensible"
This reverts commit 55e79ffdfd
2018-11-26 12:00:02 +13:00
f526c794fc
Minor / Refactor php tests for TreeMultiselectField
2018-11-23 16:03:44 +13:00
9ce6d91b76
FIX / TreeMultiselectField::objectForKey handles list of IDs correctly
2018-11-22 12:11:18 +13:00
d74af1c17e
FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621
2018-11-21 11:43:21 +13:00
80885fc231
ADD php test TreeMultiselectField::testEmptyChoiceReadonly
2018-11-20 16:45:23 +13:00
3b1e91eb59
Merge branch '4.2' into 4.3
2018-11-15 13:41:23 +02:00
ef0f9dff8a
Merge branch '4.1' into 4.2
2018-11-15 13:41:00 +02:00
c6e3a398c7
Merge branch '4.0' into 4.1
2018-11-15 13:40:08 +02:00
b5bae137bd
FIX: Redirect loop with multiple confirmation tokens present ( fixes #8607 )
2018-11-15 10:59:42 +00:00
7d1d6d0f7b
FIX Ensure that tests setting passwords have stubbed configuration
2018-11-14 11:54:17 +02:00
0bb94b018b
FIX Remove default password validation rules before running unit tests
2018-11-13 14:09:08 +02:00
8854f053c8
Fix rebase conflicts
2018-11-13 11:09:33 +02:00
a8853504b4
API API MonologErrorHandler::setLogger is deprecated, use MonologErrorHandler::pushLogger instead
2018-11-13 11:08:27 +02:00
b2dd22fb50
Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests
...
NEW Adding a stack more unit tests for logging and some form fields
2018-11-11 10:31:24 +13:00
bab84f31dc
Remove underscores from variable test class names
2018-11-10 14:55:11 +02:00
eba92d77df
Rename CheckboxFieldReadonlyTest for future PSR-2 compatibility
2018-11-10 10:04:17 +02:00
a8d3b95175
FIX: Make test work with utf8mb4
2018-11-10 12:10:25 +13:00
bd5a815909
FIX: Make all enums non-destructive, not just ClassName
...
This change also renders a portion of DBSchemaManager irrelevant, that
destructively “fixes” old values. This is in keeping with the
non-destructive principle of dev/build, and some suggestions to move
away from enum fields altogether.
Fixes https://github.com/silverstripe/silverstripe-framework/issues/1387
2018-11-10 12:10:25 +13:00
a12a5b7168
Merge pull request #8377 from creative-commoners/pulls/4.3/bootstrap-alerts
...
NEW Use Bootstrap alerts throughout the CMS
2018-11-09 14:27:38 +02:00
0f2eebe5d4
NEW Change to variadic calls in ListDecorator and add unit tests
2018-11-09 13:59:14 +02:00
bbb208e1dd
Merge pull request #8499 from sminnee/fix-1489
...
FIX: CheckboxSetField can now save into DBMultiEnum
2018-11-09 10:40:55 +01:00
24d6527845
Merge branch '4.3' into 4
2018-11-09 11:39:27 +02:00
10f502f0c7
Merge branch '4.2' into 4.3
2018-11-09 11:39:05 +02:00
5b7723df7f
Merge branch '4.1' into 4.2
...
# Conflicts:
# lang/fi.yml
# lang/nl.yml
2018-11-09 11:38:04 +02:00
df4d2bd838
Merge branch '4.0' into 4.1
...
# Conflicts:
# lang/da.yml
# lang/eo.yml
# lang/fi.yml
# lang/it.yml
# lang/nl.yml
# lang/sv.yml
2018-11-09 11:36:34 +02:00
5531baa87f
FIX: Introduce readonly transaction test to all database.
...
This should work on MySQL and PDO; let’s test this.
2018-11-09 10:57:26 +13:00
2615399535
FIX: Use PDO’s built-in transaction support in MySQLDatabase.
2018-11-09 10:31:19 +13:00
0111b98b18
FIX: Ensure that types are preserved fetching from database
...
This ensures that numeric fields appear in PHP as int/float values
rather than strings, which allows the development of more type-safe PHP
code.
This doesn’t work on the legacy mysql driver and this will now throw
a notice-level error. It requires mysqlnd.
2018-11-09 10:31:19 +13:00
bc0f17fb09
Cleanup Convert
...
* remove unneeded parenthesis and double quotes
* simplify flow / remove unneeded else
2018-11-07 17:45:01 +01:00
3f321f935a
Convert::memstring2bytes should return integer value
...
bytes are by nature an integer
fixes #8572
2018-11-07 17:01:36 +01:00
76936d863d
Merge branch '4.3' into 4
2018-11-07 23:20:44 +13:00
11fe5b3adf
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:33:24 +13:00
8d7c2dafab
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:33:24 +13:00
02ad0f44aa
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:32:55 +13:00
af000bea9b
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:32:55 +13:00
5563537cc8
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:31:33 +13:00
0610f76da0
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:31:33 +13:00
0877442c64
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:24:51 +13:00
3dbb10625c
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:24:51 +13:00
64c2938c96
Merge branch '4.3' into 4
2018-11-06 11:05:22 +01:00
3c58ae009e
Merge branch '4.2' into 4.3
2018-11-06 11:05:08 +01:00
22c7fa2bc9
Merge branch '4.1' into 4.2
2018-11-06 11:04:43 +01:00
6d2665d687
Merge branch '4.0' into 4.1
2018-11-06 11:04:28 +01:00
adafd73943
Convert::memstring2bytes should preserve -1
...
fixes #8570
2018-11-06 10:22:13 +01:00
0ba275cb40
Merge branch '4.2' into 4.3
2018-11-06 15:09:01 +13:00
e60cea8561
Merge branch '4.1' into 4.2
2018-11-06 15:08:42 +13:00
67fe41d00b
FIX: Ensure that repeated setting/unsetting doesn’t corrode forceChange()
2018-11-05 23:09:24 +13:00
5bb2d9484a
FIX: Update “original” DataObject data to be the content of the last write
...
FIX: Compare to original when determining fields changes
This fixes a number of edge-case issues relating to change detection.
Fixes #8443
Fixes #3821
Fixes #4561
2018-11-05 23:09:24 +13:00
76255c9fb5
FIX: CheckboxSetField can now save into DBMultiEnum
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489
2018-11-05 17:40:28 +13:00
78ceca6934
MINOR: Add test for defaults on subclasses
...
This was raised in https://github.com/silverstripe/silverstripe-framework/issues/8567
and wasn’t covered by a test.
2018-11-05 16:09:49 +13:00
8866e7674a
BUG: Fix duplicate plugins on HTML editor fields ( #8559 )
...
* BUG: Fix duplicate plugins on HTML editor fields
* Add new test
2018-11-02 12:26:53 +13:00
55f95b7bc8
BUGFIX many many through not sorting by join table ( #8534 )
...
* BUGFIX many many through not sorting by join table
* #8534 added docs to support many many sorting fix
* #8534 added test cases for many_many default sorting
2018-11-01 14:17:15 +13:00
7086f2ea3a
BUGFIX many many through not sorting by join table ( #8534 )
...
* BUGFIX many many through not sorting by join table
* #8534 added docs to support many many sorting fix
* #8534 added test cases for many_many default sorting
2018-11-01 13:42:27 +13:00
b02a6fa02d
FIX Replace usage of Convert JSON methods with json_encode
2018-10-28 21:15:29 +00:00
e72fc9e3d0
FIX DataObject singleton creation ( #8516 )
...
Ensure DataObject instances are aware they are singletons so functions like populateDefaults() can be skipped. (fixes #4878 )
Correctly applies https://github.com/silverstripe/silverstripe-framework/pull/7850 to the 4.x line
This has already been fixed in 3.x
2018-10-25 11:42:45 +13:00
bea4101e21
Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet
2018-10-20 20:06:02 +02:00
449b2cf291
Add tests for DefaultFormFactory
2018-10-20 19:47:11 +02:00
fd50ce6295
Add more edge case tests for disabled DateFields and DatetimeField
2018-10-20 18:29:07 +02:00
97209bc919
Add edge case unit tests for DateField
2018-10-20 18:15:42 +02:00
0e2847e289
Add tests for DatalessField
2018-10-20 17:59:55 +02:00
c06cf4820e
BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config
2018-10-20 17:47:16 +02:00
d56bad7568
Add tests for edge cases in CurrencyField
2018-10-20 17:33:59 +02:00
8929b8204f
More validation tests for ConfirmedPasswordField
2018-10-20 17:21:25 +02:00
c418ee2915
NEW Add getters and setters for public properties in ConfirmPasswordField, add tests
...
Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests
2018-10-20 16:43:49 +02:00
60b375d995
Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs
2018-10-20 15:44:23 +02:00
3cdb73bd44
NEW Add getLogger() to MonologErrorHandler and add test for exception without one
2018-10-20 15:00:08 +02:00
5bd05a2deb
Reduce setUp visibility and remove check for CLI - tests always run on CLI now
2018-10-20 14:51:53 +02:00
2694a47c45
Add more tests for DetailedErrorFormatter
2018-10-20 14:41:45 +02:00
e211e27470
Add more unit tests for DebugViewFriendlyErrorFormatter, tidy up Director::is_ajax() return
2018-10-20 14:27:57 +02:00
c18e9b1298
Merge pull request #8439 from sminnee/consistent-limit
...
FIX: Make ArrayList::limit() consistent with DataList::limit()
2018-10-16 12:05:11 +02:00
7d201309ad
Merge branch '4.2' into 4
2018-10-15 13:42:55 +13:00
7215637673
Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield
...
API Add a new GridFieldLazyLoader component
2018-10-11 13:43:10 +02:00
46c50577a4
Expect BEM class names in tests, fix PSR-2 line lengths, add ArrayList import
2018-10-11 12:04:23 +02:00
4740346ed8
FIX: Make ArrayList::limit() consistent with DataList::limit()
...
This makes it easier to swap one fo the other without code breaking.
Since it’s strictly a removed API, I’ve opted to throw a deprecation
note in SS4 rather than throwing an InvalidArgumentException.
Fixes #2949
2018-10-11 21:05:20 +13:00
250d925810
MINOR Update CompositeField::__construct to call setChildren #8460
2018-10-11 15:25:34 +13:00
0db2f84ade
FIX Persist TinyMCE updates when writing with Behat
2018-10-11 14:34:18 +13:00
2e2ca5a4a7
Make sure LazyLoader still woks after a readonly transofrmation ( #8460 )
2018-10-11 11:56:39 +13:00
56d5621934
FIX Flush extra_methods statics between test runs
2018-10-09 13:22:54 +02:00
55e79ffdfd
Add failing test to show that overloaded extensions are broken in Extensible
2018-10-09 12:35:32 +02:00
fdb53311ba
Fix linting issue.
2018-10-09 17:32:42 +13:00
a13a2cdd40
Add unit test for FieldList::getContainerField()
2018-10-09 17:32:42 +13:00
51ba787ffb
Finish writting unit test for GridFieldLazyLoader.
2018-10-09 17:32:42 +13:00
1d1cf6882d
Merge pull request #8461 from creative-commoners/pulls/4.3/unbelabelable-dom-skills
...
NEW Adding a helper to find a form field by label content (Behat)
2018-10-08 23:22:03 +02:00
e829ad78b1
Merge pull request #8429 from sminnee/fix-2950
...
FIX: Throw deprecation on limit=0
2018-10-08 15:11:52 +02:00
2775895d03
NEW Adding a helper to find a form field by label content
2018-10-08 14:28:16 +13:00
36b1066413
Merge pull request #8451 from creative-commoners/pulls/4.3/memory-cache-findtemplate
...
NEW Add memory cache to ThemeResourceLoader::findTemplate()
2018-10-08 10:38:07 +13:00
8c7459a708
FIX: Fix CompositeField test that relied on a DropdownField bug
...
A DropdownField without a source no longer returns a validation
error.
2018-10-06 19:14:34 +13:00
e5d3b28a4d
FIX: Don’t break validation on selects without a source.
...
Fixes cases where there are no valid values or an empty-string
value is manually added rather than using setEmptyString()
Fixes #4849
Fixes #7159
2018-10-06 11:53:17 +13:00
7915fe0c0f
Merge pull request #8303 from hchokshi/pulls/4.2/viewable-data-customised-isset
...
Implement __isset for ViewableData_Customised
2018-10-06 09:37:19 +13:00
98568262f2
Fixed phpcs violations
2018-10-05 16:07:33 +02:00
da9301f241
Use SilverStripe cache API instead of memory cache, add tests and fix cache config indentation
2018-10-05 14:58:48 +02:00
172d8915b7
Clear cache between ThemeResourceLoader tests
2018-10-05 14:12:26 +02:00
0fc06e51e5
FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour.
...
Note that the medium date format depends on locale, with en_NZ being
resolutely numeric. I’ve updated the test to verify a couple of locales
to make this more obvious.
Fixes #8121
2018-10-04 14:51:24 +13:00
638e6ec281
FIX: Throw deprecation notice on limit=0
...
The SS4 behaviour of limit=0 is unlikely to be the SS5 behaviour.
To clear the limit limit=null is recommended.
In addition, there’s a bit tighter type maintenance in the internal
limit data (ensure things are int).
Fixes #2950 .
2018-10-04 10:38:15 +13:00
ee24413c30
Merge branch '4.2' into 4
2018-10-03 15:28:05 +02:00
b0871ebd75
Merge pull request #8417 from creative-commoners/pulls/4.3/many-many-through-sorting-tests
...
Add more list sorting tests and fix many many through sorting
2018-10-03 13:30:20 +02:00
d1f30a20c2
Merge pull request #8408 from dhensby/pulls/4/test-cleanup
...
Test cleanup
2018-10-03 13:28:59 +02:00
d74fed554a
Merge pull request #8427 from sminnee/fix-1397
...
FIX: Append any fields that don’t match name in insertBefore/insertAfter
2018-10-03 13:22:23 +02:00
5970fc2417
FIX Moving test to correct director
2018-10-03 10:47:17 +13:00
c8e7672ede
Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict
...
FIX Avoid having search fields with the same names as form elements
2018-10-02 13:43:59 +02:00
71dad5f685
FIX: Append any fields that don’t match name in insertBefore/insertAfter
...
Previous behaviour was to return false, which has been described as
a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397
where the issue was identified.
2018-10-02 10:39:48 +13:00
bfe2a7b7e6
Update testSearchFieldSchema to expect namespaced search fields
2018-10-01 12:44:19 +02:00
60dd5f288b
Implement __isset for ViewableData_Customised
...
Resolves #8302 .
2018-10-01 09:40:12 +13:00
3584598d7a
Minor improvements
2018-09-29 22:51:26 +01:00
b0e0566c93
Formatting
2018-09-29 22:51:26 +01:00
5a3cc9503b
Formatting
2018-09-29 22:51:26 +01:00
2ef63ddbc1
Remove unused function args
2018-09-29 22:51:26 +01:00
7a18cd98e0
Improve assertion type
2018-09-29 22:51:26 +01:00
90e74a608e
Throwing and catcing an error in tests is mad
2018-09-29 22:51:26 +01:00
3c532cea0c
Minor cleanup of DirectorTest
2018-09-29 22:51:26 +01:00
3a007d52e6
Code formatting
2018-09-29 22:51:18 +01:00
231d6d9a9f
FIX New members now receive the configured default locale, not the current locale
2018-09-28 16:25:10 +02:00
d18b8eb9fb
Add more tests for descending sort orders
2018-09-28 15:42:45 +02:00
4aa7fb70ee
Add tests that show that joinClass default_sort is not used and order is honoured
2018-09-28 15:38:37 +02:00
f842ee2eec
Update deprecation PHPDocs to be PSR-5 compliant
...
See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated
2018-09-28 10:49:14 +02:00
0c7ced1513
Refactor sorting tests to use a dataprovider
2018-09-27 17:18:19 +02:00
c7d522ff6d
Add tests for sorting HasManyList
2018-09-27 17:09:24 +02:00
3321c6b39d
Add tests for sorting many many through list without a table alias
2018-09-27 14:34:37 +02:00
b3d2d4c1b1
Remove redundant code
2018-09-26 10:11:28 +01:00
db43d57618
Remove commented out test
2018-09-26 10:11:28 +01:00
fe5b431200
Use Member::actAs rather than setting and unsetting member
2018-09-26 10:11:20 +01:00
6b618b44c9
Remove regex in favour of simple assertContains
2018-09-26 00:36:58 +01:00
cb361e8caf
Remove unused code from ControllerTest
2018-09-26 00:30:20 +01:00
Serge Latyntcev
Sam Minnée
Jarkko Linnanvirta
Robbie Averill
Guy Marriott
Aaron Carlino
Maxime Rainville
Andre Kiste
Ralph Slooten
Johannes Hammersen
Damian Mooyman
Dan Hensby
Loz Calver
Maxime Rainville
Steve Boyd
Robbie Averill
Loz Calver
Werner M. Krauß
Luke Edwards
Michael Strong
Harsh Chokshi