Commit Graph

20671 Commits

Author SHA1 Message Date
Robbie Averill
1d1cf6882d
Merge pull request #8461 from creative-commoners/pulls/4.3/unbelabelable-dom-skills
NEW Adding a helper to find a form field by label content (Behat)
2018-10-08 23:22:03 +02:00
Loz Calver
5426f34b4a
Merge pull request #8463 from creative-commoners/pulls/4.3/rm-cachedata
FIX Remove unused cacheData prop from #8451
2018-10-08 15:12:14 +02:00
Loz Calver
e829ad78b1
Merge pull request #8429 from sminnee/fix-2950
FIX: Throw deprecation on limit=0
2018-10-08 15:11:52 +02:00
Robbie Averill
c4788803ee FIX Remove unused cacheData prop from #8451 2018-10-08 12:05:29 +02:00
Guy Marriott
2775895d03
NEW Adding a helper to find a form field by label content 2018-10-08 14:28:16 +13:00
Maxime Rainville
36b1066413
Merge pull request #8451 from creative-commoners/pulls/4.3/memory-cache-findtemplate
NEW Add memory cache to ThemeResourceLoader::findTemplate()
2018-10-08 10:38:07 +13:00
Robbie Averill
7668162be9
Merge pull request #8458 from sminnee/fix-4849
FIX: Don’t break validation on selects without a source.
2018-10-06 17:38:10 +02:00
Sam Minnee
8c7459a708 FIX: Fix CompositeField test that relied on a DropdownField bug
A DropdownField without a source no longer returns a validation
error.
2018-10-06 19:14:34 +13:00
Sam Minnee
e5d3b28a4d FIX: Don’t break validation on selects without a source.
Fixes cases where there are no valid values or an empty-string
value is manually added rather than using setEmptyString()

Fixes #4849
Fixes #7159
2018-10-06 11:53:17 +13:00
Sam Minnée
28c12bfec9
Merge pull request #8457 from kinglozzer/ext-json
Add ext-json to composer platform requirements
2018-10-06 09:31:40 +13:00
Loz Calver
7f6652996c Re-order composer requirements 2018-10-05 15:52:47 +01:00
Loz Calver
df73188bc6 Add ext-json to composer platform requirements 2018-10-05 15:52:12 +01:00
Robbie Averill
98568262f2 Fixed phpcs violations 2018-10-05 16:07:33 +02:00
Robbie Averill
024762f03b Move default themes lookup before cache check 2018-10-05 15:00:32 +02:00
Robbie Averill
da9301f241 Use SilverStripe cache API instead of memory cache, add tests and fix cache config indentation 2018-10-05 14:58:48 +02:00
Robbie Averill
172d8915b7 Clear cache between ThemeResourceLoader tests 2018-10-05 14:12:26 +02:00
Robbie Averill
9ea7b58a8f NEW Add memory cache to ThemeResourceLoader::findTemplate()
For large sites, this reduces the number of file_exists, Path::join, getThemePaths etc
calls and can contribute to 26% reduction in TTFB load time
2018-10-05 14:12:26 +02:00
Maxime Rainville
d68f02ad25
Merge pull request #8393 from sachajudd/pulls/4/document-help-menu
DOCS Add docs for CMS help menu links
2018-10-05 14:02:14 +13:00
Robbie Averill
4c25894a59
Merge pull request #8446 from sminnee/fix-8121
FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour.
2018-10-04 08:38:42 +00:00
Robbie Averill
79812d10c2
Merge pull request #8441 from open-sausages/pull/4.3/refernce-new-search-in-changelog
Document new Search component in change logs.
2018-10-04 08:25:24 +00:00
Robbie Averill
9c68f0e4ac
Merge pull request #8447 from pstaender/patch-3
fixing name of constant ASSETS_PATH
2018-10-04 08:07:49 +00:00
Philipp Staender
fafd9dad6d
fixing name of constant ASSETS_PATH 2018-10-04 04:34:16 +02:00
Sam Minnee
0fc06e51e5 FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour.
Note that the medium date format depends on locale, with en_NZ being
resolutely numeric. I’ve updated the test to verify a couple of locales
to make this more obvious.

Fixes #8121
2018-10-04 14:51:24 +13:00
Maxime Rainville
14a8707bf2 Address PR feedback for Search changelog 2018-10-04 13:35:48 +13:00
Maxime Rainville
191d93697d Document new Search component in change logs. 2018-10-04 13:29:48 +13:00
Sacha Judd
f5b6ce01cf DOCS Add docs for CMS help menu links
[ci skip]
2018-10-04 10:50:57 +13:00
Sam Minnee
638e6ec281 FIX: Throw deprecation notice on limit=0
The SS4 behaviour of limit=0 is unlikely to be the SS5 behaviour.
To clear the limit limit=null is recommended.

In addition, there’s a bit tighter type maintenance in the internal
limit data (ensure things are int).

Fixes #2950.
2018-10-04 10:38:15 +13:00
Robbie Averill
ee24413c30 Merge branch '4.2' into 4 2018-10-03 15:28:05 +02:00
Robbie Averill
598e9358fd Merge branch '4.1' into 4.2 2018-10-03 15:27:51 +02:00
Robbie Averill
b0871ebd75
Merge pull request #8417 from creative-commoners/pulls/4.3/many-many-through-sorting-tests
Add more list sorting tests and fix many many through sorting
2018-10-03 13:30:20 +02:00
Robbie Averill
d1f30a20c2
Merge pull request #8408 from dhensby/pulls/4/test-cleanup
Test cleanup
2018-10-03 13:28:59 +02:00
Robbie Averill
d2b646cc13
Merge pull request #8286 from wilr/patches/mysql-create-table-issue
Check database has table before altering.
2018-10-03 13:24:59 +02:00
Robbie Averill
d74fed554a
Merge pull request #8427 from sminnee/fix-1397
FIX: Append any fields that don’t match name in insertBefore/insertAfter
2018-10-03 13:22:23 +02:00
Robbie Averill
6a5fb4999c
Merge pull request #8416 from lekoala/patch-14
raw2att accepts array, but sprintf doesn't
2018-10-03 13:21:43 +02:00
Robbie Averill
7f685b0bea
Merge pull request #8423 from creative-commoners/pulls/4.2/default-locale-for-members
FIX New members now receive the configured default locale, not the current locale
2018-10-03 13:18:05 +02:00
Robbie Averill
79f9d6b733
Merge pull request #8428 from sminnee/fix-2636
FIX: Don’t change state in ArrayList::getIterator()
2018-10-03 13:11:39 +02:00
Robbie Averill
2c186854c2
Merge pull request #8432 from sminnee/ss4-php73
NEW: Add test for PHP 7.3 support (SS4 version)
2018-10-03 13:10:21 +02:00
Maxime Rainville
f4c217f8a1
Merge pull request #8420 from open-sausages/pulls/4/searching-for-api
Add extension points for ModelAdmin search API
2018-10-03 16:57:05 +13:00
Robbie Averill
cb2b9498fb API Deprecate updateSearchContextCallback and updateSearchFormCallback 2018-10-03 13:47:40 +13:00
Luke Edwards
bf60a699a5 Add extension points for ModelAdmin search API 2018-10-03 13:47:40 +13:00
Maxime Rainville
cefb81dabc
Merge pull request #8436 from creative-commoners/pulls/4.3/this-is-not-js
FIX Moving test to correct directory
2018-10-03 11:05:46 +13:00
Guy Marriott
5970fc2417
FIX Moving test to correct director 2018-10-03 10:47:17 +13:00
Robbie Averill
5a20bb5e20 Revert "FIX: Use DELETE FROM instead of TRUNCATE for clearTable"
This reverts commit 79c2b5ad42.
2018-10-02 14:35:10 +02:00
Robbie Averill
c8e7672ede
Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict
FIX Avoid having search fields with the same names as form elements
2018-10-02 13:43:59 +02:00
Robbie Averill
2ca089bcce
Merge pull request #8433 from sminnee/faster-cleartable
FIX: Use DELETE FROM instead of TRUNCATE for clearTable
2018-10-02 10:43:54 +02:00
Robbie Averill
fa44b50b4f
Merge pull request #8431 from kalicki2k/patch-1
added an http / https switch
2018-10-02 10:35:16 +02:00
Loz Calver
27076aeb93
Merge pull request #8430 from sminnee/fix-6300
FIX: Don’t use USE_FRM in MySQL repair. Fixes #6300.
2018-10-02 10:28:17 +02:00
Loz Calver
ddc86967ff
Merge pull request #8406 from creative-commoners/pulls/4.2/having-docblocks
DOCS Update do blocks for DataQuery::having() to reflect correct input types
2018-10-02 10:26:31 +02:00
Sam Minnee
79c2b5ad42 FIX: Use DELETE FROM instead of TRUNCATE for clearTable
clearTable is mainly used for clearing data between tests. In this case,
there are very few or zero records, and DELETE FROM is quicker than
TRUNCATE, which works by deleting and recreating the table.

This materially speeds up test execution, at least on MySQL.

Implemented in SS3 at 815da76b056a716c8831d22bbf93528912cbcb28
2018-10-02 18:00:38 +13:00
Sebastian Kalicki
9051fb923d
removed http... 2018-10-02 05:19:27 +02:00