4407 Commits

Author	SHA1	Message	Date
Steve Boyd	e19ef240f7	NEW VersionProvider now supports recipes as well as modules	2020-08-11 13:04:48 +12:00
Sam Minnée	8195bb480d	Merge pull request #9630 from silverstripe-terraformers/feature/with-time ... NEW: WithMockTime callback.	2020-08-07 10:16:30 +12:00
Maxime Rainville	26b8b7964e	Rename DefaultEllipsis to defaultEllipsis	2020-08-07 09:48:42 +12:00
Maxime Rainville	e31565cb71	BUG Fix GroupedDropdownFieldTest::testReadonlyValue	2020-08-06 22:50:40 +12:00
Maxime Rainville	896c0e4388	BUG Use proper ellipsis character in the various summary method.	2020-08-06 19:37:03 +12:00
Mojmir Fendek	c2ed6a4cd6	NEW: WithMockTime callback.	2020-08-06 11:18:39 +12:00
Ingo Schommer	9d03a6856c	FIX Retain custom sort on custom lists in GridFieldAddExistingAutoCompleter ... Forcing sort by the first search field isn't always appropriate. When a custom search list is used, we can set the expectation that custom sorting is intended as well. As an example, this can be used to autocomplete based on FULLTEXT indexes, and sort based on relevancy.	2020-08-04 22:02:20 +12:00
Steve Boyd	8287fad24d	Merge branch '4.6' into 4	2020-07-29 11:38:49 +12:00
Steve Boyd	52d38a8b4a	Merge pull request #9615 from creative-commoners/pulls/4.6/embed-iframe-dimensions ... FIX Set iframe dimension attributes specified in shortcode	2020-07-28 11:04:24 +12:00
Steve Boyd	f0936d4c1e	FIX Set iframe dimension attributes specified in shortcode	2020-07-27 18:04:03 +12:00
Martin Heise	404f450ac3	BUG Readonly version of GroupedDropdownField ... GroupedDropdownField was showing empty values in Readonly mode due to not correctly handling the hierarchical source array. Uses flattened source now in GroupedDropdownField->performReadonlyTransformation()	2020-07-21 09:23:30 +02:00
Robbie Averill	84b4057a9a	Merge pull request #9406 from chrispenny/feature/standardise-get-cms-validator ... v4 improvement: Standardise getCMSValidator for DataObjects/Forms	2020-07-16 15:58:33 -07:00
Garion Herman	d408a4e714	Merge branch '4.6' into 4	2020-07-13 12:28:14 +12:00
Garion Herman	fbe0f5a981	Merge branch '4.5' into 4.6	2020-07-13 12:27:02 +12:00
Maxime Rainville	8518987cbd	[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()	2020-07-10 17:56:15 +12:00
Maxime Rainville	71db45b18b	[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()	2020-07-10 14:57:26 +12:00
Maxime Rainville	b780c4f504	BUG Tweak DBHTMLText::Plain to avoid treating some chinese characters as line breaks.	2020-07-09 13:33:43 +12:00
Sam Minnee	01d3b4fd96	FIX: Set many-many-through joinRecord on newly added records. ... When many-many-through relations are queried, a joinRecord is set on each DataObject in the list to provide the extra fields defined on the connector object. This didn’t previously happen when the record was first add()ed to a list. This fixes that bug.	2020-07-02 15:18:12 +12:00
cpenny	f72491f7f4	Linting fix	2020-06-08 09:35:00 +12:00
cpenny	d4165db690	Update getter name to getCMSCompositeValidator	2020-05-28 12:23:35 +12:00
cpenny	2765b65f42	Use ReflectionClass for CompositeValidator tests	2020-05-28 11:18:46 +12:00
cpenny	bca4be77ed	Update name to CompositeValidator. Add docblocks	2020-05-28 11:18:46 +12:00
cpenny	b45a3561df	Implemented PR feedback. Added some initial test cov	2020-05-28 11:18:46 +12:00
Maxime Rainville	acccdd8a1c	Merge branch '4.5' into 4	2020-05-26 14:31:06 +12:00
Maxime Rainville	42bb28965c	Merge branch '4.4' into 4.5	2020-05-26 14:30:27 +12:00
Maxime Rainville	395893b559	Merge branch '4.3' into 4.4	2020-05-26 14:30:02 +12:00
Maxime Rainville	86fcb9e29c	Merge branch '4.2' into 4.3	2020-05-26 14:29:16 +12:00
Daniel Hensby	080ce157ce	Fix various typos in comments	2020-05-16 10:34:53 +01:00
Michal Kleiner	21129b1624	Use short array syntax across the framework's codebase	2020-05-16 10:34:45 +01:00
Steve Boyd	b1b61f866e	FIX Set nonce style on unit tests	2020-05-13 16:07:31 +12:00
Brett Tasker	1d19051c10	Add sha1 and md5 hashing options in resource URL	2020-05-12 18:14:03 +12:00
Mojmir Fendek	7dc6b36c16	Unique key for DataObject (#9400) ... NEW Unique key for DataObject	2020-05-04 09:10:51 +12:00
Dan Hensby	33b0b6985a	Update file paths for autoloading compatibility	2020-04-25 10:28:28 +01:00
Daniel Hensby	237b2d5f74	Convert array delcarations to short array syntax	2020-04-20 18:58:09 +01:00
Garion Herman	f94078d963	Merge pull request #9408 from chrometoasters/pulls/classes-with-extension ... Add ClassInfo method to get all classes with a given extension applied	2020-04-20 20:11:01 +12:00
Serge Latyntcev	cb36aab80c	Merge branch '4.5' into 4	2020-04-15 14:49:19 +12:00
mattclegg	e968f5cb86	DOCS: Remove outdated TODO	2020-04-14 15:00:08 +05:45
Ingo Schommer	2c5deceeb4	FIX Filter out all FULLTEXT BOOLEAN chars ... The query might still work depending on where these chars are placed, but it seems weird to only remove *some* of the valid chars here. See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html Note that the query runs both the actual boolean query with chars, and then a separate relevance search without them.	2020-04-09 10:32:45 +12:00
Ingo Schommer	c6b698cb02	NEW Allow InnoDB for FULLTEXT indexes ... MyISAM used to be the only one to support it, now InnoDB has caught up. Unless an engine is set specifically in create_table_options, this will auto-convert existing MyISAM tables to InnoDb. Fixes #9242	2020-04-09 10:32:45 +12:00
Dan Hensby	5bf2ac83ee	Merge branch '4.5' into 4	2020-04-01 19:23:47 +01:00
Daniel Hensby	1fb574a5bd	NEW: Variadic URL parameter matches for url_handlers (#9438) ... * Add wildcard URL parameter matches for url_handlers * Extra tests for wildcard parameters * Add a PHP warning if more params appear after wildcard param	2020-03-25 09:16:13 +13:00
Michal Kleiner	30c3b127c1	NEW Add ClassInfo method to get all classes with a given extension applied	2020-03-24 10:48:35 +13:00
Aaron Carlino	37e8720fe5	Linting	2020-03-17 16:21:46 +13:00
Aaron Carlino	7ad5f1bb14	BUGFIX: Ensure diff arrays are one-dimensional	2020-03-17 15:57:28 +13:00
Steve Boyd	667495eaf9	Merge branch '4.5' into 4	2020-03-06 10:53:28 +13:00
Steve Boyd	687435a2f1	Merge branch '4.4' into 4.5	2020-03-06 10:52:22 +13:00
UndefinedOffset	bba0f2f72f	BUGFIX: Fixed issue where TimeField_Readonly would only show "(not set)" instead of the value	2020-02-24 09:59:00 -04:00
Maxime Rainville	affd43052a	Merge branch '4.5' into 4	2020-02-17 18:11:23 +13:00
Maxime Rainville	acd7d94167	Merge branch '4.4' into 4.5	2020-02-17 13:07:26 +13:00
Maxime Rainville	49fda52b12	Merge pull request #94 from silverstripe-security/fix/cve-2019-19325 ... CVE-2019-1935	2020-02-17 12:54:40 +13:00
Serge Latyntcev	ad1b00ec7d	[CVE-2019-19325] XSS through non-scalar FormField attributes ... Silverstripe Forms allow malicious HTML or JavaScript to be inserted through non-scalar FormField attributes, which allows performing XSS (Cross-Site Scripting) on some forms built with user input (Request data). This can lead to phishing attempts to obtain a user's credentials or other sensitive user input. There is no known attack vector for extracting user-session information or credentials automatically, it required a user to fall for the phishing attempt. XSS can also be used to modify the presentation of content in malicious ways.	2020-02-17 09:58:29 +13:00
Guy Marriott	c31de772ab	Merge pull request #8838 from creative-commoners/pulls/4/slash-means-root ... Use '/' as an alternative designation for root in routing	2020-02-14 11:29:32 -08:00
Garion Herman	9d1d59d8d1	NEW Accept / as designation for root URL controller	2020-02-14 14:41:10 +13:00
Steve Boyd	9d5c3ef20e	Merge branch '4.4' into 4.5	2020-02-11 16:45:15 +13:00
Mojmir Fendek	99786dda22	ORM Column now supports related table lookup	2020-01-28 15:46:30 +13:00
Andre Kiste	6650d81324	BUG Fix extra blank Group being created when creating a new Group (#9325) ... * Fix extra blank Group being created when creating a new Group * Update tests to reflect expected behavior * Improved tests	2019-11-27 09:32:33 +13:00
Serge Latyntcev	91e4aa90f1	Merge branch '4.4' into 4.5	2019-11-20 11:09:23 +13:00
Serge Latyntcev	8219491705	Merge branch '4.3' into 4.4	2019-11-20 11:08:35 +13:00
Garion Herman	ea2a2b4786	FIX Adjust HTMLEditorField tests to support alt attr changes in assets ... The default behaviour of the alt attribute has changed from using the filename to applying an empty value.	2019-11-14 12:04:37 +13:00
Mojmir Fendek	e2bea6b41f	API Add withConfig method (#9011) ... * With config functionality added. * Update docs/en/02_Developer_Guides/04_Configuration/00_Configuration.md	2019-10-31 16:12:04 +13:00
Damian Mooyman	e76601e5c8	BUG FormAction title property cannot be set if useButtonTag is false	2019-10-29 17:21:45 +13:00
Garion Herman	17f4cc6e30	Merge pull request #9281 from creative-commoners/pulls/4/textfield-tip-ui ... NEW: Add support for Tip UI in TextField	2019-10-23 16:50:43 +13:00
Garion Herman	bed3f2b3c6	NEW Add type declarations to Tip API, add TippableFieldInterface	2019-10-23 10:46:22 +13:00
Garion Herman	195417b061	NEW Extract Tip from TextField, add test coverage	2019-10-22 17:04:58 +13:00
Maxime Rainville	e59625fe5a	NEW Add ability to define image size preset for the TinyMCE editor. (#9276) ... * NEW Add ability to define image size preset for the TinyMCE editor. * DOC Explain how to define image size pre-sets	2019-10-22 11:50:28 +13:00
Serge Latyntcev	33a28394d6	Merge branch '4.4' into 4	2019-10-18 15:59:28 +13:00
Serge Latyntcev	0cf5d4cbe2	Merge branch '4.3' into 4.4	2019-10-18 15:58:13 +13:00
Serge Latyntcev	46b9530d88	PSR2 linting fixes	2019-10-18 15:31:39 +13:00
Serge Latyntcev	7873efde9c	Merge branch '4.4' into 4	2019-10-18 10:58:19 +13:00
Serge Latyntcev	dcbe6d0310	Merge branch '4.3' into 4.4	2019-10-18 10:57:35 +13:00
Damian Mooyman	d7752b7945	Run PSR2 Lint cleaner	2019-10-04 13:26:31 +13:00
Serge Latyntcev	7db524bd90	FIX DebugViewFrendlyErrorFormatter handle of admin_email	2019-10-04 10:26:54 +13:00
Dylan Wagstaff	047ac060c4	Merge pull request #9265 from emteknetnz/feature/noopener ... Add noopener attribute to links with a target	2019-10-03 14:42:50 +13:00
Steve Boyd	887f198b07	Add rel attribute to link elements with a target attribute	2019-10-03 14:03:12 +13:00
Sam Minnée	af6644f762	Merge pull request #9240 from chrometoasters/pulls/db-readonly-transactions-support ... NEW Introduce supported database transaction mode check	2019-09-25 10:02:53 +12:00
Aaron Carlino	b002ef1171	Merge branch '4.4' into 4	2019-09-24 17:26:50 +12:00
Garion Herman	0d27f32cc9	FIX Add 'legal empty attributes' to allow empty alt values on imgs ... In some situations, a caption is used in place of a value in the alt attribute, and in others an image may be cosmetic and not in need of an alt attribute value (though the alt attribute must still be rendered in this case).	2019-09-24 11:44:12 +12:00
Robbie Averill	3cfc21c405	Merge pull request #9241 from open-sausages/pulls/4.4.3/fix-file-permission ... Fix administrators not being able to see files that are restricted to groups	2019-09-23 11:13:26 -07:00
bergice	6a1c6ecec6	Fix administrators not being able to see files that are restricted to groups ... Resolves https://github.com/silverstripe/silverstripe-asset-admin/issues/777	2019-09-23 16:44:28 +12:00
Michal Kleiner	bcbf90a837	NEW Introduce supported database transaction mode check	2019-09-16 14:44:15 +12:00
Robbie Averill	aa6b244db9	Merge branch '4.4' into 4	2019-09-13 18:11:46 -07:00
Robbie Averill	592ab6abc1	Merge branch '4.3' into 4.4	2019-09-13 18:11:34 -07:00
Robbie Averill	9a76d4adb4	Merge pull request #9181 from kinglozzer/8762-shortcode-templates ... NEW: Use templates to render embed shortcodes (closes #8762)	2019-09-13 17:58:32 -07:00
Serge Latyntsev	233e0e7aa0	ENH PasswordExpirationMiddleware implementation (#9207)	2019-09-12 14:34:06 +12:00
Aaron Carlino	da6582f593	NEW: Remove web installer, move to separate package (#9231) ... * Remove installer * Remove exposed install files * Replace Dev/Install classes still in use * Update changelog * FIX make the grid field actions consistent to what they look like on pages Resolves https://github.com/silverstripe/silverstripe-admin/issues/904 * Docs changes	2019-09-11 13:10:25 +12:00
Maxime Rainville	591b88a9bc	BUG Allow infinite loop when calling DataObject::writeComponent() recursively	2019-09-10 14:15:28 +12:00
Robbie Averill	e8c2f963fd	FIX Member::getLastName() now correctly returns the Member surname	2019-09-06 12:12:27 -07:00
Maxime Rainville	dd40d53e6b	Merge branch '4.4' into 4	2019-09-04 09:46:33 +12:00
Maxime Rainville	24015c7767	Merge branch '4.3' into 4.4	2019-09-04 09:42:09 +12:00
Robbie Averill	77ba8391c4	FIX Byte Order Marks (BOM) are now stripped when importing CSV files	2019-08-29 14:54:57 +12:00
Loz Calver	759601741d	NEW: Use templates to render embed shortcodes (closes #8762)	2019-08-21 09:32:16 +01:00
Robbie Averill	a5d6b998fc	Merge branch '4.4' into 4	2019-08-16 16:40:39 +12:00
Robbie Averill	11a7d6ccb4	Rename test to be clearer about its intent ... Co-Authored-By: Guy Marriott <guy@scopey.co.nz>	2019-08-16 09:49:36 +12:00
Robbie Averill	bae7e32680	FIX Member::changePassword() no longer applies password validation rules to the hashed value	2019-08-16 09:06:07 +12:00
Robbie Averill	f354e2018d	FIX Set minimum test scores and password length for Members while running fixtured DataObject tests	2019-08-15 15:23:11 +12:00
Robbie Averill	45f86658ca	Merge branch '4.4' into 4	2019-08-14 09:31:05 +12:00
Robbie Averill	4b44272367	Merge branch '4.3' into 4.4	2019-08-14 09:30:53 +12:00
Robbie Averill	d63e4b520c	Merge branch '4.2' into 4.3	2019-08-14 09:30:41 +12:00
Guy Marriott	f3132c89d7	Merge pull request #9170 from open-sausages/pulls/4/add-option-to-disable-user-agent-session-check ... API Add option to disable user-agent header session validation	2019-08-08 11:47:07 +12:00
Aaron Carlino	b3093b7a1a	BUGFIX: Allow state to be shared across nested GridFields	2019-08-07 23:09:51 +12:00
Maxime Rainville	4380d7d155	API Add option to disable user-agent header session validation	2019-08-06 22:00:01 +12:00
Robbie Averill	0672f8b76b	NEW HTTPRequest now has hasSession() to determine whether a session exists for it	2019-08-02 11:29:23 +12:00
UndefinedOffset	c1ffc4edfb	Added unit tests for multiple relationship sorting	2019-07-29 10:45:10 -03:00
Chee Wai	cb91f5fa06	NEW Added SRI support for Requirements::css, Requirements::javascript (#9139)	2019-07-21 09:51:22 +02:00
Simon Gow	22b514c421	#9114 - DBText::ContextSummary() cuts line breaks ... ContextSummary() was cutting the HTML which was added by nl2br because it expected plain text elements as it's stripping and replacing text. Instead this fix changes the behaviour to apply the nl2br after the text changes have been made. That way we can't cut anything in the middle of a HTML tag, but new lines, or paragraphs are replaced by BRs after, should they exist. - Added tests to ensure text is not cut in the middle of a sentence. - Added test to ensure that <br>'s are added in the correct place should the summary span between new lines.	2019-07-19 12:43:20 +12:00
Serge Latyntcev	29a663c65d	Merge branch '4.4' into 4	2019-07-15 09:24:49 +12:00
Serge Latyntcev	d667d64f13	Merge branch '4.3' into 4.4	2019-07-15 09:18:17 +12:00
Serge Latyntcev	fcd7a1e63e	FIX core memory limit test	2019-07-12 16:30:25 +12:00
Serge Latyntsev	7ef13e7ef6	FIX Confirmation components to respect SS_BASE_URL (#9074)	2019-07-05 16:05:41 +12:00
Robbie Averill	844d2ef134	NEW DBDate and DBDatetime now support modify() with a strtotime() style adjustment string (#9105)	2019-07-05 15:57:23 +12:00
UndefinedOffset	e3aa0ff63a	Added unit tests for config condition if PHP extension is loaded	2019-07-03 10:32:41 -03:00
Sam Minnee	96e7914f23	FIX: Fix MySQLQuery::seek() and Query::rewind() to fix repeated iteration ... API: Query::seek() and Query::rewind() no longer return a value. Although breaking an API inside a patch release may seem odd, this in fact is correcting a long-standing bug in our implementation of Iterator::rewind(), so I think it’s appropriate. https://github.com/silverstripe/silverstripe-framework/issues/9097	2019-07-03 09:20:05 +12:00
Saophalkun Ponlu	6a8c6703d1	Remove use_gzip from HTMLEditorField since it's been removed by TinyMCE codebase (#7261) ... * Remove `use_gzip` from HTMLEditorField * DOCS Mention remove use_gzip in changelog	2019-06-21 09:27:48 +12:00
Aaron Carlino	d04e54c1be	Merge branch '4.4' into 4	2019-06-10 17:33:30 +12:00
Aaron Carlino	c747b1f8d3	Merge branch '4.3' into 4.4	2019-06-10 17:32:07 +12:00
Aaron Carlino	f766555d61	Merge branch '4.2' into 4.3	2019-06-10 17:27:05 +12:00
Serge Latyntcev	ca56e8d78e	[CVE-2019-12246] Denial of Service on flush and development URL tools	2019-06-10 17:23:56 +12:00
Sam Minnée	654156d46d	FIX: Fix bug when confirmed password is changed but not the password. (#9012) ... In this case the confirmed password field is not reflected. It’s unclear how often this situation would arise outside of test scenarios, but may come up if $form->loadDataFrom() is called more than once. Fixes #2496 (it’s a minor issue but I think this is why Dan flagged it as a regression). Originally introduced as part of Dan’s initial fix at 2a6f1f1949.	2019-06-10 15:48:29 +12:00
Jarkko Linnanvirta	9184056b5e	URLSegmentFilter: Remove : characters from url segments when multibyte characters are allowed.	2019-06-02 11:43:51 +03:00
Robbie Averill	00fd74a0a1	Merge branch '4.4' into 4 ... # Conflicts: # src/Dev/Tasks/MigrateFileTask.php	2019-05-30 09:36:42 +12:00
Robbie Averill	14673ffd0a	Merge branch '4.3' into 4.4	2019-05-30 09:35:26 +12:00
Robbie Averill	188698dcee	Merge branch '4.2' into 4.3	2019-05-30 09:35:17 +12:00
Robbie Averill	3e2fc6aa0b	Automated phpcbf linting	2019-05-30 09:34:34 +12:00
Guy Marriott	f97ca26e76	Merge pull request #9014 from sminnee/fix-4142 ... FIX: List default items in the readonly view of ListboxField	2019-05-27 20:13:20 +12:00
Sam Minnee	7407096e99	FIX: List default items in the readonly view of ListboxField ... Adds tests for non-readonly default items too. Fixes #4142	2019-05-27 17:47:09 +12:00
Sam Minnee	2c71daacfe	MINOR: Add tests for GroupedDropdownField empty strings ... These bugs were never present in SS4 as the relevant code had a substantial rewrite at the same time they were introduced in SS3. In SS3, test C still fails. Fixes #4705 Fixes #4987 Fixes #4793	2019-05-27 17:46:03 +12:00
Guy Marriott	350888bf50	NEW Adding a shuffle method to ArrayList (#8984) ... * NEW Adding a shuffle method to ArrayList * API Add shuffle to DataList for ArrayList parity	2019-05-16 09:26:11 +12:00
Aaron Carlino	3f1479edbb	BUGFIX: DataQuery overwriting _SortColumn selects (#8974) ... * BUGFIX: DataQuery overwriting _SortColumn selects * FIX DataQuery _SortColumn handling	2019-05-15 11:42:10 +12:00
Maxime Rainville	8ee50d2ba7	API Remove DataObjectSchema::getFieldMap() (#8960) ... Introduced as a less public API in https://github.com/silverstripe/silverstripe-assets/pull/227	2019-05-06 12:33:23 +12:00
Guy Marriott	82c8225502	Merge branch '4.3' into 4.4	2019-05-03 09:45:25 +12:00
Serge Latyntcev	3d777cfb8a	Backward compatible behaviour for SQLConditionalExpression::getJoins	2019-05-02 15:39:36 +12:00
Andre Kiste	0c6c57f1ef	Add getFieldMap method to retrieve a list of all fields for any giv… (#8892) ... * Add `getFieldMap` method to retrieve a list of all fields for any given class * Add `TagsToShortcodeTask` to upgrading guide Adding after the file migration part as this is where it makes the most sense to run it. * `getFieldMap` accepts an array * Move to `DataObjectSchema` * Add `HTMLVarchar` to documentation Minor refactoring * Add test for checking that `subclassesfor` works without the base class Add test `DataObjectSchema::getFieldMap` returns the correct array * Remove cms dependency	2019-04-30 10:43:14 +12:00
Aaron Carlino	c63eecc3e1	Merge branch '4.3' into 4	2019-04-18 11:57:36 +12:00
Sam Minnée	155a9bb1f9	Merge pull request #8934 from creative-commoners/pulls/4.4/pdostgresql-boolean-consistency ... FIX Postgres booleans should return as int for consistency	2019-04-17 15:43:35 +12:00
Guy Marriott	da1af3d8b0	FIX Postgres booleans should return as int for consistency	2019-04-17 15:15:17 +12:00
Guy Marriott	cc1fdf603b	Resolve incorrect empty string assertion in tests	2019-04-17 13:29:54 +12:00
Guy Marriott	9d6b5048a6	FIX Table aliases are retained on base tables in queries built using SQLConditionalExpression (#8918) ... * Adding failing test for base table aliases using SQLSelect * FIX Retain table aliases applied to the base table on queries * FIX Move the trimmed alias outside of the condition so we can use it within the condition	2019-04-16 15:40:09 +12:00
Ralph Slooten	66c372ce28	Include baseURL with relative setGetVar() links (#8834) ... * Return baseURL with setGetVar * Adjust testSetGetVar tests for base url	2019-04-15 14:50:46 +12:00
Robbie Averill	8a06682e31	Merge branch '4.3' into 4 ... # Conflicts: # src/ORM/Connect/DBSchemaManager.php	2019-04-11 11:24:17 +12:00
Sam Minnee	d295888838	MINOR: Improve type testing	2019-04-05 15:11:21 +13:00
Sam Minnee	2625cea5e3	MINOR: Add a test that 0 is falser on int, decimal, currency ... Validates that https://github.com/silverstripe/silverstripe-framework/issues/3473 has been fixed The bug was fixed in #8448	2019-04-05 15:11:21 +13:00
Sam Minnee	4f4153c834	MINOR: Test test to validate that multiple GreaterThan filters in a filterAny work. ... Confirms https://github.com/silverstripe/silverstripe-framework/issues/3995 isn’t a bug.	2019-04-05 15:05:42 +13:00
Robbie Averill	123d483213	MemberTest and SecurityTest now set the default authenticator to use	2019-04-05 11:26:29 +13:00
Guy Marriott	a9d57f5bfb	Merge pull request #8241 from creative-commoners/pulls/4.3/separate-logging ... Separate core error logging from standard LoggerInterface	2019-04-05 08:49:09 +13:00
Aaron Carlino	fc6213c293	Merge branch '4.3' into 4	2019-03-27 13:25:57 +13:00
Johannes Hammersen	e1190e33d2	Fix PDOConnector GeneratedID return type	2019-03-21 09:26:14 +01:00
Aaron Carlino	388baa01b4	Fix linting	2019-03-20 13:19:10 +13:00
Aaron Carlino	aa491d9294	Fix tests	2019-03-20 12:33:00 +13:00
Damian Mooyman	6b450395ce	API Allow empty arraylists to be typed (#8866) ... * API Allow empty arraylists to be typed * PHPCBF fixes	2019-03-20 11:46:35 +13:00
Dan Hensby	765d1568ab	Merge branch '4.3' into 4	2019-03-06 11:04:50 +00:00
Dan Hensby	a8605b04e0	Merge branch '4.2' into 4.3	2019-03-06 11:04:14 +00:00
Damian Mooyman	d1396b7dfe	BUG Fix writeBaseRecord with unique indexes ... Fixes #6819	2019-02-27 16:40:12 +13:00
Maxime Rainville	11b9429c34	Merge branch '4.3' into 4	2019-02-27 12:14:51 +13:00
Maxime Rainville	651d537196	Merge branch '4.2' into 4.3	2019-02-27 12:13:24 +13:00
Maxime Rainville	ed013fcfbb	Merge branch '4.1' into 4.2	2019-02-27 12:12:39 +13:00
Maxime Rainville	ac53f77115	Merge branch '4.0' into 4.1	2019-02-27 12:11:47 +13:00
Maxime Rainville	6ff319a0e1	BUG Implement peer review feedback,	2019-02-27 11:14:47 +13:00
Maxime Rainville	9a59f2f57d	BUG Renable the ability to do dynamic assignment with DBField	2019-02-22 11:08:43 +13:00
Robbie Averill	3e90fdf42f	Merge branch '4.3' into 4	2019-02-19 08:41:05 +07:00
Robbie Averill	ed74549c4f	Merge branch '4.2' into 4.3	2019-02-19 08:39:59 +07:00
Robbie Averill	79e44b42fa	Merge branch '4.1' into 4.2	2019-02-19 08:37:07 +07:00
Robbie Averill	cb7f15a681	Merge branch '4.0' into 4.1	2019-02-19 08:36:41 +07:00
Aaron Carlino	09c539e1c3	Merge branch '4.3' into 4	2019-02-19 12:21:24 +13:00
Maxime Rainville	25bba49923	[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation	2019-02-19 12:20:24 +13:00
Maxime Rainville	95505db7d6	[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation	2019-02-12 21:08:09 +13:00
Maxime Rainville	fd90cf6ceb	[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation	2019-02-12 20:44:17 +13:00
Loz Calver	7c5b73881b	FIX: Prevent null->null being flagged as a value change (fixes #8774)	2019-02-06 13:24:18 +13:00
Robbie Averill	d116b9a8d2	Add test for shortcode parsing with querystring and anchor	2019-01-29 13:15:17 +02:00
Maxime Rainville	a589bcb092	Merge pull request #8729 from emteknetnz/bugfix/htmlvalue-getcontent ... Ensure document is not falsey before attempting to clone it	2019-01-29 09:11:04 +13:00
Robbie Averill	d00c59c383	Fix tests not loading fixtures and loading themes in CWP recipe kitchen sink	2019-01-28 13:34:52 +02:00
Steve Boyd	d28552915d	Add unit test for an invalid HTMLValue	2019-01-25 15:55:03 +13:00
Robbie Averill	d8cd085190	Merge branch '4.3' into 4	2019-01-24 17:14:09 +02:00
Robbie Averill	e087e564e1	Fix tests not loading fixtures and loading themes in CWP recipe kitchen sink	2019-01-24 16:45:38 +02:00
Maxime Rainville	13486ca80e	MINOR Add unit test for Requirements::add_i18n_javascript()	2019-01-16 10:36:53 +13:00
Damian Mooyman	34ac228029	BUG Fix issue with assertListEquals() ignoring field getters	2019-01-11 11:35:11 +13:00
Maxime Rainville	1e01deea39	NEW Make resources dir configurable (#8519) ... * NEW Make resources dir configurable. * Removing reference to old `resources` and updating doc #8519 * Rrtarget to 4.4 release. * DOC Reference SS_RESOURCES_DIR in Environment doc. * API Add a Resources method to SilverStripe\Core\Manifest\Module to read the resources-dir from composer.json * Clean up reference to SS_RESOURCES_DIR env var * Set default resources-dir * Update test to use RESOURCES_DIR const in expected resource url method * Correcting typos Co-Authored-By: maxime-rainville <maxime@rainville.me> * MINOR Correctubg minor typos * DOCS Document the intricacies of exposing static assets.	2019-01-09 15:35:45 +13:00
Robbie Averill	7c96feef37	Merge branch '4.3' into 4	2019-01-08 12:27:48 +01:00
Robbie Averill	394dd4765c	NEW Scaffolded field labels now only have an uppercased first word	2019-01-07 17:52:28 +01:00
Maxime Rainville	7d1aa44786	Merge pull request #8654 from creative-commoners/pulls/4.3/password-complexity-test-fixes ... Update tests to pass in CWP kitchen sink context	2018-12-13 16:50:25 +13:00
Robbie Averill	470093de2f	Merge pull request #8650 from sminnee/nested-vendor ... FIX: Manifest should ignore vendor folders within packages contained in vendor	2018-12-12 19:52:03 +00:00
Robbie Averill	fcc37350a1	Merge branch '4.3' into 4	2018-12-12 12:17:37 +00:00
Serge Latyntcev	f7846fc34c	FIX behat CmsUiContext waits for cms-loading-container after step	2018-12-10 16:49:57 +13:00
Robbie Averill	5d7c5ffb07	Merge branch '4.3' into 4	2018-12-06 09:40:40 +00:00
Robbie Averill	08866f89d9	Merge branch '4.2' into 4.3	2018-12-06 09:40:05 +00:00
Robbie Averill	96bd17d469	Merge branch '4.1' into 4.2	2018-12-06 09:38:45 +00:00
Robbie Averill	3f532466d1	Merge branch '4.0' into 4.1	2018-12-06 09:37:52 +00:00
Guy Marriott	6edcbe9086	Merge pull request #8592 from open-sausages/pulls/4.0/tree-multiselect-null ... FIX TreeMultiselectField passes value 'unchanged' as null to ORM	2018-12-06 14:23:48 +13:00
Robbie Averill	1ac36611a6	Update tests to pass in CWP kitchen sink context	2018-12-02 23:04:34 +00:00
Sam Minnee	0c17ffc944	FIX: Manifest should ignore vendor folders within packages contained in vendor ... Without this change vendor/silverstripe/framework/vendor/silverstripe/config will be pick up by the manifest, which is inappropriate. Although this doesn’t happen often, it can occur if you have run “composer install” within vendor/silverstripe/framework, which can be done either accidentally or (in my case) as part of running the framework tests isolated from the rest of your project (which is closer to the execution model on Travis) Note that the presence of the ‘nestedvendor.txt’ file tests that this works without any explicit changes to the PHP of the tests, since it’s merely confirming that such a file is *not* picked up.	2018-11-30 13:52:25 +13:00
Serge Latyntcev	4ee63eb4e7	TreeMultiselectFieldTest / make scrutinizer happy	2018-11-29 12:13:56 +13:00
Serge Latyntcev	38f8217f01	TreeMultiselectFieldTest / setUp is protected in PHPUnit5	2018-11-29 09:55:28 +13:00
Loz Calver	3f8551df41	Merge pull request #8462 from sminnee/nondestructive-enum ... FIX: Make all enums non-destructive, not just ClassName	2018-11-28 16:42:12 +01:00
Robbie Averill	1f1c344272	Merge branch '4.3' into 4 ... # Conflicts: # tests/php/Forms/ConfirmedPasswordFieldTest.php	2018-11-26 12:15:17 +01:00
Robbie Averill	41dc9229bf	FIX Reverting ExtensionTestState and Extensible extra methods modifications to prevent PHP 5.6 segfault (#8581) ... * API Revert addition of Extensible::flush_extra_methods_cache() and change to ExtensionTestState This reverts the changes from #8465 and #8505 that relate to ExtensionTestState and the tracking of extra methods between unit tests. The existing test from #8465 testing overloaded Extensions after extra_methods are populated has been updated to show that you must re-add the extension to flush the extra_methods cache if you need this behaviour. * Revert change to InjectorTest::testExtendedExtensions * Revert "Add failing test to show that overloaded extensions are broken in Extensible" This reverts commit 55e79ffdfd. * DOCS Add docs for extending extensions, and upgrade guide note to 4.3 to avoid using PHP config to do so	2018-11-26 12:00:02 +13:00
Serge Latyntcev	f526c794fc	Minor / Refactor php tests for TreeMultiselectField	2018-11-23 16:03:44 +13:00
Serge Latyntcev	9ce6d91b76	FIX / TreeMultiselectField::objectForKey handles list of IDs correctly	2018-11-22 12:11:18 +13:00
Maxime Rainville	d74af1c17e	FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621	2018-11-21 11:43:21 +13:00
Serge Latyntcev	80885fc231	ADD php test TreeMultiselectField::testEmptyChoiceReadonly	2018-11-20 16:45:23 +13:00
Robbie Averill	3b1e91eb59	Merge branch '4.2' into 4.3	2018-11-15 13:41:23 +02:00
Robbie Averill	ef0f9dff8a	Merge branch '4.1' into 4.2	2018-11-15 13:41:00 +02:00
Robbie Averill	c6e3a398c7	Merge branch '4.0' into 4.1	2018-11-15 13:40:08 +02:00
Loz Calver	b5bae137bd	FIX: Redirect loop with multiple confirmation tokens present (fixes #8607)	2018-11-15 10:59:42 +00:00
Robbie Averill	7d1d6d0f7b	FIX Ensure that tests setting passwords have stubbed configuration	2018-11-14 11:54:17 +02:00
Robbie Averill	0bb94b018b	FIX Remove default password validation rules before running unit tests	2018-11-13 14:09:08 +02:00
Robbie Averill	8854f053c8	Fix rebase conflicts	2018-11-13 11:09:33 +02:00
Robbie Averill	a8853504b4	API API MonologErrorHandler::setLogger is deprecated, use MonologErrorHandler::pushLogger instead	2018-11-13 11:08:27 +02:00
Guy Marriott	b2dd22fb50	Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests ... NEW Adding a stack more unit tests for logging and some form fields	2018-11-11 10:31:24 +13:00
Robbie Averill	bab84f31dc	Remove underscores from variable test class names	2018-11-10 14:55:11 +02:00
Robbie Averill	eba92d77df	Rename CheckboxFieldReadonlyTest for future PSR-2 compatibility	2018-11-10 10:04:17 +02:00
Sam Minnee	a8d3b95175	FIX: Make test work with utf8mb4	2018-11-10 12:10:25 +13:00
Sam Minnee	bd5a815909	FIX: Make all enums non-destructive, not just ClassName ... This change also renders a portion of DBSchemaManager irrelevant, that destructively “fixes” old values. This is in keeping with the non-destructive principle of dev/build, and some suggestions to move away from enum fields altogether. Fixes https://github.com/silverstripe/silverstripe-framework/issues/1387	2018-11-10 12:10:25 +13:00
Robbie Averill	a12a5b7168	Merge pull request #8377 from creative-commoners/pulls/4.3/bootstrap-alerts ... NEW Use Bootstrap alerts throughout the CMS	2018-11-09 14:27:38 +02:00
Robbie Averill	0f2eebe5d4	NEW Change to variadic calls in ListDecorator and add unit tests	2018-11-09 13:59:14 +02:00
Loz Calver	bbb208e1dd	Merge pull request #8499 from sminnee/fix-1489 ... FIX: CheckboxSetField can now save into DBMultiEnum	2018-11-09 10:40:55 +01:00
Robbie Averill	24d6527845	Merge branch '4.3' into 4	2018-11-09 11:39:27 +02:00
Robbie Averill	10f502f0c7	Merge branch '4.2' into 4.3	2018-11-09 11:39:05 +02:00
Robbie Averill	5b7723df7f	Merge branch '4.1' into 4.2 ... # Conflicts: # lang/fi.yml # lang/nl.yml	2018-11-09 11:38:04 +02:00
Robbie Averill	df4d2bd838	Merge branch '4.0' into 4.1 ... # Conflicts: # lang/da.yml # lang/eo.yml # lang/fi.yml # lang/it.yml # lang/nl.yml # lang/sv.yml	2018-11-09 11:36:34 +02:00
Sam Minnee	5531baa87f	FIX: Introduce readonly transaction test to all database. ... This should work on MySQL and PDO; let’s test this.	2018-11-09 10:57:26 +13:00
Sam Minnee	2615399535	FIX: Use PDO’s built-in transaction support in MySQLDatabase.	2018-11-09 10:31:19 +13:00
Sam Minnee	0111b98b18	FIX: Ensure that types are preserved fetching from database ... This ensures that numeric fields appear in PHP as int/float values rather than strings, which allows the development of more type-safe PHP code. This doesn’t work on the legacy mysql driver and this will now throw a notice-level error. It requires mysqlnd.	2018-11-09 10:31:19 +13:00
Werner M. Krauß	bc0f17fb09	Cleanup Convert ... * remove unneeded parenthesis and double quotes * simplify flow / remove unneeded else	2018-11-07 17:45:01 +01:00
Werner M. Krauß	3f321f935a	Convert::memstring2bytes should return integer value ... bytes are by nature an integer fixes #8572	2018-11-07 17:01:36 +01:00
Aaron Carlino	76936d863d	Merge branch '4.3' into 4	2018-11-07 23:20:44 +13:00
Loz Calver	11fe5b3adf	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:33:24 +13:00
Loz Calver	8d7c2dafab	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:33:24 +13:00
Loz Calver	02ad0f44aa	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:32:55 +13:00
Loz Calver	af000bea9b	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:32:55 +13:00
Loz Calver	5563537cc8	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:31:33 +13:00
Loz Calver	0610f76da0	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:31:33 +13:00
Loz Calver	0877442c64	Implement ConfirmationTokenChain to handle multiple tokens at once	2018-11-07 11:24:51 +13:00
Loz Calver	3dbb10625c	[SS-2018-019] Add confirmation token to dev/build	2018-11-07 11:24:51 +13:00
Robbie Averill	64c2938c96	Merge branch '4.3' into 4	2018-11-06 11:05:22 +01:00
Robbie Averill	3c58ae009e	Merge branch '4.2' into 4.3	2018-11-06 11:05:08 +01:00
Robbie Averill	22c7fa2bc9	Merge branch '4.1' into 4.2	2018-11-06 11:04:43 +01:00
Robbie Averill	6d2665d687	Merge branch '4.0' into 4.1	2018-11-06 11:04:28 +01:00
Werner M. Krauß	adafd73943	Convert::memstring2bytes should preserve -1 ... fixes #8570	2018-11-06 10:22:13 +01:00
Aaron Carlino	0ba275cb40	Merge branch '4.2' into 4.3	2018-11-06 15:09:01 +13:00
Aaron Carlino	e60cea8561	Merge branch '4.1' into 4.2	2018-11-06 15:08:42 +13:00
Sam Minnee	67fe41d00b	FIX: Ensure that repeated setting/unsetting doesn’t corrode forceChange()	2018-11-05 23:09:24 +13:00
Sam Minnee	5bb2d9484a	FIX: Update “original” DataObject data to be the content of the last write ... FIX: Compare to original when determining fields changes This fixes a number of edge-case issues relating to change detection. Fixes #8443 Fixes #3821 Fixes #4561	2018-11-05 23:09:24 +13:00
Sam Minnee	76255c9fb5	FIX: CheckboxSetField can now save into DBMultiEnum ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489	2018-11-05 17:40:28 +13:00
Sam Minnee	78ceca6934	MINOR: Add test for defaults on subclasses ... This was raised in https://github.com/silverstripe/silverstripe-framework/issues/8567 and wasn’t covered by a test.	2018-11-05 16:09:49 +13:00
Luke Edwards	8866e7674a	BUG: Fix duplicate plugins on HTML editor fields (#8559) ... * BUG: Fix duplicate plugins on HTML editor fields * Add new test	2018-11-02 12:26:53 +13:00
Michael Strong	55f95b7bc8	BUGFIX many many through not sorting by join table (#8534) ... * BUGFIX many many through not sorting by join table * #8534 added docs to support many many sorting fix * #8534 added test cases for many_many default sorting	2018-11-01 14:17:15 +13:00
Michael Strong	7086f2ea3a	BUGFIX many many through not sorting by join table (#8534) ... * BUGFIX many many through not sorting by join table * #8534 added docs to support many many sorting fix * #8534 added test cases for many_many default sorting	2018-11-01 13:42:27 +13:00
Robbie Averill	b02a6fa02d	FIX Replace usage of Convert JSON methods with json_encode	2018-10-28 21:15:29 +00:00
Sam Minnée	e72fc9e3d0	FIX DataObject singleton creation (#8516) ... Ensure DataObject instances are aware they are singletons so functions like populateDefaults() can be skipped. (fixes #4878) Correctly applies https://github.com/silverstripe/silverstripe-framework/pull/7850 to the 4.x line This has already been fixed in 3.x	2018-10-25 11:42:45 +13:00
Robbie Averill	bea4101e21	Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet	2018-10-20 20:06:02 +02:00
Robbie Averill	449b2cf291	Add tests for DefaultFormFactory	2018-10-20 19:47:11 +02:00
Robbie Averill	fd50ce6295	Add more edge case tests for disabled DateFields and DatetimeField	2018-10-20 18:29:07 +02:00
Robbie Averill	97209bc919	Add edge case unit tests for DateField	2018-10-20 18:15:42 +02:00
Robbie Averill	0e2847e289	Add tests for DatalessField	2018-10-20 17:59:55 +02:00
Robbie Averill	c06cf4820e	BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config	2018-10-20 17:47:16 +02:00
Robbie Averill	d56bad7568	Add tests for edge cases in CurrencyField	2018-10-20 17:33:59 +02:00
Robbie Averill	8929b8204f	More validation tests for ConfirmedPasswordField	2018-10-20 17:21:25 +02:00
Robbie Averill	c418ee2915	NEW Add getters and setters for public properties in ConfirmPasswordField, add tests ... Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests	2018-10-20 16:43:49 +02:00
Robbie Averill	60b375d995	Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs	2018-10-20 15:44:23 +02:00
Robbie Averill	3cdb73bd44	NEW Add getLogger() to MonologErrorHandler and add test for exception without one	2018-10-20 15:00:08 +02:00
Robbie Averill	5bd05a2deb	Reduce setUp visibility and remove check for CLI - tests always run on CLI now	2018-10-20 14:51:53 +02:00
Robbie Averill	2694a47c45	Add more tests for DetailedErrorFormatter	2018-10-20 14:41:45 +02:00
Robbie Averill	e211e27470	Add more unit tests for DebugViewFriendlyErrorFormatter, tidy up Director::is_ajax() return	2018-10-20 14:27:57 +02:00
Robbie Averill	c18e9b1298	Merge pull request #8439 from sminnee/consistent-limit ... FIX: Make ArrayList::limit() consistent with DataList::limit()	2018-10-16 12:05:11 +02:00
Aaron Carlino	7d201309ad	Merge branch '4.2' into 4	2018-10-15 13:42:55 +13:00
Robbie Averill	7215637673	Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield ... API Add a new GridFieldLazyLoader component	2018-10-11 13:43:10 +02:00
Robbie Averill	46c50577a4	Expect BEM class names in tests, fix PSR-2 line lengths, add ArrayList import	2018-10-11 12:04:23 +02:00
Sam Minnee	4740346ed8	FIX: Make ArrayList::limit() consistent with DataList::limit() ... This makes it easier to swap one fo the other without code breaking. Since it’s strictly a removed API, I’ve opted to throw a deprecation note in SS4 rather than throwing an InvalidArgumentException. Fixes #2949	2018-10-11 21:05:20 +13:00
Maxime Rainville	250d925810	MINOR Update CompositeField::__construct to call setChildren #8460	2018-10-11 15:25:34 +13:00
Guy Marriott	0db2f84ade	FIX Persist TinyMCE updates when writing with Behat	2018-10-11 14:34:18 +13:00
Maxime Rainville	2e2ca5a4a7	Make sure LazyLoader still woks after a readonly transofrmation (#8460)	2018-10-11 11:56:39 +13:00
Robbie Averill	56d5621934	FIX Flush extra_methods statics between test runs	2018-10-09 13:22:54 +02:00
Robbie Averill	55e79ffdfd	Add failing test to show that overloaded extensions are broken in Extensible	2018-10-09 12:35:32 +02:00
Maxime Rainville	fdb53311ba	Fix linting issue.	2018-10-09 17:32:42 +13:00
Maxime Rainville	a13a2cdd40	Add unit test for FieldList::getContainerField()	2018-10-09 17:32:42 +13:00
Maxime Rainville	51ba787ffb	Finish writting unit test for GridFieldLazyLoader.	2018-10-09 17:32:42 +13:00
Robbie Averill	1d1cf6882d	Merge pull request #8461 from creative-commoners/pulls/4.3/unbelabelable-dom-skills ... NEW Adding a helper to find a form field by label content (Behat)	2018-10-08 23:22:03 +02:00
Loz Calver	e829ad78b1	Merge pull request #8429 from sminnee/fix-2950 ... FIX: Throw deprecation on limit=0	2018-10-08 15:11:52 +02:00
Guy Marriott	2775895d03	NEW Adding a helper to find a form field by label content	2018-10-08 14:28:16 +13:00
Maxime Rainville	36b1066413	Merge pull request #8451 from creative-commoners/pulls/4.3/memory-cache-findtemplate ... NEW Add memory cache to ThemeResourceLoader::findTemplate()	2018-10-08 10:38:07 +13:00
Sam Minnee	8c7459a708	FIX: Fix CompositeField test that relied on a DropdownField bug ... A DropdownField without a source no longer returns a validation error.	2018-10-06 19:14:34 +13:00
Sam Minnee	e5d3b28a4d	FIX: Don’t break validation on selects without a source. ... Fixes cases where there are no valid values or an empty-string value is manually added rather than using setEmptyString() Fixes #4849 Fixes #7159	2018-10-06 11:53:17 +13:00
Sam Minnée	7915fe0c0f	Merge pull request #8303 from hchokshi/pulls/4.2/viewable-data-customised-isset ... Implement __isset for ViewableData_Customised	2018-10-06 09:37:19 +13:00
Robbie Averill	98568262f2	Fixed phpcs violations	2018-10-05 16:07:33 +02:00
Robbie Averill	da9301f241	Use SilverStripe cache API instead of memory cache, add tests and fix cache config indentation	2018-10-05 14:58:48 +02:00
Robbie Averill	172d8915b7	Clear cache between ThemeResourceLoader tests	2018-10-05 14:12:26 +02:00
Sam Minnee	0fc06e51e5	FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour. ... Note that the medium date format depends on locale, with en_NZ being resolutely numeric. I’ve updated the test to verify a couple of locales to make this more obvious. Fixes #8121	2018-10-04 14:51:24 +13:00
Sam Minnee	638e6ec281	FIX: Throw deprecation notice on limit=0 ... The SS4 behaviour of limit=0 is unlikely to be the SS5 behaviour. To clear the limit limit=null is recommended. In addition, there’s a bit tighter type maintenance in the internal limit data (ensure things are int). Fixes #2950.	2018-10-04 10:38:15 +13:00
Robbie Averill	ee24413c30	Merge branch '4.2' into 4	2018-10-03 15:28:05 +02:00
Robbie Averill	b0871ebd75	Merge pull request #8417 from creative-commoners/pulls/4.3/many-many-through-sorting-tests ... Add more list sorting tests and fix many many through sorting	2018-10-03 13:30:20 +02:00
Robbie Averill	d1f30a20c2	Merge pull request #8408 from dhensby/pulls/4/test-cleanup ... Test cleanup	2018-10-03 13:28:59 +02:00
Robbie Averill	d74fed554a	Merge pull request #8427 from sminnee/fix-1397 ... FIX: Append any fields that don’t match name in insertBefore/insertAfter	2018-10-03 13:22:23 +02:00
Guy Marriott	5970fc2417	FIX Moving test to correct director	2018-10-03 10:47:17 +13:00
Robbie Averill	c8e7672ede	Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict ... FIX Avoid having search fields with the same names as form elements	2018-10-02 13:43:59 +02:00
Sam Minnee	71dad5f685	FIX: Append any fields that don’t match name in insertBefore/insertAfter ... Previous behaviour was to return false, which has been described as a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397 where the issue was identified.	2018-10-02 10:39:48 +13:00
Robbie Averill	bfe2a7b7e6	Update testSearchFieldSchema to expect namespaced search fields	2018-10-01 12:44:19 +02:00
Harsh Chokshi	60dd5f288b	Implement __isset for ViewableData_Customised ... Resolves #8302.	2018-10-01 09:40:12 +13:00
Dan Hensby	3584598d7a	Minor improvements	2018-09-29 22:51:26 +01:00
Dan Hensby	b0e0566c93	Formatting	2018-09-29 22:51:26 +01:00
Dan Hensby	5a3cc9503b	Formatting	2018-09-29 22:51:26 +01:00
Dan Hensby	2ef63ddbc1	Remove unused function args	2018-09-29 22:51:26 +01:00