Robbie Averill
06acad661f
Remove obsolete branch alias
2018-06-11 12:15:09 +12:00
Robbie Averill
42a15f7241
Merge pull request #253 from creative-commoners/pulls/3.1/fix-tests
...
Fix Tests
2018-05-30 14:36:27 +12:00
Guy
c22daa2ee0
FIX Removing ID from match in tests
2018-05-30 12:25:49 +12:00
Robbie Averill
614b525c04
FIX Loosen assertions in case extension provide extra columns in global state
2018-05-29 18:56:32 +12:00
Dylan Wagstaff
02db1cc86e
[SS-2018-015] Update jQuery version, remove entwine from frontend use
...
jQuery version was extremely old, and was probably stuck at that as a way
of enabling the frivilous use of entwine on the front end for somewhat
trivial ajax submisions. A mild refactor has taken place to leverage newer
jQuery features, and remove outdated dependencies.
Also accompanying this commit are alterations to the markup to make it
more semantically correct (probably not entirely though), and help with
testing the JS functionality of reply forms (when enabled).
2018-05-29 11:40:18 +12:00
Daniel Hensby
aa46291adf
Merge pull request #249 from Dennisprins93/master
2018-05-11 14:14:58 +01:00
Dennisprins93
386f8602f0
Omit http because of potential https conflicts
2018-05-11 14:11:22 +02:00
Robbie Averill
eb0415a938
Merge pull request #245 from creative-commoners/pulls/2.0/reallow-commentform-alterations
...
FIX reintroduce extension hook for comment form rendering
2018-04-04 16:36:51 +12:00
Raissa North
a886f68c58
FIX reintroduce extension hook for comment form rendering
...
In CWP 1.x there was an extension hook to allow alterations to the commenting form.
Since the upgrade of this module for CWP 2.x this was no longer there, meaning functionality
that relied upon it no longer worked. This commit reintroduces this functionality to keep
other modules that apply extensions to that hook, happy.
2018-04-04 15:45:45 +12:00
Dylan
276ddb0c86
Update translations
2018-04-04 10:17:01 +12:00
Dylan Wagstaff
cc46ccf89e
Merge pull request #244 from creative-commoners/pulls/3.1/revert-and-deprecate
...
API Reintroduce abstract handler (previously removed in 192ddbb
2018-04-04 08:34:08 +12:00
Robbie Averill
3e0cae0cc9
API Reintroduce abstract handler (previously removed in 192ddbb) and deprecate for future removal
2018-04-03 12:22:15 +12:00
Robbie Averill
4385299f1f
Merge pull request #240 from sasky/master
...
Tiny bug fixes to work with SS4.
2018-03-14 13:18:55 +13:00
Cameron Grant
abb45aa733
Setting the http error to come from the request handler, and the session coming form the Request objects. Just small bugs fix's so the comment form works with ss4.
2018-03-14 11:18:30 +13:00
Robbie Averill
532b49c537
Merge pull request #235 from creative-commoners/pulls/3.0/run-test-independent-from-template
...
Use FunctionalTest instead of SapphireTest to disable themes.
2018-03-09 17:02:47 +13:00
Raissa North
8d5edc7821
Use FunctionalTest instead of SapphireTest to disable themes.
2018-03-09 16:45:38 +13:00
Robbie Averill
90c42ff027
Merge pull request #232 from creative-commoners/pulls/3.0/bulk-editing-compat
...
API Use concrete Handler implementations for Spam and Approve bulk editing
2018-02-27 09:29:26 +13:00
Daniel Hensby
909066c0a8
Move comment handles to shared parent class
2018-02-26 11:40:49 +00:00
Robbie Averill
192ddbb4b5
API Use concrete Handler implementations for Spam and Approve bulk editing
2018-02-26 23:24:34 +13:00
Daniel Hensby
b90ec7715e
Merge pull request #228 from benwrighton/master
2018-02-02 10:45:48 +00:00
Unknown
ae59e82021
Improve A11y of comment reply.
...
Currently this is a link. Users will expect this link to take them to another part of the page or another page altogether.
There is no indication that it opens or closes an associated form on the same page, nor does it indicate the current state of the “reply to” form.
So, instead of a link, use a button. Add to that button an aria-controls attribute that references the id of the associated form’s container, and an aria-expanded attribute that indicates (true or false) the state of the associated form.
2018-02-01 16:27:30 +13:00
Robbie Averill
17714f221a
Merge pull request #227 from creative-commoners/pulls/3.0/tx-me-js
...
FIX: update javascript requirements so user JS doesn't error
2018-01-29 16:06:27 +13:00
Dylan Wagstaff
a25668eba0
Remove SS 2.x upgrade code that runs every build
2018-01-29 15:26:16 +13:00
Dylan Wagstaff
7b38707fde
FIX: update javascript requirements so user JS doesn't error
2018-01-29 13:04:34 +13:00
Robbie Averill
4bf0a83ad3
FIX Update CommentAdmin test to create a mock session and not assert missing translation
2017-12-19 09:32:56 +13:00
Robbie Averill
b02928e02a
Merge branch '2'
2017-12-19 09:14:47 +13:00
Robbie Averill
4136bd7a63
Update branch alias for 2.x-dev
2017-12-18 18:18:32 +13:00
Robbie Averill
b68ff56624
Merge branch '2.0' into 2.1
2017-12-18 18:17:06 +13:00
Robbie Averill
4e2965e86b
Remove PHP 5.3 from Travis builds
2017-12-18 18:16:58 +13:00
Robbie Averill
85c9981962
Remove Transifex configuration. Commit directly to lang files for SS3.
2017-12-18 18:14:53 +13:00
Robbie Averill
82c4a1b9be
DOCS Update readme badges and add version support note
2017-12-18 14:11:51 +13:00
Dylan Wagstaff
3501ef7490
Merge pull request #224 from creative-commoners/pulls/3.0/fix-comments-admin
...
FIX Duplicated tabset, invalid Pjax request, update translations and Spam/Approve buttons
2017-12-15 10:09:32 +13:00
Robbie Averill
75d7de9aa6
FIX Add extra DataObject stub to CommentsGridFieldActionTest and update expectations
2017-12-14 17:57:03 +13:00
Robbie Averill
216ad8eb54
FIX Duplicated tabset, invalid Pjax request, update translations and Spam/Approve buttons
2017-12-14 16:08:43 +13:00
Daniel Hensby
118de6b595
Merge pull request #222 from creative-commoners/pulls/2.0/vendorise
...
NEW Convert to vendor module, add table_name to test stubs and add PHP 7.2 to travis
2017-12-13 12:07:34 +00:00
Robbie Averill
3f6f651eea
FIX Replace French translation in CommentAdminTest now that it's available
2017-12-12 17:12:10 +13:00
Robbie Averill
c6f8973342
NEW Convert to vendor module, add table_name to test stubs and add PHP 7.2 to travis
2017-12-12 17:03:04 +13:00
Dylan Wagstaff
8919f6da2a
Merge pull request #220 from sheadawson/patch-1
...
FIX SS4: use SilverStripe\CMS\Model\SiteTree in Comment.php
2017-10-26 14:16:05 +13:00
Shea Dawson
b1e9722320
use SilverStripe\CMS\Model\SiteTree;
2017-10-26 13:54:49 +13:00
Will Rossiter
8c43e097cd
Merge pull request #216 from fullscreeninteractive/pulls/travis-fix
...
Travis, 4.0 API fixes
2017-10-10 09:49:13 +13:00
Robbie Averill
7700d88d4a
FIX Remove base path assertions from tests which behave differently using phpdbg
2017-10-10 09:26:17 +13:00
Robbie Averill
fa61608c7d
FIX Merge config in tests, add phpcs and add HTML purifier to Travis builds
2017-10-09 17:26:07 +13:00
Will Rossiter
f294ab26d6
Update tests and lang’s for 4.0
2017-09-18 14:16:24 +12:00
Will Rossiter
9366ef603e
Split comment form out to its’ own class
2017-09-16 09:06:03 +12:00
Will Rossiter
d9333b3160
Test fixes
2017-09-14 11:12:07 +12:00
Will Rossiter
7fff17b317
Correct extra dataobjects array name
2017-09-14 10:28:29 +12:00
Will Rossiter
73a981456f
Use trusty
2017-09-14 10:09:21 +12:00
Will Rossiter
2fc7e7a004
Add phpunit, lint fixes and removed compass for webpack
2017-09-14 10:01:09 +12:00
Will Rossiter
0c964d1ed8
Composer lint
2017-09-14 09:41:11 +12:00
Will Rossiter
82c139e30a
Travis fix
2017-09-13 09:12:09 +12:00
