Commit Graph

431 Commits

Author SHA1 Message Date
Guy Marriott
1358594070
Merge pull request #275 from creative-commoners/pulls/3.1/update-jquery-validator
Update jQuery.validation to 1.19.0
2019-04-05 09:17:06 +13:00
Dylan Wagstaff
6fcc040485 Update jQuery.validation to 1.19.0
jQuery 3.3.1 is still the latest release
2019-03-25 09:56:58 +13:00
Guy Marriott
f5c7024aaf
Merge pull request #276 from creative-commoners/pulls/3.1/deprotocol-my-site
Validate protocol-less URLs
2019-01-11 15:18:27 +13:00
Dylan Wagstaff
3812057b00 Add ability for commenters to enter a URL without a protocol
When posting a comment on the a page with this module applied, there is
an optional input for the commenter to give their URL,presumably their
website. However this input currently validates (via JavaScript) to
allow URLs only iff they have a protocol.

Common use cases when someone is asked for their website in my
experience is to then receive a URL without a protocol, confounded in
that most web browsers will accept this form and automatically add the
http protocol, where a webserver may then redirect to https by default.
This means that all the magic happens behind the scenes and most folks
don't particularly care to think about protocols when entering web
addresses.

Yest this input will only validate true and allow comment submission if
they do.

So now it will allow a protocol-less entry into the URL box.
2019-01-11 15:01:34 +13:00
Guy Marriott
20c6a50f12
Merge pull request #273 from creative-commoners/pulls/3.1/name-that-member
FIX show name of members in summary tables
2019-01-11 14:56:20 +13:00
Dylan Wagstaff
0535d29f8d
Merge pull request #274 from creative-commoners/pulls/3.1/i-de-test-those-labels
FIX Correcting inconsistent capitalisation of label and cleaning up tests
2019-01-11 14:49:02 +13:00
Guy Marriott
7691237fe5
FIX Correcting inconsistent capitalisation of label 2019-01-11 14:17:36 +13:00
Guy Marriott
a57c83c121
Removing superflous i18n test and updating label test to only test labels specifically added 2019-01-11 12:22:31 +13:00
Dylan Wagstaff
dc1f8622e0 FIX show name of members in summary tables
Anonymous comments (posted by the public at large) must have a name
and an email address associated with them. On the other hand, a logged
in user will have the `Member` record details used for this information,
via the Author relationship.

However the summary fields do not allow for this, and only reference
Name and Email on the Comment model directly, so any comment posted by a
logged in member has no data for name and email displayed in the various
GridFields in the CMS for administering comments (either per page, or in
the global ModelAdmin).

To recitfy this we can change the summary fields to use getter methods
that will return the Comment model info, or fall back to the Author
associated Member record if Name and Email are unset on the Comment.
2019-01-11 11:48:51 +13:00
Dylan Wagstaff
4ee9720081
Merge pull request #269 from creative-commoners/pulls/3.1/moderation-labels
FIX Capitalise comment moderation action labels and update i18n syntax in templates
2018-11-28 14:36:30 +13:00
Dylan Wagstaff
d7761290f8
Merge pull request #268 from creative-commoners/pulls/3.1/fix-rss-comments-on-page
FIX RSS feed for comments now render correctly
2018-11-28 14:35:48 +13:00
Robbie Averill
e101b74778 FIX Capitalise comment moderation action labels and update i18n syntax in templates 2018-11-27 13:27:19 +01:00
Robbie Averill
8c08f43376 FIX RSS feed for comments now render correctly
The comment DataList filter applies ParentClass = $className - when this
is the base class, it fails to recognise comments for a BlogPost. This
change uses the late class name instead.
2018-11-27 13:19:55 +01:00
Dylan Wagstaff
f74d91041b
Merge pull request #267 from creative-commoners/pulls/3.1/remove-json-methods
FIX Replace Convert JSON methods with json_* methods, deprecated from SilverStripe 4.4
2018-10-29 11:05:43 +13:00
Robbie Averill
d38e7c5b67 FIX Replace Convert JSON methods with json_* methods, deprecated from SilverStripe 4.4 2018-10-28 21:31:19 +00:00
Guy Marriott
def91bb6d1
Merge pull request #265 from creative-commoners/pulls/3.1/minor-tidyups
Minor tidy ups to code formatting
2018-09-25 11:07:07 +12:00
Robbie Averill
ec60328a0c Use short brackets, injection where possible and type hint injector created objects 2018-09-24 18:20:38 +02:00
Robbie Averill
c0ca79090b Use injection where possible and remove redundant code lines 2018-09-24 18:11:26 +02:00
Robbie Averill
9a57c3802c Remove redundant phpcs rules, reduce some line lengths and use injector to create checkbox fields 2018-09-24 18:09:25 +02:00
Robbie Averill
9f9dc67950
Merge pull request #264 from caffeineinc/bugfix-3.1/xss-session-cookies
Prevent storing formdata to cookies.
2018-09-24 18:07:07 +02:00
Robbie Averill
94950ee79c Tidy up phpcs violations, use short array syntax, optimise class imports 2018-09-24 17:57:31 +02:00
Simon Gow
747d4f4402 Prevent storing formdata to cookies.
- XSS an be stored in a cookie and potentially abused in other ways, so
to prevent this we need to use session instead. This requires the user
to have a session with silverstripe, but this is better than saving
potentially malicious content in cookies. (Also some cookies have
limited length).

@see https://github.com/silverstripe/silverstripe-comments/issues/263
2018-09-20 14:53:35 +12:00
Robbie Averill
cf86b2bb21
Merge pull request #262 from lukereative/pulls/3.1/fix-admin-height
FIX Comment admin form should fill height
2018-08-27 14:59:30 +12:00
Luke Edwards
75d63209aa FIX Comment admin form should fill height 2018-08-27 14:36:44 +12:00
Robbie Averill
19619b083e
Merge pull request #261 from micmania1/bugfix/canpostcomment-not-passed-to-include
BUGFIX canPostComment was being called out of scope
2018-07-03 11:43:34 +12:00
micmania1
c0a01dbc91 BUGFIX created way of knowing whether user has permission to post 2018-07-03 11:00:40 +12:00
Robbie Averill
6d7b14367a
Merge pull request #259 from quantum-dragons/bugfix/reply-form-js-fix
Added JS fix for reply forms
2018-06-25 14:08:08 +12:00
pjayme
77f47af5cb Added JS fix for reply forms - fixes issue where the submit button breaks due to incorrect use of the jQuery validate function 2018-06-25 13:25:08 +12:00
Dylan Wagstaff
a1a42009cc
Merge pull request #258 from creative-commoners/pulls/3.1/travis-recipes
Add various recipe versions to Travis build matrix
2018-06-22 20:10:14 +12:00
Robbie Averill
c7235e1c5d FIX Comments GridField tests now use their own test stubs 2018-06-20 16:53:14 +12:00
Robbie Averill
4e23771d79 Add Team stub class to extra_dataobjects 2018-06-20 16:48:26 +12:00
Robbie Averill
52b8ea9104 Add various recipe versions to Travis build matrix 2018-06-20 16:39:46 +12:00
Robbie Averill
f357ca6b7f
Merge pull request #257 from creative-commoners/pulls/3.1/reply-bug
FIX Bug with requiring login when posting a comment, pass correct controller in
2018-06-20 14:28:22 +12:00
Robbie Averill
886c5be21a FIX Bug with requiring login when posting a comment, pass correct controller in 2018-06-20 14:20:50 +12:00
Dylan Wagstaff
2c00421cd2
Merge pull request #254 from creative-commoners/pulls/3.1/akismet-test-error
FIX Mock akismet spam protector if installed, fixes broken integration tests
2018-06-18 09:59:05 +12:00
Robbie Averill
32ec3bde50
FIX Add getDate method to return created date for comments, tidy up translations
RSS feeds are looking for $Date, so this method maps to the created field in these cases
2018-06-15 16:40:44 +01:00
Robbie Averill
788cb6e6d1 FIX Mock akismet spam protector if installed, fixes broken integration tests 2018-06-15 16:50:14 +12:00
Robbie Averill
eca3ac0e94
FIX Allow tests to handle extra field labels being added in global state 2018-06-13 09:59:23 +12:00
Robbie Averill
06acad661f Remove obsolete branch alias 2018-06-11 12:15:09 +12:00
Robbie Averill
42a15f7241
Merge pull request #253 from creative-commoners/pulls/3.1/fix-tests
Fix Tests
2018-05-30 14:36:27 +12:00
Guy
c22daa2ee0 FIX Removing ID from match in tests 2018-05-30 12:25:49 +12:00
Robbie Averill
614b525c04
FIX Loosen assertions in case extension provide extra columns in global state 2018-05-29 18:56:32 +12:00
Dylan Wagstaff
02db1cc86e [SS-2018-015] Update jQuery version, remove entwine from frontend use
jQuery version was extremely old, and was probably stuck at that as a way
of enabling the frivilous use of entwine on the front end for somewhat
trivial ajax submisions. A mild refactor has taken place to leverage newer
jQuery features, and remove outdated dependencies.

Also accompanying this commit are alterations to the markup to make it
more semantically correct (probably not entirely though), and help with
testing the JS functionality of reply forms (when enabled).
2018-05-29 11:40:18 +12:00
Daniel Hensby
aa46291adf
Merge pull request #249 from Dennisprins93/master 2018-05-11 14:14:58 +01:00
Dennisprins93
386f8602f0
Omit http because of potential https conflicts 2018-05-11 14:11:22 +02:00
Robbie Averill
eb0415a938
Merge pull request #245 from creative-commoners/pulls/2.0/reallow-commentform-alterations
FIX reintroduce extension hook for comment form rendering
2018-04-04 16:36:51 +12:00
Raissa North
a886f68c58 FIX reintroduce extension hook for comment form rendering
In CWP 1.x there was an extension hook to allow alterations to the commenting form.
Since the upgrade of this module for CWP 2.x this was no longer there, meaning functionality
that relied upon it no longer worked. This commit reintroduces this functionality to keep
other modules that apply extensions to that hook, happy.
2018-04-04 15:45:45 +12:00
Dylan
276ddb0c86 Update translations 2018-04-04 10:17:01 +12:00
Dylan Wagstaff
cc46ccf89e
Merge pull request #244 from creative-commoners/pulls/3.1/revert-and-deprecate
API Reintroduce abstract handler (previously removed in 192ddbb) and deprecate for future removal
2018-04-04 08:34:08 +12:00
Robbie Averill
3e0cae0cc9 API Reintroduce abstract handler (previously removed in 192ddbb) and deprecate for future removal 2018-04-03 12:22:15 +12:00