Not/srb2k-leaderboard
1
0
Fork 1
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Use checksums to identify maps #5

Closed
Not wants to merge 3 commits from checksum into master
pull from: checksum
merge into: Not:master
Conversation 3 Commits 3 Files Changed 1 +99 -35
Not commented 2022-07-10 20:47:29 +02:00
Owner
Copy Link

This change will add a map checksum for each score. On the first run it's important to load all maps before this plugin. All scores from which maps are not loaded will be removed from the leaderboard. All removed scores will be written to a new file 'leaderboard_removed_scores.txt'.

This change will add a map checksum for each score. On the first run it's important to **load all maps before this plugin**. All scores from which maps are not loaded will be removed from the leaderboard. All removed scores will be written to a new file 'leaderboard_removed_scores.txt'.
Not force-pushed checksum from ff5f1b041b to db0696294b 2022-07-19 21:03:51 +02:00 Compare
Lonsfor commented 2022-08-14 04:02:48 +02:00
Contributor
Copy Link

looking at this very late, sorry

i don't think this is a good solution as it is very destructive and unintuitive. during normal use one would like to switch packs and having previous times be constantly invalidated would be confusing and frustrating.

looking at this very late, sorry i don't think this is a good solution as it is very destructive and unintuitive. during normal use one would like to switch packs and having previous times be constantly invalidated would be confusing and frustrating.
Not commented 2022-08-21 01:30:08 +02:00
Author
Owner
Copy Link

looking at this very late, sorry

i don't think this is a good solution as it is very destructive and unintuitive. during normal use one would like to switch packs and having previous times be constantly invalidated would be confusing and frustrating.

It's only destructive on the first launch, upgrading from v1.2.19 v1.2.20. After a successful upgrade you should be able to switch map packs freely without worry.

> looking at this very late, sorry > > i don't think this is a good solution as it is very destructive and unintuitive. during normal use one would like to switch packs and having previous times be constantly invalidated would be confusing and frustrating. It's only destructive on the first launch, upgrading from ~~v1.2.19~~ v1.2.20. After a successful upgrade you should be able to switch map packs freely without worry.
Not commented 2022-12-06 19:27:49 +01:00
Author
Owner
Copy Link

Incorporated in #9

Incorporated in #9
Not closed this pull request 2022-12-06 19:27:50 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Not/srb2k-leaderboard#5
No description provided.
Delete Branch "checksum"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?