Commit Graph

183 Commits

Author SHA1 Message Date
Steve Boyd
70d9cd27b2 MNT Update @methods on class docblocks 2023-12-15 17:04:35 +13:00
Sabina Talipova
7c1ca456ba MNT Remove TODO 2023-10-19 14:54:35 +13:00
github-actions
f3bf16a065 Merge branch '5' into 6.0 2023-09-27 12:39:01 +00:00
Bauke Zwaan
a7625eb674 fix typo in translation key 2023-09-20 09:06:04 +02:00
Guy Sartorelli
ca449db3da
Merge branch '5' into 6.0
# Conflicts:
#	tests/php/Model/SubmittedFileFieldTest.php
2023-09-18 10:51:19 +12:00
Steve Boyd
f1510dca9e FIX Renable email link to submitted file 2023-09-06 10:54:20 +12:00
Steve Boyd
127955197d Merge branch '5' into 6.0 2023-08-22 15:38:22 +12:00
Guy Sartorelli
60717e5c04
FIX Use absolute URL for submitted file links in emails (#1226) 2023-08-08 14:53:14 +12:00
Steve Boyd
6f699d05da Merge branch '5.15' into 6.0 2023-06-01 16:05:11 +12:00
Steve Boyd
bf49cab678 FIX Prevent infinite recursion when field display rules are co-dependent 2023-05-31 17:33:35 +12:00
Steve Boyd
77af08139c Merge branch '5' into 6 2023-02-02 16:04:16 +13:00
Steve Boyd
10fc452c8d Merge branch '5.14' into 5 2023-02-02 16:03:12 +13:00
Steve Boyd
58583ded8d Merge branch '5.13' into 5.14 2023-02-02 16:02:49 +13:00
Sabina Talipova
1ea2b8e87f
API Remove deprecated code (#1185) 2023-01-25 13:55:24 +13:00
Steve Boyd
b6fbd374ea MNT Remove legacy upgrader config 2023-01-20 16:21:49 +13:00
Steve Boyd
14e1e5e1fa MNT Broken builds 2023-01-19 21:16:49 +13:00
Steve Boyd
746ac8aedf FIX Use HTMLValue::class 2023-01-18 10:34:46 +13:00
Sabina Talipova
2b9d9833b3 DEP PHP Support in CMS5 2023-01-09 15:24:33 +13:00
jeric realubit
c593138569 FIX Ensure .nolabel is only added once when Hide Title is used 2022-12-07 22:58:34 +13:00
Steve Boyd
7a6cd1c211 API Stop using deprecated API 2022-11-29 09:36:08 +13:00
Steve Boyd
2a2b66a09b API Update deprecations 2022-11-16 11:57:49 +13:00
Loz Calver
c0fd386ea7 Fix incorrect label on unwritten field groups 2022-10-27 10:42:43 +01:00
Dylan Wagstaff
3cd8c7ea77 FIX submission performance issues with large data
The more submissions a form receives, the more submission fields it must
process just to be able to load `getCMSFields`. Arguably submission data
does not belong here, but this is beyond the scope of this patch.

On popular forms it is not improbable to be trying to process 300,000
submitted fields just to test the unique sets of name and title...
however databases have the ability to do this without wasting PHP cycles
and memory, leaving us with a much smaller set to process and hopefully
bypassing one (of several) performance issues with this module.

The consequence of not making allowance for this is that a page in the
CMS suddenly stops saving or loading via web server or PHP (or both)
process timeouts (e.g. saving takes longer than 30 seconds so saving
never happens).
2022-10-23 23:53:46 +13:00
Sabina Talipova
2750bc3a07 ENH Protect access to the uploaded file without permission 2022-08-31 11:04:15 +12:00
Guy Sartorelli
853fb646dc Merge branch '5.13' into 5 2022-06-02 10:43:54 +12:00
Guy Sartorelli
5e226f00dd Merge branch '5.12' into 5.13 2022-06-02 10:43:42 +12:00
Sabina Talipova
63c6326a63 FIX MAX_FILE_SIZE of the last EditableFileField 2022-06-01 14:08:00 +12:00
Sabina Talipova
92aded3016 Protect uploads if folder for EditableFileField was removed 2022-05-25 14:07:35 +12:00
Steve Boyd
792d61fded ENH PHP 8.1 compatibility 2022-04-13 13:52:56 +12:00
Florian Thoma
33e9a25688 ENH Add config to hide invisible fields from email output 2022-03-15 11:46:18 +11:00
Guy Sartorelli
60cd3d0937
FIX Ensure all fields are available for updateCMSFields(). (#1089) 2022-03-03 16:47:45 +13:00
Steve Boyd
9d5b8c1b8e
Merge pull request #1111 from alex-dna/fix/controller-name
API Use controller_name static config
2021-10-19 10:47:46 +13:00
Alexandre
9f7e55b346 Use controller_name static config instead of method for better inheritance 2021-09-17 08:23:39 +12:00
Maxime Rainville
1637a29cb4 Merge branch '5.9' into 5 2021-08-26 17:00:48 +12:00
UndefinedOffset
63a1d1deb2
BUGFIX: Fixed issue causing the regex on windows to throw an error due to escaping of the parenthesis caused by DIRECTORY_SEPARATOR 2021-07-19 11:36:03 -03:00
GuySartorelli
02c15f321a
Fix: Allow removing the Versioned extension from EditableFormField
fixes #1082
2021-06-21 09:58:35 +12:00
Maxime Rainville
ab20f881eb Merge branch '5.9' into 5 2021-06-01 14:51:34 +12:00
Steve Boyd
b13cb73deb FIX Add namespaces back to translation files, use EditibleFileField class 2021-05-31 12:54:31 +12:00
Daniel Hensby
41fa8f0718
Merge pull request #1051 from wilr/wilr-patch-1
FIX Uploaded files not appearing in emails and cleanup deleted files.
2021-05-17 09:10:31 +01:00
Will Rossiter
beaf901208
FIX When deleting form submission, delete linked file 2021-05-17 09:13:19 +12:00
Andre Kiste
6b94f9b791
Merge pull request #1040 from creative-commoners/pulls/5.8/email-preview
FIX Show correct fields in email preview
2021-05-03 15:25:18 +12:00
Will Rossiter
e925aa1979
FIX Uploaded files not appearing in emails
As files uploaded into `DRAFT` mode ensure that these are still displayed in the submitted form.
2021-03-22 21:30:14 +13:00
Chris Penny
72a213790e
MNT Update docblocks and import statements (#1044) 2021-02-26 16:13:23 +13:00
Michal Kleiner
0abda42179 Use correct directory separator on Windows when selecting email templates 2021-02-10 11:52:15 +13:00
Steve Boyd
8801790b66 FIX Show correct fields in email preview
Co-authored-by: Michael Caruana <mikeyc7m@users.noreply.github.com>
2021-01-17 22:55:10 +13:00
Steve Boyd
ce2fe31bdd Merge branch '5.7' into 5.8 2021-01-17 15:58:55 +13:00
Dylan Wagstaff
c0a30f1b6a
FIX unrequire fields when they become dataless (#1016)
* FIX unrequire fields when they become dataless

When fields that collect input data are changed in configuration via the
CMS to become fields that no longer collect input data (e.g. TextField
-> HTML Block), submitting the resulting form results in a fatal error,
server 500 response, etc. due to trying to check if a field without data
(ever) has data in it.

To circumvent this we can set the required state to false if the field
is being converted to one that does not collect data (which FormField
API conveniently provides a check for).

* Move parent::onBeforeWrite() to top of function

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2021-01-17 15:55:47 +13:00
Michal Kleiner
66bbe44972
FIX Add missing dots in translation string references 2020-12-02 10:01:50 +13:00
Steve Boyd
f81360e737 Merge branch '5.7' into 5 2020-11-12 15:18:00 +13:00
Steve Boyd
ead1827aa1 Merge branch '5.6' into 5.7 2020-11-12 15:17:31 +13:00