c0a30f1b6a
FIX unrequire fields when they become dataless ( #1016 )
...
* FIX unrequire fields when they become dataless
When fields that collect input data are changed in configuration via the
CMS to become fields that no longer collect input data (e.g. TextField
-> HTML Block), submitting the resulting form results in a fatal error,
server 500 response, etc. due to trying to check if a field without data
(ever) has data in it.
To circumvent this we can set the required state to false if the field
is being converted to one that does not collect data (which FormField
API conveniently provides a check for).
* Move parent::onBeforeWrite() to top of function
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2021-01-17 15:55:47 +13:00
a42729679b
FIX account for owner class while removing orphans ( #1018 )
...
* FIX account for owner class while removing orphans
* Explicitly set $page and $block ID's in test fixture
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2021-01-17 15:29:33 +13:00
e7f51d227a
ENH Move jQuery include away from CDN ( #1019 )
...
- Move jQuery include away from CDN
2021-01-17 14:37:01 +13:00
ead1827aa1
Merge branch '5.6' into 5.7
2020-11-12 15:17:31 +13:00
8dd6950218
Merge pull request #1020 from NightJar/fix/5.7/maxfilesize
...
FIX correctly calculate MaxFileSizeMB
2020-11-11 15:10:01 +13:00
0ce94b75f5
FIX correctly calculate MaxFileSizeMB
...
The inputted value is intended to represent megabytes, but is only
multiplied by 1024 - meaning it'd represent kilobytes. This is then used
to compare with the PHP setting number, which is bytes in the range of
megabytes. Kilobytes are always under megabytes, meaning size
comparisons elsewhere in the code are always true.
We should ensure the calculation for validation is correct.
2020-11-01 11:31:23 +13:00
d2bf27c847
MNT Fix broken merged up ( #1013 )
2020-10-22 15:47:17 +13:00
4eb0fe25b9
Merge branch '5.5' into 5.6
2020-10-22 10:22:19 +13:00
61454fc5b9
Merge branch '5.4' into 5.5
2020-10-22 10:19:22 +13:00
42df67fe76
Merge branch '5.6' into 5.7
2020-09-22 10:29:09 +12:00
e1746d3e05
Merge pull request #1002 from creative-commoners/pulls/5.6/vertical-align-icon
...
FIX Vertically align confirm folder icon
2020-09-22 10:25:47 +12:00
347cfe6101
Merge pull request #1003 from creative-commoners/pulls/5/remove-boostrap3-class
...
BUG Remove old boostrap 3 CSS class
2020-09-16 12:26:47 +12:00
24e770e00d
BUG Remove old boostrap 3 CSS class
2020-09-16 11:38:33 +12:00
f09691f9cb
FIX Vertically align confirm folder icon
2020-09-15 15:24:16 +12:00
268d4e0be9
Merge pull request #995 from silverstripe/dependabot/npm_and_yarn/elliptic-6.5.3
2020-09-04 00:03:07 +00:00
dd9618e768
Merge branch '5.6' into 5
2020-09-03 09:35:15 +12:00
162319512b
Merge pull request #1000 from creative-commoners/pulls/5.6/submit-error
...
FIX Check hidden inputs exist to prevent browser alert when submitting form
2020-09-02 13:47:09 +12:00
f5d07aa682
FIX Check hidden inputs exist to prevent browser alert when submitting form
2020-09-02 13:21:53 +12:00
d82bb6b25e
Merge pull request #998 from creative-commoners/pulls/5.6/default-translations
...
FIX Use translation string that belongs to UserDefinedFormAdmin
2020-08-19 09:19:31 -07:00
8d09cb171f
FIX Use translation string that belongs to UserDefinedFormAdmin
...
This is to for the benefit of cow translate which did not like the use of _t(CMSMain::class
2020-08-18 12:20:10 +12:00
caeef2fc48
Update translations
2020-08-18 11:04:37 +12:00
719ed96570
Bump elliptic from 6.5.1 to 6.5.3
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.1 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.1...v6.5.3 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-07-30 12:38:37 +00:00
bd494e1f78
Merge pull request #992 from creative-commoners/pulls/5.6/caught-in-the-middlecolumn
...
FIX Place validation messages on .field if .middleColumn is missing
2020-07-24 14:45:38 +12:00
53e4ba079f
Merge pull request #987 from silverstripe/dependabot/npm_and_yarn/lodash-4.17.19
2020-07-22 10:37:53 +00:00
792fd82419
FIX Place validation messages on .field if .middleColumn is missing
...
Checkbox and OptionSet fields attempt to place validation errors in
.middleColumn to align them with the label, but in some custom themes
this is not available, so the error is swallowed instead. Instead, we
should place it in the main wrapping .field element as a fallback.
2020-07-22 15:48:00 +12:00
677b3dadea
Merge pull request #988 from creative-commoners/pulls/5/checkbox-radio-messages
...
FIX Show custom validation message for checkbox and radio groups
2020-07-22 11:49:17 +12:00
4bbd57c5f6
Bump lodash from 4.17.15 to 4.17.19
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-07-21 20:26:35 +00:00
66e46240f7
Merge pull request #985 from silverstripe/dependabot/npm_and_yarn/npm-registry-fetch-4.0.5
2020-07-21 20:25:38 +00:00
81fcd669a2
FIX Show custom validation message for checkbox and radio groups
2020-07-21 17:30:55 +12:00
46c6d93d9c
Merge branch '5.6' into 5
2020-07-17 23:24:37 +12:00
de5a671645
Merge pull request #986 from creative-commoners/pulls/5.6/trim-recipient-email
...
FIX Trim recipient email addresses before write
2020-07-15 09:01:24 +12:00
59cd87d842
FIX Trim recipient email addresses before write
2020-07-14 16:41:36 +12:00
27228d12af
[CVE-2020-9309] Require MimeUploadValidator on userformis' File Upload field
2020-07-13 11:33:46 +12:00
9e008e6341
[CVE-2020-9309] Require MimeUploadValidator on userformis' File Upload field
2020-07-13 11:25:17 +12:00
575d1f99a4
Merge branch '5.5' into 5.6
2020-07-09 14:40:04 +12:00
3f474b6cca
Bump npm-registry-fetch from 4.0.2 to 4.0.5
...
Bumps [npm-registry-fetch](https://github.com/npm/registry-fetch ) from 4.0.2 to 4.0.5.
- [Release notes](https://github.com/npm/registry-fetch/releases )
- [Changelog](https://github.com/npm/npm-registry-fetch/blob/latest/CHANGELOG.md )
- [Commits](https://github.com/npm/registry-fetch/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2020-07-07 19:51:29 +00:00
1dae4472ae
Merge pull request #980 from sachajudd/docs/secure-files
...
DOCS Add user help for securing file upload form submissions
2020-07-07 12:32:55 +12:00
d24db1886d
Update docs/en/userguide/form-submissions.md
...
Co-authored-by: Bryn Whyman <bryn.whyman@silverstripe.com>
2020-07-07 10:40:08 +12:00
a8c7623867
DOCS Add user help for securing file upload form submissions
...
[ci skip]
2020-07-06 17:19:26 +12:00
0c09eec6f8
DOC Add docs around creating custom fields. Fixed #928 ( #932 )
...
* Add docs around creating custom fields
* Update docs/en/creating-custom-fields.md
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2020-07-06 08:41:59 +12:00
6ca8ce2596
FIX Fixing plain email blank file field value ( #940 )
...
* Fixing plain email blank file field value
2020-07-01 09:00:31 +12:00
8c2d9a9438
Merge branch '5.5' into 5
2020-06-25 17:15:16 +12:00
9645d9d809
Merge branch '5.4' into 5.5
2020-06-25 17:07:42 +12:00
6f04f9537d
Fix linting issue
2020-06-25 17:04:20 +12:00
b80868c091
Merge branch '5.4' into 5.5
2020-06-25 16:57:44 +12:00
de9b93f5cd
Merge branch '5.3' into 5.4
2020-06-25 16:53:04 +12:00
3dffbef9f2
Merge branch '5.2' into 5.3
2020-06-25 16:44:42 +12:00
a3896eb39e
Test postgresql ( #979 )
2020-06-25 16:44:11 +12:00
7eda3c23d9
Require recipe-cms 4.6
2020-06-18 14:30:24 +12:00
1253a190c7
Merge branch '5.6' into 5
2020-06-18 12:13:47 +12:00
Dylan Wagstaff
Steve Boyd
Scott Hutchinson
Dylan Wagstaff
Maxime Rainville
Sacha Judd
dependabot[bot]
Garion Herman
Robbie Averill
Andre Kiste
Chris Penny
3Dgoo