tonyair
/
silverstripe-userforms
mirror of https://github.com/silverstripe/silverstripe-userforms.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
1,756 Commits 32 Branches 156 Tags 13 MiB
Commit Graph

1756 Commits

Author SHA1 Message Date
Guy Sartorelli 923d170847
Update translations 2022-11-10 01:56:21 +00:00
Michal Kleiner a356b0f8ce
Merge pull request #1017 from NightJar/new/5/set-max-upload-size-via-config 2022-10-28 14:41:21 +13:00
Daniel Hensby 3fb760de84
Merge pull request #1174 from kinglozzer/fix-typo 
Fix incorrect label on unwritten field groups
 2022-10-27 13:47:14 +01:00
Loz Calver c0fd386ea7 Fix incorrect label on unwritten field groups 2022-10-27 10:42:43 +01:00
Dylan Wagstaff 0ff72734dd NEW Maximum email attachment size can be configured 
Previously hard coded size of 1MB meant any file larger was excluded
from recipient emails - often confusing for CMS admins configuring an
advanced use case for a userform, expecting to recieve files to begin a
business process external to the website.

The configuration has been made to support PHP 'shorthand byte values'
https://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes
in the configuration option. This give flexibility around oddly
specific limits, but can also be used to set as 0, disabling attachments

Tests are updated to set up a known state before testing, as to be able
to accurately assert the results. One should test the class they intend,
not an Injector service of some unknown element.
 2022-10-24 20:12:58 +13:00
Michal Kleiner 25e64441b8
Merge pull request #1172 from NightJar/pulls/5/performance-tweaks 2022-10-24 00:17:29 +13:00
Dylan Wagstaff 3cd8c7ea77 FIX submission performance issues with large data 
The more submissions a form receives, the more submission fields it must
process just to be able to load `getCMSFields`. Arguably submission data
does not belong here, but this is beyond the scope of this patch.

On popular forms it is not improbable to be trying to process 300,000
submitted fields just to test the unique sets of name and title...
however databases have the ability to do this without wasting PHP cycles
and memory, leaving us with a much smaller set to process and hopefully
bypassing one (of several) performance issues with this module.

The consequence of not making allowance for this is that a page in the
CMS suddenly stops saving or loading via web server or PHP (or both)
process timeouts (e.g. saving takes longer than 30 seconds so saving
never happens).
 2022-10-23 23:53:46 +13:00
Guy Sartorelli 198466a979
Merge pull request #1169 from creative-commoners/pulls/5/review-behat-tests 
ENH Replace ADMIN permissions with less permissions in Behat test
 2022-09-15 11:13:25 +12:00
Sabina Talipova 2444e844f1 ENH Replace ADMIN permissions with less permissions in Behat test 2022-09-15 09:24:03 +12:00
Maxime Rainville 41fda09b1b
Merge pull request #1167 from creative-commoners/pulls/5/access-submitted-file 
ENH Protect access to the uploaded file without permission
 2022-08-31 11:35:33 +12:00
Sabina Talipova 2750bc3a07 ENH Protect access to the uploaded file without permission 2022-08-31 11:04:15 +12:00
Maxime Rainville 22984380a2
Merge pull request #1164 from creative-commoners/pulls/5/fix-userdoc-deploy 
MNT Fix github action for deploying userdocs
 2022-08-24 11:25:36 +12:00
Guy Sartorelli b08f5de219
MNT Fix github action for deploying userdocs 2022-08-23 15:19:56 +12:00
Guy Sartorelli a93fedafff
Merge pull request #1163 from creative-commoners/pulls/5/userhelp-fix 
DOC Correct title for userhelp
 2022-08-22 11:05:37 +12:00
Maxime Rainville 0a53cef94f DOC Correct title for userhelp 2022-08-20 21:03:34 +12:00
Steve Boyd 4ea877c7e3 Merge branch '5.13' into 5 2022-08-02 19:01:57 +12:00
Steve Boyd 704201bb34 Merge branch '5.12' into 5.13 2022-08-02 19:01:43 +12:00
Guy Sartorelli 3532127f25
Merge pull request #1161 from creative-commoners/pulls/5.12/standardise-modules 
MNT Standardise modules
 2022-08-02 15:50:27 +12:00
Steve Boyd cc601bb942 MNT Standardise modules 2022-08-01 16:23:44 +12:00
Guy Sartorelli 1a2303a579
Merge pull request #1160 from creative-commoners/pulls/5/update-js 
MNT Use up­date-js action
 2022-07-29 18:09:26 +12:00
Steve Boyd 77ff5e4e82 MNT Use update-js action 2022-07-29 13:08:35 +12:00
Guy Sartorelli 516198455e
Merge pull request #1159 from creative-commoners/pulls/5/prefer-lowest 
DEP Ensure phpunit9 compatible version of segment-field
 2022-07-28 09:41:23 +12:00
Steve Boyd bb101a6ccd DEP Ensure phpunit9 compatible version of segment-field 2022-07-27 11:12:16 +12:00
Steve Boyd 962fda9d27 Merge branch '5.13' into 5 2022-07-25 11:48:40 +12:00
Steve Boyd ddec91a52f Merge branch '5.12' into 5.13 2022-07-25 11:48:26 +12:00
Guy Sartorelli a82a924906
Merge pull request #1156 from creative-commoners/pulls/5.12/module-standards 
MNT Use GitHub Actions CI
 2022-07-15 12:32:30 +12:00
Steve Boyd 13d6ddc80e MNT Use GitHub Actions CI 2022-07-14 12:50:11 +12:00
Steve Boyd 658f069ac7
Merge pull request #1154 from creative-commoners/pulls/5/remove-cow-config 
MNT Remove unnecessary cow config.
 2022-06-22 09:00:26 +12:00
Guy Sartorelli 842a7bc5cc MNT Remove unnecessary cow config. 
Creating releases with changelogs in github is no longer cow's
responsibility.
 2022-06-16 15:57:34 +12:00
Guy Sartorelli 853fb646dc Merge branch '5.13' into 5 2022-06-02 10:43:54 +12:00
Guy Sartorelli 5e226f00dd Merge branch '5.12' into 5.13 2022-06-02 10:43:42 +12:00
Guy Sartorelli 7e18097b0a
Merge pull request #1151 from creative-commoners/pulls/5.12/wrong-max-file-size 
FIX MAX_FILE_SIZE of the last EditableFileField
 2022-06-02 10:40:58 +12:00
Steve Boyd 1f7f59fbd5
Merge pull request #1150 from creative-commoners/pulls/5/fix-kitchen-sink-ci 
MNT Explicitly set class for test polymorphic has_one
 2022-06-01 15:31:55 +12:00
Sabina Talipova 63c6326a63 FIX MAX_FILE_SIZE of the last EditableFileField 2022-06-01 14:08:00 +12:00
Guy Sartorelli 12ccb9636c MNT Explicitly set class for test polymorphic has_one 2022-05-31 15:07:04 +12:00
Guy Sartorelli 1144d1d0ad Merge branch '5.13' into 5 2022-05-27 11:33:10 +12:00
Guy Sartorelli b2ef93838c Merge branch '5.12' into 5.13 2022-05-27 11:32:55 +12:00
Steve Boyd 828e7dd884 Merge branch '5.13' into 5 2022-05-27 10:27:23 +12:00
Guy Sartorelli 84d80e3275
Merge pull request #1149 from creative-commoners/pulls/5.13/segment-field 
DEP Require a minimum version of segment field that installs in the vendor folder
 2022-05-27 10:07:58 +12:00
Steve Boyd 8feb4baaa3 DEP Require a minimum version of segment field that installs in the vendor folder 2022-05-26 13:13:18 +12:00
Steve Boyd d97bc58f20
Merge pull request #1144 from creative-commoners/pulls/5/upload-protected-folder 
Protect uploads if folder for EditableFileField was removed
 2022-05-25 17:54:44 +12:00
Sabina Talipova 92aded3016 Protect uploads if folder for EditableFileField was removed 2022-05-25 14:07:35 +12:00
Guy Sartorelli 52804b026c
Merge pull request #1148 from creative-commoners/pulls/5.12/bug-previous-form-step 
FIX Not working previous form step if there is more than one hidden page
 2022-05-25 13:58:46 +12:00
Sabina Talipova 0c066a3cfc FIX Add skipping argument and new behat tests 2022-05-25 13:11:29 +12:00
Guy Sartorelli d6a42d9530
Merge pull request #1146 from creative-commoners/pulls/5/save-values-on-add 
ENH Save modified form data when adding new field
 2022-05-23 14:34:41 +12:00
Steve Boyd d81da1eedf ENH Save modified form data when adding new field 2022-05-23 14:01:31 +12:00
Guy Sartorelli ee8fe59c6c Merge branch '5.13' into 5 2022-05-11 12:26:55 +12:00
Michal Kleiner cac56c4081
Merge pull request #1095 from silverstripe/dependabot/npm_and_yarn/path-parse-1.0.7 
Bump path-parse from 1.0.6 to 1.0.7
 2022-05-10 21:55:15 +12:00
Steve Boyd 0f12e1ecfc Update translations 2022-05-04 13:29:41 +12:00
dependabot[bot] ee2967722b
Merge pull request #1142 from silverstripe/dependabot/npm_and_yarn/async-2.6.4 2022-05-03 09:52:11 +00:00