mirror of
https://github.com/silverstripe/silverstripe-reports
synced 2024-10-22 11:05:53 +02:00
2dd96a4050
BUGFIX Ensure that VirtualPage $allowed_children are checked on original classes to avoid allowing more than necessary (AIR-38)
374 lines
12 KiB
PHP
374 lines
12 KiB
PHP
<?php
|
|
|
|
class VirtualPageTest extends SapphireTest {
|
|
static $fixture_file = 'VirtualPageTest.yml';
|
|
|
|
protected $extraDataObjects = array(
|
|
'VirtualPageTest_ClassA',
|
|
'VirtualPageTest_ClassB',
|
|
);
|
|
|
|
/**
|
|
* Test that, after you update the source page of a virtual page, all the virtual pages
|
|
* are updated
|
|
*/
|
|
function testEditingSourcePageUpdatesVirtualPages() {
|
|
$master = $this->objFromFixture('Page', 'master');
|
|
$master->Title = "New title";
|
|
$master->MenuTitle = "New menutitle";
|
|
$master->Content = "<p>New content</p>";
|
|
$master->write();
|
|
|
|
$vp1 = $this->objFromFixture('VirtualPage', 'vp1');
|
|
$vp2 = $this->objFromFixture('VirtualPage', 'vp2');
|
|
|
|
$this->assertEquals("New title", $vp1->Title);
|
|
$this->assertEquals("New title", $vp2->Title);
|
|
$this->assertEquals("New menutitle", $vp1->MenuTitle);
|
|
$this->assertEquals("New menutitle", $vp2->MenuTitle);
|
|
$this->assertEquals("<p>New content</p>", $vp1->Content);
|
|
$this->assertEquals("<p>New content</p>", $vp2->Content);
|
|
}
|
|
|
|
/**
|
|
* Test that, after you publish the source page of a virtual page, all the already published
|
|
* virtual pages are published
|
|
*/
|
|
function testPublishingSourcePagePublishesAlreadyPublishedVirtualPages() {
|
|
$this->logInWithPermission('ADMIN');
|
|
|
|
$master = $this->objFromFixture('Page', 'master');
|
|
$master->doPublish();
|
|
|
|
$master->Title = "New title";
|
|
$master->MenuTitle = "New menutitle";
|
|
$master->Content = "<p>New content</p>";
|
|
$master->write();
|
|
|
|
$vp1 = DataObject::get_by_id("VirtualPage", $this->idFromFixture('VirtualPage', 'vp1'));
|
|
$vp2 = DataObject::get_by_id("VirtualPage", $this->idFromFixture('VirtualPage', 'vp2'));
|
|
$this->assertTrue($vp1->doPublish());
|
|
$this->assertTrue($vp2->doPublish());
|
|
|
|
$master->doPublish();
|
|
|
|
Versioned::reading_stage("Live");
|
|
$vp1 = DataObject::get_by_id("VirtualPage", $this->idFromFixture('VirtualPage', 'vp1'));
|
|
$vp2 = DataObject::get_by_id("VirtualPage", $this->idFromFixture('VirtualPage', 'vp2'));
|
|
|
|
$this->assertNotNull($vp1);
|
|
$this->assertNotNull($vp2);
|
|
|
|
$this->assertEquals("New title", $vp1->Title);
|
|
$this->assertEquals("New title", $vp2->Title);
|
|
$this->assertEquals("New menutitle", $vp1->MenuTitle);
|
|
$this->assertEquals("New menutitle", $vp2->MenuTitle);
|
|
$this->assertEquals("<p>New content</p>", $vp1->Content);
|
|
$this->assertEquals("<p>New content</p>", $vp2->Content);
|
|
Versioned::reading_stage("Stage");
|
|
}
|
|
|
|
/**
|
|
* Test that virtual pages get the content from the master page when they are created.
|
|
*/
|
|
function testNewVirtualPagesGrabTheContentFromTheirMaster() {
|
|
$vp = new VirtualPage();
|
|
$vp->write();
|
|
|
|
$vp->CopyContentFromID = $this->idFromFixture('Page', 'master');
|
|
$vp->write();
|
|
|
|
$this->assertEquals("My Page", $vp->Title);
|
|
$this->assertEquals("My Page Nav", $vp->MenuTitle);
|
|
|
|
$vp->CopyContentFromID = $this->idFromFixture('Page', 'master2');
|
|
$vp->write();
|
|
|
|
$this->assertEquals("My Other Page", $vp->Title);
|
|
$this->assertEquals("My Other Page Nav", $vp->MenuTitle);
|
|
}
|
|
|
|
/**
|
|
* Virtual pages are always supposed to chose the same content as the published source page.
|
|
* This means that when you publish them, they should show the published content of the source
|
|
* page, not the draft content at the time when you clicked 'publish' in the CMS.
|
|
*/
|
|
function testPublishingAVirtualPageCopiedPublishedContentNotDraftContent() {
|
|
$p = new Page();
|
|
$p->Content = "published content";
|
|
$p->write();
|
|
$p->doPublish();
|
|
|
|
// Don't publish this change - published page will still say 'published content'
|
|
$p->Content = "draft content";
|
|
$p->write();
|
|
|
|
$vp = new VirtualPage();
|
|
$vp->CopyContentFromID = $p->ID;
|
|
$vp->write();
|
|
|
|
$vp->doPublish();
|
|
|
|
// The draft content of the virtual page should say 'draft content'
|
|
$this->assertEquals('draft content',
|
|
DB::query('SELECT "Content" from "SiteTree" WHERE "ID" = ' . $vp->ID)->value());
|
|
|
|
// The published content of the virtual page should say 'published content'
|
|
$this->assertEquals('published content',
|
|
DB::query('SELECT "Content" from "SiteTree_Live" WHERE "ID" = ' . $vp->ID)->value());
|
|
}
|
|
|
|
function testCantPublishVirtualPagesBeforeTheirSource() {
|
|
// An unpublished source page
|
|
$p = new Page();
|
|
$p->Content = "test content";
|
|
$p->write();
|
|
|
|
// With no source page, we can't publish
|
|
$vp = new VirtualPage();
|
|
$vp->write();
|
|
$this->assertFalse($vp->canPublish());
|
|
|
|
// When the source page isn't published, we can't publish
|
|
$vp->CopyContentFromID = $p->ID;
|
|
$vp->write();
|
|
$this->assertFalse($vp->canPublish());
|
|
|
|
// Once the source page gets published, then we can publish
|
|
$p->doPublish();
|
|
$this->assertTrue($vp->canPublish());
|
|
}
|
|
|
|
function testCanDeleteOrphanedVirtualPagesFromLive() {
|
|
// An unpublished source page
|
|
$p = new Page();
|
|
$p->Content = "test content";
|
|
$p->write();
|
|
$p->doPublish();
|
|
|
|
$vp = new VirtualPage();
|
|
$vp->CopyContentFromID = $p->ID;
|
|
$vp->write();
|
|
|
|
// Delete the source page
|
|
$this->assertTrue($vp->canPublish());
|
|
$this->assertTrue($p->doDeleteFromLive());
|
|
|
|
// Confirm that we can unpublish, but not publish
|
|
$this->assertTrue($vp->canDeleteFromLive());
|
|
$this->assertFalse($vp->canPublish());
|
|
|
|
// Confirm that the action really works
|
|
$this->assertTrue($vp->doDeleteFromLive());
|
|
$this->assertNull(DB::query("SELECT \"ID\" FROM \"SiteTree_Live\" WHERE \"ID\" = $vp->ID")->value());
|
|
}
|
|
|
|
function testVirtualPagesArentInappropriatelyPublished() {
|
|
// Fixture
|
|
$p = new Page();
|
|
$p->Content = "test content";
|
|
$p->write();
|
|
$vp = new VirtualPage();
|
|
$vp->CopyContentFromID = $p->ID;
|
|
$vp->write();
|
|
|
|
// VP is oragne
|
|
$this->assertTrue($vp->IsAddedToStage);
|
|
|
|
// VP is still orange after we publish
|
|
$p->doPublish();
|
|
$this->fixVersionNumberCache($vp);
|
|
$this->assertTrue($vp->IsAddedToStage);
|
|
|
|
// A new VP created after P's initial construction
|
|
$vp2 = new VirtualPage();
|
|
$vp2->CopyContentFromID = $p->ID;
|
|
$vp2->write();
|
|
$this->assertTrue($vp2->IsAddedToStage);
|
|
|
|
// Also remains orange after a republish
|
|
$p->Content = "new content";
|
|
$p->write();
|
|
$p->doPublish();
|
|
$this->fixVersionNumberCache($vp2);
|
|
$this->assertTrue($vp2->IsAddedToStage);
|
|
|
|
// VP is now published
|
|
$vp->doPublish();
|
|
|
|
$this->fixVersionNumberCache($vp);
|
|
$this->assertTrue($vp->ExistsOnLive);
|
|
$this->assertFalse($vp->IsModifiedOnStage);
|
|
|
|
// P edited, VP and P both go green
|
|
$p->Content = "third content";
|
|
$p->write();
|
|
|
|
$this->fixVersionNumberCache($vp, $p);
|
|
$this->assertTrue($p->IsModifiedOnStage);
|
|
$this->assertTrue($vp->IsModifiedOnStage);
|
|
|
|
// Publish, VP goes black
|
|
$p->doPublish();
|
|
$this->fixVersionNumberCache($vp);
|
|
$this->assertTrue($vp->ExistsOnLive);
|
|
$this->assertFalse($vp->IsModifiedOnStage);
|
|
}
|
|
|
|
function testVirtualPagesCreateVersionRecords() {
|
|
$source = $this->objFromFixture('Page', 'master');
|
|
$source->Title = "T0";
|
|
$source->write();
|
|
$source->doPublish();
|
|
|
|
// Creating a new VP to ensure that Version #s are out of alignment
|
|
$vp = new VirtualPage();
|
|
$vp->CopyContentFromID = $source->ID;
|
|
$vp->write();
|
|
|
|
$source->Title = "T1";
|
|
$source->write();
|
|
$source->Title = "T2";
|
|
$source->write();
|
|
|
|
$this->assertEquals($vp->ID, DB::query("SELECT \"RecordID\" FROM \"SiteTree_versions\"
|
|
WHERE \"RecordID\" = $vp->ID AND \"Title\" = 'T1'")->value());
|
|
$this->assertEquals($vp->ID, DB::query("SELECT \"RecordID\" FROM \"SiteTree_versions\"
|
|
WHERE \"RecordID\" = $vp->ID AND \"Title\" = 'T2'")->value());
|
|
$this->assertEquals($vp->ID, DB::query("SELECT \"RecordID\" FROM \"SiteTree_versions\"
|
|
WHERE \"RecordID\" = $vp->ID AND \"Version\" = $vp->Version")->value());
|
|
|
|
$vp->doPublish();
|
|
|
|
// Check that the published content is copied from the published page, with a legal
|
|
// version
|
|
$liveVersion = DB::query("SELECT \"Version\" FROM \"SiteTree_Live\" WHERE \"ID\" = $vp->ID")->value();
|
|
|
|
$this->assertEquals("T0", DB::query("SELECT \"Title\" FROM \"SiteTree_Live\"
|
|
WHERE \"ID\" = $vp->ID")->value());
|
|
|
|
// SiteTree_Live.Version should reference a legal entry in SiteTree_versions for the
|
|
// virtual page
|
|
$this->assertEquals("T0", DB::query("SELECT \"Title\" FROM \"SiteTree_versions\"
|
|
WHERE \"RecordID\" = $vp->ID AND \"Version\" = $liveVersion")->value());
|
|
}
|
|
|
|
function fixVersionNumberCache($page) {
|
|
$pages = func_get_args();
|
|
foreach($pages as $p) {
|
|
Versioned::prepopulate_versionnumber_cache('SiteTree', 'Stage', array($p->ID));
|
|
Versioned::prepopulate_versionnumber_cache('SiteTree', 'Live', array($p->ID));
|
|
}
|
|
}
|
|
|
|
function testUnpublishingSourcePageOfAVirtualPageAlsoUnpublishesVirtualPage() {
|
|
// Create page and virutal page
|
|
$p = new Page();
|
|
$p->Title = "source";
|
|
$p->write();
|
|
$this->assertTrue($p->doPublish());
|
|
$vp = new VirtualPage();
|
|
$vp->CopyContentFromID = $p->ID;
|
|
$vp->write();
|
|
$this->assertTrue($vp->doPublish());
|
|
|
|
// All is fine, the virtual page doesn't have a broken link
|
|
$this->assertFalse($vp->HasBrokenLink);
|
|
|
|
// Unpublish the source page, confirm that the virtual page has also been unpublished
|
|
$p->doUnpublish();
|
|
|
|
// The draft VP still has the CopyContentFromID link
|
|
$vp->flushCache();
|
|
$vp = DataObject::get_by_id('SiteTree', $vp->ID);
|
|
$this->assertEquals($p->ID, $vp->CopyContentFromID);
|
|
|
|
$vpLive = Versioned::get_one_by_stage('SiteTree', 'Live', '"SiteTree"."ID" = ' . $vp->ID);
|
|
$this->assertNull($vpLive);
|
|
|
|
// Delete from draft, confirm that the virtual page has a broken link on the draft site
|
|
$p->delete();
|
|
$vp->flushCache();
|
|
$vp = DataObject::get_by_id('SiteTree', $vp->ID);
|
|
$this->assertEquals(1, $vp->HasBrokenLink);
|
|
}
|
|
|
|
function testDeletingFromLiveSourcePageOfAVirtualPageAlsoUnpublishesVirtualPage() {
|
|
// Create page and virutal page
|
|
$p = new Page();
|
|
$p->Title = "source";
|
|
$p->write();
|
|
$this->assertTrue($p->doPublish());
|
|
$vp = new VirtualPage();
|
|
$vp->CopyContentFromID = $p->ID;
|
|
$vp->write();
|
|
$this->assertTrue($vp->doPublish());
|
|
|
|
// All is fine, the virtual page doesn't have a broken link
|
|
$this->assertFalse($vp->HasBrokenLink);
|
|
|
|
// Delete the source page from draft, confirm that this creates a broken link
|
|
$pID = $p->ID;
|
|
$p->delete();
|
|
$vp->flushCache();
|
|
$vp = DataObject::get_by_id('SiteTree', $vp->ID);
|
|
$this->assertEquals(1, $vp->HasBrokenLink);
|
|
|
|
// Delete the source page form live, confirm that the virtual page has also been unpublished
|
|
$pLive = Versioned::get_one_by_stage('SiteTree', 'Live', '"SiteTree"."ID" = ' . $pID);
|
|
$this->assertTrue($pLive->doDeleteFromLive());
|
|
$vpLive = Versioned::get_one_by_stage('SiteTree', 'Live', '"SiteTree"."ID" = ' . $vp->ID);
|
|
$this->assertNull($vpLive);
|
|
|
|
// Delete from draft, confirm that the virtual page has a broken link on the draft site
|
|
$pLive->delete();
|
|
$vp->flushCache();
|
|
$vp = DataObject::get_by_id('SiteTree', $vp->ID);
|
|
$this->assertEquals(1, $vp->HasBrokenLink);
|
|
}
|
|
|
|
/**
|
|
* Base functionality tested in {@link SiteTreeTest->testAllowedChildrenValidation()}.
|
|
*/
|
|
function testAllowedChildrenLimitedOnVirtualPages() {
|
|
$classA = new SiteTreeTest_ClassA();
|
|
$classA->write();
|
|
$classB = new SiteTreeTest_ClassB();
|
|
$classB->write();
|
|
$classBVirtual = new VirtualPage();
|
|
$classBVirtual->CopyContentFromID = $classB->ID;
|
|
$classBVirtual->write();
|
|
$classC = new SiteTreeTest_ClassC();
|
|
$classC->write();
|
|
$classCVirtual = new VirtualPage();
|
|
$classCVirtual->CopyContentFromID = $classC->ID;
|
|
$classCVirtual->write();
|
|
|
|
$classBVirtual->ParentID = $classA->ID;
|
|
$valid = $classBVirtual->validate();
|
|
$this->assertTrue($valid->valid(), "Does allow child linked to virtual page type allowed by parent");
|
|
|
|
$classCVirtual->ParentID = $classA->ID;
|
|
$valid = $classCVirtual->validate();
|
|
$this->assertFalse($valid->valid(), "Doesn't allow child linked to virtual page type disallowed by parent");
|
|
}
|
|
}
|
|
|
|
class VirtualPageTest_ClassA extends Page implements TestOnly {
|
|
|
|
static $db = array(
|
|
'MyInitiallyCopiedField' => 'Text',
|
|
'MyVirtualField' => 'Text',
|
|
'MyNonVirtualField' => 'Text',
|
|
);
|
|
|
|
static $allowed_children = array('VirtualPageTest_ClassB');
|
|
}
|
|
|
|
class VirtualPageTest_ClassB extends Page implements TestOnly {
|
|
static $allowed_children = array('VirtualPageTest_ClassC');
|
|
}
|
|
|
|
class VirtualPageTest_ClassC extends Page implements TestOnly {
|
|
static $allowed_children = array();
|
|
} |