Commit Graph

1738 Commits

Author SHA1 Message Date
Ingo Schommer
13bedbcf5e elofgren: USABILITY: Rename first left sidebar section in 'Site Content' to 'Site Content and Structure'.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41880 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:12:12 +00:00
Ingo Schommer
ad25e8b900 elofgren:USABILITY: Add ajax network-save.gif icon to all 'Save' buttons while they are being submitted. Also add it to 'Save & Publish' and 'Unpublish' buttons. Fulfills: http://www.silverstripe.com/google-summer-of-code-forum/flat/1654?showPost=1730#post1730
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41879 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:11:50 +00:00
Ingo Schommer
1741cf99cb elofgren: Make Newsletter AJAX action buttons be update after submit like happens in all other sections of the Admin. Use 'form_actions_right' instead of 'form_actions' and remove unneeded duplicated 'Form_EditForm_action_save' Behaviour.register in NewsletterAdmin?_right.js
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41878 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:11:25 +00:00
Ingo Schommer
0c895b3a30 elofgren: USABILITY: Make blue title bars in all sections match the ones in 'Site Content' section. Relable 'Files & Images' left frame to 'Folders'.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41877 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:10:53 +00:00
Ingo Schommer
04f6ce23e9 sharvey: link colours are very difficult to see compared to black text - fixed by making them blue with an underline
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41876 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:10:24 +00:00
Ingo Schommer
4ede3657e6 elofgren: BUGFIX: Fix bottom tab border collision with action buttons in 'Files & Images' & 'Security' sections in IE. Reported here: http://www.silverstripe.com/google-summer-of-code-forum/flat/1654?showPost=1780#post1780
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41875 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:09:54 +00:00
Ingo Schommer
65e0686fa0 mujma:
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41874 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:09:25 +00:00
Ingo Schommer
6ae57bdb46 mujma: Fixed bug with non-relative path
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41873 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:09:00 +00:00
Ingo Schommer
bd58e931bb mujma: All PHP and JS files for ImageEditor?, works on FF 1.5/2.0.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41872 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:08:25 +00:00
Ingo Schommer
a3d8e8c9e2 mlanthaler: Added javascript helper file for the UI of the new access tab for pages.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41871 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:05:16 +00:00
Ingo Schommer
3d5deccd43 elofgren: USABILITY: Make it so that the "Save" button text changes to "Saving..." and the "Save & Publish" button changes to "Publish..." while the request is being sent to server. Requested here:
http://www.silverstripe.com/google-summer-of-code-forum/flat/1654?showPost=1730#post1730    
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41870 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:04:51 +00:00
Ingo Schommer
b13f8a3963 elofgren: USABILITY: Comment out the blue right frame titles in all of the Admin sections to free up space (since the action buttons have been moved to the bottom, the headings are no longer needed). In addition, comment out the 'My Site' left frame title in the 'Site Content' section since the sub-sections each have their own blue title bar.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41869 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:03:23 +00:00
Ingo Schommer
658a03be74 elofgren: Add line-height to left sidebar headings to center text vertically in the blue bar. Thanks for the idea Sean\!
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41868 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:02:43 +00:00
Ingo Schommer
5fd5e3ea25 elofgren: USABILITY: Move 'RHS Action Parameters boxes' from top right to bottom right so they are next to the action buttons. Add padding to TreeDropdownField? to prevent horizontal page scrolling when a files are moved in /admin/assets/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41867 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:02:11 +00:00
Ingo Schommer
c45d26df90 elofgren: VAR FIX: Initialize 'script' and use isset($brokenPageList) in AssetAdmin::deletefolder() to fix undefined variable errors.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41866 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:01:49 +00:00
Ingo Schommer
5c7800ae2e elofgren:BUGFIX: Make deleting folders work again by replacing getElementsByTagName('a') with getElementsByTagName('button'). This was broken when the 'Delete' link was changed to a 'Delete' button.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41865 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:01:24 +00:00
Ingo Schommer
23e18d620e elofgren: USABILITY: Decrease width of TreeDropdownField? so 'arrow' icon is on same line as the drop-down in Firefox 2 like on the 'Link to File' -> 'Download a file' drop-down on the HtmlEditorField? toolbar. This should resolve Usability Issue #49: http://www.elijahlofgren.com/silverstripe/replace-arrow-with-browse-button-in-move-file-list/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41864 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:00:52 +00:00
Ingo Schommer
15d40c5cf1 elofgren: USABILITY: Rename 'Save draft' button to 'Save' and make 'Publish' (will be renamed 'Save & Publish') button save the new draft in addition to publishing it.
Requested here: http://www.silverstripe.com/google-summer-of-code-forum/flat/1654?showPost=1730#post1730 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:00:03 +00:00
Ingo Schommer
1e54b9a29d elofgren: Decrease #statusMessage.bad max-height from 600 to 300px.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41862 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:59:01 +00:00
Ingo Schommer
015498686d elofgren: Change background color of alert-bad.gif and alert-good.gif to white since status messages are now shown on bottom left with white background.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41861 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:58:33 +00:00
Ingo Schommer
8682b387f1 elofgren: Make statusMessage.bad background color white instead of transparent so that if there is a large AJAX error, it will be more readable.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41860 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:58:08 +00:00
Ingo Schommer
708621f56b elofgren: USABILITY: Move action buttons to bottom right of screen, make them look more like buttons, and add hover effect in order to fix usability issue #13 'Important Buttons Not Noticeable Enough'. More info: http://www.silverstripe.com/google-summer-of-code-forum/flat/1654
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41859 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:57:46 +00:00
Ingo Schommer
9413acbc05 elofgren: Comment out StatusTitle? code for ajax actions because on IE6, IE7, and Safari 3, the status message becomes 'null' on 2nd hover and because there is not room for long titles when action buttons are on the same line. Now a simple title tooltip is shown instead.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41858 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:57:22 +00:00
Ingo Schommer
e23eaf9f8d mlanthaler: Small fix to prevent E_NOTICEs.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41857 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:56:26 +00:00
Ingo Schommer
bf5c5154c4 qhoxie: slight stats left panel changes
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41856 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:55:58 +00:00
Ingo Schommer
0762c09ba2 qhoxie: additions to left statistics panel
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41855 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:55:36 +00:00
Ingo Schommer
83530f139f elofgren: USABILITY: Change the 'Create', 'Delete', and 'Reorganise' links into 'Create...', 'Delete...', and 'Reorder...' buttons in order to fix Usability Issue #23 "Create, Delete, and Reorganise links
need to be more prominent". More info: http://www.elijahlofgren.com/silverstripe/create-delete-and-reorganise-links-need-to-be-more-prominent/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41854 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:54:13 +00:00
Ingo Schommer
dbb645cde6 elofgren: BUGFIX: Make adding a newsletter type to the 'Newsletters' tree work when a draft is selected by changing the name of the 'NewsletterEditForm?' back to 'EditForm?' (reverts r36734 which was a fix to make the 'Save changes' button work on the now non-existant modal 'Usaved changes' dialog.) In addition this commit reverts r37173 because the form name is now 'EditForm?' like all other forms in NewsletterAdmin?.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41853 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:53:38 +00:00
Ingo Schommer
318bae74f6 elofgren: Newsletters: Remove reference to Form_NewsletterEditForm_Type in NewsletterAdmin?_right.js since the newsletter type form is simply called EditForm? and saving the newsletter type doesn't require check for 'action_savenewsletter' being set.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41852 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:58 +00:00
Ingo Schommer
05a8a40e01 elofgren: BUGFIX: Fix status message displayed after deleting items from the left 'Newsletters' tree. Instead of 'Deleted items', actually give a value to and display it as a number.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41851 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:37 +00:00
Ingo Schommer
768862a9e4 elofgren: BUGFIX: Newsletters section: Make unsaved changes confirm() dialogue show when a new selection is made in the left tree by removing the check for the existance of the save() function which was removed in r36869. The save() function used to be called by the old modal 'Unsaved Changes' dialogue when the 'Save changes' button was pressed. The new confirm() dialogue has no 'Save changes' button so the save() function is no longer needed.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:12 +00:00
Ingo Schommer
e2475e8dcd elofgren: BUGFIX: Make adding a newsletter draft to the left site tree work again.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41849 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:50:47 +00:00
Ingo Schommer
14acd05f1b elofgren: USABILITY: Make 'Go' button be on same line as 'Create a Page' drop-down.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41848 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:50:20 +00:00
Ingo Schommer
e1438c9949 qhoxie: updates to stats panels
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41847 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:49:54 +00:00
Ingo Schommer
dd853ef168 elofgren: USABILITY: Add 'label' tags for 'Compare mode (click 2 below)' and 'Show unpublished versions' checkboxes in left frame 'Page Version History' section.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41846 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:49:11 +00:00
Ingo Schommer
e70d060983 elofgren: USABILITY: In 'Page Version History' left sidebar section, use a checkbox labeled 'Compare mode (click 2 below)' instead of a drop-down with only 'View (click to see)' and 'Compare (click 2 to see)' options. More info: http://www.elijahlofgren.com/silverstripe/inconsistent-go-buttons/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:48:48 +00:00
Ingo Schommer
d497fbf671 elofgren: VAR FIXES: Add some needed issets() and variable initializations to fix a lot of warnings when comparing 2 versions of a page.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41844 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:48:11 +00:00
Ingo Schommer
9b29b09a24 elofgren: VAR FIX: Fix typo in LeftAndMain::addTreeNodeJS() by renaming 'select' parameter to 'selected' because 'selected' is what is used in the method body.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41843 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:46:51 +00:00
Ingo Schommer
dfa6b99f18 elofgren: VAR FIXES: Fix 2 undefined variable errors in CMSMain::deletefromlive() and 1 in CMSMain::deleteitems() that showed up in status messages while deleting pages.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:46:22 +00:00
Ingo Schommer
8f980e1e02 elofgren: USABILITY: Add tooltips to pages in 'Site Content' tree showing 'Page type: className' where className is the page's type.
More info: http://www.elijahlofgren.com/silverstripe/icons-missing-from-left-navigation-tree-key/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41809 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:42:24 +00:00
Ingo Schommer
5e6fd830e2 elofgren: USABILITY: Fix usability issue #30 'Replace Image button needs repositioning' by adding back the margin, border, and padding around the fieldset and increasing height. More info:
http://www.elijahlofgren.com/silverstripe/replace-image-button-needs-repositioning/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41808 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:41:51 +00:00
Ingo Schommer
59bfa913a5 elofgren: USABILITY: In 'Site Content' left frame, relabel 'Site Tree' => 'Site Content', 'History' => 'Page Version History', 'Reports' => 'Site Reports' .Fixes usability issue #21: http://www.elijahlofgren.com/silverstripe/site-content-needs-consistent-labeling/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41807 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:41:22 +00:00
Ingo Schommer
ad3aed7930 mlanthaler: Bugfix: "if($className == null); $className = $this->stat('subitem_class');" had no effect because of the semicolon after the if-statement.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:40:56 +00:00
Ingo Schommer
c2f57b75de mlanthaler: Suppress E_NOTICE when $_REQUESTctf?childID? is not set (e.g. when adding a new member by clicking on "Add member" in the security tab).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41805 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:39:59 +00:00
Ingo Schommer
3ee2969cd5 elofgren: USABILITY: Remove 'Surname', 'FirstName?', and 'Email' from list of 'changeDetection_fieldsToIgnore'. This completes fixes for usability issue #91 "Warning needs to be added for unsaved changes
in Security section". More info: http://www.elijahlofgren.com/silverstripe/warning-needs-to-be-added-for-unsaved-changes-in-security-section/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41804 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:38:25 +00:00
Ingo Schommer
119b3b017a elofgren: USABILITY: Remove the left Side Tabs and implement clicking on the headings to show sidebar sections instead in order to fix Usability issue "#22 Allow clicking on blue heading bar of Left
Site Tree to reduce it". More info: http://www.elijahlofgren.com/silverstripe/allow-clicking-on-blue-heading-bar-of-left-site-tree-to-reduce-it/ 
A big THANK YOU to Andy Skelton for permission to use his WordPress? toggle icons originally posted at: http://trac.wordpress.org/attachment/ticket/1904/toggle.gif 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41803 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:37:48 +00:00
Ingo Schommer
274a3d678c elofgren: Set svn:mime-type=application/octet-stream on psd images in cms/images/sidetabs so they won't show up in diffs when they are deleted.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41802 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:34:34 +00:00
Ingo Schommer
8fe47c6e87 qhoxie: basic setup for statistics viewing and handling in the cms
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41801 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:33:51 +00:00
Ingo Schommer
7f61325204 elofgren: Remove unused code: 1. doYouWantToSave() that called OpenModalDialog?() has been replaced by a call to confirm() 2. CMSMain::savedialog() which was the PHP part of the old modal save dialog. 3. save() in NewsletterAdmin?_right.js which seems to have been replaced by the save function of Form_EditForm
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41800 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:32:19 +00:00
Ingo Schommer
93ae866e60 elofgren: USABILITY: Make Newsletter section use new js confirm dialog instead of old modal one. More info: http://www.elijahlofgren.com/silverstripe/alert-users-when-leaving-tab-with-unsaved-changes/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41799 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:30:54 +00:00