Ingo Schommer
878cf541b9
Better UI feedback on VirtualPage states ( fixes #1594 )
2013-04-16 11:56:33 +02:00
Ingo Schommer
da515b8f65
FIX Use SSViewer.theme_enabled in CMS logic
2013-04-08 19:29:09 +12:00
Ingo Schommer
18201c05af
Fixed Config usage in ErrorPage
2013-03-27 12:00:55 +01:00
Ingo Schommer
51c8e8639e
API Marked statics private, use Config API instead ( #8317 )
...
See "Static configuration properties are now immutable, you must use Config API." in the 3.1 change log for details.
2013-03-24 17:21:04 +01:00
Daniel Hensby
e131a041d4
BUG Metadata heading removed from RediretorPage
...
Currently the empty metadata accordion stays on the RedirectorPage. This is now removed.
2013-02-20 13:32:55 +00:00
Ingo Schommer
a0e965b7b4
Revert "FIX: updateCMSFields not accepting var by reference"
...
This reverts commit e56a78b160
.
2013-02-06 18:59:51 +01:00
Ingo Schommer
23eeb99075
FIX Clear Requirements before in-memory HTTP request for ErrorPage
...
For example, avoids issues where separate controllers (calling and called) operate on the same
set of files through Requirements::combine_files().
2013-02-06 10:43:42 +01:00
Ingo Schommer
b19a82b693
SiteTree on*() callbacks now consistently invoke on subclasses as well
...
Before this was only possible for some specific ones, like onBeforeWrite.
This excludes any callbacks with augment*() or update*() naming,
since these are assumed to be on extension only, with a corresponding
base method available on the class itself (e.g. "updateCMSFields()"
vs "getCMSFields()").
2013-02-06 10:43:31 +01:00
Michael Andrewartha
e56a78b160
FIX: updateCMSFields not accepting var by reference
...
updateCMSFields should be taking the fields var by reference.
@see https://github.com/silverstripe/sapphire/pull/1156
2013-02-04 12:55:29 +00:00
Ingo Schommer
00097a5d5d
NEW Clickable URL preview in CMS
...
- Refactored SiteTreeURLSegmentField to render controls in template
rather than JS for better clientside performance, and cleaner behaviour.
- Added dynamic ellipsis to start of URL, to retain most relevant
part of the URL (the last bits)
- Added "suffix" setting to field, which defaults to ?stage=Stage
- Removed prefix from edit view to leave more room for URL
Thanks to @sunnysideup for getting this started in
https://github.com/silverstripe/silverstripe-cms/pull/269
2013-02-04 12:12:28 +01:00
Ingo Schommer
931b726589
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-01-30 13:09:14 +01:00
Ingo Schommer
b25063b09c
Extracted ErrorPage default data to getter
...
Allows for less verbose overloading, while still keeping i18n capabilities
in place, which isn't possible with DataObject::$default_records
2013-01-30 13:07:11 +01:00
Ingo Schommer
416178b668
Reduced code duplication in ErrorPage (no functional changes)
2013-01-29 19:34:05 +01:00
Kirk Mayo
81cd0e6e04
BUG: Replaced extendedSQL with DataList as per ticket 8183
2013-01-24 08:45:30 +13:00
Ingo Schommer
61f2ab7519
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-01-21 10:03:30 +01:00
unclecheese
cfc976bff8
MINOR: Grammar error
2013-01-17 14:31:35 -05:00
Ingo Schommer
76aeec70e7
NEW SiteTree->PreviewLink() for fine grained URL control
2013-01-14 17:12:23 +01:00
Normann Lou
f674af0c73
BUG: dependentPages grid field not showing necessary columns and their values.
2013-01-09 22:35:54 +01:00
Ingo Schommer
cc536f644e
Fixed "last edited" display in CMS actions
2012-12-17 12:31:28 +01:00
Ingo Schommer
5b2cc19704
Added placeholder text to group listboxes
2012-12-15 19:57:14 +01:00
Ingo Schommer
74d63791b7
Fixed regression in SiteTree->getCMSActions()
...
Caused by toolbar recent changes
2012-12-14 01:21:54 +01:00
Mateusz Uzdowski
26cc14a930
API Rework the CMS actions to use alternating buttons and drop-ups.
...
Utilise the new features provided by the framework to get richer
interface:
* save buttons that highlight the current state of the page
* minor actions in a drop-up
* embed last publishing and saving information
2012-12-13 19:10:39 +01:00
Ingo Schommer
1bf67fd942
Merge remote-tracking branch 'origin/3.0'
2012-12-10 18:09:34 +01:00
Mateusz Uzdowski
c0751df54e
BUG Remove handwritten SQL and use the ORM.
...
The custom SQL does not take subsites into account and breaks the CMS
on certain pages - under some circumstances the custom count will return
1 or more, while the set will be in fact empty because of augmentation.
2012-12-05 10:27:12 +13:00
Ingo Schommer
e6e12fe00e
Merge branch '3.0'
...
Conflicts:
composer.json
2012-11-22 23:48:18 +01:00
Tim Klein
59719a46cc
MINOR removed reference to non existent js
...
cms/javascript/SitetreeAccess.js is no longer with us :)
2012-11-19 16:15:57 +13:00
Sean Harvey
cef087f689
Removed deprecated SiteTree::TreeTitle(), use getTreeTitle() instead
2012-11-15 14:41:17 +13:00
Sean Harvey
d236bb58eb
Removed deprecated SiteTree::prepopuplate_permission_cache()
...
This function is misspelled, and was marked deprecated. This commit
removes that function. Please use prepopulate_permission_cache()
instead (note the removal of the extraneous "p" in "prepopuplate")
2012-11-15 14:39:48 +13:00
Sean Harvey
555ecd7f24
Removed deprecated SiteTreeDecorator, use SiteTreeExtension instead
2012-11-15 14:31:54 +13:00
Simon Welsh
d006c08db3
Reverts test code committed in a52514a3
2012-11-10 15:42:45 +13:00
Ingo Schommer
a52514a306
ENHANCEMENT Tab style consolidation and design consistency
2012-11-06 22:24:01 +01:00
Sam Minnee
ef32310ef8
FIX: Allow 1024 chars for keywords, not a mere 255
2012-11-05 17:58:32 +13:00
Will Rossiter
b221f7ba7a
FIX Remove Metadata Label from RedirectorPage. ( Fixes #7959 )
2012-10-23 19:32:25 +13:00
Ingo Schommer
17113039be
NEW Enable SiteTree::$nested_urls by default
2012-10-08 17:05:46 +02:00
Ingo Schommer
0d03c62984
Merge remote-tracking branch 'origin/3.0'
2012-10-03 16:16:25 +02:00
Ingo Schommer
a6d09988ed
Merge pull request #214 from silverstripe-droptables/ssexpress
...
Tweaks to CMS required for Translatable
2012-10-02 02:10:47 -07:00
Robert Curry
9cf5a6f47a
BUG: Remove the is_null check on augmentValidURLSegment
...
Object::extend already does a check for NULL before it adds the results
to the array of return values. This was required for Translatable as the
result from Translatable::augmentValidURLSegment was being ignored.
2012-10-02 11:29:10 +13:00
Sean Harvey
cb8c10a473
Merge branch '3.0' of github.com:silverstripe/silverstripe-cms into 3.0
2012-09-27 10:49:03 +12:00
Sean Harvey
345dbc8a4f
BUG Fixing broken links "admin/show", should be "admin/pages..."
2012-09-25 15:31:42 +12:00
Ingo Schommer
cbd31e3ab2
API Removed SiteTree.MetaTitle and MetaKeywords
...
They are irrelevant in terms of SEO, general page informancy,
clutter up the CMS UI, and encourage CMS authors to waste
their time filling them out.
[1] http://www.seomoz.org/learn-seo/title-tag
[2] http://www.mattcutts.com/blog/keywords-meta-tag-in-web-search/
2012-09-21 11:31:00 +02:00
Ingo Schommer
cebce51bc1
Merge branch 'open/7875' of git://github.com/jbridson/silverstripe-cms into jbridson-open/7875
2012-09-21 10:49:20 +02:00
Ingo Schommer
df44239060
Method visibility according to coding conventions
2012-09-20 10:41:50 +02:00
Jeremy Bridson
05d5bd7508
ENHANCEMENT:open/7875 - added help labels to metadata fields on page content edit screen.
2012-09-20 13:22:12 +12:00
Damian Mooyman
02e95adb4c
BUG Consistently save SiteConfig, and refactor Translatable hooks
...
Squashed commit of the following:
commit a60eddfacc710d3047bd1d5107e5df0cc6dba93c
Merge: c847b55
76be14b
Author: Ingo Schommer <ingo@silverstripe.com>
Date: Fri Sep 7 17:02:47 2012 +0200
Merge branch '3.0-translation-migration' of git://github.com/tractorcow/silverstripe-cms into tractorcow-3.0-translation-migration
commit 76be14b1fccc05b5dcca8c805e0354a42e75135d
Author: Damian Mooyman <damian.mooyman@gmail.com>
Date: Fri Aug 24 08:28:18 2012 +1200
FIXED: Indentation
commit 715b60387c970846db1bf9a5f14140aee49ce665
Author: Damian Mooyman <damian.mooyman@gmail.com>
Date: Fri Aug 24 08:25:14 2012 +1200
FIXED: Coding style inconsistencies
commit 6395f9030ed65b24494842ce74864ff7ebbf6c5e
Author: Damian Mooyman <damian.mooyman@gmail.com>
Date: Thu Aug 16 16:30:11 2012 +1200
FIXED: Issue where new SiteConfig instances weren't always saved to the database
commit aca242e31c8d98ee3b8acc397bf605ceb964e1bf
Author: Damian Mooyman <damian.mooyman@gmail.com>
Date: Thu Aug 16 14:22:56 2012 +1200
UPDATED: Refactored Translation module specific code out of the SiteConfig
2012-09-07 17:06:29 +02:00
Hamish Friedlander
af2c890168
Merge pull request #190 from silverstripe-rebelalliance/open/5971
...
NEW Add warning if viewed SiteTree object class is obsolete
2012-09-02 14:12:23 -07:00
Ingo Schommer
1cd82e2db1
BUG Enforce $allowed_children in controllers on page creation ( fixes #7694 )
...
Original bug fix contributed by @kmayo-ss
2012-09-02 18:20:22 +02:00
Hamish Friedlander
949507c3fe
NEW Add warning if viewed SiteTree object class is obsolete
2012-08-29 14:48:23 +12:00
Ingo Schommer
8a514d8b64
BUG Correct live state in SiteTree->getAbsoluteLiveLink()
...
Was fetching the record from live (and its direct URLSegment),
but all of its parents from the current stage, which might be draft,
leading to "mixed" draft/live nested URLs which might no longer
be reachable in live mode.
2012-08-28 19:04:16 +02:00
Ingo Schommer
59546ccf11
Localized page name in "add page" dialog and dropdowns (see #7798 )
2012-08-26 23:58:38 +02:00
Ingo Schommer
2e791abad2
Better i18n for "new page" label ( fixes #7796 )
...
Also using better standard name for auto generated
page names ("Page" instead of "Site Tree", "Pages" instead of "Site Tres" [sic])
2012-08-20 22:25:18 +02:00
Sean Harvey
c019f22163
Fix notice when ErrorPage tries to create static error pages and can't write
2012-08-20 15:23:46 +12:00
Ruud Arentsen
18a40b4b5d
BUG Adding siteconfig translations
...
translations were not added in the same translation group, and the
translation module didn't work. Also commited changes in the translation module, which will need this commit.
2012-08-10 10:16:39 +02:00
Ingo Schommer
39a9093715
BUG SiteTree->provideI18nEntities() limited to class
...
Called for each subclass by the collector,
so we don't need to aggregate here.
In fact, its harmful because it causes entities
to be placed in the wrong definitions file.
The <class>.DESCRIPTION entity was always placed in cms/lang/en.yml,
regardless of the original location of the file containing the class.
2012-08-06 14:28:04 +02:00
Ingo Schommer
671c7daa4c
SiteConfig load/save with ID in CMS
...
Allow loading a SiteConfig by ID (by specifying $tree_class),
and pass the ID through with the form data. Unifies processing
with SiteTree, and allows the Translatable module
to use the same logic for interacting with the load/save process.
2012-08-06 09:36:25 +02:00
Ingo Schommer
9076286162
SiteTree->CMSEditLink()
...
Mainly to make it compatible with the Translatable
extension linking to existing translations of it,
but also to make it work similarly to the SiteTree logic elsewhere.
2012-08-05 20:52:22 +02:00
Kirk Mayo
b15fabaf0d
BUG: open ticket 5880 always show the current page type in the page type dropdown list
2012-07-16 14:56:24 +12:00
Ingo Schommer
69e4fa072a
Toggle metadata fields in SiteTree->getCMSFields()
...
To save space, reduce clutter and deemphasize the fields.
Partially fixes #7405 , needs better design though.
2012-07-15 21:29:46 +02:00
Mateusz Uzdowski
54fd54a2fb
BUG Change all shortcodes into the new, comma separated, format.
...
Ref http://open.silverstripe.org/ticket/7337
2012-07-12 17:57:38 +02:00
Ingo Schommer
d1bc7219a8
Merge branch '3.0'
2012-07-05 17:53:35 +02:00
Sam Minnee
040f780a15
BUG: Allow children on RedirectorPage (Trac #7587 )
2012-06-29 16:24:20 +12:00
Ingo Schommer
bb5e3e5fbd
MINOR Remove DB dependency from SiteTree->provideEntities()
...
Use class manifest instead, which provides same level of info,
and means we can run the text collector on bare checkouts
without a database set.
2012-06-25 14:01:19 +02:00
Will Rossiter
facc8ba653
MINOR: restore backlinkcount into cms module. (removed from framework in 266a61221c
)
2012-06-20 16:27:47 +02:00
Will Rossiter
3b7af0e945
MINOR: restore backlinkcount into cms module. (removed from framework in 266a61221c
)
2012-06-20 16:20:04 +02:00
Ingo Schommer
4986355e3f
MINOR Simplified page type dropdown labels, removed redundant info ( fixes #7474 )
2012-06-15 16:22:27 +02:00
Ingo Schommer
eccfc1a664
Merge branch 'stylingfixes' of https://github.com/ajshort/silverstripe-cms into ajshort-stylingfixes
2012-06-13 13:24:12 +02:00
Andrew Short
a6cee248e0
BUGFIX: Consistently style custom defined page icons.
...
* Renamed generateTreeStylingCSS() to generatePageIconsCSS().
* Removed legacy icon definitions.
2012-06-13 17:46:43 +10:00
Ingo Schommer
e50936fe9f
MINOR Added caching to SiteTree->getStatusFlags(), as its called twice for every node now in LeftAndMain->SiteTreeAsUL() (see #7410 )
2012-06-12 19:35:15 +02:00
Sean Harvey
ad28780959
MINOR Use shorthand syntax for DataList querying
2012-05-28 21:05:24 +12:00
Sean Harvey
808819ec3b
BUGFIX Themes dropdown in SiteConfig::getCMSFields() should use setEmptyString() as the $emptyString argument is now deprecated.
2012-05-24 14:38:00 +12:00
Sean Harvey
542d727db2
MINOR Don't use deprecated extraStatics when adding extra statics with
...
DataExtension
2012-05-23 22:13:27 +12:00
Sean Harvey
ec3ebc91d8
MINOR Use instance methods on current Controller instance for redirect()
...
instead of static Director functions
2012-05-23 21:45:16 +12:00
Sean Harvey
7ed09917ac
BUGFIX Fixing incorrect URL to edit canonical page on VirtualPage
2012-05-22 17:44:01 +12:00
Ingo Schommer
1614bc4505
MINOR Removed unknown "cancel draft" button icon ( fixes #7333 )
2012-05-20 14:20:59 +02:00
Ingo Schommer
73e5c34896
BUGFIX Encoding multibyte characters in custom X-Status HTTP headers used in CMS (headers don't allow multibyte data)
2012-05-14 15:11:35 +02:00
Ingo Schommer
af48b3948b
Merge pull request #121 from chillu/silverstripe-cms
...
---
....Main" to "Root.Main", merged "Root.Content.Metadata" tab into "Root.Main"
See https://github.com/silverstripe/sapphire/pull/420
Conflicts:
code/model/SiteTree.php
2012-05-11 14:03:44 +02:00
Ingo Schommer
1863bb00db
ENHANCEMENT Refactored SiteTreeURLSegmentField JS to a more selector based approach (future proof field for reusability e.g. in ModelAdmin with custom DataObject URL previews)
2012-05-10 14:50:08 +02:00
Ryan Wachtl
bd94c6f336
Trac 6981: Opt-in URL Updating
2012-05-09 19:01:57 -05:00
Ingo Schommer
42d404faa8
API CHANGE Restructured SiteTree->getCMSFields() tabs from "Root.Content.Main" to "Root.Main", merged "Root.Content.Metadata" tab into "Root.Main" ( fixes #7261 )
2012-05-09 17:48:59 +02:00
Ingo Schommer
d15b4ad8ee
Merge pull request #119 from chillu/urlsegment-multibyte-fix
...
Urlsegment multibyte fix
2012-05-09 01:32:52 -07:00
Ingo Schommer
8563322971
BUGFIX Fixed publication of multibyte URLSegment in SiteTree->onBeforeWrite(), was wrongly detecting a change and double encoding
2012-05-08 23:45:29 +02:00
Ingo Schommer
63536af875
MINOR Documentation
2012-05-08 22:22:11 +02:00
Ingo Schommer
38f1236b1f
MINOR Switching _t() calls from sprintf() to using injection parameters ( #7170 )
2012-05-01 22:05:19 +02:00
Ingo Schommer
9f1668505b
MINOR Remove usage of deprecated array access on SQLQuery in SiteTreeFolderExtension
2012-05-01 17:58:14 +02:00
Robert Curry
db3332e629
MINOR: Modify VirtualPage to work with lazy loading.
2012-05-01 09:38:20 +12:00
Ingo Schommer
8c1651ec59
MINOR Using GridField instead of TableListField for SiteTree->getCMSFields() DependentPages ( fixes #7239 )
2012-04-30 16:10:24 +02:00
Ingo Schommer
a73e45769a
ENHANCEMENT Titles for lozenges in page tree for more context ( fixes #7206 )
2012-04-30 14:56:42 +02:00
Sean Harvey
614f307a37
ENHANCEMENT When loading CMS, ensure that "Parent page" tree dropdown is
...
either hidden or shown depending on initial "Page location" state
2012-04-23 21:02:29 +12:00
Ingo Schommer
ca853d73f2
ENHANCEMENT Renamed "Content" tab in SiteTree->getCMSFields() to "Main Content" to distinguish it from the top-level "Content" tag
2012-04-18 16:28:07 +02:00
Ingo Schommer
0f7dd7922f
API CHANGE Removed $controller context from SiteTree->CMSTreeClasses(), now handled through closures in the specific LeftAndMain usage instead (to handle separate contexts for links and determining "current page")
2012-04-17 22:59:11 +02:00
Ingo Schommer
6aeac37906
API CHANGE Combined "Pages" and "Edit Page" into a single menu entry
...
ENHANCEMENT Namespaced tree search parameters in CMSMain, in order to detect more reliably if a filter has been applied. Changing page search form to standard pushState behaviour, same as ModelAdmin (for both tree and list view).
MINOR Refactored list view loading
2012-04-17 22:59:08 +02:00
Ingo Schommer
52e69dd1fd
MINOR Removed usage of deprecated $priority argument for _t()
2012-04-15 16:49:31 +02:00
Ingo Schommer
2dc0e72c00
ENHANCEMENT Caching expensive CMSMain->SiteTreeHints() call on disk
2012-04-15 16:49:31 +02:00
Ingo Schommer
d9c4aa8583
MINOR Using new DataObject::fieldLabels() caching in SiteTree
2012-04-15 16:49:30 +02:00
Simon Welsh
c4e018928e
API-CHANGE sapphire folder can now be renamed.
2012-04-15 10:56:40 +12:00
Simon Welsh
b8e86ae261
MINOR Add newline to end of files without one
2012-04-15 10:56:40 +12:00
Will Rossiter
d4750c2a96
MINOR: group ShowInMenus and ShowInSearch check boxes. Fixes #6901
2012-04-14 18:16:47 +12:00
Ingo Schommer
dc0168d01b
MINOR Removed $params argument to DataObject->getCMSFields(), please use FormScaffolder directly ( fixes #7135 )
2012-04-13 15:55:32 +02:00
Ingo Schommer
73a466c927
Merge branch 'integration'
2012-04-11 16:25:46 +02:00
Stig Lindqvist
587de186d0
Merge pull request #90 from halkyon/redirectorpage_changes
...
BUGFIX Adding RedirectorPage.js to cms module (was in sapphire) and swapping out old behaviour.js usage
2012-04-11 04:10:01 -07:00
Sam Minnee
7213d2b7dc
MINOR: Clarified meaning of SiteTree::
2012-04-11 15:48:17 +12:00