Commit Graph

17 Commits

Author SHA1 Message Date
Ingo Schommer
7f4dd7279b elofgren: USABILITY: Make 'Add new draft' the default action for 'Create...' in the Newsletter section. Also make 'Add new draft' be selected whenever a selection is made in the left tree. Only select 'Add new type' by default if there are no Newsletter types. This will reduce confusion and make the more common 'Add new draft' action easier since it will be the default. Also select the 'Add new draft' option after a Newsletter type is added since this will be the next logical action. This fixes GSoC trac ticket: http://support.silverstripe.com/gsoc/ticket/70
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:32:33 +00:00
Ingo Schommer
a1fcfa6271 elofgren: BUGFIX: If there are no Newsletter types, and 'Add new draft' is chosen, create a Newsletter type to prevent errors. This makes either drop-down option work.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42060 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:31:41 +00:00
Ingo Schommer
e63c16fcff elofgren: BUGFIX: If no selection is made in the left tree, and a draft is added, parentID won't be set, so don't rely on it being set in Javascript and instead add a hidden ParentID field that is returned by PHP and use that so it is alway set correctly. This solves a bug where Newsletter drafts will be added, but not show up in the left tree (because of a Javascript error), if no selection has been made.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42059 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:31:06 +00:00
Ingo Schommer
4167ab9108 elofgren: BUGFIX: Don't save new Newsletter drafts as soon as they are created to prevent TinyMCE Javascript errors in IE. Always save Newsletter drafts before sending to prevent unsaved newsletter drafts from being sent out completely blank because change detection for new newsletter drafts does not work in IE.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42053 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:28:14 +00:00
Ingo Schommer
95c9255395 elofgren: Fix wording on alert() shown when Delete button is clicked in NewsletterAdmin?.js left to refer to 'Newsletter item' instead of 'Page'
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42041 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:18:43 +00:00
Ingo Schommer
6cb2df64dd elofgren: Added delete confirmation for items in Newsletter left tree. As part of fix for gsoc trac ticekt: #51 Warning is needed before items are deleted from security & newsletter tree
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42040 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:18:18 +00:00
Ingo Schommer
1daba65357 elofgren: Fix indentation of code in AddForm::form_submit()
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42007 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:30:05 +00:00
Ingo Schommer
ed0232eb71 elofgren: BUGFIX: Make adding newsletter types work again (was broken by r38923). Fix long-standing problem of whole page reloading when adding a Newsletter type. Now it is always added via AJAX.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42006 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:29:40 +00:00
Ingo Schommer
170c5b1fba elofgren: Make the status message shown after sending a newsletter always include the # of emails sent.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42003 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:04:10 +00:00
Ingo Schommer
2c012f3c4e elofgren: BUGFIX: Fix gsoc trac ticket: #54 For newly created Newsletter drafts, Content of Newsletter Sent is not what is shown on screen (Save button has to be clicked)
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41999 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:01:06 +00:00
Ingo Schommer
83530f139f elofgren: USABILITY: Change the 'Create', 'Delete', and 'Reorganise' links into 'Create...', 'Delete...', and 'Reorder...' buttons in order to fix Usability Issue #23 "Create, Delete, and Reorganise links
need to be more prominent". More info: http://www.elijahlofgren.com/silverstripe/create-delete-and-reorganise-links-need-to-be-more-prominent/ 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41854 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:54:13 +00:00
Ingo Schommer
dbb645cde6 elofgren: BUGFIX: Make adding a newsletter type to the 'Newsletters' tree work when a draft is selected by changing the name of the 'NewsletterEditForm?' back to 'EditForm?' (reverts r36734 which was a fix to make the 'Save changes' button work on the now non-existant modal 'Usaved changes' dialog.) In addition this commit reverts r37173 because the form name is now 'EditForm?' like all other forms in NewsletterAdmin?.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41853 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:53:38 +00:00
Ingo Schommer
768862a9e4 elofgren: BUGFIX: Newsletters section: Make unsaved changes confirm() dialogue show when a new selection is made in the left tree by removing the check for the existance of the save() function which was removed in r36869. The save() function used to be called by the old modal 'Unsaved Changes' dialogue when the 'Save changes' button was pressed. The new confirm() dialogue has no 'Save changes' button so the save() function is no longer needed.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:12 +00:00
Ingo Schommer
e2475e8dcd elofgren: BUGFIX: Make adding a newsletter draft to the left site tree work again.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41849 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:50:47 +00:00
Ingo Schommer
1eca17e0a9 elofgren: USABILITY: Rework the tabs in the Newsletter section to be less confusing as per issue #57 of the Usability Report
Includes the removal of all tabs and submit action buttons when 'Drafts' or 'Sent Items' are clicked and the addition of an 'add one' link on 'Drafts' folder page. 
For more information see: http://www.elijahlofgren.com/silverstripe/newletter-tree-and-tab-row-are-confusing/ 
Includes a few fixes for undefined variables.  (merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41772 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:29:08 +00:00
Sam Minnee
df2b2f695a Added SiteTreeHandlers.controller_url so that subsites module can work
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41219 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-04 04:12:30 +00:00
Hayden Smith
abb9a61d0d Moved CMS module to open source path
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@39000 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-07-19 10:40:05 +00:00