Commit Graph

70 Commits

Author SHA1 Message Date
Sam Minnee
185e30a750 BUGFIX Disallow addition of members to groups with MemberTableField->addtogroup() when the editing member doesn't have permissions on the added member (from r110859)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@112797 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:02:47 +00:00
Sam Minnee
00ff9c4daf BUGFIX Fixing default group selection in 'add member' dialog (in MemberTableField) (fixes #5836) (from r108099)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@112790 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:00:14 +00:00
Ingo Schommer
d402ca527a MINOR Removed debug code in MemberTableField (from r107525)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@112610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:57:05 +00:00
Sam Minnee
79133892f6 MINOR Replaced locations of Director::is_ajax() and Director::redirectBack() with instance method calls - the latter static function is deprecated (from r100484)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@112078 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 02:10:28 +00:00
Sam Minnee
7ee0ad5fa6 BUGFIX Using try/catch in MemberTableField->saveComplexTableField() similiar to parent implementation, which means trying to save a Member duplicate doesn't end up in a fatal error (fixes #5444) (from r103336)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@111662 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 06:14:56 +00:00
Sam Minnee
00a5a5bd5b Reverted r111624
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@111625 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 05:52:58 +00:00
Sam Minnee
ba163b83ae MINOR Replaced locations of Director::is_ajax() and Director::redirectBack() with instance method calls - the latter static function is deprecated (from r100484)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@111624 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 05:51:54 +00:00
Sam Minnee
65aa49d564 BUGFIX Setting default $groups in MemberTableField::AddForm() in addition to MemberTableField_Popup::__construct() - this was broken by r99777 (from r99993)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@111617 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 05:47:08 +00:00
Ingo Schommer
01b02969f9 MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@103384 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 00:11:32 +00:00
Ingo Schommer
ca7d87078f MINOR when you delete a user from a group, they are also removed from any sub groups. (from r87119) (from r98158)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102754 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 01:49:29 +00:00
Ingo Schommer
186e43e60b BUGFIX: Removed XSS holes (from r94822) (from r96822)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102682 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:59:09 +00:00
Ingo Schommer
129ab60ae7 BUGFIX Unsetting 'ID' parameter in MemberTableField->addtogroup() to avoid confusion between Group and Member records (regression from r100716)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@100720 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-03-09 20:28:59 +00:00
Ingo Schommer
4eed1360c4 BUGFIX Fixed MemberTableField->addtogroup() to fetch existing Member records by ID or $unique_identifier_field instead of relying on the (now removed) "auto-merging" in Member->onBeforeWrite() (see r100705)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@100716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-03-09 08:42:54 +00:00
Ingo Schommer
9c75acb113 MINOR Fixed MemberTableField regression from r99706
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@99710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 04:55:09 +00:00
Ingo Schommer
7e6dfe14f5 BUGFIX Fixed MemberTableField limiting of , wasnt taking children groups into account (regression from r99684)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@99706 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 04:43:25 +00:00
Ingo Schommer
fa04f03b0f BUGFIX Setting ID explicitly in MemberTableField-> to ensure getCsvQuery() correctly filters (the custom group filter was only implemented in sourceItems() before)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@99684 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 03:30:46 +00:00
Ingo Schommer
ca3b8d5792 ENHANCEMENT Saving group relations on SecurityAdmin->EditForm()/RootForm() through TreeMultiselectField instead of hidden 'Group'/'GroupID' values
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@99579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-22 04:36:36 +00:00
Ingo Schommer
d68bbc2c01 MINOR Fixed height of MemberTableField 'Groups' tab to allow enough room for TreeMultiSelectField expansion
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@98883 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-12 04:01:49 +00:00
Ingo Schommer
fc8f4130c2 ENHANCEMENT Saving MemberTableField through new 'Groups' field added in Member->getCMSFields().
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@98882 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-12 04:01:48 +00:00
Ingo Schommer
1ba1c563a8 ENHANCEMENT Making setting optional in MemberTableField. Field instances without will list all members unfiltered, and remove members from the database rather than the group relation.
ENHANCEMENT Allow disabling of 'inline add' formfields in a MemberTableField through setPermissions(array('inlineadd'))

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@98825 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-11 21:55:33 +00:00
Ingo Schommer
e56852dcd8 ENHANCEMENT Adjusted SecurityAdmin to new LeftAndMain API and jquery.concrete javascript. Changed 'delete' and 'create' interface to be more in line with CMSMain parent implementation, and increase code reuse.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92831 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:20:17 +00:00
Ingo Schommer
64d74e043b MINOR Fixed merge error from r91584
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@91593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-15 20:43:08 +00:00
Ingo Schommer
ceeb9dfcc3 API CHANGE Removed deprecated MemberTableField->addMembershipField() and MemberTableField->addPermissions(), use TableListField->setPermissions() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@91584 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-15 19:36:53 +00:00
Sean Harvey
42a6692d79 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@75592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-04-29 01:44:28 +00:00
Sam Minnee
550931c02a Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@72801 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-10 21:59:19 +00:00
Andrew O'Neil
fa76e64d48 Merged from trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@72452 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-04 03:35:29 +00:00
Sean Harvey
5141700f41 MINOR Re-added deprecated variable on MemberTableField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-10 03:27:12 +00:00
Sean Harvey
aa69629a3c MINOR Added translatable error message for MemberTableField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71389 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-04 21:13:04 +00:00
Sean Harvey
c4d3abcc29 ENHANCEMENT Show at most, 100 members in a group before paging required instead of 10
MINOR Removed setting of permissions since this never worked - use MemberTableField->setPermissions() instead
MINOR Deprecated the use of addMembershipFields() - use updateSummaryFields() on your Member decorator instead
MINOR Removed redundant code that wasn't being used

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71388 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-04 20:36:23 +00:00
Sean Harvey
34a50e3de6 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71276 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-03 03:46:15 +00:00
Sean Harvey
3680bbea46 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@71264 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-03 03:22:20 +00:00
Ingo Schommer
7b3068ac4f MINOR Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@69703 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-05 06:17:59 +00:00
Sam Minnee
a93a0c3c95 Updated SQL queries to be ansi compatable
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@66402 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-23 00:31:13 +00:00
Sean Harvey
6afd96eba4 Reverted previous change, as MemberTableField has it's own use of sourceFilter - not the most documentation situation however.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65175 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 23:30:16 +00:00
Sean Harvey
0c650b20fb BUGFIX MemberTableField use of sourceFilter should be treated as a string, not an array as per the API of TableListField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@65174 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 23:23:20 +00:00
Ingo Schommer
118efae75d BUGFIX Adjusted HeaderField and LabelField implementation to new constructor arguments (see r64421)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@64423 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:27:12 +00:00
Sean Harvey
a0c107a338 BUGFIX MemberTableField_Popup had an odd way of overloading saveComplexTableField() - this should be on MemberTableField instead, since that's the direct subclass of ComplexTableField for where saveComplexTableField() is defined. This broke the "Add Member" button in CMS Security, probably due to the way the form URLs have been changed. See ticket #2907 for the reported problem.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:46:19 +00:00
Sean Harvey
d1572b1272 BUGFIX Fixed blatant error where $SNG_member wasn't defined
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63799 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 01:00:08 +00:00
Sean Harvey
5aac6f5693 BUGFIX MemberTableField->AddLink() was calling &methodName=add - this should be just "add", as per changes to the forum URLs in sapphire
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63793 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 00:07:53 +00:00
Sean Harvey
b4fb295a37 BUGFIX Removed query that was causing issues displaying members in the security groups. Open ticket #2591
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63786 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 23:01:46 +00:00
Ingo Schommer
4541dbb04e ENHANCEMENT Removed overloaded MemberTableField->DetailForm() and reduced overloaded constructor logic - same behaviour found in parent classes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63626 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 16:33:37 +00:00
Ingo Schommer
a322fbd59f ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@63175 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:12:20 +00:00
Ingo Schommer
f79a49fa31 API CHANGE Deprecated Member::isInGroup() - use Member::inGroup() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@62846 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-22 16:07:13 +00:00
Sam Minnee
03265942cc MemberTableField delete just removes the member from the group
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@62311 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 03:22:56 +00:00
Sam Minnee
725ba3a610 Fixed bugs in MemberTableField search
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@61614 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 04:58:34 +00:00
Hayden Smith
f74a39d1b0 Merged [47018]: Some additions made to use Object::create to allow MemberTableField to deal with subclasses of Member. Also merged a modification to MemberTableField::__construct that allowed greater control over the details form's fields (defaults to same behaviour as trunk), and MemberTableField::DetailForm, although this might need to be removed later.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@60302 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-11 01:14:07 +00:00
Ingo Schommer
08beafbcdb (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@60208 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 04:06:52 +00:00
Ingo Schommer
4b5ab8a997 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@59969 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-06 06:54:59 +00:00
Ingo Schommer
a894ad377d MINOR Unified @package PHPdoc (added where missing, removed duplicates)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@56212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-15 13:33:53 +00:00
Sam Minnee
deaddc841d Merged revisions 52875 via svnmerge from
http://svn.silverstripe.com/open/modules/cms/branches/govtsecurity

........
  r52875 | sminnee | 2008-04-16 20:12:35 +1200 (Wed, 16 Apr 2008) | 1 line
  
  Respect Member validation in the add-record part of MemberTableField
........


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@53457 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-04-26 06:28:33 +00:00