Commit Graph

828 Commits

Author SHA1 Message Date
Ingo Schommer
7a996450e6 elofgren: Make 'Email' colum always be 1/3 of width of table and listed first in every report for consistency on Newsletter 'Sent Status Report' tab.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42013 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:36:31 +00:00
Ingo Schommer
3a0d2596c9 elofgren: Make class BouncedList? extend TableListField? so that checkboxes and red 'X' icon links will show. @TODO Make it possible to disable sending to bounced emails by unchecking a box and delete the email from the mailing list by clicking the red X @TODO Try to find way to show Firstname and Surname under a 'Username' heading
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42012 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:36:04 +00:00
Ingo Schommer
6714eea295 elofgren: Add style="width:auto;" to the 'Sending to the Following Recipients Failed' and 'Sending to the Following Recipients Bounced' headings in the 'Sent Status Report' tab so they are not always width:50%.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42011 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:35:26 +00:00
Ingo Schommer
29cecf3845 elofgren: Remove the 'Firstname' and 'Surname' colums from all reports except the 'The Newsletter has Never Been Sent to Following Subscribers' one on the 'Sent Status Report' tab since it wasn't showing and I can't get the MySQL join working right.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42010 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:31:51 +00:00
Ingo Schommer
094c3629f1 elofgren: Remove '@TODO: Make bounces actually show up here.' from above 'Sending to the Following Recipients Bounced' heading in the 'Sent Status Report' tab of Newsletters since bounce logging for Newsletters was implemented in r39232
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42009 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:31:07 +00:00
Ingo Schommer
a42fd1d2d2 mujma: ENHANCEMENTS: Now image is placed in scrolled container so operation that results in image larger than screen are no longer problem.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42008 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:30:43 +00:00
Ingo Schommer
1daba65357 elofgren: Fix indentation of code in AddForm::form_submit()
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42007 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:30:05 +00:00
Ingo Schommer
ed0232eb71 elofgren: BUGFIX: Make adding newsletter types work again (was broken by r38923). Fix long-standing problem of whole page reloading when adding a Newsletter type. Now it is always added via AJAX.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42006 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:29:40 +00:00
Ingo Schommer
456ce4ebcc elofgren: In Newsletter_SentRecipient, instead of putting 'MemberId?' in $db put 'Member' in $has_one in order to be consistent with Newsletter_Recipient and Email_BounceRecord. This does not change the structure of the Newsletter_SentRecipient table, but does add an Index on the MemberID column.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42005 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:05:04 +00:00
Ingo Schommer
5303c3ba2f elofgren: BUGFIX: Make 'Sent Status Report' tab be reloaded after a Newsletter is sent 'to only people not previously sent to'
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42004 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:04:35 +00:00
Ingo Schommer
170c5b1fba elofgren: Make the status message shown after sending a newsletter always include the # of emails sent.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42003 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:04:10 +00:00
Ingo Schommer
b784ccc5e7 elofgren: Clean up the code which enabled the 'Send to only people not previously sent to' feature committed in r38895
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42002 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:03:04 +00:00
Ingo Schommer
24ed3ff68b elofgren: NEW FEATURE: Add 'Send to only people not previously sent to' option for sending Newsletters. Please test. :)
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42001 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:02:32 +00:00
Ingo Schommer
03423e67be elofgren: Add 'Firstname' and 'Surname' columns to all Sent Status report tables.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@42000 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:01:27 +00:00
Ingo Schommer
2c012f3c4e elofgren: BUGFIX: Fix gsoc trac ticket: #54 For newly created Newsletter drafts, Content of Newsletter Sent is not what is shown on screen (Save button has to be clicked)
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41999 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:01:06 +00:00
Ingo Schommer
8e583e2a4d elofgren: Don't show a 'No template selected' error when sending a test Newsletter if no template has been selected since templates for Emails are optional. See Email::parseVariables(). Resolves gsoc trac ticket: #53 "No template selected" error only occurs when "Send test to", but not when "Send to the mailing list" is selected
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41998 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:00:10 +00:00
Ingo Schommer
137f302fbc elofgren: Remove 6 lines of code by directly passing the unsent_subscribers_array data to push(new ArrayData?($data)) instead of pointlessly creating a new array.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41997 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:58:31 +00:00
Ingo Schommer
226afd84ba mlanthaler: Bugfix: The TinyMCE buttons shouldn't be underlined (spaces produce an ugly _ at least in IE7).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41996 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:58:02 +00:00
Ingo Schommer
4deaf09212 elofgren: Track whether mail() returns TRUE or FALSE when a Newsletter is sent and record the result in a new Newsletter_SentRecipient table.
Add a 'Sent Status Report' tab to Newsletters that shows the following 4 reports: 
* Sending to the Following Recipients Failed 
* Sending to the Following Recipients Bounced (@TODO: Make bounces actually show up here) 
* The Newsletter has Never Been Sent to Following Subscribers 
* Sending to the Following Recipients was Successful 
More info: http://support.silverstripe.com/gsoc/wiki/GSoc07UsabilityElijah 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41995 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:57:31 +00:00
Ingo Schommer
07c4301ca7 elofgren: USABILITY: Add <label for=...> tags to 'Send to the mailing list' and 'Send test to' radio buttons.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41994 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:54:16 +00:00
Ingo Schommer
d6ef666925 mujma: ENHANCEMENTS: Tmp folder name changed to _tmp, depends on r38621 in sapphire branch.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41993 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:53:45 +00:00
Ingo Schommer
0f7cf9628c mujma: BUGFIX: No longer photo under FF/Linux can be dragged out of dragging area.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41992 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:52:11 +00:00
Ingo Schommer
cd124fe98a mujma: BUGFIX: Any redo are now working after applying new operation.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41991 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:51:43 +00:00
Ingo Schommer
5150e6c6b6 mujma: BUGFIX: Fixed image flickering under IE6
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41990 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:51:15 +00:00
Ingo Schommer
8e08868354 mujma: BUGFIX: Fixed buttons(Ok/Cancel) visibility after "Crop area to small" message.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41989 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:50:48 +00:00
Ingo Schommer
5c3e3b1d6b mujma: ADD-ON: Removed image toolbar under IE6
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41988 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:50:22 +00:00
Ingo Schommer
b3c45a89b9 mujma: BUGFIX: Big images on IE6 now works correctly.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41987 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:49:57 +00:00
Ingo Schommer
fd8ba77c27 mujma: BUGFIX: Removed image flickering after operation(crop,rotate,resize), problem still occurs under Safari.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41986 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:49:34 +00:00
Ingo Schommer
37cddf0845 elofgren: Make the error alert() that comes up after clicking on 'Mailing List' in NewsletterAdmin? state tell where it is being called from. It should probably be commented out as per r38490
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41985 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:49:10 +00:00
Ingo Schommer
8b46cab94c elofgren: Remove leftover file drag and drop debug code accidentally committed in r37813
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41984 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:48:41 +00:00
Ingo Schommer
ed69e36116 mujma: BUGFIX: Fixed blocking during resize in IE6.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41971 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 22:02:35 +00:00
Ingo Schommer
bcbdd364e0 elofgren: BUGFIX: Fix bug 'Errors when Importing Recipients to Newsletter Mailing List'. Fixes gsoc trac ticket #38. Tested and importing newsletter recipients works in FF2 and IE7. Reported here: http://www.silverstripe.com/bugs/flat/1470 This fix needs GenericEmail?.ss added in r38503
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41970 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 22:02:06 +00:00
Ingo Schommer
31921fb25b elofgren: Truly fix problem with overflow:hidden being applied to RecipientImportField? iframe by simply setting <body onload=""> and reverting changes in r38497
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41969 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 22:01:23 +00:00
Ingo Schommer
03f0b31f70 elofgren: Make RecipientImportField? iframe body be style.overflow = 'auto'; so that all messages can be seen after recipients are imported.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41968 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 22:00:16 +00:00
Ingo Schommer
b7be0c523a reverted "comment-out-bugfix" from r41968
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41967 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:59:34 +00:00
Ingo Schommer
670c9ca573 mrisen: Resolved "undefined" error message popup in Safari with AJAX iframe load
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41966 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:57:58 +00:00
Ingo Schommer
cff0c9186c elofgren: VAR FIX: Initialize 'colCount' to prevent error when importing Newsletter Recipients.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41965 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:57:33 +00:00
Ingo Schommer
f7a1b199db elofgren: BUGFIX: Fix issue with deleting pictures with 'X' delete link not removing thumbs in _resampled folder. Thanks to Mateusz for reporting this.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41964 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:57:11 +00:00
Ingo Schommer
c3dc22e7b8 elofgren: When 'Duplicate this page' is clicked, first silently (without confirmation) save the page, then duplicate it so the new page is identical to the other page. Closes gsoc Ticket #41: Apply xmedeko's "autoSave before page duplicate" fixes to gsoc branch. Adapted from code posted here: http://www.silverstripe.com/contributions/flat/2073 Thanks Ondra\!
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41963 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:56:40 +00:00
Ingo Schommer
4bd9352924 mujma: BUGFIX: Added blocking history during resize and rotate.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41962 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:55:15 +00:00
Ingo Schommer
5e4b0852c4 mujma: BUGFIX: No longer croping under IE6 selects all image.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41961 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:54:51 +00:00
Ingo Schommer
abca2d257a mlanthaler: Bugfix: Fixed E_NOTICE error due to uninitialized variable
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41960 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:54:24 +00:00
Ingo Schommer
dcc83f8ff3 elofgren: BUGIX: Fix trac ticket: '#28: Fix problems with adding a new newsletter type and trying to edit its title' by making the id of the new newsletter type be returned instead of the id of Session::get('currentPage')
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41949 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:14:17 +00:00
Ingo Schommer
9d0cf998e1 elofgren: Adds 'Newsletter Settings' tab to Newsletter type edit form for consistency with other forms. Closes Ticket #30: Add tab to 'newsletter type' edit form
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41948 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:13:53 +00:00
Ingo Schommer
9f633edd49 elofgren: VAR FIX: Initialize 'result' in ThumbnailStripField::getflash()
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41947 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:13:23 +00:00
Ingo Schommer
2706c3e668 elofgren: Remove the large margin above #sitetree and make it only 2px
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41946 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:12:28 +00:00
Ingo Schommer
650317f43f elofgren: Get rid of the large blank space at the bottom of the left frame in the AssetAdmin?, NewsletterAdmin?, and SecurityAdmin? sections.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41945 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:12:05 +00:00
Ingo Schommer
c09c1050e4 elofgren: VAR FIX: Prevent undefined variable 'resent' in NewsletterEmailProcess::complete()
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41944 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:11:36 +00:00
Ingo Schommer
1af0b19db0 elofgren: Remove toggle images in cms/images/panels/ and use the new sapphire/images/ location.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41943 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:09:53 +00:00
Ingo Schommer
7463a8fb05 elofgren:Display a useful error message if getCMSFields() returns null. Thanks Sam: http://www.silverstripe.com/general-discussion/flat/1537?showPost=2042#post2042
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41942 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:09:13 +00:00