5c7800ae2e
elofgren:BUGFIX: Make deleting folders work again by replacing getElementsByTagName('a') with getElementsByTagName('button'). This was broken when the 'Delete' link was changed to a 'Delete' button.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41865 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:01:24 +00:00
23e18d620e
elofgren: USABILITY: Decrease width of TreeDropdownField? so 'arrow' icon is on same line as the drop-down in Firefox 2 like on the 'Link to File' -> 'Download a file' drop-down on the HtmlEditorField? toolbar. This should resolve Usability Issue #49 : http://www.elijahlofgren.com/silverstripe/replace-arrow-with-browse-button-in-move-file-list/
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41864 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:00:52 +00:00
15d40c5cf1
elofgren: USABILITY: Rename 'Save draft' button to 'Save' and make 'Publish' (will be renamed 'Save & Publish') button save the new draft in addition to publishing it.
...
Requested here: http://www.silverstripe.com/google-summer-of-code-forum/flat/1654?showPost=1730#post1730
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:00:03 +00:00
1e54b9a29d
elofgren: Decrease #statusMessage.bad max-height from 600 to 300px.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41862 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:59:01 +00:00
015498686d
elofgren: Change background color of alert-bad.gif and alert-good.gif to white since status messages are now shown on bottom left with white background.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41861 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:58:33 +00:00
8682b387f1
elofgren: Make statusMessage.bad background color white instead of transparent so that if there is a large AJAX error, it will be more readable.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41860 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:58:08 +00:00
708621f56b
elofgren: USABILITY: Move action buttons to bottom right of screen, make them look more like buttons, and add hover effect in order to fix usability issue #13 'Important Buttons Not Noticeable Enough'. More info: http://www.silverstripe.com/google-summer-of-code-forum/flat/1654
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41859 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:57:46 +00:00
9413acbc05
elofgren: Comment out StatusTitle? code for ajax actions because on IE6, IE7, and Safari 3, the status message becomes 'null' on 2nd hover and because there is not room for long titles when action buttons are on the same line. Now a simple title tooltip is shown instead.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41858 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:57:22 +00:00
e23eaf9f8d
mlanthaler: Small fix to prevent E_NOTICEs.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41857 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:56:26 +00:00
bf5c5154c4
qhoxie: slight stats left panel changes
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41856 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:55:58 +00:00
0762c09ba2
qhoxie: additions to left statistics panel
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41855 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:55:36 +00:00
83530f139f
elofgren: USABILITY: Change the 'Create', 'Delete', and 'Reorganise' links into 'Create...', 'Delete...', and 'Reorder...' buttons in order to fix Usability Issue #23 "Create, Delete, and Reorganise links
...
need to be more prominent". More info: http://www.elijahlofgren.com/silverstripe/create-delete-and-reorganise-links-need-to-be-more-prominent/
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41854 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:54:13 +00:00
dbb645cde6
elofgren: BUGFIX: Make adding a newsletter type to the 'Newsletters' tree work when a draft is selected by changing the name of the 'NewsletterEditForm?' back to 'EditForm?' (reverts r36734 which was a fix to make the 'Save changes' button work on the now non-existant modal 'Usaved changes' dialog.) In addition this commit reverts r37173 because the form name is now 'EditForm?' like all other forms in NewsletterAdmin?.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41853 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:53:38 +00:00
318bae74f6
elofgren: Newsletters: Remove reference to Form_NewsletterEditForm_Type in NewsletterAdmin?_right.js since the newsletter type form is simply called EditForm? and saving the newsletter type doesn't require check for 'action_savenewsletter' being set.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41852 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:58 +00:00
05a8a40e01
elofgren: BUGFIX: Fix status message displayed after deleting items from the left 'Newsletters' tree. Instead of 'Deleted items', actually give a value to and display it as a number.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41851 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:37 +00:00
768862a9e4
elofgren: BUGFIX: Newsletters section: Make unsaved changes confirm() dialogue show when a new selection is made in the left tree by removing the check for the existance of the save() function which was removed in r36869. The save() function used to be called by the old modal 'Unsaved Changes' dialogue when the 'Save changes' button was pressed. The new confirm() dialogue has no 'Save changes' button so the save() function is no longer needed.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:51:12 +00:00
e2475e8dcd
elofgren: BUGFIX: Make adding a newsletter draft to the left site tree work again.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41849 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:50:47 +00:00
14acd05f1b
elofgren: USABILITY: Make 'Go' button be on same line as 'Create a Page' drop-down.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41848 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:50:20 +00:00
e1438c9949
qhoxie: updates to stats panels
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41847 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:49:54 +00:00
dd853ef168
elofgren: USABILITY: Add 'label' tags for 'Compare mode (click 2 below)' and 'Show unpublished versions' checkboxes in left frame 'Page Version History' section.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41846 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:49:11 +00:00
e70d060983
elofgren: USABILITY: In 'Page Version History' left sidebar section, use a checkbox labeled 'Compare mode (click 2 below)' instead of a drop-down with only 'View (click to see)' and 'Compare (click 2 to see)' options. More info: http://www.elijahlofgren.com/silverstripe/inconsistent-go-buttons/
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:48:48 +00:00
d497fbf671
elofgren: VAR FIXES: Add some needed issets() and variable initializations to fix a lot of warnings when comparing 2 versions of a page.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41844 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:48:11 +00:00
9b29b09a24
elofgren: VAR FIX: Fix typo in LeftAndMain::addTreeNodeJS() by renaming 'select' parameter to 'selected' because 'selected' is what is used in the method body.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41843 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:46:51 +00:00
dfa6b99f18
elofgren: VAR FIXES: Fix 2 undefined variable errors in CMSMain::deletefromlive() and 1 in CMSMain::deleteitems() that showed up in status messages while deleting pages.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:46:22 +00:00
8f980e1e02
elofgren: USABILITY: Add tooltips to pages in 'Site Content' tree showing 'Page type: className' where className is the page's type.
...
More info: http://www.elijahlofgren.com/silverstripe/icons-missing-from-left-navigation-tree-key/
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41809 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:42:24 +00:00
5e6fd830e2
elofgren: USABILITY: Fix usability issue #30 'Replace Image button needs repositioning' by adding back the margin, border, and padding around the fieldset and increasing height. More info:
...
http://www.elijahlofgren.com/silverstripe/replace-image-button-needs-repositioning/
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41808 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:41:51 +00:00
59bfa913a5
elofgren: USABILITY: In 'Site Content' left frame, relabel 'Site Tree' => 'Site Content', 'History' => 'Page Version History', 'Reports' => 'Site Reports' .Fixes usability issue #21 : http://www.elijahlofgren.com/silverstripe/site-content-needs-consistent-labeling/
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41807 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:41:22 +00:00
ad3aed7930
mlanthaler: Bugfix: "if($className == null); $className = $this->stat('subitem_class');" had no effect because of the semicolon after the if-statement.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:40:56 +00:00
c2f57b75de
mlanthaler: Suppress E_NOTICE when $_REQUESTctf?childID? is not set (e.g. when adding a new member by clicking on "Add member" in the security tab).
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41805 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:39:59 +00:00
3ee2969cd5
elofgren: USABILITY: Remove 'Surname', 'FirstName?', and 'Email' from list of 'changeDetection_fieldsToIgnore'. This completes fixes for usability issue #91 "Warning needs to be added for unsaved changes
...
in Security section". More info: http://www.elijahlofgren.com/silverstripe/warning-needs-to-be-added-for-unsaved-changes-in-security-section/
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41804 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:38:25 +00:00
119b3b017a
elofgren: USABILITY: Remove the left Side Tabs and implement clicking on the headings to show sidebar sections instead in order to fix Usability issue " #22 Allow clicking on blue heading bar of Left
...
Site Tree to reduce it". More info: http://www.elijahlofgren.com/silverstripe/allow-clicking-on-blue-heading-bar-of-left-site-tree-to-reduce-it/
A big THANK YOU to Andy Skelton for permission to use his WordPress? toggle icons originally posted at: http://trac.wordpress.org/attachment/ticket/1904/toggle.gif
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41803 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:37:48 +00:00
274a3d678c
elofgren: Set svn:mime-type=application/octet-stream on psd images in cms/images/sidetabs so they won't show up in diffs when they are deleted.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41802 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:34:34 +00:00
8fe47c6e87
qhoxie: basic setup for statistics viewing and handling in the cms
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41801 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:33:51 +00:00
7f61325204
elofgren: Remove unused code: 1. doYouWantToSave() that called OpenModalDialog?() has been replaced by a call to confirm() 2. CMSMain::savedialog() which was the PHP part of the old modal save dialog. 3. save() in NewsletterAdmin?_right.js which seems to have been replaced by the save function of Form_EditForm
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41800 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:32:19 +00:00
93ae866e60
elofgren: USABILITY: Make Newsletter section use new js confirm dialog instead of old modal one. More info: http://www.elijahlofgren.com/silverstripe/alert-users-when-leaving-tab-with-unsaved-changes/
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41799 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:30:54 +00:00
f7ed6b050f
elofgren: USABILITY: 1. Always use confirmation when calling autoSave, not just for 'Microsoft Internet Explorer' since the new confirm() dialog works in all browsers.
...
2. Make MainMenu? links call LeftAndMain?_window_unload() to check for unsaved changes before loading new page. Don't register LeftAndMain?_window_unload with window 'beforeunload' event because it
cannot stop the page unload and the save check is now done via links (where stopping the unload works).
3. Make external Logo link open in a new window like the Menu-help link to prevent unsaved changes being lost.
More info: http://www.elijahlofgren.com/silverstripe/alert-users-when-leaving-tab-with-unsaved-changes/ (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41798 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:30:11 +00:00
b1173b174b
elofgren: Add back options save code deleted in r36865 because it is used if confirmation=false
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41797 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:29:12 +00:00
067d630e06
elofgren: USABILITY: Use a confirm() javascript dialog box instead of the slow loading modal one for asking user if they want to save their changes when they click on a new page in the left tree. More info: http://www.elijahlofgren.com/silverstripe/alert-users-when-leaving-tab-with-unsaved-changes/
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41796 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:28:41 +00:00
9792c6bf37
elofgren: Add ellipsis (...) to Newsletter Send button to be consistent with 'Move Files...' button.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41795 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:28:03 +00:00
8be38885d0
elofgren: USABILITY: Fix usability issue #66 'Cancel button needs to be added to Send Newsletter Window' by adding a Cancel button and aligning it left.
...
More info here: http://www.elijahlofgren.com/silverstripe/cancel-button-needs-to-be-added-to-send-newsletter-window/
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41794 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:27:34 +00:00
74214051b8
mlanthaler: Changed the login messages to reflect the fact that more authentication methods are available.
...
(merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41793 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:26:56 +00:00
19e222b5c2
elofgren: BUGFIX: In NewsletterAdmin::getNewsletterEditForm() use 'NewsletterEditForm?' instead of 'EditForm?' as the name of the form so that clicking 'Save changes' in the 'Unsaved Changes' reminder popup will actually save the Newsletter draft. (merged from branches/gsoc)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41783 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 18:12:42 +00:00
4c0681927d
elofgren: Instead of setting className= in NewsletterAdmin?'s save() and savenewsletter() functions (in order to fix an undefined variable problem earlier), set it to 'NewsletterType?' in save() and 'Newsletter' in savenewsletter(), and then use those values in both calls to DataObject::get_one() (merged from branches/gsoc)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 18:12:00 +00:00
1eca17e0a9
elofgren: USABILITY: Rework the tabs in the Newsletter section to be less confusing as per issue #57 of the Usability Report
...
Includes the removal of all tabs and submit action buttons when 'Drafts' or 'Sent Items' are clicked and the addition of an 'add one' link on 'Drafts' folder page.
For more information see: http://www.elijahlofgren.com/silverstripe/newletter-tree-and-tab-row-are-confusing/
Includes a few fixes for undefined variables. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41772 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:29:08 +00:00
9a229d70a5
mujma: USABILITY: Fixed usability issue number #46 . (merged from branches/gsoc)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 02:33:58 +00:00
18cde3fb7d
mujma: USABILITY: Fixed usability issue number #43 . (merged from branches/gsoc)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 02:32:55 +00:00
83bc91db7f
mujma: BBUGFIX: Save button is now on right hand side. (merged from branches/gsoc)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 02:20:42 +00:00
1bff08f5d2
wscott: The cms will now ping google with sitemap updates when pages are published or unpublished (merged from branches/gsoc)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 01:19:13 +00:00
e3fee8edf6
wscott: Added comment to _config.php (merged from branches/gsoc)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41697 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 01:01:48 +00:00
4301f7b29f
added a message to indicate there are no widgets available
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@41492 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-09 11:28:26 +00:00
Ingo Schommer
Sean Harvey
