tonyair
/
silverstripe-reports
mirror of https://github.com/silverstripe/silverstripe-reports
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

FIX Respect escaping rules on readonly fields in CMS history view 

Avoids showing unescaped HTML on fields which didn't allow it otherwise,
e.g. TextField. This also fixes problems with SiteTree->ExtraMeta
which got evaluated within the CMS. If this section contains any
JavaScript it gets executed and can disrupt CMS operation.
This commit is contained in:
Ingo Schommer 2013-02-04 17:12:55 +01:00
parent 1525684e68
commit 97fbfd3f12
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
code/controllers/CMSPageHistoryController.php
View File

@ -113,11 +113,6 @@ class CMSPageHistoryController extends CMSMain {
$fields = $fields->makeReadonly();
$navField->setAllowHTML(true);
foreach($fields->dataFields() as $field) {
$field->dontEscape = true;
$field->reserveNL = true;
}
if($compareID) {
$link = Controller::join_links(
$this->Link('show'),