tonyair/silverstripe-reports
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-reports synced 2024-10-22 11:05:53 +02:00
Code Issues Projects Releases Wiki Activity

Fixed report link escaping

Browse Source
This commit is contained in:
Ingo Schommer 2013-10-02 11:52:14 +02:00
parent daf92e6ce0
commit 92e0c410b8
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/reports/Report.php
View File

@ -303,7 +303,7 @@ class SS_Report extends ViewableData {
if(isset($info['link']) && $info['link']) { if(isset($info['link']) && $info['link']) {
$fieldFormatting[$source] = function($value, &$item) { $fieldFormatting[$source] = function($value, &$item) {
return sprintf( return sprintf(
'<a href=\"%s\">%s</a>', '<a href="%s">%s</a>',
Controller::join_links(singleton('CMSPageEditController')->Link('show'), $item->ID), Controller::join_links(singleton('CMSPageEditController')->Link('show'), $item->ID),
Convert::raw2xml($value) Convert::raw2xml($value)
); );

5
tests/behat/features/view-reports.feature
View File

@ -12,4 +12,7 @@ Feature: View Reports
Scenario: I can view the "Pages with no content" report Scenario: I can view the "Pages with no content" report
When I follow "Pages with no content" When I follow "Pages with no content"
Then I should see "Empty Page" Then I should see "Empty Page"
But I should not see "Filled Page" But I should not see "Filled Page"
When I follow "Empty Page"
Then I should see an edit page form
And the "Page name" field should contain "Empty Page"