tonyair/silverstripe-reports
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-reports synced 2024-10-01 05:39:36 +02:00
Code Issues Projects Releases Wiki Activity

MINOR Removed usage of prototype.js style $() alias in WidgetAreaEditor.js

Browse Source
This commit is contained in:
Ingo Schommer 2012-02-16 12:28:24 +01:00
parent 38cf7e5c4d
commit 63d0fcbde4
1 changed files with 23 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
javascript/WidgetAreaEditor.js
View File

@ -1,3 +1,6 @@
// Shortcut-function (until we update to Prototye v1.5)
if(typeof $$ != "Function") $$ = document.getElementsBySelector;
/** /**
* File: WidgetAreaEditor.js * File: WidgetAreaEditor.js
*/ */
@ -10,9 +13,9 @@ WidgetAreaEditorClass.prototype = {
initialize: function() { initialize: function() {
this.name = this.getAttribute('name'); this.name = this.getAttribute('name');
this.rewriteWidgetAreaAttributes(); this.rewriteWidgetAreaAttributes();
UsedWidget.applyToChildren($('usedWidgets-'+this.name), 'div.Widget'); UsedWidget.applyToChildren(document.getElementById('usedWidgets-'+this.name), 'div.Widget');
var availableWidgets = $('availableWidgets-'+this.name).childNodes; var availableWidgets = document.getElementById('availableWidgets-'+this.name).childNodes;
for(var i = 0; i < availableWidgets.length; i++) { for(var i = 0; i < availableWidgets.length; i++) {
var widget = availableWidgets[i]; var widget = availableWidgets[i];
@ -42,7 +45,7 @@ WidgetAreaEditorClass.prototype = {
// Figure out maxid, this is used when creating new widgets // Figure out maxid, this is used when creating new widgets
this.maxid = 0; this.maxid = 0;
var usedWidgets = $('usedWidgets-'+this.name).childNodes; var usedWidgets = document.getElementById('usedWidgets-'+this.name).childNodes;
for(var i = 0; i < usedWidgets.length; i++) { for(var i = 0; i < usedWidgets.length; i++) {
var widget = usedWidgets[i]; var widget = usedWidgets[i];
if(widget.id) { if(widget.id) {
@ -92,7 +95,7 @@ WidgetAreaEditorClass.prototype = {
beforeSave: function() { beforeSave: function() {
// Ensure correct sort values are written when page is saved // Ensure correct sort values are written when page is saved
var usedWidgets = $('usedWidgets-'+this.name); var usedWidgets = document.getElementById('usedWidgets-'+this.name);
if(usedWidgets) { if(usedWidgets) {
this.sortWidgets(); this.sortWidgets();
@ -111,8 +114,8 @@ WidgetAreaEditorClass.prototype = {
addWidget: function(className, holder) { addWidget: function(className, holder) {
if ($('WidgetAreaEditor-'+holder).getAttribute('maxwidgets')) { if (document.getElementById('WidgetAreaEditor-'+holder).getAttribute('maxwidgets')) {
var maxCount = $('WidgetAreaEditor-'+holder).getAttribute('maxwidgets'); var maxCount = document.getElementById('WidgetAreaEditor-'+holder).getAttribute('maxwidgets');
var count = $$('#usedWidgets-'+holder+' .Widget').length; var count = $$('#usedWidgets-'+holder+' .Widget').length;
if (count+1 > maxCount) { if (count+1 > maxCount) {
alert(ss.i18n._t('WidgetAreaEditor.TOOMANY')); alert(ss.i18n._t('WidgetAreaEditor.TOOMANY'));
@ -124,7 +127,7 @@ WidgetAreaEditorClass.prototype = {
this.name = holder; this.name = holder;
jQuery.ajax({ jQuery.ajax({
'url': 'Widget_Controller/EditableSegment/' + className, 'url': 'Widget_Controller/EditableSegment/' + className,
'success' : $('usedWidgets-'+holder).parentNode.parentNode.insertWidgetEditor.bind(this) 'success' : document.getElementById('usedWidgets-'+holder).parentNode.parentNode.insertWidgetEditor.bind(this)
}); });
}, },
@ -143,7 +146,7 @@ WidgetAreaEditorClass.prototype = {
// This is called when an available widgets is dragged over to used widgets. // This is called when an available widgets is dragged over to used widgets.
// It inserts the editor form into the new used widget // It inserts the editor form into the new used widget
var usedWidgets = $('usedWidgets-'+this.name).childNodes; var usedWidgets = document.getElementById('usedWidgets-'+this.name).childNodes;
for(var i = 0; i < usedWidgets.length; i++) { for(var i = 0; i < usedWidgets.length; i++) {
var widget = usedWidgets[i]; var widget = usedWidgets[i];
if(widget.id && (widget.id.indexOf("Widget[") != 0) && (widget.id != 'NoWidgets-'+this.name)) { if(widget.id && (widget.id.indexOf("Widget[") != 0) && (widget.id != 'NoWidgets-'+this.name)) {
@ -154,7 +157,7 @@ WidgetAreaEditorClass.prototype = {
jQuery.ajax({ jQuery.ajax({
'url': 'Widget_Controller/EditableSegment/' + wIdArray.join('-'), 'url': 'Widget_Controller/EditableSegment/' + wIdArray.join('-'),
'success' : function() { 'success' : function() {
$('usedWidgets-'+self.name).parentNode.parentNode.insertWidgetEditor(); document.getElementById('usedWidgets-'+self.name).parentNode.parentNode.insertWidgetEditor();
} }
}); });
} }
@ -163,18 +166,18 @@ WidgetAreaEditorClass.prototype = {
insertWidgetEditor: function(response) { insertWidgetEditor: function(response) {
// Remove placeholder text // Remove placeholder text
if($('NoWidgets-'+this.name)) { if(document.getElementById('NoWidgets-'+this.name)) {
$('usedWidgets-'+this.name).removeChild($('NoWidgets-'+this.name)); document.getElementById('usedWidgets-'+this.name).removeChild(document.getElementById('NoWidgets-'+this.name));
} }
var usedWidgets = $('usedWidgets-'+this.name).childNodes; var usedWidgets = document.getElementById('usedWidgets-'+this.name).childNodes;
// Give the widget a unique id // Give the widget a unique id
widgetContent = response.responseText.replace(/Widget\[0\]/gi, "Widget[new-" + (++$('usedWidgets-'+this.name).parentNode.parentNode.maxid) + "]"); widgetContent = response.responseText.replace(/Widget\[0\]/gi, "Widget[new-" + (++document.getElementById('usedWidgets-'+this.name).parentNode.parentNode.maxid) + "]");
new Insertion.Top($('usedWidgets-'+this.name), widgetContent); new Insertion.Top(document.getElementById('usedWidgets-'+this.name), widgetContent);
$('usedWidgets-'+this.name).parentNode.parentNode.rewriteWidgetAreaAttributes(); document.getElementById('usedWidgets-'+this.name).parentNode.parentNode.rewriteWidgetAreaAttributes();
UsedWidget.applyToChildren($('usedWidgets-'+this.name), 'div.Widget'); UsedWidget.applyToChildren(document.getElementById('usedWidgets-'+this.name), 'div.Widget');
// Repply some common form controls // Repply some common form controls
WidgetTreeDropdownField.applyTo('div.usedWidgets .TreeDropdownField'); WidgetTreeDropdownField.applyTo('div.usedWidgets .TreeDropdownField');
@ -183,13 +186,13 @@ WidgetAreaEditorClass.prototype = {
tag: 'div', tag: 'div',
handle: 'handle', handle: 'handle',
containment: ['availableWidgets-'+this.name, 'usedWidgets-'+this.name], containment: ['availableWidgets-'+this.name, 'usedWidgets-'+this.name],
onUpdate: $('usedWidgets-'+this.name).parentNode.parentNode.updateWidgets onUpdate: document.getElementById('usedWidgets-'+this.name).parentNode.parentNode.updateWidgets
}); });
}, },
sortWidgets: function() { sortWidgets: function() {
// Order the sort by the order the widgets are in the list // Order the sort by the order the widgets are in the list
var usedWidgets = $('usedWidgets-'+this.name); var usedWidgets = document.getElementById('usedWidgets-'+this.name);
if(usedWidgets) { if(usedWidgets) {
widgets = usedWidgets.childNodes; widgets = usedWidgets.childNodes;
@ -213,7 +216,7 @@ WidgetAreaEditorClass.prototype = {
deleteWidget: function(widgetToRemove) { deleteWidget: function(widgetToRemove) {
// Remove a widget from the used widgets column // Remove a widget from the used widgets column
$('usedWidgets-'+this.name).removeChild(widgetToRemove); document.getElementById('usedWidgets-'+this.name).removeChild(widgetToRemove);
// TODO ... re-create NoWidgets div? // TODO ... re-create NoWidgets div?
} }
} }
@ -261,7 +264,7 @@ AvailableWidgetHeader.prototype = {
parts = this.parentNode.id.split('-'); parts = this.parentNode.id.split('-');
var widgetArea = parts.pop(); var widgetArea = parts.pop();
var className = parts.pop(); var className = parts.pop();
$('WidgetAreaEditor-'+widgetArea).addWidget(className, widgetArea); document.getElementById('WidgetAreaEditor-'+widgetArea).addWidget(className, widgetArea);
} }
} }
AvailableWidgetHeader.applyTo('div.availableWidgets .Widget h3'); AvailableWidgetHeader.applyTo('div.availableWidgets .Widget h3');