tonyair/silverstripe-reports
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-reports synced 2024-09-28 04:16:22 +02:00
Code Issues Projects Releases Wiki Activity

MNT Update method signature for test class (#191)

Browse Source
This commit is contained in:
Guy Sartorelli 2024-08-26 09:58:30 +12:00 committed by GitHub
parent be2dc34ca6
commit 0cb9d96ab3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/Report.php
View File

@ -431,7 +431,7 @@ class Report extends ViewableData
if ($item instanceof CMSPreviewable) { if ($item instanceof CMSPreviewable) {
return sprintf( return sprintf(
'<a class="grid-field__link-block" href="%s" title="%s">%s</a>', '<a class="grid-field__link-block" href="%s" title="%s">%s</a>',
Convert::raw2att($item->CMSEditLink()), Convert::raw2att($item->getCMSEditLink()),
Convert::raw2att($value), Convert::raw2att($value),
Convert::raw2xml($value) Convert::raw2xml($value)
); );

4
code/SideReportView.php
View File

@ -95,8 +95,8 @@ class SideReportView extends ViewableData
} }
if (isset($info['link']) && $info['link']) { if (isset($info['link']) && $info['link']) {
$link = ($info['link'] === true && $record->hasMethod('CMSEditLink')) $link = ($info['link'] === true && $record->hasMethod('getCMSEditLink'))
? $record->CMSEditLink() ? $record->getCMSEditLink()
: $info['link']; : $info['link'];
return $prefix . "<a $classClause href=\"$link\">$val</a>"; return $prefix . "<a $classClause href=\"$link\">$val</a>";
} else { } else {

2
tests/ReportTest/FakeObject.php
View File

@ -24,7 +24,7 @@ class FakeObject extends DataObject implements CMSPreviewable, TestOnly
return Controller::join_links('dummy-link', $this->ID); return Controller::join_links('dummy-link', $this->ID);
} }
public function CMSEditLink() public function getCMSEditLink(): ?string
{ {
return Controller::join_links('dummy-edit-link', $this->ID); return Controller::join_links('dummy-edit-link', $this->ID);
} }