Commit Graph

220 Commits

Author SHA1 Message Date
Mateusz Uzdowski
d066f99d5e BUGFIX: re-enabling MARS, framework assumes it can run DB::query without fetching the results, which leaves the result set open and prohibits executing another query in the mean time 2010-08-30 21:51:09 +00:00
Sean Harvey
1cab98c219 MINOR Updated class documentation for MSSQLDatabase 2010-08-30 05:47:57 +00:00
Sean Harvey
81de1e073f BUGFIX When MSSQL_USE_WINDOWS_AUTHENTICATION is enabled, ensure the connection parameters include CharacterSet, MultipleActiveResultSets as "UTF-U" and boolean false respectively 2010-08-30 05:29:21 +00:00
Mateusz Uzdowski
410d15cf08 BUGFIX: disable MARS, we don't need it/don't support it 2010-08-30 04:18:29 +00:00
Mateusz Uzdowski
94355edcd2 BUGFIX: busy wait for indexing to complete before continuing with the test, so we can be sure the FTS returns up to date results 2010-08-26 20:54:40 +00:00
Mateusz Uzdowski
2745036563 BUGFIX: adjust the full-text search for mssql by stripping out non-alphabetic characters which are ignored by mssql anyway (and some of them crash the search engine) 2010-08-25 23:21:06 +00:00
Mateusz Uzdowski
0b28428a16 BUGFIX: the search for "quoted string" would fail. Changed to ANSI compliant quotes and prevented double-quoting. 2010-08-25 20:44:51 +00:00
Sean Harvey
27c3997061 BUGFIX Fixed fulltext not being dropped before re-adding it in MSSQLDatabase::getIndexSqlDefinition() 2010-07-18 23:14:51 +00:00
Sean Harvey
c44f5ca9ed MINOR Code syntax formatting 2010-07-13 05:46:33 +00:00
Sean Harvey
f211d2cea8 BUGFIX Fixed dev/build always showing changes in nvarchar fields because of a stray whitespace in the spec value 2010-07-13 05:07:40 +00:00
Andreas Piening
77f453c036 ENHANCEMENT: added transaction support 2010-06-24 05:37:45 +00:00
Sean Harvey
1e22a12cd6 BUGFIX MSSQLDatabase::__construct() should use "UTF-8" as a CharacterSet parameter to sqlsrv_connect(), not "utf8" as it's not recognised by that API 2010-06-03 12:06:26 +00:00
Sean Harvey
7c7e81ac70 MINOR Removed stray $error variable that isn't necessary in MSSQLDatabase::query() 2010-06-03 12:05:12 +00:00
Sean Harvey
13f90299cc MINOR Better error debugging message when sqlsrv_errors() is used on MSSQLDatabase::query() on a failed query 2010-06-03 12:03:27 +00:00
Sam Minnee
78d47d312f BUGFIX: Fixed index creation in MSSQL. 2010-06-03 00:58:33 +00:00
Sam Minnee
53156eb94e BUGFIX: Fixed MSSQLDatabase::hasTable() 2010-06-03 00:58:32 +00:00
Sam Minnee
9a1ee37cbd BUGFIX: Prevent dev/build errors with fulltext indexes on MSSQL. 2010-06-03 00:58:32 +00:00
Sam Minnee
feebe26208 API CHANGE: Added MSSQLDatabase::set_collation() to let you set the collation for the nvarchar fields. 2010-06-03 00:58:31 +00:00
Sam Minnee
07ea9353e1 ENHANCEMENT: Switch MSSQL to use the utf8 character set for the connection. 2010-06-03 00:58:31 +00:00
Sean Harvey
8e28fc70f6 MINOR Updated class doc 2010-05-27 23:05:32 +00:00
Sean Harvey
b6b9e00803 MINOR Class doc 2010-05-27 22:25:45 +00:00
Sean Harvey
028e54c306 MINOR Updated MSSQLDatabase class docs 2010-05-26 10:05:21 +00:00
Sean Harvey
b4851c5c1c MINOR Removed MSSQLDatabase::runTableCheckCommand() which is not used 2010-05-26 09:58:40 +00:00
Sean Harvey
b484b14be5 ENHANCEMENT Added MSSQLDatabase::getVersion() to determine the current version of MSSQL in use 2010-05-26 05:24:15 +00:00
Sean Harvey
a0768ec44d MINOR Re-added in function_exists() for sqlsrv_num_rows() for backwards compatability with sqlsrv 1.0, added a warning that it'll only work on cursors other than forward only 2010-05-19 12:13:33 +00:00
Sean Harvey
888dc64c0a BUGFIX MSSQLDatabase::searchEngine() no longer relies on MSSQLQuery::numRecords() which doesn't always work properly anyway, instead it counts if the record can be viewed and was pushed into the result DataObjectSet 2010-05-19 12:11:33 +00:00
Sean Harvey
07c4800374 API CHANGE Removed MSSQLQuery::forceNumRows which was a workaround for a lack of sqlsrv_num_rows() which exists as of sqlsrv 1.1 (current version) 2010-05-19 11:37:43 +00:00
Sean Harvey
075f4e53b9 MINOR Code tidy up in MSSQLDatabase 2010-05-19 11:06:35 +00:00
Sean Harvey
530a780a90 API CHANGE Removed MSSQLDatabase::escape_character() which doesn't need to belong on the database 2010-05-19 10:48:19 +00:00
Sean Harvey
d667b49f5f MINOR Removed unused MSSQLDatabase::fulltext() method which did nothing but echo a debug statement 2010-05-19 10:45:30 +00:00
Sean Harvey
b5edca6f91 BUGFIX MSSQLDatabase::formattedDatetimeClause() should start the epoch at 1/1/1970 12:00 instead of 00:00 which it defaults at, otherwise comparing it to PHP produces a full 24 hour time difference 2010-05-19 10:25:46 +00:00
Sean Harvey
7fad117464 MINOR Removed unncessary use of LEFT() in MSSQLDatabase::datetimeIntervalClause() 2010-05-19 10:09:51 +00:00
Sean Harvey
39576dd4e0 BUGFIX MSSQLDatabase date formatting uses style code 120 which represents a typical datetime format without millseconds 2010-05-18 10:47:05 +00:00
Sean Harvey
cb499039ab MINOR Better debugging output for failed queries 2010-05-11 00:12:13 +00:00
Sean Harvey
69ec2c12c9 BUGFIX Fixed error when mssql functions not available 2010-05-10 23:47:44 +00:00
Sean Harvey
28434a195d MINOR Better debugging in MSSQLDatabase::query() 2010-05-10 22:56:43 +00:00
Sean Harvey
572d025029 ENHANCEMENT MSSQLDatabase::text() and MSSQLDatabase::varchar() now use nvarchar which plays along better with UTF-8 characters 2010-05-10 04:45:54 +00:00
Ingo Schommer
2329ac93a5 BUGFIX Quoting of database name in MSSQLDatabase->allTablesSQL() 2010-04-29 23:01:33 +00:00
Sean Harvey
0307d40a61 BUGFIX Float should always be not null and default 0 in the database 2010-04-13 05:38:01 +00:00
Sean Harvey
93c87b4671 BUGFIX Added missing dbDataType method to MSSQLDatabase 2010-04-07 02:46:28 +00:00
Sean Harvey
fd47409602 MINOR Cast MSSQLDatabase::fulltextEnabled() as boolean 2010-03-11 09:46:16 +00:00
Sean Harvey
a9c6c54f4c MINOR Reverted last commit 2010-03-11 09:44:51 +00:00
Sean Harvey
2013c70090 MINOR Small improvement to ini_get() check in MSSQLDatabase::__construct() 2010-03-11 09:41:53 +00:00
Sean Harvey
f1d6819da4 MINOR Partially reverted changes to MSSQLDatabase::affectedRows() in r100630 2010-03-11 08:47:04 +00:00
Sean Harvey
cd0e39c554 MINOR Removed MSSQLDatabase::tableDetails() - there is no base API for this, and it isn't implemented 2010-03-11 08:41:37 +00:00
Sean Harvey
661ce65d24 BUGFIX Proper use of sqlsrv_rows_affected() 2010-03-08 20:15:27 +00:00
Sean Harvey
a37fd93c37 BUGFIX Stop sqlsrv warnings from being returned as errors to keep it in line with mssql functions 2010-03-05 02:40:20 +00:00
Sean Harvey
84aed0d9c3 BUGFIX Don't show search result items in MSSQLDatabase::searchEngine() that can't be viewed 2010-02-25 02:40:26 +00:00
Sean Harvey
d09acc0cbe BUGFIX MSSQLDatabase::fullTextEnabled() should be cached so it doesn't have to query it all the time and slow down the database when dev/build occurs 2010-02-23 01:23:42 +00:00
Sean Harvey
5667388908 BUGFIX MSSQLDatabase::fullTextEnabled() should check that full-text capability is installed properly instead of just checking the status of it on the database 2010-02-11 23:09:37 +00:00
Sean Harvey
a2c2b3ebc0 BUGFIX Added MSSQLDatabase::set() - it doesn't do anything different to enum at the moment 2010-02-07 01:59:13 +00:00
Andreas Piening
6b82e2b1c2 MINOR: cast to datetime for higher precision 2010-02-04 04:53:25 +00:00
Sean Harvey
ab1b49fdf0 MINOR Removed query to enable fulltext each time MSSQLDatabase::createFullTextCatalog() was called - it's already enabled on databases where fulltext is supported 2010-02-03 08:24:33 +00:00
Sean Harvey
9bbe3603ee BUGFIX Check value() return on MSSQLDatabase::fullTextEnabled() 2010-02-03 08:13:41 +00:00
Sean Harvey
adef3ced70 ENHANCEMENT Automatic checking of fulltext support by looking into the sys.databases table for MSSQLDatabase 2010-02-03 08:11:31 +00:00
Sean Harvey
7d67d25402 MINOR Changed MSSQLDatabase::now() block comment to be more useful 2010-02-03 07:53:08 +00:00
Sean Harvey
de7068d591 MINOR Removed redundant code from various MSSQLDatabase methods - it is now more inline with MySQLDatabase 2010-02-03 07:50:29 +00:00
Sean Harvey
b8b85a12a2 ENHANCEMENT MSSQLDatabase::decimal() field type now accepts user defined default values if it's available 2010-02-03 07:27:50 +00:00
Andreas Piening
9c1bda45ff FEATURE: added datetime helper functions 2010-02-03 05:01:37 +00:00
Sean Harvey
adb7369f5f MINOR Removed MSSQLDatabase::$mssqlVersion - it's not used 2010-02-02 02:08:02 +00:00
Sean Harvey
b8b44eaef5 BUGFIX Fixed proper checking of $this->fullTextIndexExists() when checking for indexes - NULL case means it's fulltext isn't enabled
ENHANCEMENT Support for only one active result set when building a SQL Server database
ENHANCEMENT Removed deprecated two-part syntax for DROP INDEX and used ON instead
2010-02-01 23:24:02 +00:00
Sean Harvey
b7f44bf043 MINOR Ease up restrictions of private variables and methods on MSSQLDatabase - this allows for a subclass for a more specific subset of SQL Server functionality 2010-02-01 21:45:01 +00:00
Sean Harvey
05d2831fb9 BUGFIX Fixed conflict of temp table creation between sites in MSSQLDatabase::createTable() by randomizing the table name 2009-12-15 00:58:58 +00:00
Sean Harvey
7e01c97e53 MINOR Use $this->query instead of DB::query() for instance MSSQLDatabase::createTable() temp table drop queries 2009-12-15 00:19:37 +00:00
Sean Harvey
6ae790f3a3 BUGFIX MSSQL stores temporary tables in the "tempdb" database, so special requirements are needed to make this work correctly with SapphireTest assumptions that this table exists in the same database as the project 2009-12-14 23:57:30 +00:00
Sean Harvey
6bfa6e9d0f BUGFIX Make use of fulltextIndexExists() in MSSQLDatabase::getIndexSqlDefinition() instead of issuing it's own query to do so 2009-12-08 20:53:15 +00:00
Sean Harvey
3bba7b9ef1 ENHANCEMENT Added MSSQLDatabase::fulltextIndexExists() to check if an index exists before dropping it in MSSQLDatabase::alterTableAlterColumn()
BUGFIX Fixed alterting field types with a fulltext index on a table - an error would complain that a fulltext index exists, which needs to be dropped before the column can be altered
2009-12-07 05:38:26 +00:00
Sean Harvey
5bd3bcac67 BUGFIX Ensure that the ID is returned as a string when coming out of the database using the mssql_*() functions. This is NOT set to an integer, because there are many places in the sapphire framework that expect ID to be a string 2009-11-13 03:46:43 +00:00
Sean Harvey
7e45cfda78 ENHANCEMENT Support for Windows authentication for MSSQLDatabase - this is a more secure way of connecting to the database server, because a username and password is not required in the _ss_environment.php file 2009-11-12 09:23:46 +00:00
Sean Harvey
e4fe94aae3 BUGFIX If full text not enabled, return empty DataObjectSet in MSSQLDatabase::searchEngine() instead of null (undefined variable) 2009-10-27 07:08:51 +00:00
Sean Harvey
3e04b42048 MINOR Removed incorrect Exception thrown from MSSQLDatabase::searchEngine() - it should still carry on if there's no records anyway 2009-10-27 06:59:47 +00:00
Sean Harvey
1157f3e0db ENHANCEMENT Added support for sqlsrv_num_rows in MSSQLQuery::numRecords() - this feature was added in version 1.1 of the sqlsrv driver
MINOR Documentation updates
2009-10-26 23:44:08 +00:00
Sean Harvey
2b7c27382d MINOR Updated inaccurate documentation of methods due to class name changes in r90075 2009-10-26 21:16:37 +00:00
Sean Harvey
1f9af45389 BUGFIX Fixed incorrect method name ssdatetime due to changes in sapphre (r90075) 2009-10-26 21:12:42 +00:00
Sean Harvey
c751b64eab API CHANGE MSSQLDatabase now extends from SS_Database and SS_Query due to changes in sapphire (r90075) 2009-10-26 20:59:29 +00:00
Sean Harvey
eb10888c08 BUGFIX MSSQLDatabase::getIndexSqlDefinition() - before trying to create an index that may exist, check if it exists and drop it if necessary
ENHANCEMENT Tidied up MSSQLDatabase::alterTable()
MINOR Code formatting fixes
2009-10-22 06:51:35 +00:00
Sean Harvey
edfa1dde19 MINOR Spelling mistake in class documentation for MSSQLDatabase 2009-10-22 04:02:40 +00:00
Sean Harvey
1ea7a2fec8 MINOR Class documentation for MSSQLDatabase
MINOR Code formatting cleanup for MSSQLDatabase::__destruct()
MINOR phpDoc for class variables
2009-10-22 04:01:17 +00:00
Mateusz Uzdowski
5eec769564 BUGFIX: disabling database connection reuse. This resulted in fail if two parallel connections to the same server were estabilished, each using different database. Second MSSQLDatabase object would change the DB also for the first one, resulting in invalid queries afterwards. 2009-10-15 22:04:55 +00:00
Sean Harvey
fe67223740 BUGFIX Added missing parameters to MSSQLDatabase::createTable() and MSSQLDatabase::alterTable() that were introuced in r88293 2009-10-14 05:51:43 +00:00
Geoff Munn
fb5dc5c298 API CHANGE: database extensions now supported by MSSQL 2009-10-11 22:04:24 +00:00
Geoff Munn
ad3c2d91be API CHANGE: Transaction stubs created 2009-10-01 21:11:18 +00:00
Sean Harvey
91ee7ca80d BUGFIX Added missing MSSQLDatabase::random() method 2009-09-17 07:07:02 +00:00
Andrew O'Neil
bdddbc61a5 BUGFIX: sqlserv crashes php if there are too many open handles - free the handle as soon as the end of the dataset is reached 2009-09-14 01:44:58 +00:00
Sam Minnee
ddbd0fda5d Updated MSSQLDatabase and MSSQLQuery to suit r84061 2009-08-08 02:57:37 +00:00
Geoff Munn
396384e709 MINOR FIX: ID column protected against index and column alterations 2009-07-28 21:15:27 +00:00
Sean Harvey
82dcbb89d2 BUGFIX MSSQLDatabase::__destruct() should check if the db handle is a resource before attempting to close it, otherwise it'll give a warning about an invalid MSSQL link, when it should've said "unable to connect to server" 2009-07-28 04:07:42 +00:00
Sean Harvey
4c2cb7f3e9 BUGFIX MSSQLDatabase - fixed bigint broken on dev/build, it shouldn't have a column width 2009-07-28 03:48:52 +00:00
Sam Minnee
8e7516e537 BUGFIX: Fix the generation of fields to be more accurate, and detection of existing fields to be more accurate, so as not to run unnecessary field type change operations. 2009-07-27 22:39:57 +00:00
Sean Harvey
f555c3518f MINOR Check for $this->mssql in MSSQLDatabase::__destruct()
MINOR Removed Debug from MSSQLQuery::__destruct()
MINOR Code formatting fixes in MSSQLQuery
2009-07-27 21:50:54 +00:00
Sean Harvey
915457b86b BUGFIX Ensure that dbConn is a resource before attempting to close it 2009-07-23 04:45:16 +00:00
Sean Harvey
8b3f4f9963 MINOR phpDoc of MSSQLDatabase methods 2009-07-20 09:09:53 +00:00
Sean Harvey
b6a0c4f8a4 BUGFIX Ensure that the current DB connection is properly closed when scripts stop executing (applies to mssql_close and sqlsrv_close) 2009-07-20 07:23:38 +00:00
Sean Harvey
333ac5f26a MINOR Removed unncessary whitespace from MSSQLDatabase and double up of phpDoc tags 2009-07-15 23:39:35 +00:00
Tom Rix
5293397e42 MINOR fix private static typo 2009-07-09 03:59:44 +00:00
Tom Rix
808f10e1d0 FEATURE function to strip SQL Server noise words from a full-text query. 2009-07-09 01:11:02 +00:00
Sean Harvey
f5d41cedfd BUGFIX Fixed MSSQLDatabase::searchEngine() to search keywords properly by connecting them with AND to go in the CONTAINS() function 2009-07-07 05:38:16 +00:00
Andrew O'Neil
31cedd108b BUGFIX: Fix times returned after midday being 12 hours early 2009-06-30 02:09:02 +00:00
Geoff Munn
c3a0542c66 MINOR FIX: 'DISTINCT' keyword must come before 'TOP' 2009-06-29 00:08:22 +00:00
Andrew O'Neil
0ec54f3359 Fix defaults 2009-06-25 02:27:02 +00:00