FIX: skip unit tests and loading page objects if cms module is not installed.

This commit is contained in:
Will Rossiter 2012-06-30 21:39:35 +12:00
parent c5c92abad2
commit df9b224937
5 changed files with 65 additions and 17 deletions

View File

@ -1,8 +1,9 @@
<?php <?php
// add the extension to pages // add the extension to pages
if (class_exists('SiteTree')) if (class_exists('SiteTree')) {
Object::add_extension('SiteTree', 'GoogleSitemapSiteTreeDecorator'); Object::add_extension('SiteTree', 'GoogleSitemapSiteTreeDecorator');
}
// if you need to add this to DataObjects include the following in // if you need to add this to DataObjects include the following in
// your own _config: // your own _config:

View File

@ -21,6 +21,13 @@
*/ */
class GoogleSitemap extends Controller { class GoogleSitemap extends Controller {
/**
* @var array
*/
public static $allowed_actions = array(
'index'
);
/** /**
* @var boolean * @var boolean
*/ */

View File

@ -0,0 +1,6 @@
Page:
Page1:
Title: Testpage1
Priority: 0.2
Page2:
Title: Testpage2

View File

@ -2,6 +2,7 @@
/** /**
* @package googlesitemaps * @package googlesitemaps
* @subpackage tests
*/ */
class GoogleSitemapTest extends FunctionalTest { class GoogleSitemapTest extends FunctionalTest {
@ -13,28 +14,56 @@ class GoogleSitemapTest extends FunctionalTest {
'GoogleSitemapTest_UnviewableDataObject' 'GoogleSitemapTest_UnviewableDataObject'
); );
function setUp() {
parent::setUp();
if(class_exists('Page')) {
$this->loadFixture('googlesitemaps/tests/GoogleSitemapPageTest.yml');
}
}
function testItems() { function testItems() {
$sitemap = new GoogleSitemap();
// register a DataObject and see if its aded to the sitemap
GoogleSitemap::register_dataobject("GoogleSitemapTest_DataObject", '');
$this->assertEquals(2, $sitemap->Items()->Count());
GoogleSitemap::register_dataobject("GoogleSitemapTest_OtherDataObject");
$this->assertEquals(3, $sitemap->Items()->Count());
GoogleSitemap::register_dataobject("GoogleSitemapTest_UnviewableDataObject");
$this->assertEquals(3, $sitemap->Items()->Count());
}
function testItemsWithPages() {
if(!class_exists('Page')) {
$this->markTestIncomplete('No cms module installed, page related test skipped');
}
$sitemap = new GoogleSitemap();
$page = $this->objFromFixture('Page', 'Page1'); $page = $this->objFromFixture('Page', 'Page1');
$page->publish('Stage', 'Live'); $page->publish('Stage', 'Live');
$page->flushCache(); $page->flushCache();
$page2 = $this->objFromFixture('Page', 'Page2'); $page2 = $this->objFromFixture('Page', 'Page2');
$page2->publish('Stage', 'Live'); $page2->publish('Stage', 'Live');
$page2->flushCache(); $page2->flushCache();
$sitemap = new GoogleSitemap();
$this->assertDOSEquals(array( $this->assertDOSEquals(array(
array('Title' => 'Testpage1'), array('Title' => 'Testpage1'),
array('Title' => 'Testpage2') array('Title' => 'Testpage2')
), $sitemap->Items(), "There should be 2 pages in the sitemap after publishing"); ), $sitemap->Items(), "There should be 2 pages in the sitemap after publishing");
// check if we make a page readonly that it is hidden // check if we make a page readonly that it is hidden
$page2->CanViewType = 'LoggedInUsers'; $page2->CanViewType = 'LoggedInUsers';
$page2->write(); $page2->write();
$page2->publish('Stage', 'Live'); $page2->publish('Stage', 'Live');
$this->session()->inst_set('loggedInAs', null); $this->session()->inst_set('loggedInAs', null);
$this->assertDOSEquals(array( $this->assertDOSEquals(array(
array('Title' => 'Testpage1') array('Title' => 'Testpage1')
), $sitemap->Items(), "There should be only 1 page, other is logged in only"); ), $sitemap->Items(), "There should be only 1 page, other is logged in only");
@ -59,6 +88,7 @@ class GoogleSitemapTest extends FunctionalTest {
GoogleSitemap::enable(); GoogleSitemap::enable();
$response = $this->get('sitemap.xml'); $response = $this->get('sitemap.xml');
$this->assertEquals(200, $response->getStatusCode(), 'Sitemap returns a 200 success when enabled'); $this->assertEquals(200, $response->getStatusCode(), 'Sitemap returns a 200 success when enabled');
$this->assertEquals('application/xml; charset="utf-8"', $response->getHeader('Content-Type')); $this->assertEquals('application/xml; charset="utf-8"', $response->getHeader('Content-Type'));
@ -69,19 +99,27 @@ class GoogleSitemapTest extends FunctionalTest {
} }
function testDecoratorAddsFields() { function testDecoratorAddsFields() {
if(!class_exists("Page")) {
$this->markTestIncomplete('No cms module installed, page related test skipped');
}
$page = $this->objFromFixture('Page', 'Page1'); $page = $this->objFromFixture('Page', 'Page1');
$fields = $page->getSettingsFields(); $fields = $page->getSettingsFields();
$tab = $fields->fieldByName('Root')->fieldByName('Settings')->fieldByName('GoogleSitemap'); $tab = $fields->fieldByName('Root')->fieldByName('Settings')->fieldByName('GoogleSitemap');
$this->assertInstanceOf('Tab', $tab); $this->assertInstanceOf('Tab', $tab);
$this->assertInstanceOf('DropdownField', $tab->fieldByName('Priority')); $this->assertInstanceOf('DropdownField', $tab->fieldByName('Priority'));
$this->assertInstanceOf('LiteralField', $tab->fieldByName('GoogleSitemapIntro')); $this->assertInstanceOf('LiteralField', $tab->fieldByName('GoogleSitemapIntro'));
} }
function testGetPriority() { function testGetPriority() {
$page = $this->objFromFixture('Page', 'Page1'); if(!class_exists("Page")) {
$this->markTestIncomplete('No cms module installed, page related test skipped');
}
$page = $this->objFromFixture('Page', 'Page1');
// invalid field doesn't break google // invalid field doesn't break google
$page->Priority = 'foo'; $page->Priority = 'foo';
$this->assertEquals(0.5, $page->getPriority()); $this->assertEquals(0.5, $page->getPriority());
@ -94,6 +132,7 @@ class GoogleSitemapTest extends FunctionalTest {
/** /**
* @package googlesitemaps * @package googlesitemaps
* @subpackage tests
*/ */
class GoogleSitemapTest_DataObject extends DataObject implements TestOnly { class GoogleSitemapTest_DataObject extends DataObject implements TestOnly {
@ -112,6 +151,7 @@ class GoogleSitemapTest_DataObject extends DataObject implements TestOnly {
/** /**
* @package googlesitemaps * @package googlesitemaps
* @subpackage tests
*/ */
class GoogleSitemapTest_OtherDataObject extends DataObject implements TestOnly { class GoogleSitemapTest_OtherDataObject extends DataObject implements TestOnly {
@ -130,6 +170,7 @@ class GoogleSitemapTest_OtherDataObject extends DataObject implements TestOnly {
/** /**
* @package googlesitemaps * @package googlesitemaps
* @subpackage tests
*/ */
class GoogleSitemapTest_UnviewableDataObject extends DataObject implements TestOnly { class GoogleSitemapTest_UnviewableDataObject extends DataObject implements TestOnly {

View File

@ -1,10 +1,3 @@
Page:
Page1:
Title: Testpage1
Priority: 0.2
Page2:
Title: Testpage2
GoogleSitemapTest_DataObject: GoogleSitemapTest_DataObject:
DataObjectTest1: DataObjectTest1:
Priority: 0.4 Priority: 0.4
@ -14,7 +7,7 @@ GoogleSitemapTest_DataObject:
GoogleSitemapTest_OtherDataObject: GoogleSitemapTest_OtherDataObject:
OtherDataObjectTest2: OtherDataObjectTest2:
Priority: 0.3 Priority: 0.3
GoogleSitemapTest_UnviewableDataObject: GoogleSitemapTest_UnviewableDataObject:
Unviewable1: Unviewable1:
Priority: 0.4 Priority: 0.4