Merge pull request #338 from creative-commoners/pulls/4/ReturnTypeWillChange

API Strongly type iterator classes and remove ReturnTypeWillChange annotation

src/Utils/CombinationsArrayIterator.php

@@ -32,29 +32,26 @@ class CombinationsArrayIterator implements Iterator
         $this->rewind();
     }
 
-    #[\ReturnTypeWillChange]
+    public function rewind(): void
-    public function rewind()
     {
         if (!$this->numArrays) {
             $this->isValid = false;
         } else {
             $this->isValid = true;
             $this->k = 0;
-            
+
             for ($i = 0; $i < $this->numArrays; $i++) {
                 reset($this->arrays[$i]);
             }
         }
     }
 
-    #[\ReturnTypeWillChange]
+    public function valid(): bool
-    public function valid()
     {
         return $this->isValid;
     }
 
-    #[\ReturnTypeWillChange]
+    public function next(): void
-    public function next()
     {
         $this->k++;
 
@@ -71,8 +68,7 @@ class CombinationsArrayIterator implements Iterator
         }
     }
 
-    #[\ReturnTypeWillChange]
+    public function current(): mixed
-    public function current()
     {
         $res = array();
         for ($i = 0; $i < $this->numArrays; $i++) {
@@ -81,8 +77,7 @@ class CombinationsArrayIterator implements Iterator
         return $res;
     }
 
-    #[\ReturnTypeWillChange]
+    public function key(): mixed
-    public function key()
     {
         return $this->k;
     }

src/Utils/MultipleArrayIterator.php

@@ -22,8 +22,7 @@ class MultipleArrayIterator implements Iterator
         $this->rewind();
     }
 
-    #[\ReturnTypeWillChange]
+    public function rewind(): void
-    public function rewind()
     {
         $this->active = $this->arrays;
         if ($this->active) {
@@ -31,20 +30,17 @@ class MultipleArrayIterator implements Iterator
         }
     }
 
-    #[\ReturnTypeWillChange]
+    public function current(): mixed
-    public function current()
     {
         return $this->active ? current($this->active[0]) : false;
     }
 
-    #[\ReturnTypeWillChange]
+    public function key(): mixed
-    public function key()
     {
         return $this->active ? key($this->active[0]) : false;
     }
 
-    #[\ReturnTypeWillChange]
+    public function next(): void
-    public function next()
     {
         if (!$this->active) {
             return;
@@ -58,8 +54,7 @@ class MultipleArrayIterator implements Iterator
         }
     }
 
-    #[\ReturnTypeWillChange]
+    public function valid(): bool
-    public function valid()
     {
         return $this->active && (current($this->active[0] ?? []) !== false);
     }