Commit Graph

143 Commits

Author SHA1 Message Date
Ingo Schommer
ffa33aef74 elofgren: *Blacklist bounced newsletter recipient emails by default* in order to comply with spec: 'Bounces report with tickboxes ticked by default (to not send to in the future, unticking resends)'
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42033 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:00:28 +00:00
Ingo Schommer
4622ce38fc elofgren: BUGFIX: Fix Email_BlackList::isBlocked() to check the Email_BlackList.BlockedEmail? field instead of non-existant Email field so that it will actaully return true when an email is blocked.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42025 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:54:32 +00:00
Ingo Schommer
8d89050618 mlanthaler: Refactored the created code since the coding conventions for static methods were changed (ticket #49).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42019 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:48:38 +00:00
Ingo Schommer
cbe32dca20 elofgren: NEW FEATURE: If the contents of the X-SilverStripeMessageID header is sent to /Email_BounceHandler in the 'SilverStripeMessageID' _GET variable, then it will be logged in the Newsletter_SentRecipient table so that the bounce report will show up on the 'Sent Status Report' tab of the Newsletter. @TODO: Add checkboxes checked by default to the 'Bounced' tab of the 'Mailing List' to not send to in the future (use Email_BlackList?), unticking resends. In addition, add ability to remove bounced emails from mailing list.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41981 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:40:29 +00:00
Ingo Schommer
481781c797 elofgren: Display a 'Sorry, this bounce report has already been logged, not logging this duplicate bounce.' on duplicate bounce logs instead of a blank screen to aid in debugging.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41980 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:39:04 +00:00
Ingo Schommer
f3dde5bf6b elofgren: If the access key for Email_BounceHandler is not given, display a 'No "Key" specified' error instead of 'Invalid "Key" specified' to make things clearer.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41979 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:38:41 +00:00
Ingo Schommer
87a0535439 elofgren: Define 'EMAIL_BOUNCEHANDLER_KEY' in sapphire/_config.php and require its value to be sent as 'Key' $_GET var in pings to /Email_BounceHandler to prevent fake email bounce pings.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41977 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:35:09 +00:00
Ingo Schommer
12afad7f1e mlanthaler: Check if TEMP_FOLDER was already defined before defining it so that the user can set the temporary folder himself.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41974 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:23:00 +00:00
Ingo Schommer
9af317a264 mlanthaler: Bugfix: Indexes and defaults were not supported in DataObjectDecorators?.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41973 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:20:31 +00:00
Ingo Schommer
9b75ec925a mlanthaler: Bugfix: Fixed bug "Fatal error: Access to undeclared static property: Controller::$db in ../sapphire/core/Object.php(282) : eval()'d code on line 1". Could be implemented better if we require support for PHP 5.1 because then we can avoid the exception by calling ReflectionClass::hasProperty() respectively ReflectionClass::getStaticPropertyValue() (http://www.php.net/manual/en/language.oop5.reflection.php).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41972 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:19:54 +00:00
Ingo Schommer
b358c50f2f mlanthaler: Bugfix: If DataObject::add_extension() is used more than once per class, previously the extensions were overwritten and so only the last one was usable.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41951 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:34:40 +00:00
Ingo Schommer
efd51a2b1e mlanthaler: Add support for _manifest_exclude files (http://support.silverstripe.com/gsoc/ticket/36).
Now it is possible to exclude directories from their inclusion by the ManifestBuilder? by simply adding a "_manifest_exclude" file. This file can be placed in any directory and then that directory and all its subdirectories won't be included anymore.
ischommer: merged with current ManifestBuilder, lots of differences 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41950 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:29:52 +00:00
Ingo Schommer
56853999bb elofgren: VAR FIX: Prevent 'auth' from being undefined in HTTP::sendRequest()
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41941 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:07:51 +00:00
Ingo Schommer
5a06cb4684 elofgren: Add note 'The constant 'BOUNCE_EMAIL' should be defined as a valid email address for where bounces should be returned to.' because I was unsure what BOUNCE_EMAIL should be set to until I found reference to it on: http://doc.silverstripe.com/assets/classes/default/_sapphire_core_Email_php.html
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:06:22 +00:00
Ingo Schommer
49fa87cceb elofgren: VAR FIX: Prevent errors when sending newsletter drafts by initializing variables and calling isset() and empty() where needed in core/Email.php
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41938 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:05:58 +00:00
Ingo Schommer
67743359a1 elofgren: Add needed isset($_GETshowtemplate?) to SSViewer_FromString::process() to prevent errors when sending a newsletter draft.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:04:33 +00:00
Ingo Schommer
5536aac284 qhoxie: ssviewer foreach interation tracking
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41914 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 20:07:32 +00:00
Ingo Schommer
408c8d63d5 bfojcapell: better i18n support and more flexibility allowed in templates. Also fixed some possible warnings in 2.02rc1 if more than one language file is found with the same name. ManifestBuilder? now skips language files - they cannot be autoloaded and they are already loaded on demand, so no need to be in the manifest
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41913 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 20:06:42 +00:00
Ingo Schommer
6b378430f4 sminnee: Changes to keep db/build working on sites that don't yet have RememberLoginToken?
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41910 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 19:42:14 +00:00
Ingo Schommer
5e0a5283b2 fixed bugs introduced by merging branches/gsoc
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 02:05:23 +00:00
Ingo Schommer
d292e5ccf0 mlantahler: Reverted Sam's changes because now we can exclude directories from the ManifestBuilder? simply by adding a "_manifest_exclude" file.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41906 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 01:55:55 +00:00
Ingo Schommer
fedd019322 sminnee: Changes to keep db/build working on sites that don't yet have RememberLoginToken?
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41839 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:27:40 +00:00
Ingo Schommer
ef33498a97 elofgren: In SilverStripeNavigator?(), change 'View page in:' to 'Page view:', 'CMS' to 'Edit', and group 'Edit' & 'Draft Site' together. Reason: http://www.silverstripe.com/silverstripe-development/flat/626?showPost=1785#post1785
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41838 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:26:21 +00:00
Ingo Schommer
8d3c8a51d9 elofgren: USABILITY: Change tooltip references to 'stage site' to 'draft site' instead. See: http://www.elijahlofgren.com/silverstripe/consistently-use-draft-site-instead-of-stage-site/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41837 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:24:15 +00:00
Ingo Schommer
0872f87358 bfojcapell: Renaming of functions and new function prototype of the translator function
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41835 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:21:51 +00:00
Ingo Schommer
3444cf28e8 mlanthaler: Bugfix: Invalid code caused an parse error.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:19:29 +00:00
Ingo Schommer
e25d8bab65 bfojcapell: Added i18n api comments
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:17:37 +00:00
Ingo Schommer
7e9623f4ac bfojcapell: Added security check, only admins can use text collector
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:16:41 +00:00
Ingo Schommer
46be50f0a2 bfojcapell: LocaleAPI renamed to i18n
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41829 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:16:11 +00:00
Ingo Schommer
89b737678e bfojcapell: sapphire changes to allow i18n
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41827 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:12:28 +00:00
Ingo Schommer
be2f2243ae mlanthaler: Added permission check for edit rights and changed the labels according to Sigs suggestions.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41823 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:06:49 +00:00
Ingo Schommer
ca366a15c7 mlanthaler: Allow CMS users to limit view/edit access to a page (ticket #8, ticket #9).
Also refactored the SiteTree? class to respect the coding standards. 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:03:12 +00:00
Ingo Schommer
ef54473d1b elofgren: Add 'extraClass' parameter to FormAction? and use it to assign the 'delete' CSS class to the 'Unpublish' and 'Cancel draft changes' buttons so that their background turns red on hover.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:43:02 +00:00
Ingo Schommer
3be2d445f9 elofgren: VAR FIX: Initialize 'has' to an array and use isset() for removeList in ComponentSet::setByIDList() to fix undefined variable errors when saving 'SubscribeForm?' page.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:38:26 +00:00
Ingo Schommer
f9c5f25254 mlanthaler: Bugfix: Make sure *Priority* is set, otherwise an invalid SQL statement will be generated when the page is published (Priority = ).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41818 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:33:51 +00:00
Ingo Schommer
e452de966c elofgren: VAR FIX: Fix a large amount of undefined variable errors when creating and editing a 'newsletter subscription form' page by adding needed issets and initializations.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:31:08 +00:00
Ingo Schommer
2a2b1db203 mlanthaler: Small fix to prevent E_NOTICEs.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41815 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:21:35 +00:00
Ingo Schommer
fa43f70696 mlanthaler: Fixed small typo.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:10:25 +00:00
Ingo Schommer
4d7346825a mlanthaler: Bugfix: Fixed small bug. Also notified the OpenID library maintainer so that they fix the library itself.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41811 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:07:23 +00:00
Ingo Schommer
0eada9f41b Refactored getClassManifest() for clearer ignore-rules
added $ignore_files and $ignore_folders

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41810 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:03:29 +00:00
Ingo Schommer
17202b859e mlanthaler: Bugfix: Fixed error "Trying to get property of non-object" when the accessed page doesn't exists (passed wrong URL).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41789 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:17:37 +00:00
Ingo Schommer
fbc375a282 mlanthaler:OpenID authentication works now. To use it simple create an user account without password and put your *complete* OpenID identifier in the email field, e.g. "http://markus-lanthaler.myopenid.com/".
You can get a free OpenID from http://www.myopenid.com  (merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41785 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:10:18 +00:00
Ingo Schommer
4ae8c85d46 mlantahler:Bugfix: Small bugfix to prevent the usage of uninitialized $funcName. Happens if the form is submitted by pressing <enter> instead of pressing the button (at least in IE7). (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41779 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 18:02:03 +00:00
Ingo Schommer
d47e6cf67c mlantahler:Bugfix: Added checks in DataObjectSet::First() and DataObjectSet::Last() to prevent errors on an empty $items array. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41778 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:59:33 +00:00
Ingo Schommer
898d897c9e mlantahler: Bugfix: $URL != $url. The variable names are case-sensitive in PHP (http://www.php.net/manual/en/language.variables.php) (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41777 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:47:45 +00:00
Ingo Schommer
9a22699fcc elofgren: Add 2 needed calls to isset(): in Hierarchy::markingFilterMatches() and Notifications::getItems(). Errors were encountered when moving and deleting files in 'Files and Images'. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41775 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:40:29 +00:00
Ingo Schommer
daca02b9a7 mlanthaler: Don't show a error message and don't quit the script when the error was expected (statement with an @ in front to suppress the error). (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41730 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 03:19:34 +00:00
Ingo Schommer
f7646412f4 fixed merging error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41727 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 02:49:36 +00:00
Ingo Schommer
817f279cf1 pkrenn: Added methods needed for testing, namely databaseExists and selectDatabase (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41713 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 01:45:06 +00:00
Ingo Schommer
f912a33b63 pkrenn: Fixing database issues (wrong DB connections, logical errors) (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41712 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 01:44:34 +00:00