Commit Graph

452 Commits

Author SHA1 Message Date
Sean Harvey
fda6ab0afb MINOR Unnecessary check of trim() twice on TextareaField->Field()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:54:04 +00:00
Sean Harvey
62a28cab64 ENHANCEMENT Clearer indication of setting disabled attribute in DropdownField->Field() since the disabled attribute shouldn't be set if the field isn't to be disabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:52:47 +00:00
Sean Harvey
719bc5dff4 MINOR whitespace removal
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:32:14 +00:00
Sean Harvey
a16f55b068 ENHANCEMENT Clearer indication of setting disabled attribute in CheckboxField->Field() since the disabled attribute shouldn't be set if the field isn't to be disabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:22:01 +00:00
Sean Harvey
2fd43fccfa ENHANCEMENT If TextField->disabled has been set to true, then add the "disabled" attribute to the input type text attribute list
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:18:25 +00:00
Sean Harvey
f5a39b5c2c ENHANCEMENT Made use of FormField->createTag() functionality for creating a textarea field in TextareaField->Field()
MINOR Documentation tweaks in TextareaField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:05:05 +00:00
Sean Harvey
1611deb019 MINOR Convert::raw2att() isn't required because FormField->createTag() already does this
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:03:20 +00:00
Normann Lou
249c7a7d12 APICHANGE: delete GenericDataAdmin, RelatedDataEditor, DropdownField_WithAdd and their related code (js, css, etc) from cms, sapphire, "GenericDataAdmin" name space has also been deleted from lang files. They are all added in the new module "genericdataadmin"
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 00:20:00 +00:00
Sean Harvey
8e1f647252 MINOR Added to @deprecated note for TypeDropdown about why this class shouldn't be used
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-19 00:41:16 +00:00
Sean Harvey
7048077184 API CHANGE Removed HtmlOneLineField. This field has been deprecated for some time now, and it does not work.
API CHANGE Changed HTMLVarchar->scaffoldFormField() to use HtmlEditorField instead of HtmlOneLineField, which does not work.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-19 00:18:55 +00:00
Normann Lou
e30b5e3f22 MINOR: documenting my new method, correct a coding convention about whitespace
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64460 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 22:22:32 +00:00
Ingo Schommer
00eaa1b5b7 BUGFIX Removed $headingLevel reference from LabelField (was supposed to go into HeaderField)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64438 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 14:03:10 +00:00
Ingo Schommer
06671277a7 BUGFIX Second constructor argument $title for HeaderField should be optional for legacy reasons
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64437 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:54:21 +00:00
Ingo Schommer
cb5d772111 MINOR deprecation notes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64429 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:44:20 +00:00
Ingo Schommer
794ae40f8f API CHANGE Moved CheckboxFieldDisabled class to more common CheckboxField_Disabled notation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64428 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:44:05 +00:00
Ingo Schommer
80b5bfd4d2 API CHANGE Removed NoScriptField, please use LiteralField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64426 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:31:57 +00:00
Ingo Schommer
82e1ad8d8a API CHANGE Removed EncryptField, use PasswordField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64425 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:31:34 +00:00
Ingo Schommer
e95c5657ff API CHANGE Changed constructor parameters for LabelField and Header: First parameter is now $name, not $title. Necessary change to consistently support labelled fields which can be identified and modified within a FieldSet, and in the DOM structure. Both HeaderField and LabelField still acceppt old notation through checking the parameter signature with func_get_args().
API CHANGE Moved setAllowHTML() to DataLessField
ENHANCEMENT Using createTag() to create HeaderField and LabelField, which adds support for HTML id attributes and extra css classes through addExtraClass()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64421 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:26:25 +00:00
Ingo Schommer
ab891c67ec API CHANGE Removed LabelledLiteralField, use LiteralField
API CHANGE Removed NamedLabelField, use LabelField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:22:36 +00:00
Ingo Schommer
461354bb47 MINOR Misc deprecation notes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64419 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:00:30 +00:00
Sean Harvey
b8ef87d24a MINOR phpDoc comment error fix
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64411 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:50:55 +00:00
Sean Harvey
3e13bd8307 ENHANCEMENT Made use of createTag() on FormAction->Field()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64410 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:50:13 +00:00
Ingo Schommer
8cf23e6d6c API CHANGE Removed NoScriptFormAction, use unobtrusive scripting
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64407 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:34:25 +00:00
Ingo Schommer
e9a2e5d464 API CHANGE Removed deprecated ComplexRequiredFields, use RequiredFields and custom javascript instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64399 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 10:51:09 +00:00
Ingo Schommer
c67d1b6425 API CHANGE Removed FormField->setExtraClass(), use FormField->addExtraClass()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64379 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:41:34 +00:00
Ingo Schommer
b45e583d29 API CHANGE Removed deprecated CustomValidator class
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64372 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:33:44 +00:00
Ingo Schommer
f7a0c5db04 API CHANGE Removed deprecated EditForm classa
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64371 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:33:21 +00:00
Sean Harvey
89b3241584 MINOR Whitespace changes in TextField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64344 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:34:46 +00:00
Sean Harvey
8a385d9fc0 Removed TextField_Disabled - this is unnecessary
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64343 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:34:31 +00:00
Normann Lou
9ba71a54da MINOR: delete some unnecessary duplicated variable in a assignment statement.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64338 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:00:12 +00:00
Normann Lou
2c384e732f Feature: attach extraClasses to a CurrencyField when it is transform to readonly
API: add CurrencyField_Readonly

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64326 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:49:34 +00:00
Normann Lou
480f18ab48 BUGFIX: $this->extraData is not alway set for an TableField_Item
API: add funcion TableField_Item::IsAddRow()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64325 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:47:01 +00:00
Normann Lou
ab0503fe22 Feature: attach extraClasses to a FormField when it is transform to readonly
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64324 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:43:00 +00:00
Normann Lou
19d5b377a8 API: add TextField_Disabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64323 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:36:50 +00:00
Sean Harvey
972558df3f BUGFIX If DropdownField->Field() lack of source checking before looping through it
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64320 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 23:25:55 +00:00
Ingo Schommer
2ddc6f13e8 BUGFIX Fixed DropdownField handling of Iterator objects rather than arrays in the newly created getSource()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64318 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 21:44:38 +00:00
Ingo Schommer
dada15629a ENHANCEMENT Added BankAccountField::is_valid_array_structure() to avoid PHP Notices when converting empty array values
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64305 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 12:57:17 +00:00
Ingo Schommer
c8c9c2166d ENHANCEMENT Added DropdownField->setEmptyString() and DropdownField->setHasEmptyDefault() to decrease constructor arguments and allow for modification of behaviour after calling construtor. Added DropdownField->getSource() to dynamically include empty defaults at rendering-time rather than construction time. Adjusted DropdownField subclasses to new behaviour
ENHANCEMENT Added DropdownFieldTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64304 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 12:39:09 +00:00
Will Rossiter
28bfea28b8 BUGFIX: fixed default_country_value so that it will actually call the default country if IP lookup doesnt work
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64275 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 03:26:24 +00:00
Andrew O'Neil
68aaa32e86 BUGFIX Fix disappearing fields when a field without a name was being pushed onto a FieldSet (eg a CompositeField)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64263 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 01:30:14 +00:00
Ingo Schommer
ff93176f70 ENHANCEMENT Making confirmation message in ConfirmedFormAction translatable
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64252 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 23:07:05 +00:00
Ingo Schommer
3b16fe9b59 BUGFIX Fixed ComplexTableField->saveComplexTableField() success message object link - was assuming same context as ComplexTableField_ItemRequest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64251 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 23:06:22 +00:00
Ingo Schommer
d5a37d40dd ENHANCEMENT Showing image thumb before input field in a separate block <div class="thumbnail"> in SimpleImageField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64238 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 21:46:52 +00:00
Ingo Schommer
6feab01a6f BUGFIX Fixed FormScaffolder string literal parsing FALE in getFieldSet()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64237 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 21:38:37 +00:00
Ingo Schommer
524d7a9011 ENHANCEMENT Disrecard $includeRelations setting when scaffolding $has_one relationships in FormScaffolder - use $restrictFields to limit instead
BUGFIX Using fieldLabel() for $has_one relationships in FormScaffolder

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64224 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:31:18 +00:00
Ingo Schommer
a24ccecb69 FEATURE Added ForeignKey and used it in relation- and databasefield getters in DataObject
FEATURE Added FormScaffolder for more flexible scaffolding of FieldSets from DataObject metadata
API CHANGE Removed DataObject->addScaffoldRelationFields(), now in separate class FormScaffolder
API CHANGE Changed parameters for DataObject->scaffoldSearchFields() to unify them with scaffoldFormFields()
API CHANGE Added optional $params parameter to DataObject->getCMSFields() to be passed on to scaffoldFormFields()
API CHANGE Renamed DataObject->getFormFields() to getFrontEndFields()
ENHANCEMENT Added $params parameter to all DBField->scaffoldFormField() subclasses
API CHANGE Added third optional parameter $object to DBField::create() to comply with ForeignKey and PrimaryKey constructors

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 22:20:41 +00:00
Hayden Smith
8a1ab89b84 BUGFIX: Fixed order of arguments.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64109 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 22:21:35 +00:00
Ingo Schommer
8cc5625708 ENHANCEMENT Ability to add title constructor arguments to Tab and TabSet classes to resolve i18n issues with untranslated or unreferencable Tabs (see #2359)
ENHANCEMENT Support for $field_labels in relation tabs created by DataObject->addScaffoldRelationFields()
ENHANCEMENT Type checking and user errors for Tab and TabSet constructor arguments
ENHANCEMENT Supporting titles in FieldSet->findOrMakeTab()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64073 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 16:00:50 +00:00
Ingo Schommer
9d596f6157 ENHANCEMENT Using i18n fieldlabels for column-headlines in TableListField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 12:13:23 +00:00
Ingo Schommer
d2e5662d47 MINOR Formatting
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64014 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 20:27:01 +00:00